34ced382db
Eliminate final remaining usage of TypeConverter::netItemStackToCore()
...
instead, we can verify that the held items match by comparing the received ItemStack with the one cached in InventoryManager, which is more cost effective and closes off internal item deserializers to external attacks.
2023-03-14 22:56:11 +00:00
dace20ad1f
Merge branch 'item-stack-request' into item-stack-request-pm5
2023-03-14 22:34:47 +00:00
a573a279fa
Merge branch 'minor-next' into item-stack-request
2023-03-14 22:25:49 +00:00
14f141fab2
NetworkSession: Stop counting DataPacketReceiveEvent in handler timings
...
we want it to be included in receive timings, but not handler timings. Handler timings should reflect the time spent in the actual session PacketHandler, not in the event.
2023-03-14 19:00:15 +00:00
c500ccd891
Merge branch 'minor-next' into major-next
2023-03-14 18:43:43 +00:00
daff955bc4
Merge remote-tracking branch 'origin/stable' into minor-next
2023-03-14 18:42:14 +00:00
cc69383b6f
Merge branch 'minor-next' into major-next
2023-03-14 18:40:57 +00:00
0022d82779
Merge commit 'd376399b7f332384532a82eaf69b9b02dad5bd0c' into minor-next
2023-03-14 18:39:03 +00:00
3de7a8c27f
Updated for 1.19.70
2023-03-14 18:08:10 +00:00
8e280ebb8b
RuntimeBlockMapping: avoid unnecessary PacketSerializer usage
2023-03-11 22:16:24 +00:00
f03afba10e
Merge branch 'minor-next' into major-next
2023-03-11 22:13:31 +00:00
fa7c38276c
Fixing gigantic clusterfuck with protocol contexts and broadcasting
...
fixes #5623
2023-03-11 21:54:14 +00:00
b13e97de3d
Timings: fixed receivePacket timer showing 2x the actual number of received packets
2023-03-11 19:13:10 +00:00
6db2b022fb
Merge branch 'next-minor' into next-major
2023-03-04 16:58:03 +00:00
3db1492c18
Fix CS again
2023-03-04 16:43:29 +00:00
a523189149
Added separate timings for broadcast and session buffer compression
2023-03-04 16:41:41 +00:00
f8893efb94
Don't bother with global batch compression if there is only 1 recipient
...
this allows the session to achieve better ratios, and also reduces worker pool spam.
2023-03-04 16:34:00 +00:00
aaec21f544
Compressor: Use minCompressionThreshold exclusively
...
closes #5589
2023-03-04 15:07:50 +00:00
407b78de3b
Merge branch 'next-minor' into next-major
2023-02-28 19:25:05 +00:00
0fcd2e7894
Merge branch 'stable' into next-minor
2023-02-28 19:23:25 +00:00
e7209679fb
...
2023-02-24 22:23:00 +00:00
ae50b952f1
Accept 1.19.63 (same protocol, different protocol version)
2023-02-24 22:15:58 +00:00
c82b43a586
Merge branch 'next-minor' into next-major
2023-02-23 22:00:14 +00:00
9acb4d64db
Added generated constants for available BedrockData files
...
this makes it easier to detect unused files, detect removed files, and also avoid typos in usages.
2023-02-23 21:45:12 +00:00
5854b1c8c2
Merge branch 'next-minor' into next-major
2023-02-22 22:51:51 +00:00
8234360c8d
Avoid creating batch buffers just to determine whether a batch should be globally compressed
...
Instead, sum together the lengths of encoded packet buffers and use that to decide whether to build the buffer or not.
2023-02-22 22:43:10 +00:00
6a64486f55
StandardPacketBroadcaster: Improve performance when broadcasting small packets
...
In refactors during PM4, I stripped out packet buffer caching, as it was problematic when events alter packets in undetectable ways.
However, I never cleaned this part of the code up properly after enabling DataPacketSendEvent to include multiple packets and multiple targets, so we were still individually encoding the packet(s) for every single session if the sum total of the sizes was below 256 bytes.
This change encodes packets once in the StandardPacketBroadcaster and retains their buffers to post to the session's send buffer directly if the resulting batch is below compression threshold.
This code is still not optimal (see ##5589), but fixing this brings broadcasting performance back to PM3 levels, without any of PM3's problems.
2023-02-22 21:52:12 +00:00
50b8d39aba
Merge branch 'next-minor' into next-major
2023-02-21 15:41:57 +00:00
4dbcd714bd
NetworkSession: fixed some segments of recv/send logic not being covered by their respective network timingsÂ
2023-02-19 17:21:10 +00:00
d5e92b4ae6
...
2023-02-19 16:53:04 +00:00
2a3288c4f9
Avoid useless throwaway PacketBatch objects
2023-02-19 16:50:03 +00:00
9cdb641936
Added encode packet timings
...
these changes required some new APIs in BedrockProtocol.
2023-02-19 16:47:20 +00:00
42df1a5c70
Fixed merge error
2023-02-17 20:19:32 +00:00
0e0f5e85eb
Merge branch 'next-minor' into next-major
2023-02-17 20:00:51 +00:00
71aad310c6
stfu
2023-02-17 16:39:46 +00:00
1e3b025916
1.19.62
2023-02-17 16:36:32 +00:00
c5dcd268ad
CS
2023-02-15 15:04:41 +00:00
2fd6e769e6
NetworkSession: Improved packet budgeting
...
this fixes players getting kicked during server lag spikes.
closes #5532
2023-02-15 14:59:05 +00:00
d891646d0a
Fix CS
2023-02-13 14:10:42 +00:00
886b40a455
ÂLocalize disconnect reasons for RakLib disconnects
2023-02-13 14:10:25 +00:00
525f62e1e4
ÂRakLib 0.15
2023-02-13 14:00:16 +00:00
2d56aa50b9
A bunch of mostly inseparable changes to PlayerPreLoginEvent
...
including support for separated disconnect reasons and disconnect screen messages (closes #4512 )
While the refactoring of kick reason -> kick flag wasn't exactly in my agenda, I realized that these changes would become pretty confusing and inconsistent with other events if they weren't refactored.
Hopefully I don't have to break this API again for a while...
2023-02-13 11:32:32 +00:00
074e7586cb
Merge branch 'next-minor' into next-major
2023-02-11 17:17:08 +00:00
475888b031
InGamePacketHandler: do not process repeated skin change requests for the same full skin ID
...
this fixes a feedback loop with persona skins in 1.19.60.
2023-02-08 20:16:41 +00:00
40b90bb722
InGamePacketHandler: log a debug when processing skin change requests
2023-02-08 19:47:12 +00:00
5a4550a4fc
CS
2023-02-08 18:55:49 +00:00
7bbc04e6de
Silence PlayerSkinPacket debug messages during spawn response stage
...
the client sends its skin here in 1.19.60 for some reason, which makes no sense - I can only assume it's a bug
2023-02-08 18:55:38 +00:00
3ba662f64f
1.19.60
2023-02-08 18:46:37 +00:00
da5302ca86
BlockStateData: introduce and use current()
2023-02-02 16:21:50 +00:00
222415859a
Require pthreads ^5.1
...
This version of pthreads has a substantially improved API, improved
performance, improved memory usage, and much less magical and broken
behaviour.
2023-01-23 20:02:33 +00:00
