Dylan K. Taylor
7864294336
Merge branch 'stable' into next-minor
2022-10-16 16:53:14 +01:00
Dylan K. Taylor
2a910c1cc2
World: more minor documentation improvements
2022-10-16 16:50:42 +01:00
Dylan K. Taylor
cd04a3db2e
World: ensure that addParticle/addSound don't send stuff to players who are not in range, even when an array of targets is given
...
closes #5347
2022-10-16 16:45:52 +01:00
Dylan K. Taylor
572def9245
World: Improve quality of type information
2022-10-16 16:21:59 +01:00
IvanCraft623
14d17a9546
Remove Erroneous documentation ( #5346 )
2022-10-16 15:21:35 +01:00
Dylan K. Taylor
b74c092d9b
Server: removed reference to nonexistent API method
2022-10-15 15:06:43 +01:00
Dylan K. Taylor
7bcc663b60
Migrate core code to using symfony/filesystem
...
webmozart/path-util is retained for plugin compatibility, but is dropped in 5.0
2022-10-14 21:51:29 +01:00
Dylan K. Taylor
b3bda788d9
Server: Deprecated getPlayerByPrefix()
...
this is only used for commands anyway, but we can't get rid of it yet.
2022-10-14 21:45:09 +01:00
Dylan K. Taylor
2cc8a56e68
Server: fixed borked serverCommand timings
2022-10-14 20:02:44 +01:00
Dylan K. Taylor
57deb60355
Merge branch 'stable' into next-minor
2022-10-13 21:03:50 +01:00
Dylan K. Taylor
b84c110819
Fix CS according to newest php-cs-fixer
2022-10-13 21:00:57 +01:00
IvanCraft623
421379fc77
SplashPotion: Use World::getCollidingEntities() instead of World::getNearbyEntities() ( #5326 )
...
fixes spectator players receiving effects from splash potions
2022-10-11 22:57:35 +01:00
Dylan K. Taylor
293cea7714
4.9.2 is next
2022-10-11 22:47:58 +01:00
Dylan K. Taylor
15645759e9
Release 4.9.1
2022-10-11 22:47:54 +01:00
Dylan K. Taylor
6ae7cb288e
Merge remote-tracking branch 'origin/stable' into next-minor
2022-10-11 21:59:40 +01:00
Dylan K. Taylor
c1fbac412e
event: ensure that modifications to items expected to be readonly have no effect
...
this isn't a very glorious fix, but it's the best I have for now.
2022-10-07 11:33:14 +01:00
Dylan K. Taylor
3feaa18f6c
DelegateInventory: use WeakReference and __destruct to clean up inventory listener
...
this is more sane, since it allows the delegate to be reused without unexpected behaviour.
2022-09-30 15:12:37 +01:00
Dylan T
41970feb57
Entity: Fire EntitySpawnEvent/ItemSpawnEvent on the first entity tick, instead of in the constructor ( #5314 )
...
This allows plugins to modify the entity via setters in EntitySpawnEvent without their changes getting overwritten by setter calls directly after the 'new YourEntity' statement.
As well as benefiting plugins, this also clears a path for a BC-breaking change in PM5 (to have the programmer use addEntity() to spawn entities, instead of the constructor doing it, which will improve on a number of data handling aspects).
fixes #4973
This targets next-minor because it has some side effects on plugins that depended on the old behaviour, such as VanillaHopper, so it's not suitable for a patch release.
2022-09-29 22:30:12 +01:00
Dylan K. Taylor
cd4bb91676
Living: alter eye height so the player doesn't drown on the surface of water when swimming
...
fixes #4989
2022-09-29 00:15:07 +01:00
Dylan K. Taylor
2be527060f
Sign: Fixed desync of colour and glowing state when using dye on signs
...
fixes #4932
2022-09-28 23:34:08 +01:00
Dylan K. Taylor
6f68c6d8a0
Melon: extend Solid instead of Transparent, fixes #5050
2022-09-28 23:07:53 +01:00
Dylan K. Taylor
ac16378410
Silence pre-spawn PlayerAuthInputPacket debug spam
2022-09-28 21:58:23 +01:00
Dylan K. Taylor
1f9dfa77bf
PreSpawnPacketHandler: emit a separate debug message for sending creative data
2022-09-28 21:58:23 +01:00
Dylan K. Taylor
0c7f8470b9
Avoid repeated strtolower usages in a couple of places
2022-09-28 21:30:06 +01:00
IvanCraft623
fc56c041f3
Correct knockback from explosions ( #5161 )
2022-09-28 21:09:07 +01:00
Dylan K. Taylor
d6bbf8217d
ResourcePackManager: avoid repeated operation
2022-09-28 20:57:17 +01:00
ShockedPlot7560
22486dd75e
Mushroom: check the light for placement, unless placed on mycelium or podzol ( #5054 )
...
The previous behaviour was inconsistent with vanilla.
2022-09-28 18:41:23 +01:00
Dylan K. Taylor
bda0ca23b4
Living: deprecated hasLineOfSight()
2022-09-28 17:34:51 +01:00
BrandPVP
b21cd82e94
Allow specifying a key for encrypted resource packs ( #5297 )
2022-09-28 17:27:33 +01:00
ShockedPlot7560
1c7b1e9e5d
Fix sugarcane behaviour on fertilizers ( #4930 )
2022-09-28 16:38:24 +01:00
Dylan T
b87e4d8bd3
Introduce and use TextFormat::addBase() ( #5268 )
...
This function adds "base" format to a string. The given formats are inserted directly after any RESET code in the sequence.
An example of where this is needed is in the logger.
Without this change, the following code:
$logger->notice("I'm a " . TextFormat::RED . "special" . TextFormat::RESET . " cookie");
causes the "cookie" part of the message to show as grey, instead of the expected aqua for NOTICE level messages.
There are also many workarounds for this problem throughout the server, mostly in command outputs, being forced to use WHITE instead of RESET to avoid breaking the logger output.
2022-09-28 16:13:11 +01:00
Dylan K. Taylor
86a2f8e360
Merge branch 'stable' into next-minor
2022-09-28 01:01:51 +01:00
Dylan K. Taylor
def2f8c145
InventoryManager: ensure the windowID is valid before attempting to remove any window
...
this is currently a harmless bug, since remove() isn't currently doing any heavy lifting.
2022-09-28 01:01:42 +01:00
Dylan K. Taylor
ed7c95549d
PreSpawnPacketHandler: add a bunch of debug messages
...
this is useful for observing timings during first spawn, so that performance issues can be more easily spotted.
2022-09-27 21:08:31 +01:00
Dylan K. Taylor
cfb0cad7e0
Console commands now write to stdout directly, instead of being fed through the logger
...
this has a number of implications:
- Console command outputs are now (obviously) not logged. This is consistent with every other type of command sender, be it RCON, players, or anything else.
- The assumption that the console command sender must be able to see the logger output is now broken, since the command sender can receive output separately from the logs.
In the future, it might be desirable to send the console command output to stderr instead of stdout, so that stdout can be silenced while still allowing commands to be used.
closes #2543
2022-09-27 21:03:03 +01:00
Dylan T
83e5b0adb6
ConsoleCommandSender is no longer responsible for forwarding broadcast messages to the logger ( #5311 )
...
This is a step towards implementing #2543 .
2022-09-27 20:58:33 +01:00
IvanCraft623
5e5661de75
Play burp sound when consuming a FoodSource ( #5158 )
2022-09-27 17:21:55 +01:00
DHJ1
dec188d4ad
TaskHandler: mark some public methods as @internal ( #5310 )
...
closes #5309
2022-09-27 17:17:29 +01:00
Dylan K. Taylor
a7dfa0907c
Merge branch 'stable' into next-minor
2022-09-24 18:07:56 +01:00
Dylan K. Taylor
f448b2e685
Block: Improve documentation for a whole bunch of methods
2022-09-24 18:06:46 +01:00
Dylan K. Taylor
6a0c54f850
Block: Relocate and document addVelocityToEntity()
...
maybe we should consider merging this with onEntityInside(), since they are both called for the same reasons? ...
2022-09-24 17:32:02 +01:00
Dylan K. Taylor
77a18d0aea
Block: add documentation for getFrictionFactor()
...
has no one ever questioned the fact that a higher _friction_ factor _reduces_ the block's friction???
2022-09-24 17:05:38 +01:00
Dylan K. Taylor
140a809c40
Block: improve documentation of hasEntityCollision() and onEntityInside()
2022-09-24 17:04:42 +01:00
Dylan K. Taylor
cb7c136035
Added documentation for some base Block classes
2022-09-24 16:54:21 +01:00
IvanCraft623
83a136a176
EntityFactory: Avoid code duplication on validation of creation functions ( #5294 )
2022-09-24 13:55:24 +01:00
Ali
3c55db531d
HealthBoostEffect: Ensure that current health is within limits after reducing max health on removal( #5303 )
2022-09-24 13:45:12 +01:00
famima65536
e4fc523251
Introduce Player::sendToastNotification() ( #5102 )
2022-09-23 11:37:08 +01:00
Dylan K. Taylor
7804172846
Player: added API documentation for some functions
2022-09-21 14:46:04 +01:00
Dylan K. Taylor
7d29ac8293
Merge branch 'stable' into next-minor
2022-09-21 14:21:27 +01:00
Dylan K. Taylor
d1c75da14b
Player: lock flight state in spectator mode
...
players should not be able to stop flying in spectator mode
2022-09-20 21:53:51 +01:00
