Dylan K. Taylor
1dd6591ac1
Migrate a bunch of PluginManager->callEvent() usages to Event->call
...
This has the triple bonus effect of a) making a lot of code easier to read, b) reducing Server::getInstance() usages, and c) removing a whole bunch of Server dependencies.
The network and block namespaces are untouched by this commit due to potential for merge conflicts. These should be dealt with separately on master.
2018-10-05 17:30:06 +01:00
Dylan K. Taylor
c447d51e3f
Bucket: use ItemFactory instead of self-clone
...
in the future Item->setDamage() will be removed.
2018-09-06 18:42:09 +01:00
Dylan K. Taylor
7b0ce16b12
Fixed buckets being able to delete any block
2018-06-13 17:05:51 +01:00
Dylan K. Taylor
de0741f727
Item: remove unused imports
2018-01-26 17:12:00 -05:00
Dylan K. Taylor
6c8a1a5b80
Item: Remove redundant Level parameter from onActivate()
...
there are three other sources this could be gotten from, an arbitrary level doesn't make sense.
2018-01-25 10:15:36 +00:00
Dylan K. Taylor
5f48433c95
Bucket: Added sounds for bucket fill/empty
2018-01-03 14:27:41 +00:00
Dylan K. Taylor
33352638a9
Bucket: Fixed appearing empty when picking up still liquids
...
Buckets already affected by this bug will still appear empty until used. After that they'll work fine.
2018-01-03 14:22:53 +00:00
Dylan K. Taylor
db52501462
Bucket: Fixed stack size handling for empty buckets
...
GOD this code is horrible
close #1472
2018-01-03 14:12:04 +00:00
Dylan K. Taylor
6e1df36188
Consumables refactor ( #1796 )
...
* Removed broken EntityEatEvents - these don't fit the pattern since they only apply to Human entities anyway. PlayerItemConsumeEvent and PlayerInteractEvent can be used for cancellation purposes, and plugins can do custom stuff without mess.
* Restrict item consuming to Living entities only
* Added FoodSource->requiresHunger()
* Only items implementing the Consumable interface can now be consumed.
* The effects from consuming items are now generic-ized by way of the Living->consume() function. This is overridden in Human to allow applying food and hunger.
* Fixed the hardcoded mess for buckets
2017-12-23 13:03:41 +00:00
Dylan K. Taylor
4f8e4f0522
Add EOF newlines where missing (bulk) ( #1836 )
...
This should solve issues with people making GitHub PRs and having the web editor messing things up. GitHub Web Editor sucks :(
2017-12-20 11:56:36 +00:00
Dylan K. Taylor
d1db27016e
s/facePos/clickVector/
...
clickVector better describes this
2017-10-27 19:05:26 +01:00
Dylan K. Taylor
769a50faa5
Refactor confusing parameter names for Item->onActivate()
...
next: refactor the function itself
2017-10-16 13:30:36 +01:00
Dylan K. Taylor
4df261b75a
Made some variable names in Bucket less confusing
2017-09-03 12:00:24 +01:00
Dylan K. Taylor
14ea76ecd7
Fixed PlayerBucketEmptyEvent never called, close #1339
2017-09-01 19:36:57 +01:00
Dylan K. Taylor
697ea55fb7
Another typehint
2017-08-27 20:01:38 +01:00
Dylan K. Taylor
9e142655ea
Removed redundant count parameter from item constructors, added some documentation and tightened safety checks
...
the count parameter is useless since Item ctor should now only be used for constructing item _types_, not actual items. All item creations for inventories etc, should go through the ItemFactory.
2017-08-25 19:06:23 +01:00
Dylan K. Taylor
02f42eba48
Move block registration to its own class
2017-08-20 18:05:01 +01:00
Dylan K. Taylor
e1d894057c
Changed face position floating-point params to Vector3s
2017-08-20 10:23:34 +01:00
Dylan K. Taylor
0e24596aed
Changed block construction calls to Block::get()
2017-08-19 13:46:17 +01:00
Dylan K. Taylor
6efa4343b1
Cleaned up fuel duration handling, fixed some fuel items not working in furnaces
2017-08-17 10:22:47 +01:00
Dylan K. Taylor
6ae24c5c19
Removed unnecessary methods Block->canBeActivated() and Item->canBeActivated() (needless extra confusion)
2017-07-30 18:14:43 +01:00
Dylan K. Taylor
51b0673b4b
Bite the bullet and enable strict types on everything
2017-06-07 12:53:16 +01:00
Dylan K. Taylor
9004417456
Fixed file headers ( #255 )
2017-01-13 16:57:05 +00:00
Dylan K. Taylor
1cb96d24ce
Some fixes, thanks PhpStorm
2017-01-04 11:29:24 +00:00
Shoghi Cervantes
747f7685e7
Fix formatting issues due to bad IDE settings
2014-12-07 16:30:04 +01:00
Shoghi Cervantes
7506f01302
Improved Item property handling
2014-12-07 15:51:00 +01:00
Shoghi Cervantes
a98da3bab1
Renamed old getID() calls to getId()
2014-12-07 15:21:32 +01:00
Shoghi Cervantes
8601405a88
Fixed CPU leak
2014-10-31 21:07:00 +01:00
Shoghi Cervantes
78f8d0280d
Removed unused imports
2014-10-29 01:14:09 +01:00
Shoghi Cervantes
350cee3d41
Added Event allocation pool, updated SPL with Class::onClassLoaded()
2014-10-28 10:47:40 +01:00
Shoghi Cervantes
da23cf685d
Added PlayerBucketEvent and children, improved Bucket usage and Liquid placing
2014-10-13 18:04:40 +02:00
Shoghi Cervantes
62af784d37
Removed unused imports
2014-10-08 17:00:23 +02:00
Shoghi Cervantes
48bc919a33
Added Liquid flow
2014-09-26 16:56:10 +02:00
Shoghi Cervantes
ac4b4b08fd
Fixed Level::setBlock() old calls
2014-09-05 11:00:13 +02:00
Shoghi Cervantes
0be679c9d5
Updated method names: getMetadata() & setMetadata() to getDamage() & setDamage() on Block and Item classes
2014-05-22 18:37:28 +02:00
Shoghi Cervantes
dd17652aca
Fixed wrong paths
2014-04-01 05:06:12 +02:00
