eb4679fefd
Merge remote-tracking branch 'origin/stable' into minor-next
2023-04-26 14:28:29 +01:00
a4f2b99ed5
InGamePacketHandler: queue slots for syncing if they appear in requestChangedSlots
...
this is essentially a prediction without the actual predicted item. We have to sync these regardless of what happens.
fixes #5708
2023-04-24 14:06:29 +01:00
3ecc980bc4
ÂInventoryManagerEntry: fixed incorrect PHPDoc type
2023-04-24 13:42:11 +01:00
107b56154b
ItemStackRequestExecutor: fixed stonecutter recipes
...
this uses the same dodgy hack used by CraftingTransaction, which assumes that getResultsFor() does not care about the crafting inputs.
While this is currently OK, since none of the currently-implemented recipes care about inputs anyway, it will become a problem when we implement shulker box recipes, so this needs to be addressed.
However, it can't be addressed without BC breaks, so this will have to be dealt with in PM5.
closes #5715
2023-04-24 13:35:00 +01:00
f86fde064d
CraftingManager: fixed uninitialized field
...
I'm having deja vu about this ...
2023-04-24 12:34:34 +01:00
edcaeef831
VanillaBlocks: reduce width of element block registration
2023-04-21 21:33:45 +01:00
d4ca566fd0
Move block permutation generation into Block
...
this allows sealing off a whole bunch of internal APIs.
2023-04-21 20:38:28 +01:00
6c0ad9589b
Block: rename isSameType() to hasSameTypeId()
...
this should remove any ambiguity about its behaviour.
2023-04-21 20:25:21 +01:00
84a16ce69a
HandlerList: fixed crash on getting unused priority
...
these sub-arrays are no longer allocated if no handlers are registered.
fixes #5713
2023-04-21 16:19:15 +01:00
d06d3bc871
4.19.4 is next
2023-04-21 15:53:05 +01:00
11e34b3e5c
Release 4.19.3
2023-04-21 15:53:02 +01:00
f9318bf286
TimingsHandler: stop throwing exceptions when timers aren't stopped in the right order
...
this is usually because of an uncaught exception interacting with a try...finally block.
This will normally result in a crash anyway, and we don't want to obscure the real error.
2023-04-21 15:38:11 +01:00
769be8e140
Fix CSÂ
2023-04-20 00:18:32 +01:00
c878bd8289
Merge remote-tracking branch 'origin/minor-next' into major-next
2023-04-20 00:18:19 +01:00
71b78b02d3
Merge remote-tracking branch 'origin/stable' into minor-next
2023-04-19 23:57:26 +01:00
4147d0dc75
tools/generate-blockstate-upgrade-schema: give better errors when a weird new blockstate version is found
2023-04-19 16:43:29 +01:00
674b65f789
Item: optimise serializeCompoundTag() a little
2023-04-18 16:18:34 +01:00
a77fc8109f
TypeConverter: avoid repeated calls to getId() and getMeta()
2023-04-18 15:02:52 +01:00
6102740ee3
TypeConverter: use a less slow hack to restore meta values on items sent by the client
...
this isn't even really needed anymore, since we don't decode items from the client since 4.18.
However, this may still be useful for tools.
2023-04-18 15:00:34 +01:00
40168a457e
TypeConverter: fixed coreItemStackToNet() causing item NBT to be prepared twice
...
hasNamedTag() calls getNamedTag(), which calls serializeCompoundTag(), which writes the item's properties into the given NBT tag.
2023-04-18 14:43:25 +01:00
d07acd0013
RakLibInterface: split error ID into 4-character chunks
...
this makes it easier to read, since the error ID can't be copy-pasted from the disconnection screen on the client.
2023-04-17 14:05:46 +01:00
9561ae5af7
Entity: micro optimisation for checkBlockIntersections()
2023-04-16 17:57:51 +01:00
56fbd45dd5
Entity: avoid double-checking block intersections for moving entities
...
fixes #1824
2023-04-16 17:38:26 +01:00
b5dc72b0ee
tools/simulate-chunk-selector: fixed the script being completely broken
...
getopt() behaviour is really, really dumb
2023-04-16 16:47:17 +01:00
4ba57f2b03
RegisteredListener: use try...finally to stop timings
...
While event handlers should not throw exceptions, we need to make sure the timings get stopped in the correct order, because the parent Event timer will be stopped due to using a finally block.
If this happens while the handler timing is still running, a second exception will occur, obscuring the real error.
2023-04-16 00:40:43 +01:00
1026811741
Merge branch 'minor-next' into major-next
2023-04-14 21:00:08 +01:00
84cb070d56
Merge branch 'stable' into minor-next
2023-04-14 20:12:33 +01:00
df0d72bf61
4.19.3 is next
2023-04-14 18:43:44 +01:00
a534ac759a
Release 4.19.2
2023-04-14 18:43:41 +01:00
5ab954b7a0
Update composer dependencies
2023-04-14 18:31:57 +01:00
6c6f686f8e
Timings: be more intelligent about shortening timer names
...
non-pocketmine classes may reuse the names of pocketmine core classes. We don't want timers to get erroneously reused in this case.
2023-04-14 18:24:53 +01:00
bf7975da57
Timings: use class to index packet timings, not IDs
...
on multi version servers, the same packet may have different IDs, or different packets might use the same ID. In these cases, we don't want the timings to get split up or erroneously reused.
2023-04-14 18:22:35 +01:00
7aeedd8220
Timings: fixed every player getting its own timings
...
we need a more consistent way to deal with this
2023-04-14 17:32:56 +01:00
3dd1ce2d02
4.19.2 is next
2023-04-14 16:47:46 +01:00
5a29d07021
Release 4.19.1
2023-04-14 16:47:43 +01:00
692e1253c6
Fixed AABB height for farmland and grass paths (fixed in 1.19.50)
2023-04-14 16:02:28 +01:00
ab0c444823
Player: fixed ticking chunks not being re-registered if they never left the view distance
...
closes #5699
2023-04-14 16:02:28 +01:00
e48a4aaa55
World: fixed chunk ticking not being disabled by setting chunk ticking radius to 0
...
I can't believe I missed this ...
2023-04-14 16:02:28 +01:00
6fc4ce0f86
ÂTimingsCommand: include HTTP response code in debug message
...
we should probably show this in the regular response message, but we need new translations for that.
2023-04-14 16:02:27 +01:00
6acabf7a1b
Block: add clarifying note about isSameType()
...
I'm still not happy with this method though...
2023-04-13 13:40:53 +01:00
10243c7b2c
Bump phpstan/phpstan from 1.10.11 to 1.10.13 ( #5697 )
...
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan ) from 1.10.11 to 1.10.13.
- [Release notes](https://github.com/phpstan/phpstan/releases )
- [Changelog](https://github.com/phpstan/phpstan/blob/1.11.x/CHANGELOG.md )
- [Commits](https://github.com/phpstan/phpstan/compare/1.10.11...1.10.13 )
---
updated-dependencies:
- dependency-name: phpstan/phpstan
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-13 13:19:24 +01:00
b122703fd0
BaseCoral: fixed late property initialization
2023-04-13 13:18:47 +01:00
e40774d62f
Block: make internal methods private (they are no longer used outside of Block)
2023-04-13 13:06:56 +01:00
027d8f7377
always the CS...
2023-04-13 12:55:18 +01:00
5950707267
Block: simplify required type data / state data bits code
2023-04-13 12:55:09 +01:00
6cace51a21
Remove unused variable
2023-04-13 12:47:17 +01:00
6703f46a08
Remove random dead TODOs
2023-04-13 12:47:08 +01:00
874fdf5adb
ItemBlock: reference blocks directly (take 2)
...
This was first attempted in f64dc01bd1closes #5609
2023-04-13 12:44:54 +01:00
1c626baf1a
Fixed dodgy custom block registration test
2023-04-13 12:27:55 +01:00
c3a2199f0e
Reduce global usage in world providers
2023-04-13 12:05:37 +01:00
