Dylan K. Taylor
24aab8365e
RCONInstance: remove redundant size ref param from readPacket()
2018-05-07 13:53:34 +01:00
Dylan K. Taylor
0e5504ed3f
RCONInstance: add docs to fields, make 'stop' private
2018-05-07 13:52:33 +01:00
Dylan K. Taylor
83008440c0
RCONInstance: replace hardcoded status values with constants
...
I thought I'd seen the worst of PM, but I haven't.........
2018-05-07 13:44:59 +01:00
Dylan K. Taylor
b14dfa9f7e
RCONInstance: Remove pointless code that makes pthreads segfault
...
pthreads doesn't play well with resources, and this code upsets it. Also, this code is utterly pointless.
The whole of RCON needs burning to the ground...
2018-05-07 10:05:05 +01:00
Dylan K. Taylor
197102ca3d
Level: fixed blocks not dropping when not broken by player
...
closes #2172
2018-05-05 21:50:28 +01:00
Dylan K. Taylor
f497e43db3
SourceInterface: removed redundant return value from process()
2018-05-05 15:30:46 +01:00
Dylan K. Taylor
38c3f00ef7
avoid crashes when XUID is null
2018-05-05 13:33:13 +01:00
Dylan K. Taylor
396056c636
Sign: Pad exploded blob to appropriate size
...
I'm not sure how it's possible to get one of these blobs with less newlines than expected, but whatever I guess
closes #2152
2018-05-04 23:29:32 +01:00
Dylan K. Taylor
dd1dfefd83
ItemEntity: remove unnecessary damage types restrictions
...
Invalid damage types are all restricted by other means anyway. This fixes items not getting killed by fire (close #2143 ) and cacti.
2018-05-04 22:57:28 +01:00
Dylan K. Taylor
7565b786e7
Implemented @notHandler annotation for event handlers - skip registering any handlers with this annotation ( #2164 )
...
It is somewhat reasonable to have a function in an event handler which accepts an Event parameter, but is not a handler. For example, multiple event handlers can redirect to the same function to process an event, but this function may not want to receive called events.
There are other ways to get around this, such as making the event handler protected/private, or adding a dummy parameter, but this way is cleaner and more explicit.
Relevant old-repo PR: PocketMine/PocketMine-MP#2143
2018-05-04 21:36:58 +01:00
SOFe
ae0c1c185f
Fixed wrong doccomment for Permission::$children
2018-05-04 15:31:00 +08:00
Dylan K. Taylor
723251e800
Fixed bug in commit hash detection when output ends with newline
2018-05-03 16:37:05 +01:00
Dylan K. Taylor
295016cbc1
DisconnectPacket: fix decoding
2018-05-02 16:56:48 +01:00
Dylan K. Taylor
d80c471ae1
Typehints on missed sound and particle APIs
2018-05-02 11:44:18 +01:00
Dylan K. Taylor
b4068dfd2f
remove unused import
2018-05-02 10:44:05 +01:00
Dylan K. Taylor
3095eb544d
Item: removed isTool()
...
this should be replaced with `instanceof Tool`.
2018-05-01 20:05:53 +01:00
Dylan K. Taylor
0247dff909
Fixed mis-uses of Item->isTool()
...
this has been wrongly used to indicate a durable item, but not just tools are durable items.
2018-05-01 20:05:02 +01:00
Dylan K. Taylor
5368120f13
Level: remove redundant getAutoSave() condition in close()
...
this is already checked by save() anyway.
2018-05-01 18:47:08 +01:00
Dylan K. Taylor
2e7db552dc
Level: __construct() now accepts a LevelProvider object instead of string, string
...
This is made possible by the removal of LevelProvider dependence on their Levels, and furthers the goal of #2024 .
2018-05-01 18:43:11 +01:00
Dylan K. Taylor
53c35aaa1d
Server: remove unused variable from generateLevel()
2018-05-01 18:26:03 +01:00
SOFe
3293074cfc
Implement @softDepend annotation for event handlers - skip registering if the event class is undefined ( #2162 )
...
This allows plugins to soft-depend on other plugins without separating their listeners into a dedicated class for listening to that plugin.
This can be utilized by adding a `@softDepend PluginName` to the event handler's annotations.
If the plugin providing the event does not exist or is not loaded, then the handler will silently not be registered.
If it does exist and the event is not found, the original behaviour applies and an exception will be thrown.
This change should be fully backwards compatible.
2018-05-01 14:33:24 +01:00
Dylan K. Taylor
d8f4dde5f3
PlayerHotbarPacket: remove unused import
2018-05-01 14:09:17 +01:00
Dylan K. Taylor
dfa6cd2b7e
Biome: Moved biome classes from level\generator\* to level\biome
2018-05-01 14:07:46 +01:00
Dylan K. Taylor
e03d2b23f7
Sign: add some typehints where it wasn't previously possible
2018-05-01 14:00:23 +01:00
Dylan K. Taylor
96a2fd7482
Server: fixed wonky doc comment for broadcastTitle()
2018-05-01 12:30:06 +01:00
Dylan K. Taylor
88c56bcdc8
Server: move formattingCodes check to initial assignment of doTitleTick
2018-05-01 12:21:41 +01:00
Dylan K. Taylor
2731fc3d0f
Server: remove redundant return value from tick()
2018-05-01 12:17:11 +01:00
Dylan K. Taylor
a02f178f80
PocketMine.php: add git hash length check "just in case"
2018-04-29 18:07:40 +01:00
Dylan K. Taylor
96d26a77a1
Explosion: set block damage to zero on destruction
2018-04-16 14:30:54 +01:00
Dylan K. Taylor
554fe4d14d
Updated dependencies, require 64-bit PHP in composer.json
2018-04-16 10:19:17 +01:00
Dylan K. Taylor
532269a484
Implemented block break XP drops
2018-04-15 19:03:18 +01:00
Dylan K. Taylor
1e2122d854
avoid crashing in forceShutdown() if properties wasn't initialized yet
2018-04-14 12:45:03 +01:00
Dylan K. Taylor
c276ef2b7f
Updated dependency versions
2018-04-13 20:09:18 +01:00
Dylan K. Taylor
5138bdc4bd
Updated DevTools submodule
2018-04-13 17:38:51 +01:00
Dylan K. Taylor
a30a157d8c
API bump to 3.0.0-ALPHA12
...
Yes, I am not happy about this either. new-versioning has issues, and there hasn't been enough development and testing on it.
I didn't want to delay release to cram in a half-baked new versioning system, and it's ended up delayed anyway and new-versioning is still half-baked.
we're overdue a new release, so here it is.
2018-04-13 13:31:15 +01:00
Dylan K. Taylor
e565cdeea4
Tile: remove unnecessary createAdditionalNBT() things
...
these things are filled in by the tiles' constructors anyway.
2018-04-13 11:50:04 +01:00
Dylan K. Taylor
556a465c05
Container tiles: remove unnecessary ListTag Items creation
...
the existence of this tag is checked for anyway.
2018-04-13 11:27:11 +01:00
Dylan K. Taylor
280f2b7259
always loose imports...
2018-04-13 11:25:52 +01:00
Dylan K. Taylor
933b0e8b41
Furnace: cleanup, stop abusing NBT, stop spamming packets
2018-04-13 11:22:47 +01:00
Dylan K. Taylor
58279d4cfe
NetworkBinaryStream: fixed not decoding items with negative IDs correctly
...
negative IDs are used for new block-items.
2018-04-11 13:01:41 +01:00
Dylan K. Taylor
1e21066c1c
Server: remove redundant == true from setConfigBool()
2018-04-10 12:22:21 +01:00
Dylan K. Taylor
76854da7ba
Command: remove dead field
2018-04-10 12:11:27 +01:00
Dylan K. Taylor
46cbcb0c42
Fixed fire with no nearby flammable blocks burning for too long
2018-04-10 10:07:14 +01:00
Dylan K. Taylor
af9b0b019d
Added BlockBurnEvent
2018-04-10 10:04:11 +01:00
Dylan K. Taylor
7db8845375
Fire has a 1/3 chance of aging on a random or scheduled tick
2018-04-10 09:59:54 +01:00
Dylan K. Taylor
f47f593555
Level: Removed fire hack from destroyBlockInternal()
...
this was causing unexpected behaviour particularly on burning trees, whereby fire would be unconditionally extinguished if the block below it was removed.
2018-04-10 09:59:40 +01:00
Dylan K. Taylor
691df5c11d
FlintSteel: remove instanceof Solid check
...
This makes the behaviour match vanilla. This will now allow Fire block itself to handle deletion of itself when the area is not suitable (now that the logic is implemented in Fire for this).
This allows attempting to place in invalid conditions, which is as expected. This will produce the sound and flash as per vanilla, as the fire extinguishes itself.
2018-04-10 09:59:27 +01:00
Dylan K. Taylor
9a1d3aec6b
Flammable blocks adjacent to fire now burn away
...
There are some strange bugs with blockupdating causing invisible client-side-only fires that need to be investigated.
2018-04-10 09:59:10 +01:00
Dylan K. Taylor
670a53ba3b
Fire: fixed logic of extinguishing
2018-04-10 09:58:58 +01:00
Dylan K. Taylor
f22ad14c67
Block: added isFlammable()
2018-04-10 09:58:35 +01:00
