06a9c98ded
MemoryManager: fix strict-rules error on phpstan level 7
2020-03-15 15:49:04 +00:00
5c7b05c2ba
CrashDump: do not assign possibly-false return value of fopen() directly to non-union field
...
this would become a problem with typed properties, and also phpstan level 7 doesn't like it.
2020-03-15 15:48:09 +00:00
9c86763322
CrashDump: do not assume that error_get_last() always returns array
...
this returns NULL if there was no error before the shutdown handler was triggered (usually caused by a plugin calling exit() prematurely).
2020-03-15 15:47:07 +00:00
35490ca41c
CrashDump: do not assume that file() always returns array
...
phpstan level 7 prep
2020-03-15 15:46:03 +00:00
47c7872c88
Merge branch 'stable' into next-minor
2020-03-14 13:42:39 +00:00
f84abcd1fe
sync composer.lock with 0dd68e587f
2020-03-14 13:36:35 +00:00
b5dd147ec7
PlayerQuitEvent: fix types of quitMessage
2020-03-14 13:24:40 +00:00
f8ce01e2fd
ItemFactory: extract fromStringSingle() from fromString()
...
on PM4, the multiple functionality is removed, but on PM3 this is a problem for phpstan.
2020-03-13 17:54:25 +00:00
3907a2b6ba
Process: split getMemoryUsage() into 2 functions
...
this isn't released yet so it's OK to change.
phpstan level 7 doesn't like these kinds of ambiguous return types because there's no way for it to tell which type is returned without a return type specifying extension, and it's easier to just change the API than to make PHPStan understand it.
2020-03-13 17:32:17 +00:00
0dd68e587f
require phpstan ^0.12.14 (for incremental analysis)
2020-03-13 16:30:35 +00:00
1171cd2493
Merge branch 'stable' into next-minor
2020-03-13 15:16:42 +00:00
330e93e5e3
Player: do not handle inbound ActorEvents that are not for self
2020-03-13 15:15:20 +00:00
e2579e0a2a
Merge branch 'stable' into next-minor
2020-03-12 11:47:33 +00:00
2020fcd18e
updated build/php submodule
2020-03-12 11:47:15 +00:00
5a9a576bfa
AddActorPacket: remove unused import
2020-03-10 12:45:52 +00:00
b8caf34e62
Merge branch 'stable' into next-minor
2020-03-10 12:45:00 +00:00
456d9a722a
reduce some doc comments to single line
2020-03-10 12:36:19 +00:00
344c980cff
GlobalConstants: add strict_types
2020-03-10 12:35:13 +00:00
167492087f
Chunk: specify expected bounds for Y coordinates
2020-03-10 12:33:53 +00:00
db215283a2
Effect: add desc for color parameter
2020-03-10 12:28:44 +00:00
6a507bb149
further CS fixes
2020-03-10 12:18:16 +00:00
dc757c25c8
cleanup CS from 8ec0a4d0d6
2020-03-10 12:14:38 +00:00
73267ae077
Merge branch 'stable' into next-minor
2020-03-10 12:11:36 +00:00
a72e6ee706
Player: be aware of held item changing during click-block
...
this caused bugs if the inventory was cleared while using a hoe.
2020-03-10 12:10:01 +00:00
8ec0a4d0d6
Allow specifying compatible OS in plugin manifest ( #3192 )
2020-03-10 10:12:56 +00:00
89ea7f0a76
Player: Stop setting held item post entity attack if changed ( #3348 )
...
closes #3340
2020-03-10 10:09:31 +00:00
df65f1009c
Merge branch 'stable' into next-minor
2020-03-09 14:33:37 +00:00
a6ca37429c
Player: do not set held item post block-break if changed ( #3345 )
...
this usually happens when a plugin replaces the held item during BlockBreakEvent.
closes #2010
2020-03-09 13:45:58 +00:00
4bf9fb278b
Bump phpstan/phpstan from 0.12.11 to 0.12.14 ( #3338 )
2020-03-09 13:31:23 +00:00
15d81154e6
PluginDescription: drop unenforceable type constraint on array keys
...
the data that comes through here isn't validated, and there's also no guarantee that all the keys will be strings in spite of our best efforts even if it was validated, because PHP is fucking stupid and casts int-like string keys to int keys.
2020-03-05 19:53:01 +00:00
93e5c80962
MultiplayerSettingsPacket is bothways, close #3331
2020-03-03 12:32:57 +00:00
c19ab97610
AddActorPacket: move BC hack to higher level
...
we shouldn't hack the protocol impl for BC.
2020-02-27 17:37:45 +00:00
dbaf851be7
Merge branch 'stable' into next-minor
2020-02-27 16:51:06 +00:00
7aa8bd18d3
Revert "Item: restrict bounds of count to 0-255"
...
This reverts commit 10317527e4
2020-02-25 20:42:03 +00:00
53067c26d7
BaseInventory: stop mutating item for no reason in canAddItem()
2020-02-25 20:30:37 +00:00
04581e2700
DataPacket: account for splitscreen header when decoding
2020-02-24 21:20:25 +00:00
93597dcd50
SkinData: fixed loss of data from packet decode
2020-02-24 20:48:03 +00:00
778814a35e
changelog: fix typo
2020-02-24 20:18:47 +00:00
3cd1da196a
UpdateTradePacket: fix order of fields, closes #3327
2020-02-24 20:16:07 +00:00
365d4a1592
better fix for 1.14.30 movement bug
2020-02-23 19:31:32 +00:00
2d7f37ac47
avoid direct mutation of Item->count field, use Item->pop() instead
...
I think this change was already applied on the master branch, but I don't remember for sure.
2020-02-23 17:37:25 +00:00
50fcdd6e7e
Item: fixed documentation of pop() return type (it's not fluent)
2020-02-23 17:32:50 +00:00
10317527e4
Item: restrict bounds of count to 0-255
2020-02-23 17:23:53 +00:00
46ac4cbca1
3.11.7 is next
2020-02-21 19:18:48 +00:00
cb9e79b398
Release 3.11.6
2020-02-21 19:18:48 +00:00
2f1fad2745
Bucket: implement MaybeConsumable, fixes #3306
...
this is a nauseating fix, but it's only needed for stable.
2020-02-21 17:49:55 +00:00
44182dccbd
Human: an additional hack for MoveActor(Absolute|Delta)Packet on 1.14.30+
...
before anyone asks, we still can't use this for regular player movement, because it would cause the player to receive their own movement. This was OK with MoveActor, but isn't OK with MovePlayer.
2020-02-21 12:35:17 +00:00
2f3d2d4a0b
Bump phpstan/phpstan from 0.12.10 to 0.12.11 ( #3311 )
2020-02-19 18:57:53 +00:00
8ac7f7f11f
Level: fix type of randomTickBlocks and friends
2020-02-17 15:13:40 +00:00
dbe7caab7b
updated build/preprocessor submodule
2020-02-14 08:21:46 +00:00
