Dylan K. Taylor
3be8472ae2
MemoryManager: fixed dumping of uninitialized properties
...
closes #4643
2021-12-13 12:11:49 +00:00
Dylan K. Taylor
22bb1ce8e0
4.0.3 is next
2021-12-12 23:27:54 +00:00
Dylan K. Taylor
178dcb71a9
Release 4.0.2
2021-12-12 23:27:50 +00:00
Dylan K. Taylor
0a58fd5472
GeneratorManager: fixed addGenerator() being case-sensitive when overwrite=true
...
this was caused by 083a1e1ff6b6ff5c0c1ba14250d2b026af103b90.
This was discovered by a new PHPStan rule I'm working on, which disallows overwriting the values of parameter variables. During the refactor of this function to correct the error, another error appeared: Variable might not be defined.
This is yet another excellent example of why mutability is bad.
2021-12-12 21:58:07 +00:00
Dylan K. Taylor
e06eefeab0
build/generate-known-translation-apis: fixed incorrect positional parameter order
...
closes #4639
2021-12-11 21:28:52 +00:00
Dylan K. Taylor
ede07c4314
Mark KnownTranslationKeys and KnownTranslationFactory as @internal
2021-12-11 21:24:18 +00:00
Dylan K. Taylor
cba00bf1e2
Merge branch 'stable' of github.com:pmmp/PocketMine-MP into stable
2021-12-10 23:24:38 +00:00
Dylan K. Taylor
e81bee3866
ConsoleReaderThread: disable opcache for console reader subprocess
2021-12-10 23:24:18 +00:00
dependabot[bot]
e6b85988b2
Bump fgrosse/phpasn1 from 2.3.0 to 2.3.1 ( #4636 )
...
Bumps [fgrosse/phpasn1](https://github.com/fgrosse/PHPASN1 ) from 2.3.0 to 2.3.1.
- [Release notes](https://github.com/fgrosse/PHPASN1/releases )
- [Changelog](https://github.com/fgrosse/PHPASN1/blob/master/CHANGELOG.md )
- [Commits](https://github.com/fgrosse/PHPASN1/compare/v2.3.0...v2.3.1 )
---
updated-dependencies:
- dependency-name: fgrosse/phpasn1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-12-10 22:37:28 +00:00
Dylan T
b50591303b
README: make shield show download count for 4.0.1, not 3.26.3
2021-12-10 20:23:48 +00:00
Leo Lee
9e75c1463a
Implement carving pumpkin ( #4637 )
2021-12-10 19:45:15 +00:00
Dylan K. Taylor
a94b88424e
Merge branch 'stable' into next-minor
2021-12-10 19:15:57 +00:00
Dylan K. Taylor
448f26cefc
SimpleCommandMap: do not strip backslashes from unquoted command arguments
2021-12-10 18:27:49 +00:00
Dylan K. Taylor
fa48100da5
PluginDescription: ensure base type of decoded document is actually an array
...
fixes #4628
2021-12-10 18:08:50 +00:00
Dylan K. Taylor
bcf8a3424c
Merge branch 'legacy/pm3' into stable
2021-12-10 18:02:06 +00:00
Dylan K. Taylor
69d5bfa0d4
3.26.4 is next
2021-12-10 17:55:11 +00:00
Dylan K. Taylor
549fb923bf
Release 3.26.3
2021-12-10 17:55:07 +00:00
Dylan K. Taylor
6d5c463bdd
PlayerExperienceChangeEvent: added range checks to setNewProgress()
...
WE FINALLY FUCKING FOUND IT
This took several years to identify because PHP's exception stack traces don't show the actual values of parameters, but rather the values of the variables they were assigned to.
This means that if the parameter variable is mutated, the exception trace will show the value of the variable inside the function, not the value that was actually passed.
2021-12-10 17:29:57 +00:00
Dylan K. Taylor
911ad344c9
Human: do not mutate parameter variables in setXpAndProgress()
...
this caused a mystery that took 3 entire years to debug.
2021-12-10 17:27:28 +00:00
Dylan K. Taylor
3b77462935
WritableBookBase: fixed crash when finding pages containing corrupted UTF-8 characters
...
maybe we should treat this as corrupted? but for now, it's consistent with how we deal with signs.
2021-12-10 16:39:13 +00:00
Dylan K. Taylor
6b40ed7bf8
Merge branch 'stable' of github.com:pmmp/PocketMine-MP into stable
2021-12-10 16:32:32 +00:00
Dylan K. Taylor
1ed9302f5a
ItemEntity: clone items given to the constructor directly
...
this fixes some bizarre mutability issues that occurred when using World->dropItem() with the same object multiple times.
2021-12-10 16:31:56 +00:00
Dylan T
b3dab0beef
readme: added total downloads & latest downloads badges
...
[ci skip]
2021-12-10 00:40:29 +00:00
Dylan K. Taylor
7ad1afee89
Merge branch 'next-minor' of github.com:pmmp/PocketMine-MP into next-minor
2021-12-09 13:54:06 +00:00
Dylan K. Taylor
292827a311
Switch to PlayerAuthInputPacket for movement handling
...
sticking with the non-rewind version for now, for simplicity's sake.
We do want the rewind version at some point for server side knockback, but that's a job for later.
For now, using this packet fixes various problems with slightly-incorrect positions and rotations (e.g. AimTP no longer requires you to jump to get the exact correct rotation; previously it would hit the wrong block at long distances due to errors of a fraction of a degree due to the client not sending its position.
Note that this might cause some performance degradation since the packet is sent every tick. This has yet to be assessed, but the advantages offered are undeniable in any case.
2021-12-09 13:53:53 +00:00
Matthew Jordan
f8ed23cc1e
ClearCommand: Add OffHandInventory to $inventories ( #4631 )
2021-12-09 11:19:33 +00:00
Dylan K. Taylor
6ddaed97fa
4.0.2 is next
2021-12-09 00:48:45 +00:00
Dylan K. Taylor
036b90d247
Release 4.0.1
2021-12-09 00:48:42 +00:00
Dylan K. Taylor
d909cd8a91
Merge branch 'legacy/pm3' into stable
2021-12-09 00:33:05 +00:00
Dylan K. Taylor
06eaf9f273
3.26.3 is next
2021-12-09 00:27:03 +00:00
Dylan K. Taylor
1e56ed2ea3
Release 3.26.2
2021-12-09 00:26:59 +00:00
Dylan K. Taylor
dccb8a3595
Merge branch 'legacy/pm3' into stable
2021-12-09 00:00:11 +00:00
Dylan K. Taylor
0ace807756
Merge commit 'b081394125f90c14d6894b24e2edb32f3284b3a0' into stable
2021-12-08 23:59:51 +00:00
Dylan K. Taylor
40895a86e5
draft-release: stick a banner on the release notes to declare obsolescence
2021-12-08 23:55:43 +00:00
Dylan K. Taylor
b081394125
Do not restrict the allowed update channels client-side
...
we really should have an endpoint on the server that deals with this.
2021-12-08 21:57:16 +00:00
Dylan K. Taylor
f48cf68cac
updater: log a message when an update was found, but it's an older version
2021-12-08 21:55:44 +00:00
Dylan K. Taylor
264cff70ec
Release new PM3 builds onto pm3 channel
2021-12-08 21:55:12 +00:00
Dylan K. Taylor
3aabfa4ab0
bootstrap: display value of PHPRC when PHP binary is borked
...
PHPRC overrides the search path for php.ini, which might break the php.ini locating.
2021-12-08 20:48:44 +00:00
Dylan K. Taylor
922ce2e312
Merge branch 'stable' into next-minor
2021-12-08 20:10:23 +00:00
Dylan K. Taylor
0793e7e094
PluginLoadabilityChecker: fixed logic of extension compatibility check
...
if the extension doesn't specify any version, we can't do any constraint other than *.
2021-12-08 20:08:53 +00:00
Dylan K. Taylor
7a385ddc8b
simulate-chunk-selector: remove unused colour allocation
2021-12-08 20:04:03 +00:00
Dylan K. Taylor
2254f31bec
Use Utils::assumeNotFalse() in tools/
2021-12-08 20:01:19 +00:00
Dylan K. Taylor
77a74d84e2
CrashDump: phpversion() could return false for a loaded extension
...
if the extension wrote NULL into the zend_module_entry->version field, phpversion() will return false.
2021-12-08 19:58:28 +00:00
Dylan K. Taylor
5b868e6d5e
Merge branch 'stable' into next-minor
2021-12-08 19:40:25 +00:00
Dylan K. Taylor
889d048ca3
Make use of Utils::assumeNotFalse() in a bunch of places
...
I've stuck to only doing this in the places where I'm sure we should never get false back. Other places I'm less sure of (and I found more bugs along the way).
2021-12-08 19:39:04 +00:00
Dylan K. Taylor
8b73549355
Use JSON_THROW_ON_ERROR for json_encode() and json_decode()
2021-12-08 19:14:07 +00:00
Dylan K. Taylor
c6466a6da9
Utils: added crutch assumeNotFalse()
...
this can be used to get PHPStan to shut up about stuff that will never return false in normal contexts.
It's more fine-grained than @phpstan-ignore-line and less hassle than ignoreErrors (and works in PhpStorm too).
In addition, it's easy to search for references.
2021-12-08 18:58:39 +00:00
Dylan K. Taylor
3d9e19546f
EntityShootBowEvent: fixed incorrect field type
2021-12-07 23:35:45 +00:00
Dylan K. Taylor
45b4fa0e96
Server: improve confusing condition in crashDump()
2021-12-07 23:08:06 +00:00
Dylan K. Taylor
bf29409a45
Server: fixed PHPStan level 7 error in crashDump()
2021-12-07 23:06:10 +00:00
