Dylan K. Taylor
f7de6eb59f
Network: Deprecate some garbage
...
Deprecations on a patch version breaks release protocol, but I don't care at this point. Nobody should have been using this shit anyway.
2018-12-31 22:52:39 +00:00
Dylan K. Taylor
75a0627bf2
Network: cut this catch-all bullshit out as well
...
If a network interface crashes, it should take out the whole server, not try to keep on ticking.
2018-12-31 22:40:13 +00:00
Dylan K. Taylor
8752e363c9
EXCUSE ME, HOW DARE YOU NOT LOG NETWORK ERRORS?!
2018-12-31 22:33:56 +00:00
Dylan K. Taylor
ff3d2ba19e
Fixed no-NBT banner items always placing black banners, closes #2624
2018-12-31 22:04:08 +00:00
Dylan K. Taylor
3b183447b0
Merge branch 'release/3.5'
2018-12-31 21:52:48 +00:00
Dylan K. Taylor
9ed1b5ca7f
Event: More detailed errors for non-cancellable events
2018-12-31 21:29:22 +00:00
Dylan K. Taylor
1cbb31f1db
Player: Reintroduce permission checks for command hints
...
This was removed way back in 2016 because of an unidentified bug which caused permissible commands not to show up on the client. Back then, command parsing and validity checks were client-sided, and the client would simply not send the command at all if it didn't recognize it. Now, that problem is gone, so it doesn't matter as much if there are permission bugs which cause commands to be erroneously missing.
closes #2625
2018-12-31 19:35:59 +00:00
Dylan K. Taylor
1393b4c4e2
Player: aDd a HacK foR CliEnt SidE rIghT cLicK SpaM BuG
...
this bug has existed for so long I forgot it was still here. People stopped pestering me to do something about it, and as a result I forgot to do anything about it.
This hack isn't perfect, but it filters out the worst of the noise. It has side effects for legitimate fast double-clicks, but I don't think anyone will be too bothered - just click more slowly.
This hack may also have negative side effects on poor connections where latency spikes are a problem, but there isn't really much that can be done about that.
2018-12-31 19:16:13 +00:00
Dylan K. Taylor
2921c86b3c
Torch: fixed crash on blockupdate with corrupted meta
2018-12-30 19:50:35 +00:00
Dylan K. Taylor
8415e49a7f
Merge branch 'release/3.5'
2018-12-30 19:06:37 +00:00
Dylan K. Taylor
9c3a929b65
3.5.4 is next
2018-12-30 19:04:47 +00:00
Dylan K. Taylor
9abaa42cd7
Release 3.5.3
2018-12-30 18:44:16 +00:00
Dylan K. Taylor
77b9feb3c0
Player: don't waste CPU time ordering chunks for non-moving players
2018-12-30 18:40:36 +00:00
Dylan K. Taylor
c6036fb012
Merge branch 'master' of https://github.com/pmmp/pocketmine-mp
2018-12-30 17:33:54 +00:00
Dylan K. Taylor
ae497a828f
Merge branch 'release/3.5'
2018-12-30 17:33:31 +00:00
Dylan K. Taylor
e0e2e1775f
Player: Fixed sluggish chunk updates when not moving
...
Always order chunks ASAP on chunk change, not just during the spawn sequence. This fixes the sluggishness observed in BlockSniper when doing async chunk modifications.
2018-12-30 17:32:38 +00:00
Dylan T
1e58144a38
Add Discord link to issue template
2018-12-30 17:19:25 +00:00
Dylan K. Taylor
d2d65ce6cc
Attribute: Fix exception messages, make them less useless
2018-12-30 13:44:30 +00:00
Dylan K. Taylor
ff2e982f22
Updated BinaryUtils dependency
2018-12-30 12:44:08 +00:00
Dylan K. Taylor
daf56e990b
Get rid of some network-layer asserts
...
NEVER assert on user data. 🤦
2018-12-30 12:42:52 +00:00
Dylan K. Taylor
39c0fa6103
Merge branch 'release/3.5'
2018-12-29 20:58:12 +00:00
Dylan K. Taylor
2e5465e328
Updated RakLib dependency
2018-12-29 20:13:28 +00:00
Dylan K. Taylor
7b3115c00c
Moved network NBT serializer into network namespace
2018-12-29 20:12:00 +00:00
Dylan K. Taylor
3f5e83a322
Backport 23954c4cda739190cb79295eeb78859c5c329be0 to 3.5 branch
2018-12-29 16:39:56 +00:00
Dylan K. Taylor
5ecc5ed7e0
Get rid of catch-all on chunk unload
...
god only knows what the fuck is going on in here that warrants this catch-all... so let's remove it and find out!
2018-12-29 16:37:59 +00:00
Dylan K. Taylor
cd80ae00d4
Handle errors properly on chunk load
...
Only CorruptedChunkException and UnsupportedChunkFormatException are expected. Anything else should crash the server.
2018-12-29 16:37:10 +00:00
Dylan T
ac87319aed
Introduce a "block write-batch" concept ( #2555 )
...
Make use of writebatch to generate trees, doors and double plants safely
- Fixes #2441
- Fixes #2548
- Closes #2498
2018-12-29 12:00:14 +00:00
Dylan K. Taylor
aaaddd1fd6
Terminal: stick a RESET on the end when writing a newline
2018-12-29 11:54:44 +00:00
Dylan K. Taylor
d86107e22a
Terminal: Added write() and writeLine() to allow easily emitting Minecraft-formatted text to the console
2018-12-29 11:28:25 +00:00
Dylan K. Taylor
498bffb34f
Fixed --enable-ansi and --disable-ansi not being respected on threads
...
this causes some breakage to the behaviour of Terminal, and for that reason this is going on 4.0.
Terminal::hasFormattingCodes() will no longer auto-detect whether colour codes are supported.
2018-12-29 11:23:32 +00:00
Dylan K. Taylor
10ac322b8f
Merge branch 'release/3.5'
2018-12-29 00:04:33 +00:00
Dylan K. Taylor
beb5d72299
RegionLoader: fix off-by-one bug with large chunks, closes #2615
2018-12-29 00:02:54 +00:00
Dylan K. Taylor
23954c4cda
RegionLoader: Remove dead/broken code
...
garbage collection does need to be implemented, but I was looking at this code and found so many fucking bugs I decided it wasn't worth the effort of fixing.
2018-12-28 23:03:24 +00:00
Dylan K. Taylor
baf278831e
Merge branch 'release/3.5'
2018-12-28 19:32:48 +00:00
Dylan K. Taylor
0eef634aab
Player: Give me ALLLLL your crashdumps
...
I suspect this is going to cause a firestorm, but once it does we'll be able to see what needs fixing.
2018-12-28 19:30:05 +00:00
Dylan K. Taylor
e6381297c7
NetworkCipher: fix some missing typehints
2018-12-28 17:35:37 +00:00
Dylan K. Taylor
3ebd7e8ba6
Add network-wide API to filter raw packets by regex, stricter validation for Query
2018-12-28 16:30:52 +00:00
Frago9876543210
f06e67a792
Allow plugins to disable background generation ( #2613 )
2018-12-28 14:34:54 +00:00
Dylan K. Taylor
78a80a6958
Tighten validity checks for block metadata
...
This filters out over 200 invalid states which were previously considered just fine, including zero-width cakes, buttons with broken facing values, furnace/chest with crazy values, and more.
2018-12-28 14:33:09 +00:00
Dylan K. Taylor
333773bf14
Merge branch 'release/3.5'
2018-12-28 13:04:17 +00:00
Dylan K. Taylor
0ea166a551
Prevent placement of unknown blocks, closes #2260
...
I don't know why I ever allowed this in the first place... stupid idea...
2018-12-28 13:03:34 +00:00
Dylan K. Taylor
045868783c
Merge branch 'master' of https://github.com/pmmp/pocketmine-mp
2018-12-28 12:56:01 +00:00
Dylan K. Taylor
e9d43aa44f
Fixed MainLogger not being assigned as global on async workers
2018-12-28 12:55:49 +00:00
Dylan K. Taylor
f64cef7eb6
ItemFactory: Get rid of $multiple crap
...
this is required in a specialized format, which doesn't make any sense. Plugins with multiple packed item formats should parse them themselves.
2018-12-28 11:55:52 +00:00
Dylan K. Taylor
ab75e89d95
Fixed generation changes in recent builds compared to 3.x
...
this was caused by improper RNG sanitization and a recent cleanup refactor.
2018-12-27 17:36:41 -05:00
Dylan K. Taylor
cf20f0e23a
Merge branch 'release/3.5'
2018-12-27 15:53:12 +00:00
Dylan K. Taylor
6417cff618
Fixed resource packs with comments in manifest
...
MOJANG, THERE'S NO SUCH THING AS COMMENTS IN STANDARD JSON
2018-12-27 15:50:51 +00:00
Dylan K. Taylor
8564efc011
Sync item and block legacy IDs
2018-12-27 15:02:14 +00:00
Dylan K. Taylor
b8f8a81704
Merge branch 'release/3.5'
2018-12-26 23:18:33 +00:00
Dylan K. Taylor
a71af952ba
Sign: simplify network data reading, ensure text is always 4 lines, closes #2610
2018-12-26 22:57:42 +00:00
