Dylan K. Taylor
c3c647d51e
NetworkSession: remove useless disconnect() call
...
this can't execute here because of the disconnectGuard, so this call always does nothing.
2020-11-16 22:13:48 +00:00
Dylan K. Taylor
d1775b166f
Merge branch 'stable'
...
# Conflicts:
# resources/vanilla
2020-11-16 21:35:08 +00:00
Dylan K. Taylor
37299ab804
ChunkCache: explicitly check for requesting of unloaded chunk
...
NetworkSession will never do this, but other things might.
2020-11-16 19:45:46 +00:00
Dylan K. Taylor
1d27225553
Relocate cache-related classes to mcpe\cache namespace
2020-11-16 19:39:30 +00:00
Dylan K. Taylor
9984b15de6
fix build #3
2020-11-16 19:25:13 +00:00
Dylan K. Taylor
6ea01e0dd4
fix build #2
2020-11-16 19:21:44 +00:00
Dylan K. Taylor
869c9dabf1
SetCommandsEnabledPacket: added ::create()
2020-11-16 19:11:10 +00:00
Dylan K. Taylor
ca6a892834
[ci skip] NetworkSession: added some extra TODOs
2020-11-16 19:10:27 +00:00
Dylan K. Taylor
16b71a265f
Barrel: added missing function import
2020-11-16 19:09:59 +00:00
Dylan K. Taylor
46331df7db
fix build
2020-11-16 19:06:56 +00:00
Dylan K. Taylor
691c49fb32
I don't know how to pass custom arguments to these scripts :<
2020-11-16 19:05:04 +00:00
Dylan K. Taylor
db815360d1
[ci skip] BUILDING.md: tell users to use 'composer make-server' instead of the server-phar script directly
...
this takes care of the dev dependencies automatically.
2020-11-16 19:03:39 +00:00
Dylan K. Taylor
6e297168c2
travis.sh: use new composer commands
2020-11-16 19:01:07 +00:00
Dylan K. Taylor
95dbb00d4c
Added custom composer commands: 'composer make-devtools' and 'composer make-server'
2020-11-16 18:55:23 +00:00
Dylan K. Taylor
50e29a5ed8
build/make-server: bail when composer dev dependencies are installed
...
these mess up the phar and make it extremely bloated. Almost everyone building for themselves unintentionally includes dev dependencies.
2020-11-16 18:54:07 +00:00
Dylan K. Taylor
de40ad80a6
Updated DevTools submodule to pmmp/DevTools@0c46527bee
2020-11-16 18:33:28 +00:00
Dylan K. Taylor
a9faed7171
[ci skip] update BlockFactory TODOs
2020-11-16 18:23:01 +00:00
Dylan K. Taylor
430d16e5f5
fixed borked test
2020-11-16 18:17:04 +00:00
Dylan K. Taylor
563336cdc9
CoralType: remove unused magicNumber stuff
2020-11-16 18:12:38 +00:00
Dylan K. Taylor
fd88c78d3a
added test for CoralTypeIdMap
...
we really need a better way to guarantee exhaustiveness for this ...
2020-11-16 18:12:01 +00:00
Dylan K. Taylor
1eee24f1fa
Implemented coral blocks
...
there are some complications with coral plants due to the fact we're stuck with R12 worlds right now - and also coral fans are a major pain to implement due to how messed up the metadata is.
2020-11-16 18:05:39 +00:00
Dylan K. Taylor
55a9ce46b9
VanillaBlocks: added BARREL
2020-11-16 17:56:13 +00:00
Dylan K. Taylor
d7c6a20b34
Barrel: added @return $this to setOpen()
2020-11-16 17:29:24 +00:00
Aericio
b2765f32e9
Implemented Barrels, closes #3672
2020-11-16 17:26:07 +00:00
Dylan K. Taylor
1cf3a500f8
Clean up ChestInventory handling
...
longer term I want to rip this crap out completely, but right now this provides minor maintainability benefits, while also making it slightly less nasty to deal with other containers which animate their blocks, such as barrels and shulker boxes.
2020-11-16 16:59:19 +00:00
Dylan K. Taylor
b534ae050e
DisallowEnumComparisonRule: detect bugs involving union types (Enum|null compared to Enum|null)
2020-11-14 16:51:13 +00:00
Dylan K. Taylor
4ade7b6225
added CoralType enum
2020-11-14 16:24:13 +00:00
Dylan K. Taylor
06efad94b6
Separated metadata handling from PillarRotationTrait
2020-11-14 16:21:50 +00:00
Dylan K. Taylor
7469f28f24
Server: rename getPlayer() to getPlayerByPrefix()
...
closes #3910
the existing naming was misleading, and many plugin devs assumed that it returns an exact match. However, this is not guaranteed, and it's possible for two different players to match the same prefix.
- There is no defined behaviour for what happens when multiple players can equally match a prefix (e.g. 'fr' could match 'fred' or 'frog' equally, because the name lengths are the same)
- A prefix might match a different player at a different time (e.g. 'fr' could match 'freddie' before 'fred' joins, after which it will match 'fred' instead)
With these flaws in mind, it's better to break compatibility on this to make the intent more clear, and to make plugin developers reassess their usages of this method. In most non-command use cases, they should likely be using getPlayerExact() instead.
2020-11-14 15:49:41 +00:00
Dylan K. Taylor
41a8007c47
phpstan: drop some error counts to account for recent Sugarcane changes
2020-11-12 22:26:04 +00:00
Dylan K. Taylor
8e0cba56b8
Merge remote-tracking branch 'origin/stable'
...
# Conflicts:
# resources/vanilla
# src/pocketmine/entity/Entity.php
# src/pocketmine/tile/Tile.php
# tests/phpstan/configs/check-explicit-mixed-baseline.neon
# tests/phpstan/configs/l7-baseline.neon
2020-11-12 22:10:47 +00:00
Dylan K. Taylor
9f3fb935b5
Update composer dependencies
2020-11-12 22:03:32 +00:00
Dylan K. Taylor
e30b1ee2c7
Clean up entity and tile saveID handling
...
we only ever need the first entry, so there's no point storing all of them. In addition, the field is private, which guarantees that nothing else needs the array either.
This also fixes phpstan/phpstan@c50650c5dd .
2020-11-12 21:49:12 +00:00
Dylan K. Taylor
04b038ff4b
[ci skip] more detail to PM4 changelog
2020-11-12 21:34:12 +00:00
Dylan K. Taylor
0d9561c93f
Removed crafting data cache from CraftingManager
2020-11-12 21:30:59 +00:00
Dylan K. Taylor
31089ce3b2
Timings: added broadcastPackets timer
...
the body of this function is potentially very expensive and isn't currently recorded by any timer.
2020-11-12 17:53:07 +00:00
Dylan K. Taylor
afbef242c6
bootstrap: remove useless phpdoc
2020-11-12 17:12:08 +00:00
Dylan K. Taylor
5efd0eba13
Imports cleanup
2020-11-12 17:11:34 +00:00
Dylan K. Taylor
c4d35d52e8
Do not store a pre-compressed cache for crafting data
...
this reduces bandwidth efficiency because it can't be compressed with everything else this way. If we want to cache stuff sent during the login sequence, it's better to stuff a bunch of stuff into a batch (e.g. crafting, creative, actor ids, biome defs) and pre-compress that as one big package instead.
2020-11-11 18:20:03 +00:00
Dylan K. Taylor
8f36957c10
phpstan: drop some dead level 8 ignoreErrors
2020-11-10 22:46:30 +00:00
Dylan K. Taylor
21d37623f8
sync phpstan level 8 baseline with 75f2f12b998014e6fb13ae1a98697aa188c4d002
2020-11-10 22:46:15 +00:00
Dylan K. Taylor
d08c9ee634
Merge remote-tracking branch 'origin/stable'
...
# Conflicts:
# resources/vanilla
# src/pocketmine/VersionInfo.php
2020-11-10 22:44:59 +00:00
Dylan K. Taylor
574b7f6343
3.15.5 is next
2020-11-10 16:48:18 +00:00
Dylan K. Taylor
e8b6b56330
Release 3.15.4
3.15.4
2020-11-10 16:48:18 +00:00
Dylan K. Taylor
c368ebb5e7
InventoryTransaction: beware of conflicting slot change actions with the same origin/target
...
these types of chains would never normally occur, but they've been seen in the wild. Attempting to resolve such chains has exponentially increasing complexity.
2020-11-10 16:45:20 +00:00
Dylan K. Taylor
75f2f12b99
NetworkSession: rename some badly-named hooks
2020-11-10 15:01:48 +00:00
Dylan K. Taylor
e23379c34b
EncryptionContext: provide the packet ID in the exception message
2020-11-10 14:45:19 +00:00
Dylan K. Taylor
6a266bcbd1
Separated XUID stuff from PlayerInfo into its own XboxLivePlayerInfo
2020-11-10 14:25:08 +00:00
Dylan K. Taylor
c43f14a2d2
Updated phpstan checkExplicitMixed baseline to account for changes in 463bc044df382d2f6d8caa8414cffe7daa965d29
2020-11-10 14:06:13 +00:00
Dylan K. Taylor
6c02bac437
Updated DevTools submodule to 66b8f7dfd77f78478a180e40137e17606301233e
2020-11-09 20:30:22 +00:00