4dcc14e0a1
Integrate block container animations and SFX into Block classes by way of AnimatedContainer interface
...
this allows getting rid of several container window classes.
we should probably look into adding more info to the BlockInventoryWindow to make the type easier to identify, though.
now that holder is tracked by an ephemeral window, we can put whatever we like in there.
2024-11-25 10:55:35 +00:00
f4d50a1aa1
Merge branch 'major-next' into inventory-rework
2024-11-24 23:57:03 +00:00
d72941c36c
Update IceBomb.php
2024-11-24 23:56:44 +00:00
6aa4e4c21f
CS
2024-11-24 23:51:41 +00:00
5c221247fe
Merge branch 'major-next' into inventory-rework
2024-11-24 23:51:16 +00:00
e51903d7ea
Merge branch 'minor-next' into major-next
2024-11-24 23:51:07 +00:00
30ee0aa63d
Merge branch 'stable' into minor-next
2024-11-24 23:50:56 +00:00
aef4fa7174
Remove unused variable
2024-11-24 23:50:30 +00:00
53aa380ca3
Candle: fix extinguish logic
...
closes #5983
2024-11-24 23:49:32 +00:00
7f58122ac6
Avoid unnecessary repeated calls
2024-11-24 23:43:51 +00:00
1738355357
Remove potentially problematic ephemeral window creation
...
this is *probably* fine, but best avoided.
2024-11-24 23:43:32 +00:00
fe1a8d98e7
namespace tidy
2024-11-24 23:29:13 +00:00
1d2b52732e
Chest block now has responsibility for configuring double chest inventories
...
it already needs to locate the correct pair anyway to know the left/right for DoubleChestInventoryWindow, so we might as well use this logic for initializing the DoubleChestInventory itself too. The old logic in tile/Chest didn't work correctly.
2024-11-24 22:47:35 +00:00
9c5df90e9b
Burn more junk
2024-11-24 22:11:38 +00:00
dcbf1c706a
this bites me every single time
2024-11-24 21:45:45 +00:00
45a4282e8b
First look: Split up Inventory & InventoryWindow
...
this unblocks a variety of changes, such as positionless tiles, enhanced APIs on Blocks for inventories, and also eliminates a bunch of cyclic references within the core code.
linked to #5033
2024-11-24 21:40:47 +00:00
473bbe64e0
BaseInventory no longer uses viewers to send updates to players
...
we want viewers to be as close to decorative as possible, so that they provide useful information to plugins, but don't get in the way of other changes.
2024-11-24 21:22:44 +00:00
f98cebbd62
Separate hotbar from player inventory
...
this allows this functionality to be used with any type of inventory, and also makes it a little nicer to use in many cases.
2024-11-24 17:58:58 +00:00
a5f607138c
Implement Ice Bomb ( #5452 )
...
Co-authored-by: Dylan K. Taylor <dktapps@pmmp.io >
2024-11-24 15:01:26 +00:00
8338ebaffd
Add generic types for TaskHandler ( #6030 )
2024-11-24 14:14:34 +00:00
3e9a96b43a
Merge 'minor-next' into 'major-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11990667732
2024-11-23 21:49:02 +00:00
082119cfd2
Merge 'stable' into 'minor-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11990667732
2024-11-23 21:49:01 +00:00
7460e12b6a
pr-remove-waiting-label: suppress failure on 404 errors
...
this usually means the label wasn't on the PR in the first place
2024-11-23 21:48:30 +00:00
9fce27eaa8
Merge 'minor-next' into 'major-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11990103798
2024-11-23 20:14:24 +00:00
a53b0116a0
Merge 'stable' into 'minor-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11990103798
2024-11-23 20:14:23 +00:00
5b72f202bf
actions: automatically remove waiting label from PRs on synchronize
...
there are probably other conditions where we'd want to remove this, but this will do for now.
2024-11-23 20:13:46 +00:00
7208733d62
Merge 'minor-next' into 'major-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11989715327
2024-11-23 19:10:14 +00:00
8b6adf86d6
Merge 'stable' into 'minor-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11989715327
2024-11-23 19:10:12 +00:00
0070426e97
auto-approve: only re-review if previous review was dismissed
...
this avoids unnecessary spam when someone clicks "Update branch" on the PR.
2024-11-23 19:07:24 +00:00
c61434d87b
Merge 'minor-next' into 'major-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11964819241
2024-11-22 01:36:17 +00:00
a523ed6e40
Merge 'stable' into 'minor-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11964819241
2024-11-22 01:36:16 +00:00
7c2ed7d884
Fix insta break check ( #6528 )
2024-11-21 02:22:10 +00:00
dcc258706f
Merge 'minor-next' into 'major-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11944832380
2024-11-21 01:27:14 +00:00
1e3a858de6
Add setUp and tearDown for event unit tests
2024-11-20 16:42:50 +00:00
844ba0ff9f
Move event test fixtures to a subdirectory
2024-11-20 15:40:34 +00:00
49bdaee930
Move event handler inheritance test to PHPUnit using mock objects
...
this is dodgy and we shouldn't rely on it long term.
relates to #6524
2024-11-20 15:38:51 +00:00
9195c88670
ConsoleReader: Use proc_open()'s socket support to send commands back to the main server process ( #5273 )
...
Support for this was introduced in PHP 8.0, though not mentioned in any changelog: php/php-src#5777
This simplifies the subprocess handling considerably. However, there is a potential for problems if PHP generates any E_* errors, since these get written to STDOUT as well.
To avoid error messages being treated as a command, a hash is attached to each IPC message, seeded with an incrementing counter. This prevents error messages causing command replays or unintended commands.
Unfortunately, PHP doesn't support binding pipes other than stdin/stdout/stderr on Windows for the child process, so we have to use stdout for this. In the future, if it becomes possible, a dedicated pipe for the purpose should be introduced. We'd need something like php://fd/<number> to work on Windows.
2024-11-20 14:56:52 +00:00
820e2d4a2f
Merge 'minor-next' into 'major-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11924942897
2024-11-20 01:27:32 +00:00
ae19d05fd5
Merge 'stable' into 'minor-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11924942897
2024-11-20 01:27:30 +00:00
bf7a53b00f
Update api-change-request.md
...
[ci skip]
2024-11-19 17:47:46 +00:00
e710b3750f
Adjust pretty name of closures on PHP 8.4 ( #6351 )
...
related to https://github.com/php/php-src/pull/13550
see analog symfony change: https://github.com/symfony/symfony/pull/54614
2024-11-19 17:05:21 +00:00
0fb1415f7f
Merge 'minor-next' into 'major-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11904511045
2024-11-19 01:36:12 +00:00
8ccd1edb17
Merge 'stable' into 'minor-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11904511045
2024-11-19 01:36:11 +00:00
faf1e26bac
Fix: implicitly nullable parameter declarations deprecated ( #6522 )
2024-11-18 23:54:22 +00:00
a6534ecbbb
Fixed merge error
2024-11-17 01:55:46 +00:00
330bcd2423
Merge 'minor-next' into 'major-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11874902000
2024-11-17 01:39:53 +00:00
b4259ef988
Merge 'stable' into 'minor-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11874902000
2024-11-17 01:39:52 +00:00
b2aa6396c3
auto-approve: don't request approvals for draft PRs
2024-11-16 23:15:07 +00:00
1555fa17e7
Added ability to pick end crystal item ( #6509 )
2024-11-16 19:06:03 +00:00
e77f2c5198
Implemented End Crystal ( #4715 )
...
Co-authored-by: Dylan T. <dktapps@pmmp.io >
2024-11-16 17:57:57 +00:00
