a6ca37429c
Player: do not set held item post block-break if changed ( #3345 )
...
this usually happens when a plugin replaces the held item during BlockBreakEvent.
closes #2010
2020-03-09 13:45:58 +00:00
dbaf851be7
Merge branch 'stable' into next-minor
2020-02-27 16:51:06 +00:00
365d4a1592
better fix for 1.14.30 movement bug
2020-02-23 19:31:32 +00:00
2f1fad2745
Bucket: implement MaybeConsumable, fixes #3306
...
this is a nauseating fix, but it's only needed for stable.
2020-02-21 17:49:55 +00:00
d63d6b73f6
Player: workaround 1.14.30 movement bug
...
I can understand why this bug happened, but it doesn't mean I like it.
Fix it pls mojang, this sucks.
2020-02-13 19:40:31 +00:00
15b76a24b7
scrub useless phpdoc
2020-02-10 12:21:07 +00:00
f08e411cad
Merge branch 'stable' into next-minor
2020-02-10 11:40:08 +00:00
495bfda044
Drop a bunch of invalid null defaults
...
phpstan doesn't report these out of the box, for reasons I'm not clear on. It's also not clear if having null defaults has any effect on nullability behaviour, so they are best removed. In addition, these would be problematic on 7.4.
2020-02-05 20:53:54 +00:00
dfc8a6ffdd
Player: remove useless code from save()
2020-02-05 19:54:50 +00:00
b96bb7d824
Player: use strict base64_decode() for login decoding
...
though, perhaps we should beware of false returns?
2020-02-05 13:55:38 +00:00
f624871b3f
strip extra blank lines (php-cs-fixer)
2020-01-22 14:50:29 +00:00
9f44adf04a
pass 2, manual removal of incorrect non-nullable @param for nullable native types
2020-01-21 15:44:34 +00:00
c4793241f5
Mass removal of useless @param/@return PHPDoc annotations, pass 1
2020-01-21 15:10:18 +00:00
2c11742f9e
Player: populate missing type information
2020-01-19 19:16:38 +00:00
1eedac87b2
added missing @var property types (reported by phpstan)
2020-01-09 14:13:54 +00:00
f355044626
resources: do not remove client-side resource packs when forcing resources
...
I wanted to make this into a dedicated option, but it had some side effects (see 4794ba236a
).
I'll settle for just disabling this useless behaviour, since we have other ways to force vanilla resources anyway; setting this flag to always-false has no user-facing effects anyway.
2020-01-04 16:14:08 +00:00
4794ba236a
Revert "resource packs: added new option remove_client_resources, fixed client packs being removed when forcing resource pack download"
...
This reverts commit 06ec8b8397
.
unfortunately, this had some unanticipated side effects, thanks to
idiotic behaviour in the client ... when having optional downloads but
trying to force resources, the client chokes because it thinks the
server is forcing it to apply a pack that it doesn't have. Since
there's no way to detect when this problem occurs in the protocol, the
only option is to revert this.
2020-01-04 16:04:07 +00:00
06ec8b8397
resource packs: added new option remove_client_resources, fixed client packs being removed when forcing resource pack download
2020-01-04 13:16:47 +00:00
494660102e
Replace empty() usages with count()
2019-12-18 11:23:24 +00:00
1a467420e3
Merge branch 'stable' into next-minor
2019-12-12 13:07:02 +00:00
26230c1f9b
Player: don't report never-played for a disconnected player
...
this should catch fire like everything else does.
2019-12-12 12:17:52 +00:00
1171bae691
login: read the correct key SkinAnimationData
2019-12-11 22:40:05 +00:00
494f8e8251
login: fixed missing base64_decode() for animation images
2019-12-11 22:39:40 +00:00
02fcfcc383
Merge branch 'stable' into next-minor
2019-12-09 10:47:53 +00:00
394c999710
Merge branch 'drew-1.13' into stable
2019-12-06 20:38:49 +00:00
16817ff301
Player: remove superfluous conditions for RESPAWN action handling
...
spawned is always true here because of the condition at the top of the function.
isOnline() is always true here because the handler won't even be called if it isn't.
2019-12-05 14:52:12 +00:00
18863b1098
Player: remove superfluous check from processMovement()
...
if we reached this branch, revert is always false because it is not modified between this branch and the parent one.
detected by phpstan level 4
2019-12-05 14:47:15 +00:00
fa56290bb4
Reflect StartGamePacket changes in Player
2019-11-21 15:05:09 -05:00
c8d0cb315b
Move persona skin hack to legacyskinadapter
2019-11-20 21:52:49 -05:00
be9c413a9e
Added network components for skins, to collect instead of throw out data
2019-11-20 21:43:41 -05:00
ba5a5981a0
Update Player.php
2019-11-12 08:19:05 +00:00
a81d8dd6d5
Return false in unexpected condition
2019-11-11 16:25:53 -05:00
7b152def7d
Move SkinAnimation and changed SerializedImage to SkinImage
...
Also change putImage and getImage to getSkinImage and putSkinImage
2019-11-11 15:23:48 -05:00
e2fc7cdf88
Friendly BC skins (persona not supported)
2019-11-10 21:04:38 -05:00
29cc9283f8
reverse unnecessary formatting changes
2019-11-08 11:29:00 +00:00
e60962c31f
reverse BC-breaking change to Player->changeSkin()
...
this change would cause LSP violations for subclasses
2019-11-08 11:22:55 +00:00
f6b5301e17
Player: remove unused import
2019-11-08 11:10:20 +00:00
73b923e3a1
cleanup eating clusterfuck
2019-11-08 11:08:22 +00:00
d2e4eb40b3
CompletedUsingItemPacket is superfluous
2019-11-08 08:29:25 +00:00
bfb1ad1327
Removed PlayerUIInventory and BaseUIInventory
2019-11-07 23:17:01 -05:00
eef979db4c
Switch to isUsingItem()
...
I don't plan on using this, as you informed me on discord that I didn't need the extra step, and it's a BC break anyway
2019-11-07 19:49:04 -05:00
40b4166a6e
created method sendCompletedUsingItemPacket for less duplication
2019-11-06 22:30:05 -05:00
3511ac010d
Fixed crafting
2019-11-06 20:42:53 -05:00
07f19dd4a1
Fixed respawning
2019-11-05 22:33:12 -05:00
17a17c31f3
Fixed items, but I'm not so sure how well this'll work out, it'll need improved in the future
2019-11-05 22:25:11 -05:00
8b912c1363
Removed some useless casts
2019-11-05 20:59:48 -05:00
080209c469
Fixed persona skins being messed up on join
2019-11-05 20:35:33 -05:00
cd2b60a860
Initial update to 1.13
2019-10-30 21:36:08 -04:00
0591458ef6
Merge branch 'stable' into next-minor
2019-10-22 18:49:22 +01:00
562b47a1e5
Player: guard against repeated resource pack sequence
...
this can happen because of the client being super broken in 1.12
close #3036
2019-10-03 11:20:44 +01:00