mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-10-17 19:50:18 +00:00
Code Issues Projects Releases Wiki Activity
16,016 Commits 15 Branches 453 Tags
2538880408b54418cce05171b7cf3af58cfdf4c3
Commit Graph

998 Commits

Author SHA1 Message Date
Dylan K. Taylor
e7771d76f2 Cover buffered inventory sync in timings 2023-03-20 23:29:02 +00:00
Dylan K. Taylor
ecc830a689 InventoryManager: avoid calling TypeConverter::getInstance() in a loop 2023-03-20 23:24:52 +00:00
Dylan K. Taylor
ee72e80fbb ItemStackResponseBuilder: removed incorrect code 
the client expects that all itemstacks must be acked by ItemStackResponse, regardless of whether the server changed them to some other item.
We'll overwrite the item to the correct thing at the end of the tick anyway.
 2023-03-20 23:21:24 +00:00
Dylan K. Taylor
63310cf764 Do not cache ItemStacks for every item 
this is very memory inefficient, and only provides a performance advantage in cold code anyway.
 2023-03-20 23:18:43 +00:00
Dylan K. Taylor
1992d3b6db InventoryManager: avoid useless work in trackItemStack() 
this attempts to accommodate slots being set to themselves, which is a rare enough occurrence (only plugins will cause it) that it doesn't make sense to penalize every inventory update this way.
attempting to avoid changing the itemstackID in this way is detrimental to performance, and it doesn't actually matter if we set a new itemstackID anyway.
 2023-03-20 23:08:17 +00:00
Dylan K. Taylor
035a0a4e9d InventoryManager: specialize trackItemStack() to avoid useless lookups 2023-03-20 22:57:58 +00:00
Dylan K. Taylor
23ea721164 Reduce packets-per-batch limit to 100 
this should be well in excess of requirements with the ItemStackRequest system in use.
 2023-03-20 22:15:02 +00:00
Dylan K. Taylor
8408da8534 Merge branch 'item-stack-request' into minor-next 2023-03-20 22:05:50 +00:00
Dylan K. Taylor
c9601ae67d Fixed crash when opening crafting table and other 'UI' inventories 2023-03-20 22:00:38 +00:00
Dylan K. Taylor
758b5ee500 InventoryManager: fixed armor slots hack 
the correct condition for this should be an unsynced armor slot changed during a transaction, but conveying this information to syncSlot() is a bit of a hassle, so this will do for now.
 2023-03-20 21:27:56 +00:00
Dylan K. Taylor
ca6d51498f Buffer slot and content syncing until the end of the tick 
we may receive multiple requests in one tick (e.g. crafting in a batch)
 2023-03-20 19:16:00 +00:00
Dylan K. Taylor
e8085e22a0 Fixed crash when opening main inventory 
the InventoryManagerEntry was getting overwritten, since we don't expect to open the same inventory with two different window IDs.
 2023-03-20 18:40:18 +00:00
Dylan K. Taylor
a83fc85f1e InventoryManagerEntry: fixed missing default 2023-03-20 17:32:44 +00:00
Dylan K. Taylor
3d70a169e1 Reduce chaos in InventoryManager 
the information in these arrays is usually needed all at the same time, so it doesn't make sense to force multiple array lookups for it.

in addition, this (obviously) cleans up the code quite a lot.
 2023-03-20 17:31:54 +00:00
Dylan K. Taylor
6ccb8f7373 git 2023-03-20 16:57:38 +00:00
Dylan K. Taylor
59bae9b077 Give InventoryManager internals clearer names 
and stop mixing 'window' and 'inventory' terminology...
 2023-03-20 16:53:57 +00:00
Dylan K. Taylor
c91168db66 ... 2023-03-20 01:35:15 +00:00
Dylan K. Taylor
4e55433ed8 Fixed request rejecting 2023-03-20 01:35:03 +00:00
Dylan K. Taylor
eece6c4433 InGamePacketHandler: remove dead code 2023-03-20 01:28:18 +00:00
Dylan K. Taylor
67b7b60d18 .............. 2023-03-20 01:19:07 +00:00
Dylan K. Taylor
804feedb67 Added some dumb limits 2023-03-20 00:54:33 +00:00
Dylan K. Taylor
d57aca1367 CS 2023-03-20 00:53:00 +00:00
Dylan K. Taylor
7b0816e42f Properly handle transaction building errors instead of kicking the player 2023-03-20 00:52:26 +00:00
Dylan K. Taylor
4864444440 Added CraftingManager::getCraftingRecipeFromIndex() 2023-03-19 22:14:23 +00:00
Dylan K. Taylor
f696a5881b Merge remote-tracking branch 'origin/stable' into minor-next 2023-03-19 16:23:09 +00:00
Dylan K. Taylor
9a969e21c7 ÂNetworkSession: ensure onResolve handler for CompressBatchPromise is covered by network send timings 2023-03-18 22:49:52 +00:00
Dylan K. Taylor
195bc3b623 NetworkSession: prevent dev client asserts from missing ability flags 2023-03-18 21:53:17 +00:00
Dylan K. Taylor
ef45180b80 Rename DataPacketPreReceiveEvent -> DataPacketDecodeEvent 
thank you @IvanCraft623 for the suggestion
 2023-03-16 13:40:37 +00:00
Dylan K. Taylor
941fd03998 Remove useless code 2023-03-15 22:58:10 +00:00
Armen Deroian
183d1f4038 Implement DataPacketPreReceiveEvent (#5559) 
closes #5554

This is called just before the packet is decoded, allowing the event to be used to drop packets from clients without wasting CPU time decoding them. This can be particularly useful for mitigating denial-of-service attacks.
 2023-03-15 22:47:19 +00:00
Dylan K. Taylor
08ee825d91 StandardPacketBroadcaster: Include varint length prefix in length calculation 
varints encode 7 bits per byte, so a log with base 128 will tell us how many bytes are required to encode the length of the packet.
 2023-03-15 22:41:19 +00:00
Dylan K. Taylor
a31e3331fd Move Server::broadcastPackets() to NetworkBroadcastUtils::broadcastPackets() 
this has no business being in Server, and it also doesn't need to be an instance method, since it never uses $this.
 2023-03-15 22:25:23 +00:00
Dylan K. Taylor
cc8660629b First look at shared EntityEventBroadcaster, 
this improves performance in PvP servers and other areas where lots of players or entities exist in one space.

fixes #5622
 2023-03-15 18:22:56 +00:00
Dylan K. Taylor
e7e19abe85 IPv4 and IPv6 RakLibInterface instances now both use the same broadcaster and context 
fixes #5625
 2023-03-15 17:17:56 +00:00
Dylan K. Taylor
34ced382db Eliminate final remaining usage of TypeConverter::netItemStackToCore() 
instead, we can verify that the held items match by comparing the received ItemStack with the one cached in InventoryManager, which is more cost effective and closes off internal item deserializers to external attacks.
 2023-03-14 22:56:11 +00:00
Dylan K. Taylor
a573a279fa Merge branch 'minor-next' into item-stack-request 2023-03-14 22:25:49 +00:00
Dylan K. Taylor
14f141fab2 NetworkSession: Stop counting DataPacketReceiveEvent in handler timings 
we want it to be included in receive timings, but not handler timings. Handler timings should reflect the time spent in the actual session PacketHandler, not in the event.
 2023-03-14 19:00:15 +00:00
Dylan K. Taylor
daff955bc4 Merge remote-tracking branch 'origin/stable' into minor-next 2023-03-14 18:42:14 +00:00
Dylan K. Taylor
0022d82779 Merge commit 'd376399b7f332384532a82eaf69b9b02dad5bd0c' into minor-next 2023-03-14 18:39:03 +00:00
Dylan K. Taylor
3de7a8c27f Updated for 1.19.70 2023-03-14 18:08:10 +00:00
Dylan K. Taylor
8e280ebb8b RuntimeBlockMapping: avoid unnecessary PacketSerializer usage 2023-03-11 22:16:24 +00:00
Dylan K. Taylor
fa7c38276c Fixing gigantic clusterfuck with protocol contexts and broadcasting 
fixes #5623
 2023-03-11 21:54:14 +00:00
Dylan K. Taylor
b13e97de3d Timings: fixed receivePacket timer showing 2x the actual number of received packets 2023-03-11 19:13:10 +00:00
Dylan K. Taylor
3db1492c18 Fix CS again 2023-03-04 16:43:29 +00:00
Dylan K. Taylor
a523189149 Added separate timings for broadcast and session buffer compression 2023-03-04 16:41:41 +00:00
Dylan K. Taylor
f8893efb94 Don't bother with global batch compression if there is only 1 recipient 
this allows the session to achieve better ratios, and also reduces worker pool spam.
 2023-03-04 16:34:00 +00:00
Dylan K. Taylor
aaec21f544 Compressor: Use minCompressionThreshold exclusively 
closes #5589
 2023-03-04 15:07:50 +00:00
Dylan K. Taylor
0fcd2e7894 Merge branch 'stable' into next-minor 2023-02-28 19:23:25 +00:00
Dylan K. Taylor
e7209679fb ... 2023-02-24 22:23:00 +00:00
Dylan K. Taylor
ae50b952f1 Accept 1.19.63 (same protocol, different protocol version) 2023-02-24 22:15:58 +00:00