Implement handlers stuck detection system

Merge remote-tracking branch 'upstream/minor-next' into feat/async-events
github web editor don't fuck up indentation, challenge impossible
2025-09-12 20:35:11 +00:00 · 2025-08-05 15:37:24 +02:00 · 2025-07-29 14:12:40 +02:00 · 2024-11-29 14:13:25 +00:00 · 2024-11-29 14:08:06 +00:00 · 2024-11-29 13:49:20 +00:00
213 changed files with 5016 additions and 6399 deletions
--- a/.github/workflows/build-docker-image.yml
+++ b/.github/workflows/build-docker-image.yml
@ -4,11 +4,6 @@ on:
  release:
    types:
      - published
-  workflow_dispatch:
-    inputs:
-      release:
-        description: 'Tag name to build'
-        required: true

 jobs:
  build:
@ -33,28 +28,16 @@ jobs:
          password: ${{ secrets.GITHUB_TOKEN }}

      - name: Clone pmmp/PocketMine-Docker repository
-        uses: actions/checkout@v5
+        uses: actions/checkout@v4
        with:
          repository: pmmp/PocketMine-Docker
          fetch-depth: 1

-
-      - name: Get tag name
+      - name: Get tag names
        id: tag-name
        run: |
-          if [[ "${{ github.event_name }}" == "release" ]]; then
-            echo TAG_NAME="${{ github.event.release.tag_name }}" >> $GITHUB_OUTPUT
-          elif [[ "${{ github.event_name }}" == "workflow_dispatch" ]]; then
-            echo TAG_NAME="${{ github.event.inputs.release }}" >> $GITHUB_OUTPUT
-          else
-            echo "Unsupported event type: ${{ github.event_name }}"
-            exit 1
-          fi
-
-      - name: Parse version
-        id: version
-        run: |
-          VERSION="${{ steps.tag-name.outputs.TAG_NAME }}"
+          VERSION=$(echo "${{ github.ref }}" | sed 's{^refs/tags/{{')
+          echo TAG_NAME=$VERSION >> $GITHUB_OUTPUT
          echo MAJOR=$(echo $VERSION | cut -d. -f1) >> $GITHUB_OUTPUT
          echo MINOR=$(echo $VERSION | cut -d. -f1-2) >> $GITHUB_OUTPUT

@ -88,8 +71,8 @@ jobs:
          push: true
          context: ./pocketmine-mp
          tags: |
-            ${{ steps.docker-repo-name.outputs.NAME }}:${{ steps.version.outputs.MAJOR }}
-            ghcr.io/${{ steps.docker-repo-name.outputs.NAME }}:${{ steps.version.outputs.MAJOR }}
+            ${{ steps.docker-repo-name.outputs.NAME }}:${{ steps.tag-name.outputs.MAJOR }}
+            ghcr.io/${{ steps.docker-repo-name.outputs.NAME }}:${{ steps.tag-name.outputs.MAJOR }}
          build-args: |
            PMMP_TAG=${{ steps.tag-name.outputs.TAG_NAME }}
            PMMP_REPO=${{ github.repository }}
@ -101,8 +84,8 @@ jobs:
          push: true
          context: ./pocketmine-mp
          tags: |
-            ${{ steps.docker-repo-name.outputs.NAME }}:${{ steps.version.outputs.MINOR }}
-            ghcr.io/${{ steps.docker-repo-name.outputs.NAME }}:${{ steps.version.outputs.MINOR }}
+            ${{ steps.docker-repo-name.outputs.NAME }}:${{ steps.tag-name.outputs.MINOR }}
+            ghcr.io/${{ steps.docker-repo-name.outputs.NAME }}:${{ steps.tag-name.outputs.MINOR }}
          build-args: |
            PMMP_TAG=${{ steps.tag-name.outputs.TAG_NAME }}
            PMMP_REPO=${{ github.repository }}
--- a/.github/workflows/copilot-setup-steps.yml
+++ b/.github/workflows/copilot-setup-steps.yml
@ -18,7 +18,7 @@ jobs:
      contents: read

    steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v4

      - name: Setup PHP
        uses: pmmp/setup-php-action@3.2.0
@ -41,7 +41,7 @@ jobs:
        run: composer install --prefer-dist --no-interaction

      - name: Clone extension stubs
-        uses: actions/checkout@v5
+        uses: actions/checkout@v4
        with:
          repository: pmmp/phpstorm-stubs
          path: extension-stubs
--- a/.github/workflows/discord-release-notify.yml
+++ b/.github/workflows/discord-release-notify.yml
@ -4,21 +4,16 @@ on:
  release:
    types:
      - published
-  workflow_dispatch:
-    inputs:
-      release:
-        description: 'Release to make notification for'
-        required: true

 jobs:
  build:
    runs-on: ubuntu-latest

    steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v4

      - name: Setup PHP and tools
-        uses: shivammathur/setup-php@2.35.4
+        uses: shivammathur/setup-php@2.34.1
        with:
          php-version: 8.2

@ -35,17 +30,9 @@ jobs:
      - name: Install Composer dependencies
        run: composer install --no-dev --prefer-dist --no-interaction --ignore-platform-reqs

-      - name: Get tag name
+      - name: Get actual tag name
        id: tag-name
-        run: |
-          if [[ "${{ github.event_name }}" == "release" ]]; then
-            echo TAG_NAME="${{ github.event.release.tag_name }}" >> $GITHUB_OUTPUT
-          elif [[ "${{ github.event_name }}" == "workflow_dispatch" ]]; then
-            echo TAG_NAME="${{ github.event.inputs.release }}" >> $GITHUB_OUTPUT
-          else
-            echo "Unsupported event type: ${{ github.event_name }}"
-            exit 1
-          fi
+        run: echo TAG_NAME=$(echo "${{ github.ref }}" | sed 's{^refs/tags/{{') >> $GITHUB_OUTPUT

      - name: Run webhook post script
        run: php .github/workflows/discord-release-embed.php ${{ github.repository }} ${{ steps.tag-name.outputs.TAG_NAME }} ${{ github.token }} ${{ secrets.DISCORD_RELEASE_WEBHOOK }} ${{ secrets.DISCORD_NEWS_PING_ROLE_ID }}
--- a/.github/workflows/draft-release-pr-check.yml
+++ b/.github/workflows/draft-release-pr-check.yml
@ -30,7 +30,7 @@ jobs:
      valid: ${{ steps.validate.outputs.DEV_BUILD == 'false' }}

    steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v4

      - name: Check IS_DEVELOPMENT_BUILD flag
        id: validate
@ -46,10 +46,10 @@ jobs:
    runs-on: ubuntu-22.04

    steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v4

      - name: Setup PHP
-        uses: shivammathur/setup-php@2.35.4
+        uses: shivammathur/setup-php@2.34.1
        with:
          php-version: 8.2

--- a/.github/workflows/draft-release.yml
+++ b/.github/workflows/draft-release.yml
@ -82,12 +82,12 @@ jobs:
    runs-on: ubuntu-22.04

    steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v4
        with:
          submodules: true

      - name: Setup PHP
-        uses: shivammathur/setup-php@2.35.4
+        uses: shivammathur/setup-php@2.34.1
        with:
          php-version: ${{ env.PHP_VERSION }}

--- a/.github/workflows/main-php-matrix.yml
+++ b/.github/workflows/main-php-matrix.yml
@ -27,7 +27,7 @@ jobs:
      fail-fast: false

    steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v4

      - name: Setup PHP
        uses: pmmp/setup-php-action@3.2.0
@ -59,7 +59,7 @@ jobs:
      fail-fast: false

    steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v4

      - name: Setup PHP
        uses: pmmp/setup-php-action@3.2.0
@ -91,7 +91,7 @@ jobs:
      fail-fast: false

    steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v4
        with:
          submodules: true

@ -125,7 +125,7 @@ jobs:
      fail-fast: false

    steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v4

      - name: Setup PHP
        uses: pmmp/setup-php-action@3.2.0
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@ -11,7 +11,7 @@ jobs:
    strategy:
      fail-fast: false
      matrix:
-        php: ["8.1", "8.2", "8.3", "8.4"]
+        php: ["8.1", "8.2", "8.3"]

    uses: ./.github/workflows/main-php-matrix.yml
    with:
@ -25,10 +25,10 @@ jobs:
      fail-fast: false

    steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v4

      - name: Setup PHP and tools
-        uses: shivammathur/setup-php@2.35.4
+        uses: shivammathur/setup-php@2.34.1
        with:
          php-version: 8.3
          tools: php-cs-fixer:3.75
@ -45,7 +45,7 @@ jobs:
      fail-fast: false

    steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v4

      - name: Run ShellCheck
        uses: ludeeus/action-shellcheck@2.0.0
--- a/.github/workflows/update-updater-api.yml
+++ b/.github/workflows/update-updater-api.yml
@ -4,11 +4,6 @@ on:
  release:
    types:
      - published
-  workflow_dispatch:
-    inputs:
-      release:
-        description: 'Release to publish info for'
-        required: true

 jobs:
  build:
@ -19,22 +14,14 @@ jobs:
      - name: Install jq
        run: sudo apt update && sudo apt install jq -y

-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v4
        with:
          repository: ${{ github.repository_owner }}/update.pmmp.io
          ssh-key: ${{ secrets.UPDATE_PMMP_IO_DEPLOY_KEY }}

-      - name: Get tag name
+      - name: Get actual tag name
        id: tag-name
-        run: |
-          if [[ "${{ github.event_name }}" == "release" ]]; then
-            echo TAG_NAME="${{ github.event.release.tag_name }}" >> $GITHUB_OUTPUT
-          elif [[ "${{ github.event_name }}" == "workflow_dispatch" ]]; then
-            echo TAG_NAME="${{ github.event.inputs.release }}" >> $GITHUB_OUTPUT
-          else
-            echo "Unsupported event type: ${{ github.event_name }}"
-            exit 1
-          fi
+        run: echo TAG_NAME=$(echo "${{ github.ref }}" | sed 's{^refs/tags/{{') >> $GITHUB_OUTPUT

      - name: Download new release information
        run: curl -f -L ${{ github.server_url }}/${{ github.repository }}/releases/download/${{ steps.tag-name.outputs.TAG_NAME }}/build_info.json -o new_build_info.json
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@ -56,6 +56,7 @@ PocketMine-MP has three primary branches of development.
 | Deprecating API classes, methods or constants                                               |    ❌     |               ✔️                |      ✔️      |
 | Adding optional parameters to an API method                                                 |    ❌     |               ✔️                |      ✔️      |
 | Changing API behaviour                                                                      |    ❌     | 🟡 Only if backwards-compatible |      ✔️      |
+| Changing an event from sync to async or vice versa                                          |    ❌     |                ❌                |      ✔️      |
 | Removal of API                                                                              |    ❌     |                ❌                |      ✔️      |
 | Backwards-incompatible API change (e.g. renaming a method)                                  |    ❌     |                ❌                |      ✔️      |
 | Backwards-incompatible internals change (e.g. changing things in `pocketmine\network\mcpe`) |    ❌     |               ✔️                |      ✔️      |
--- a/README.md
+++ b/README.md
@ -12,7 +12,7 @@
 </p>

 <p align="center">
-	<a href="https://github.com/pmmp/PocketMine-MP/actions/workflows/main.yml"><img src="https://github.com/pmmp/PocketMine-MP/actions/workflows/main.yml/badge.svg" alt="CI" /></a>
+	<a href="https://github.com/pmmp/PocketMine-MP/actions/workflows/main.yml"><img src="https://github.com/pmmp/PocketMine-MP/workflows/CI/badge.svg" alt="CI" /></a>
 	<a href="https://github.com/pmmp/PocketMine-MP/releases/latest"><img alt="GitHub release (latest SemVer)" src="https://img.shields.io/github/v/release/pmmp/PocketMine-MP?label=release&sort=semver"></a>
 	<a href="https://discord.gg/bmSAZBG"><img src="https://img.shields.io/discord/373199722573201408?label=discord&color=7289DA&logo=discord" alt="Discord" /></a>
 	<br>
@ -73,7 +73,7 @@ PocketMine-MP is free, but it requires a lot of time and effort from unpaid volu
 You can support development using the following methods:

 - [Patreon](https://www.patreon.com/pocketminemp)
- Bitcoin (BTC): `bc1q2v5ngyf8ugyd55kqa9ep35g2rv342ueqm6ks33`
+- Bitcoin (BTC): `171u8K9e4FtU6j3e5sqNoxKUgEw9qWQdRV`
 - Stellar Lumens (XLM): `GAAC5WZ33HCTE3BFJFZJXONMEIBNHFLBXM2HJVAZHXXPYA3HP5XPPS7T`

 Thanks for your support!
--- a/build/php
+++ b/build/php
--- a/changelogs/5.32.md
+++ b/changelogs/5.32.md
@ -1,25 +0,0 @@
-# 5.32.0
-Released 6th August 2025.
-
-This is a support release for Minecraft: Bedrock Edition 1.21.100.
-
-**Plugin compatibility:** Plugins for previous 5.x versions will run unchanged on this release, unless they use internal APIs, reflection, or packages like the `pocketmine\network\mcpe` or `pocketmine\data` namespace.
-Do not update plugin minimum API versions unless you need new features added in this release.
-
-**WARNING: If your plugin uses the `pocketmine\network\mcpe` namespace, you're not shielded by API change constraints.**
-Consider using the `mcpe-protocol` directive in `plugin.yml` as a constraint if you're using packets directly.
-
-## General
- Added support for Minecraft: Bedrock Edition 1.21.100.
- Removed support for earlier versions.
-
-## Fixes
- Fixed deadlock on RakLib thread crash (e.g. due to port binding failure).
-
-# 5.32.1
-Released 14th August 2025.
-
-## Fixes
- Hardened checks when processing resource pack sending during player logins.
- Fixed content log warning about crafting recipe with missing ID.
- Fixed packets in a batch still being processed after one of them caused the session to be terminated.
--- a/changelogs/5.33.md
+++ b/changelogs/5.33.md
@ -1,135 +0,0 @@
-# 5.33.0
-Released 30th August 2025.
-
-This is a minor feature release containing internals improvements, API improvements and new gameplay features.
-
-**Plugin compatibility:** Plugins for previous 5.x versions will run unchanged on this release, unless they use internal APIs, reflection, or packages like the `pocketmine\network\mcpe` or `pocketmine\data` namespace.
-Do not update plugin minimum API versions unless you need new features added in this release.
-
-**WARNING: If your plugin uses the `pocketmine\network\mcpe` namespace, you're not shielded by API change constraints.**
-Consider using the `mcpe-protocol` directive in `plugin.yml` as a constraint if you're using packets directly.
-
-## Performance
- Worlds now remember when a chunk isn't generated. This reduces world I/O during world generation.
- `BlockObjectToStateSerializer` now creates fewer objects in certain cases.
-
-## Gameplay
- The following blocks have been added and/or are now properly supported:
-  - Hanging signs
-  - Illager banners
-
-## Tools
- `generate-bedrock-data-from-packets.php` now represents items as strings directly when only an ID is present. This significantly improves readability in `BedrockData` and reduces file sizes.
-
-## API
-### `pocketmine\block`
- Added (and implemented) interfaces for many common block properties, to allow `instanceof` to be used:
-  - `Ageable`: for blocks with age, such as crops
-  - `AnyFacing`: for blocks which can face up, down, and horizontal directions (not the same as `HorizontalFacing`!)
-  - `Colored`: for blocks with 16 `DyeColor` variants
-  - `CoralMaterial`: for coral blocks, provides access to coral type and dead/alive
-  - `HorizontalFacing`: for blocks which can **only** face horizontal directions (not the same as `AnyFacing`!)
-  - `Lightable`: for light-source blocks which can be turned on and off, e.g. redstone lamp
-  - `MultiAnyFacing`: for blocks which can appear in multiple faces of the same block (including up, down, and horizontal faces), e.g. glow lichen
-  - `PillarRotation`: for blocks which can be oriented on an axis, e.g. logs
-  - `PoweredByRedstone`: for blocks which receive power from a redstone component, e.g. redstone lamp
-  - `SignLikeRotation`: for blocks which can be rotated 16 ways, e.g. signs, banners
-  - `WoodMaterial`: for blocks made from wood
-  - These interfaces have been implemented on many blocks. For the sake of brevity, they are not listed here, but you can expect to see them wherever the corresponding traits were used.
- The following classes have been added:
-  - `BaseOminousBanner`
-  - `CeilingCenterHangingSign` - both chains connected to the same point on the block above, can face 16 directions
-  - `CeilingEdgesHangingSign` - each chain connected to separate edges of the block above, can face 4 directions
-  - `OminousFloorBanner` - floor version of illager banner, can face 16 directions
-  - `OminousWallBanner` - wall version of illager banner, can face 4 directions
-  - `WallHangingSign` - hangs from a horizontal beam, can face 4 directions
- The following API methods have been added:
-  - `public ChiseledBookshelf->setSlots(list<ChiseledBookshelfSlot> $slots) : $this`
-  - `public static VanillaBlocks` methods:
-    - `ACACIA_CEILING_CENTER_HANGING_SIGN() : CeilingCenterHangingSign`
-    - `ACACIA_CEILING_EDGES_HANGING_SIGN() : CeilingEdgesHangingSign`
-    - `ACACIA_WALL_HANGING_SIGN() : WallHangingSign`
-    - `BIRCH_CEILING_CENTER_HANGING_SIGN() : CeilingCenterHangingSign`
-    - `BIRCH_CEILING_EDGES_HANGING_SIGN() : CeilingEdgesHangingSign`
-    - `BIRCH_WALL_HANGING_SIGN() : WallHangingSign`
-    - `CHERRY_CEILING_CENTER_HANGING_SIGN() : CeilingCenterHangingSign`
-    - `CHERRY_CEILING_EDGES_HANGING_SIGN() : CeilingEdgesHangingSign`
-    - `CHERRY_WALL_HANGING_SIGN() : WallHangingSign`
-    - `CRIMSON_CEILING_CENTER_HANGING_SIGN() : CeilingCenterHangingSign`
-    - `CRIMSON_CEILING_EDGES_HANGING_SIGN() : CeilingEdgesHangingSign`
-    - `CRIMSON_WALL_HANGING_SIGN() : WallHangingSign`
-    - `DARK_OAK_CEILING_CENTER_HANGING_SIGN() : CeilingCenterHangingSign`
-    - `DARK_OAK_CEILING_EDGES_HANGING_SIGN() : CeilingEdgesHangingSign`
-    - `DARK_OAK_WALL_HANGING_SIGN() : WallHangingSign`
-    - `JUNGLE_CEILING_CENTER_HANGING_SIGN() : CeilingCenterHangingSign`
-    - `JUNGLE_CEILING_EDGES_HANGING_SIGN() : CeilingEdgesHangingSign`
-    - `JUNGLE_WALL_HANGING_SIGN() : WallHangingSign`
-    - `MANGROVE_CEILING_CENTER_HANGING_SIGN() : CeilingCenterHangingSign`
-    - `MANGROVE_CEILING_EDGES_HANGING_SIGN() : CeilingEdgesHangingSign`
-    - `MANGROVE_WALL_HANGING_SIGN() : WallHangingSign`
-    - `OAK_CEILING_CENTER_HANGING_SIGN() : CeilingCenterHangingSign`
-    - `OAK_CEILING_EDGES_HANGING_SIGN() : CeilingEdgesHangingSign`
-    - `OAK_WALL_HANGING_SIGN() : WallHangingSign`
-    - `OMINOUS_FLOOR_BANNER() : OminousFloorBanner`
-    - `OMINOUS_WALL_BANNER() : OminousWallBanner`
-    - `PALE_OAK_CEILING_CENTER_HANGING_SIGN() : CeilingCenterHangingSign`
-    - `PALE_OAK_CEILING_EDGES_HANGING_SIGN() : CeilingEdgesHangingSign`
-    - `PALE_OAK_WALL_HANGING_SIGN() : WallHangingSign`
-    - `SPRUCE_CEILING_CENTER_HANGING_SIGN() : CeilingCenterHangingSign`
-    - `SPRUCE_CEILING_EDGES_HANGING_SIGN() : CeilingEdgesHangingSign`
-    - `SPRUCE_WALL_HANGING_SIGN() : WallHangingSign`
-    - `WARPED_CEILING_CENTER_HANGING_SIGN() : CeilingCenterHangingSign`
-    - `WARPED_CEILING_EDGES_HANGING_SIGN() : CeilingEdgesHangingSign`
-    - `WARPED_WALL_HANGING_SIGN() : WallHangingSign`
-  - `public AgeableTrait->getMaxAge() : int` (included by all growable plant-like blocks, e.g. crops)
-
-### `pocketmine\data\bedrock\block\convert`
- A new system for symmetric block serializers and deserializers has been introduced.
-  - This allows registering both a serializer and a deserializer with the same code, meaning way less code
-  - It also eliminates information duplication and potential inconsistencies, improving maintainability.
-  - A proper way to deal with flattened IDs (e.g. color blocks) has been introduced which _doesn't_ require hardcoding a giant mess of IDs
-  - This symmetric system covers 99% of blocks which have a 1:1 association between PM and vanilla blocks, or 1:N where IDs are flattened
-  - However, there are still some special cases which require registering separate serializers and deserializers (usually in cases where the PM implementation deviates from Mojang where Mojang's implementation sucks, such as hanging signs or big dripleaf).
-  - No backwards compatibility breaks are expected as a result of this change. However, it's recommended to migrate old code to this new system for maintainability.
-  - The following new classes have been added:
-    - `BlockSerializerDeserializerRegistrar` - handles unified registration of block serializers and deserializers, based on a provided block model
-    - `FlattenedIdModel` - represents a block with some properties baked into its Minecraft ID, e.g. coral or color blocks
-    - `Model` - represents a regular block with all properties in its `states` NBT
-    - `property\BoolFromStringProperty<TBlock>` - property mapping a bool value from a string NBT state
-    - `property\BoolProperty<TBlock>`
-    - `property\CommonProperties` - singleton containing commonly-used block property definitions and groups, e.g. facing, stair properties
-    - `property\EnumFromRawStateMap<TEnum, TRaw>` - maps a raw NBT value to a PHP `enum` and vice versa
-    - `property\IntFromRawStateMap<TRaw>` - maps a raw NBT value to PM integer constants and vice versa
-    - `property\IntProperty<TBlock>` - an integer range property with a min, max, and optional offset
-    - `property\Property<TBlock>` - interface implemented by all property definitions accepted by a `Model` or `FlattenedIdModel`
-    - `property\StateMap<TValue, TRaw>` - interface implemented by classes accepted by mapping properties, e.g. `BoolFromStringProperty`
-    - `property\StringProperty<TBlock>` - interface implemented by properties whose raw outputs are strings - these can be used as ID components in `FlattenedIdModel`
-    - `property\ValueFromIntProperty<TBlock, TValue>` - property mapping a generic PM value from an int NBT state
-    - `property\ValueFromStringProperty<TBlock, TValue>` - same as above, but for a string NBT state
-    - `property\ValueSetFromIntProperty<TBlock, TOption>` - a property mapping an `int[]` or `enum[]` from a set of flags in NBT states
-    - `property\ValueMappings` - singleton containing commonly-needed `StateMap`s
-  - The following classes have been deprecated:
-    - `BlockStateDeserializerHelper`
-    - `BlockStateSerializerHelper`
-  - The following methods have been deprecated:
-    - All methods for decoding mapped property types in `BlockStateReader`, e.g. `readFacingDirection()`
-    - All methods for encoding mapped property types in `BlockStateWriter`, e.g. `writeFacingDirection()`
-    - All specific blocktype mapping functions in `BlockStateToObjectDeserializer`, e.g. `mapStairs()`
-    - All specific blocktype mapping functions in `BlockObjectToStateSerializer`, e.g. `mapStairs()`
-
-### `pocketmine\item`
- The following hooks have been added:
-  - `public Item->getPlacementTransaction(Block $blockReplace, Block $blockClicked, int $face, Vector3 $clickVector, ?Player $player = null) : ?BlockTransaction` - allows more complex logic for itemblocks to place blocks, without duplicating their placement conditions (used for hanging signs)
-
-### `pocketmine\world`
- `World->setChunk()` now verifies that blockstate IDs in the provided chunk are all registered in `RuntimeBlockStateRegistry`. This should provide earlier detection for custom block registration errors by plugins.
-
-## Internals
- `BlockStateUpgrader` is now almost entirely independent from `BlockStateData`. It's anticipated that the upgrader library will be separable from the core in the future.
- `Block->readStateFromWorld()` is now triggered on chunk load for any position containing a tile. This should allow more effective updating of blocks with properties in their tiles.
-
-# 5.33.1
-Released 31st August 2025.
-
-## Fixes
- Fixed banners placed in prior versions getting their tiles deleted (due to missing `Type` tags).
--- a/composer.json
+++ b/composer.json
@ -34,9 +34,9 @@
      "adhocore/json-comment": "~1.2.0",
      "netresearch/jsonmapper": "~v5.0.0",
      "pocketmine/bedrock-block-upgrade-schema": "~5.1.0+bedrock-1.21.60",
-      "pocketmine/bedrock-data": "~6.0.0+bedrock-1.21.100",
-      "pocketmine/bedrock-item-upgrade-schema": "~1.15.0+bedrock-1.21.100",
-      "pocketmine/bedrock-protocol": "~40.0.0+bedrock-1.21.100",
+      "pocketmine/bedrock-data": "~5.2.0+bedrock-1.21.93",
+      "pocketmine/bedrock-item-upgrade-schema": "~1.14.0+bedrock-1.21.50",
+      "pocketmine/bedrock-protocol": "~39.1.0+bedrock-1.21.93",
      "pocketmine/binaryutils": "^0.2.1",
      "pocketmine/callback-validator": "^1.0.2",
      "pocketmine/color": "^0.3.0",
@ -48,7 +48,7 @@
      "pocketmine/raklib": "~1.2.0",
      "pocketmine/raklib-ipc": "~1.0.0",
      "pocketmine/snooze": "^0.5.0",
-      "ramsey/uuid": "~4.9.0",
+      "ramsey/uuid": "~4.8.0",
      "symfony/filesystem": "~6.4.0"
   },
   "require-dev": {
--- a/composer.lock
+++ b/composer.lock
@ -4,7 +4,7 @@
        "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
        "This file is @generated automatically"
    ],
-    "content-hash": "27fee330bdcb6ea2373c57cdfb3bc22f",
+    "content-hash": "679ab8fc31e55b5170daa34258dc0fd4",
    "packages": [
        {
            "name": "adhocore/json-comment",
@ -204,16 +204,16 @@
        },
        {
            "name": "pocketmine/bedrock-data",
-            "version": "6.0.0+bedrock-1.21.100",
+            "version": "5.2.0+bedrock-1.21.93",
            "source": {
                "type": "git",
                "url": "https://github.com/pmmp/BedrockData.git",
-                "reference": "edc0d829175e5e1e57c87001acfd03526c63fd34"
+                "reference": "740e18e490c6a102b774518ff2224a06762bcaf8"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/pmmp/BedrockData/zipball/edc0d829175e5e1e57c87001acfd03526c63fd34",
-                "reference": "edc0d829175e5e1e57c87001acfd03526c63fd34",
+                "url": "https://api.github.com/repos/pmmp/BedrockData/zipball/740e18e490c6a102b774518ff2224a06762bcaf8",
+                "reference": "740e18e490c6a102b774518ff2224a06762bcaf8",
                "shasum": ""
            },
            "type": "library",
@ -224,22 +224,22 @@
            "description": "Blobs of data generated from Minecraft: Bedrock Edition, used by PocketMine-MP",
            "support": {
                "issues": "https://github.com/pmmp/BedrockData/issues",
-                "source": "https://github.com/pmmp/BedrockData/tree/6.0.0+bedrock-1.21.100"
+                "source": "https://github.com/pmmp/BedrockData/tree/bedrock-1.21.93"
            },
-            "time": "2025-08-30T17:25:42+00:00"
+            "time": "2025-07-08T12:30:28+00:00"
        },
        {
            "name": "pocketmine/bedrock-item-upgrade-schema",
-            "version": "1.15.0",
+            "version": "1.14.0",
            "source": {
                "type": "git",
                "url": "https://github.com/pmmp/BedrockItemUpgradeSchema.git",
-                "reference": "09e0dbe9743f21a76b1fe04b2b4136785775f52b"
+                "reference": "9fc7c9bbb558a017395c1cb7dd819c033ee971bb"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/pmmp/BedrockItemUpgradeSchema/zipball/09e0dbe9743f21a76b1fe04b2b4136785775f52b",
-                "reference": "09e0dbe9743f21a76b1fe04b2b4136785775f52b",
+                "url": "https://api.github.com/repos/pmmp/BedrockItemUpgradeSchema/zipball/9fc7c9bbb558a017395c1cb7dd819c033ee971bb",
+                "reference": "9fc7c9bbb558a017395c1cb7dd819c033ee971bb",
                "shasum": ""
            },
            "type": "library",
@ -250,22 +250,22 @@
            "description": "JSON schemas for upgrading items found in older Minecraft: Bedrock world saves",
            "support": {
                "issues": "https://github.com/pmmp/BedrockItemUpgradeSchema/issues",
-                "source": "https://github.com/pmmp/BedrockItemUpgradeSchema/tree/1.15.0"
+                "source": "https://github.com/pmmp/BedrockItemUpgradeSchema/tree/1.14.0"
            },
-            "time": "2025-08-06T15:08:48+00:00"
+            "time": "2024-12-04T12:22:49+00:00"
        },
        {
            "name": "pocketmine/bedrock-protocol",
-            "version": "40.0.0+bedrock-1.21.100",
+            "version": "39.1.0+bedrock-1.21.93",
            "source": {
                "type": "git",
                "url": "https://github.com/pmmp/BedrockProtocol.git",
-                "reference": "5e95cab3a6e6c24920e0c25ca4aaf887ed4b70ca"
+                "reference": "e9bc5fb691d18dab229a158462c13f0c6fea79c8"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/pmmp/BedrockProtocol/zipball/5e95cab3a6e6c24920e0c25ca4aaf887ed4b70ca",
-                "reference": "5e95cab3a6e6c24920e0c25ca4aaf887ed4b70ca",
+                "url": "https://api.github.com/repos/pmmp/BedrockProtocol/zipball/e9bc5fb691d18dab229a158462c13f0c6fea79c8",
+                "reference": "e9bc5fb691d18dab229a158462c13f0c6fea79c8",
                "shasum": ""
            },
            "require": {
@ -296,9 +296,9 @@
            "description": "An implementation of the Minecraft: Bedrock Edition protocol in PHP",
            "support": {
                "issues": "https://github.com/pmmp/BedrockProtocol/issues",
-                "source": "https://github.com/pmmp/BedrockProtocol/tree/40.0.0+bedrock-1.21.100"
+                "source": "https://github.com/pmmp/BedrockProtocol/tree/39.1.0+bedrock-1.21.93"
            },
-            "time": "2025-08-06T15:13:45+00:00"
+            "time": "2025-07-08T12:31:39+00:00"
        },
        {
            "name": "pocketmine/binaryutils",
@ -818,20 +818,21 @@
        },
        {
            "name": "ramsey/uuid",
-            "version": "4.9.1",
+            "version": "4.8.1",
            "source": {
                "type": "git",
                "url": "https://github.com/ramsey/uuid.git",
-                "reference": "81f941f6f729b1e3ceea61d9d014f8b6c6800440"
+                "reference": "fdf4dd4e2ff1813111bd0ad58d7a1ddbb5b56c28"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/ramsey/uuid/zipball/81f941f6f729b1e3ceea61d9d014f8b6c6800440",
-                "reference": "81f941f6f729b1e3ceea61d9d014f8b6c6800440",
+                "url": "https://api.github.com/repos/ramsey/uuid/zipball/fdf4dd4e2ff1813111bd0ad58d7a1ddbb5b56c28",
+                "reference": "fdf4dd4e2ff1813111bd0ad58d7a1ddbb5b56c28",
                "shasum": ""
            },
            "require": {
-                "brick/math": "^0.8.8 || ^0.9 || ^0.10 || ^0.11 || ^0.12 || ^0.13 || ^0.14",
+                "brick/math": "^0.8.8 || ^0.9 || ^0.10 || ^0.11 || ^0.12 || ^0.13",
+                "ext-json": "*",
                "php": "^8.0",
                "ramsey/collection": "^1.2 || ^2.0"
            },
@ -890,22 +891,22 @@
            ],
            "support": {
                "issues": "https://github.com/ramsey/uuid/issues",
-                "source": "https://github.com/ramsey/uuid/tree/4.9.1"
+                "source": "https://github.com/ramsey/uuid/tree/4.8.1"
            },
-            "time": "2025-09-04T20:59:21+00:00"
+            "time": "2025-06-01T06:28:46+00:00"
        },
        {
            "name": "symfony/filesystem",
-            "version": "v6.4.24",
+            "version": "v6.4.13",
            "source": {
                "type": "git",
                "url": "https://github.com/symfony/filesystem.git",
-                "reference": "75ae2edb7cdcc0c53766c30b0a2512b8df574bd8"
+                "reference": "4856c9cf585d5a0313d8d35afd681a526f038dd3"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/symfony/filesystem/zipball/75ae2edb7cdcc0c53766c30b0a2512b8df574bd8",
-                "reference": "75ae2edb7cdcc0c53766c30b0a2512b8df574bd8",
+                "url": "https://api.github.com/repos/symfony/filesystem/zipball/4856c9cf585d5a0313d8d35afd681a526f038dd3",
+                "reference": "4856c9cf585d5a0313d8d35afd681a526f038dd3",
                "shasum": ""
            },
            "require": {
@ -942,7 +943,7 @@
            "description": "Provides basic utilities for the filesystem",
            "homepage": "https://symfony.com",
            "support": {
-                "source": "https://github.com/symfony/filesystem/tree/v6.4.24"
+                "source": "https://github.com/symfony/filesystem/tree/v6.4.13"
            },
            "funding": [
                {
@ -953,31 +954,27 @@
                    "url": "https://github.com/fabpot",
                    "type": "github"
                },
-                {
-                    "url": "https://github.com/nicolas-grekas",
-                    "type": "github"
-                },
                {
                    "url": "https://tidelift.com/funding/github/packagist/symfony/symfony",
                    "type": "tidelift"
                }
            ],
-            "time": "2025-07-10T08:14:14+00:00"
+            "time": "2024-10-25T15:07:50+00:00"
        }
    ],
    "packages-dev": [
        {
            "name": "myclabs/deep-copy",
-            "version": "1.13.4",
+            "version": "1.13.1",
            "source": {
                "type": "git",
                "url": "https://github.com/myclabs/DeepCopy.git",
-                "reference": "07d290f0c47959fd5eed98c95ee5602db07e0b6a"
+                "reference": "1720ddd719e16cf0db4eb1c6eca108031636d46c"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/myclabs/DeepCopy/zipball/07d290f0c47959fd5eed98c95ee5602db07e0b6a",
-                "reference": "07d290f0c47959fd5eed98c95ee5602db07e0b6a",
+                "url": "https://api.github.com/repos/myclabs/DeepCopy/zipball/1720ddd719e16cf0db4eb1c6eca108031636d46c",
+                "reference": "1720ddd719e16cf0db4eb1c6eca108031636d46c",
                "shasum": ""
            },
            "require": {
@ -1016,7 +1013,7 @@
            ],
            "support": {
                "issues": "https://github.com/myclabs/DeepCopy/issues",
-                "source": "https://github.com/myclabs/DeepCopy/tree/1.13.4"
+                "source": "https://github.com/myclabs/DeepCopy/tree/1.13.1"
            },
            "funding": [
                {
@ -1024,20 +1021,20 @@
                    "type": "tidelift"
                }
            ],
-            "time": "2025-08-01T08:46:24+00:00"
+            "time": "2025-04-29T12:36:36+00:00"
        },
        {
            "name": "nikic/php-parser",
-            "version": "v5.6.1",
+            "version": "v5.5.0",
            "source": {
                "type": "git",
                "url": "https://github.com/nikic/PHP-Parser.git",
-                "reference": "f103601b29efebd7ff4a1ca7b3eeea9e3336a2a2"
+                "reference": "ae59794362fe85e051a58ad36b289443f57be7a9"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/nikic/PHP-Parser/zipball/f103601b29efebd7ff4a1ca7b3eeea9e3336a2a2",
-                "reference": "f103601b29efebd7ff4a1ca7b3eeea9e3336a2a2",
+                "url": "https://api.github.com/repos/nikic/PHP-Parser/zipball/ae59794362fe85e051a58ad36b289443f57be7a9",
+                "reference": "ae59794362fe85e051a58ad36b289443f57be7a9",
                "shasum": ""
            },
            "require": {
@ -1056,7 +1053,7 @@
            "type": "library",
            "extra": {
                "branch-alias": {
-                    "dev-master": "5.x-dev"
+                    "dev-master": "5.0-dev"
                }
            },
            "autoload": {
@ -1080,9 +1077,9 @@
            ],
            "support": {
                "issues": "https://github.com/nikic/PHP-Parser/issues",
-                "source": "https://github.com/nikic/PHP-Parser/tree/v5.6.1"
+                "source": "https://github.com/nikic/PHP-Parser/tree/v5.5.0"
            },
-            "time": "2025-08-13T20:13:15+00:00"
+            "time": "2025-05-31T08:24:38+00:00"
        },
        {
            "name": "phar-io/manifest",
@ -1315,16 +1312,16 @@
        },
        {
            "name": "phpstan/phpstan-strict-rules",
-            "version": "2.0.6",
+            "version": "2.0.5",
            "source": {
                "type": "git",
                "url": "https://github.com/phpstan/phpstan-strict-rules.git",
-                "reference": "f9f77efa9de31992a832ff77ea52eb42d675b094"
+                "reference": "1f1358da2f8e1317478c63c21beb9918c9821f6f"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/phpstan/phpstan-strict-rules/zipball/f9f77efa9de31992a832ff77ea52eb42d675b094",
-                "reference": "f9f77efa9de31992a832ff77ea52eb42d675b094",
+                "url": "https://api.github.com/repos/phpstan/phpstan-strict-rules/zipball/1f1358da2f8e1317478c63c21beb9918c9821f6f",
+                "reference": "1f1358da2f8e1317478c63c21beb9918c9821f6f",
                "shasum": ""
            },
            "require": {
@ -1357,9 +1354,9 @@
            "description": "Extra strict and opinionated rules for PHPStan",
            "support": {
                "issues": "https://github.com/phpstan/phpstan-strict-rules/issues",
-                "source": "https://github.com/phpstan/phpstan-strict-rules/tree/2.0.6"
+                "source": "https://github.com/phpstan/phpstan-strict-rules/tree/2.0.5"
            },
-            "time": "2025-07-21T12:19:29+00:00"
+            "time": "2025-07-17T12:01:44+00:00"
        },
        {
            "name": "phpunit/php-code-coverage",
@ -1684,16 +1681,16 @@
        },
        {
            "name": "phpunit/phpunit",
-            "version": "10.5.54",
+            "version": "10.5.47",
            "source": {
                "type": "git",
                "url": "https://github.com/sebastianbergmann/phpunit.git",
-                "reference": "b1dbbaaf96106b76d500b9d3db51f9b01f6a3589"
+                "reference": "3637b3e50d32ab3a0d1a33b3b6177169ec3d95a3"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/sebastianbergmann/phpunit/zipball/b1dbbaaf96106b76d500b9d3db51f9b01f6a3589",
-                "reference": "b1dbbaaf96106b76d500b9d3db51f9b01f6a3589",
+                "url": "https://api.github.com/repos/sebastianbergmann/phpunit/zipball/3637b3e50d32ab3a0d1a33b3b6177169ec3d95a3",
+                "reference": "3637b3e50d32ab3a0d1a33b3b6177169ec3d95a3",
                "shasum": ""
            },
            "require": {
@ -1703,7 +1700,7 @@
                "ext-mbstring": "*",
                "ext-xml": "*",
                "ext-xmlwriter": "*",
-                "myclabs/deep-copy": "^1.13.4",
+                "myclabs/deep-copy": "^1.13.1",
                "phar-io/manifest": "^2.0.4",
                "phar-io/version": "^3.2.1",
                "php": ">=8.1",
@ -1720,7 +1717,7 @@
                "sebastian/exporter": "^5.1.2",
                "sebastian/global-state": "^6.0.2",
                "sebastian/object-enumerator": "^5.0.0",
-                "sebastian/recursion-context": "^5.0.1",
+                "sebastian/recursion-context": "^5.0.0",
                "sebastian/type": "^4.0.0",
                "sebastian/version": "^4.0.1"
            },
@ -1765,7 +1762,7 @@
            "support": {
                "issues": "https://github.com/sebastianbergmann/phpunit/issues",
                "security": "https://github.com/sebastianbergmann/phpunit/security/policy",
-                "source": "https://github.com/sebastianbergmann/phpunit/tree/10.5.54"
+                "source": "https://github.com/sebastianbergmann/phpunit/tree/10.5.47"
            },
            "funding": [
                {
@ -1789,7 +1786,7 @@
                    "type": "tidelift"
                }
            ],
-            "time": "2025-09-11T06:19:38+00:00"
+            "time": "2025-06-20T11:29:11+00:00"
        },
        {
            "name": "sebastian/cli-parser",
@ -1961,16 +1958,16 @@
        },
        {
            "name": "sebastian/comparator",
-            "version": "5.0.4",
+            "version": "5.0.3",
            "source": {
                "type": "git",
                "url": "https://github.com/sebastianbergmann/comparator.git",
-                "reference": "e8e53097718d2b53cfb2aa859b06a41abf58c62e"
+                "reference": "a18251eb0b7a2dcd2f7aa3d6078b18545ef0558e"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/sebastianbergmann/comparator/zipball/e8e53097718d2b53cfb2aa859b06a41abf58c62e",
-                "reference": "e8e53097718d2b53cfb2aa859b06a41abf58c62e",
+                "url": "https://api.github.com/repos/sebastianbergmann/comparator/zipball/a18251eb0b7a2dcd2f7aa3d6078b18545ef0558e",
+                "reference": "a18251eb0b7a2dcd2f7aa3d6078b18545ef0558e",
                "shasum": ""
            },
            "require": {
@ -2026,27 +2023,15 @@
            "support": {
                "issues": "https://github.com/sebastianbergmann/comparator/issues",
                "security": "https://github.com/sebastianbergmann/comparator/security/policy",
-                "source": "https://github.com/sebastianbergmann/comparator/tree/5.0.4"
+                "source": "https://github.com/sebastianbergmann/comparator/tree/5.0.3"
            },
            "funding": [
                {
                    "url": "https://github.com/sebastianbergmann",
                    "type": "github"
-                },
-                {
-                    "url": "https://liberapay.com/sebastianbergmann",
-                    "type": "liberapay"
-                },
-                {
-                    "url": "https://thanks.dev/u/gh/sebastianbergmann",
-                    "type": "thanks_dev"
-                },
-                {
-                    "url": "https://tidelift.com/funding/github/packagist/sebastian/comparator",
-                    "type": "tidelift"
                }
            ],
-            "time": "2025-09-07T05:25:07+00:00"
+            "time": "2024-10-18T14:56:07+00:00"
        },
        {
            "name": "sebastian/complexity",
@ -2549,23 +2534,23 @@
        },
        {
            "name": "sebastian/recursion-context",
-            "version": "5.0.1",
+            "version": "5.0.0",
            "source": {
                "type": "git",
                "url": "https://github.com/sebastianbergmann/recursion-context.git",
-                "reference": "47e34210757a2f37a97dcd207d032e1b01e64c7a"
+                "reference": "05909fb5bc7df4c52992396d0116aed689f93712"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/sebastianbergmann/recursion-context/zipball/47e34210757a2f37a97dcd207d032e1b01e64c7a",
-                "reference": "47e34210757a2f37a97dcd207d032e1b01e64c7a",
+                "url": "https://api.github.com/repos/sebastianbergmann/recursion-context/zipball/05909fb5bc7df4c52992396d0116aed689f93712",
+                "reference": "05909fb5bc7df4c52992396d0116aed689f93712",
                "shasum": ""
            },
            "require": {
                "php": ">=8.1"
            },
            "require-dev": {
-                "phpunit/phpunit": "^10.5"
+                "phpunit/phpunit": "^10.0"
            },
            "type": "library",
            "extra": {
@ -2600,28 +2585,15 @@
            "homepage": "https://github.com/sebastianbergmann/recursion-context",
            "support": {
                "issues": "https://github.com/sebastianbergmann/recursion-context/issues",
-                "security": "https://github.com/sebastianbergmann/recursion-context/security/policy",
-                "source": "https://github.com/sebastianbergmann/recursion-context/tree/5.0.1"
+                "source": "https://github.com/sebastianbergmann/recursion-context/tree/5.0.0"
            },
            "funding": [
                {
                    "url": "https://github.com/sebastianbergmann",
                    "type": "github"
-                },
-                {
-                    "url": "https://liberapay.com/sebastianbergmann",
-                    "type": "liberapay"
-                },
-                {
-                    "url": "https://thanks.dev/u/gh/sebastianbergmann",
-                    "type": "thanks_dev"
-                },
-                {
-                    "url": "https://tidelift.com/funding/github/packagist/sebastian/recursion-context",
-                    "type": "tidelift"
                }
            ],
-            "time": "2025-08-10T07:50:56+00:00"
+            "time": "2023-02-03T07:05:40+00:00"
        },
        {
            "name": "sebastian/type",
--- a/phpstan.neon.dist
+++ b/phpstan.neon.dist
@ -4,8 +4,6 @@ includes:
 	- tests/phpstan/configs/impossible-generics.neon
 	- tests/phpstan/configs/php-bugs.neon
 	- tests/phpstan/configs/phpstan-bugs.neon
-	- tests/phpstan/configs/property-hook-sadness.neon
-	- tests/phpstan/configs/reflection-class-sadness.neon
 	- tests/phpstan/configs/spl-fixed-array-sucks.neon
 	- vendor/phpstan/phpstan-phpunit/extension.neon
 	- vendor/phpstan/phpstan-phpunit/rules.neon
--- a/src/Server.php
+++ b/src/Server.php
@ -39,6 +39,7 @@ use pocketmine\crash\CrashDumpRenderer;
 use pocketmine\data\bedrock\BedrockDataFiles;
 use pocketmine\entity\EntityDataHelper;
 use pocketmine\entity\Location;
+use pocketmine\event\AsyncHandlerListManager;
 use pocketmine\event\HandlerListManager;
 use pocketmine\event\player\PlayerCreationEvent;
 use pocketmine\event\player\PlayerDataSaveEvent;
@ -1527,6 +1528,7 @@ class Server{

 			$this->logger->debug("Removing event handlers");
 			HandlerListManager::global()->unregisterAll();
+			AsyncHandlerListManager::global()->unregisterAll();

 			if(isset($this->asyncPool)){
 				$this->logger->debug("Shutting down async task worker pool");
--- a/src/VersionInfo.php
+++ b/src/VersionInfo.php
@ -31,7 +31,7 @@ use function str_repeat;

 final class VersionInfo{
 	public const NAME = "PocketMine-MP";
-	public const BASE_VERSION = "5.33.2";
+	public const BASE_VERSION = "5.31.1";
 	public const IS_DEVELOPMENT_BUILD = true;
 	public const BUILD_CHANNEL = "stable";

--- a/src/block/ActivatorRail.php
+++ b/src/block/ActivatorRail.php
@ -23,10 +23,9 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\PoweredByRedstone;
 use pocketmine\block\utils\RailPoweredByRedstoneTrait;

-class ActivatorRail extends StraightOnlyRail implements PoweredByRedstone{
+class ActivatorRail extends StraightOnlyRail{
 	use RailPoweredByRedstoneTrait;

 	//TODO
--- a/src/block/AmethystCluster.php
+++ b/src/block/AmethystCluster.php
@ -24,7 +24,6 @@ declare(strict_types=1);
 namespace pocketmine\block;

 use pocketmine\block\utils\AmethystTrait;
-use pocketmine\block\utils\AnyFacing;
 use pocketmine\block\utils\AnyFacingTrait;
 use pocketmine\block\utils\FortuneDropHelper;
 use pocketmine\block\utils\SupportType;
@ -39,7 +38,7 @@ use pocketmine\player\Player;
 use pocketmine\utils\AssumptionFailedError;
 use pocketmine\world\BlockTransaction;

-final class AmethystCluster extends Transparent implements AnyFacing{
+final class AmethystCluster extends Transparent{
 	use AmethystTrait;
 	use AnyFacingTrait;

--- a/src/block/Anvil.php
+++ b/src/block/Anvil.php
@ -26,7 +26,6 @@ namespace pocketmine\block;
 use pocketmine\block\inventory\AnvilInventory;
 use pocketmine\block\utils\Fallable;
 use pocketmine\block\utils\FallableTrait;
-use pocketmine\block\utils\HorizontalFacing;
 use pocketmine\block\utils\HorizontalFacingTrait;
 use pocketmine\block\utils\SupportType;
 use pocketmine\data\runtime\RuntimeDataDescriber;
@ -42,7 +41,7 @@ use pocketmine\world\sound\AnvilFallSound;
 use pocketmine\world\sound\Sound;
 use function round;

-class Anvil extends Transparent implements Fallable, HorizontalFacing{
+class Anvil extends Transparent implements Fallable{
 	use FallableTrait;
 	use HorizontalFacingTrait;

--- a/src/block/Barrel.php
+++ b/src/block/Barrel.php
@ -24,7 +24,6 @@ declare(strict_types=1);
 namespace pocketmine\block;

 use pocketmine\block\tile\Barrel as TileBarrel;
-use pocketmine\block\utils\AnyFacing;
 use pocketmine\block\utils\AnyFacingTrait;
 use pocketmine\data\runtime\RuntimeDataDescriber;
 use pocketmine\item\Item;
@ -34,7 +33,7 @@ use pocketmine\player\Player;
 use pocketmine\world\BlockTransaction;
 use function abs;

-class Barrel extends Opaque implements AnyFacing{
+class Barrel extends Opaque{
 	use AnyFacingTrait;

 	protected bool $open = false;
--- a/src/block/BaseBanner.php
+++ b/src/block/BaseBanner.php
@ -25,7 +25,6 @@ namespace pocketmine\block;

 use pocketmine\block\tile\Banner as TileBanner;
 use pocketmine\block\utils\BannerPatternLayer;
-use pocketmine\block\utils\Colored;
 use pocketmine\block\utils\ColoredTrait;
 use pocketmine\block\utils\SupportType;
 use pocketmine\item\Banner as ItemBanner;
@ -37,7 +36,7 @@ use pocketmine\world\BlockTransaction;
 use function assert;
 use function count;

-abstract class BaseBanner extends Transparent implements Colored{
+abstract class BaseBanner extends Transparent{
 	use ColoredTrait;

 	/**
@ -50,10 +49,6 @@ abstract class BaseBanner extends Transparent implements Colored{
 		parent::readStateFromWorld();
 		$tile = $this->position->getWorld()->getTile($this->position);
 		if($tile instanceof TileBanner){
-			if($tile->getType() === TileBanner::TYPE_OMINOUS){
-				//illager banner is implemented as a separate block, as it doesn't support base color or custom patterns
-				return $this->getOminousVersion();
-			}
 			$this->color = $tile->getBaseColor();
 			$this->setPatterns($tile->getPatterns());
 		}
@ -61,13 +56,6 @@ abstract class BaseBanner extends Transparent implements Colored{
 		return $this;
 	}

-	/**
-	 * TODO: make this abstract in PM6 (BC break)
-	 */
-	protected function getOminousVersion() : Block{
-		return VanillaBlocks::AIR();
-	}
-
 	public function writeStateToWorld() : void{
 		parent::writeStateToWorld();
 		$tile = $this->position->getWorld()->getTile($this->position);
--- a/src/block/BaseBigDripleaf.php
+++ b/src/block/BaseBigDripleaf.php
@ -23,7 +23,6 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\HorizontalFacing;
 use pocketmine\block\utils\HorizontalFacingTrait;
 use pocketmine\block\utils\SupportType;
 use pocketmine\event\block\StructureGrowEvent;
@ -34,7 +33,7 @@ use pocketmine\math\Vector3;
 use pocketmine\player\Player;
 use pocketmine\world\BlockTransaction;

-abstract class BaseBigDripleaf extends Transparent implements HorizontalFacing{
+abstract class BaseBigDripleaf extends Transparent{
 	use HorizontalFacingTrait;

 	abstract protected function isHead() : bool;
--- a/src/block/BaseCoral.php
+++ b/src/block/BaseCoral.php
@ -24,13 +24,12 @@ declare(strict_types=1);
 namespace pocketmine\block;

 use pocketmine\block\utils\BlockEventHelper;
-use pocketmine\block\utils\CoralMaterial;
 use pocketmine\block\utils\CoralTypeTrait;
 use pocketmine\block\utils\SupportType;
 use pocketmine\item\Item;
 use function mt_rand;

-abstract class BaseCoral extends Transparent implements CoralMaterial{
+abstract class BaseCoral extends Transparent{
 	use CoralTypeTrait;

 	public function onNearbyBlockChange() : void{
--- a/src/block/BaseOminousBanner.php
+++ b/src/block/BaseOminousBanner.php
@ -1,90 +0,0 @@
-<?php
-
-/*
- *
- *  ____            _        _   __  __ _                  __  __ ____
- * |  _ \ ___   ___| | _____| |_|  \/  (_)_ __   ___      |  \/  |  _ \
- * | |_) / _ \ / __| |/ / _ \ __| |\/| | | '_ \ / _ \_____| |\/| | |_) |
- * |  __/ (_) | (__|   <  __/ |_| |  | | | | | |  __/_____| |  | |  __/
- * |_|   \___/ \___|_|\_\___|\__|_|  |_|_|_| |_|\___|     |_|  |_|_|
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * @author PocketMine Team
- * @link http://www.pocketmine.net/
- *
- *
- */
-
-declare(strict_types=1);
-
-namespace pocketmine\block;
-
-use pocketmine\block\tile\Banner as TileBanner;
-use pocketmine\block\utils\DyeColor;
-use pocketmine\block\utils\SupportType;
-use pocketmine\item\Item;
-use pocketmine\item\VanillaItems;
-use pocketmine\math\Vector3;
-use pocketmine\player\Player;
-use pocketmine\world\BlockTransaction;
-use function assert;
-
-abstract class BaseOminousBanner extends Transparent{
-
-	public function writeStateToWorld() : void{
-		parent::writeStateToWorld();
-		$tile = $this->position->getWorld()->getTile($this->position);
-		assert($tile instanceof TileBanner);
-		$tile->setBaseColor(DyeColor::WHITE);
-		$tile->setPatterns([]);
-		$tile->setType(TileBanner::TYPE_OMINOUS);
-	}
-
-	public function isSolid() : bool{
-		return false;
-	}
-
-	public function getMaxStackSize() : int{
-		return 16;
-	}
-
-	public function getFuelTime() : int{
-		return 300;
-	}
-
-	protected function recalculateCollisionBoxes() : array{
-		return [];
-	}
-
-	public function getSupportType(int $facing) : SupportType{
-		return SupportType::NONE;
-	}
-
-	private function canBeSupportedBy(Block $block) : bool{
-		return $block->isSolid();
-	}
-
-	public function place(BlockTransaction $tx, Item $item, Block $blockReplace, Block $blockClicked, int $face, Vector3 $clickVector, ?Player $player = null) : bool{
-		if(!$this->canBeSupportedBy($blockReplace->getSide($this->getSupportingFace()))){
-			return false;
-		}
-
-		return parent::place($tx, $item, $blockReplace, $blockClicked, $face, $clickVector, $player);
-	}
-
-	abstract protected function getSupportingFace() : int;
-
-	public function onNearbyBlockChange() : void{
-		if(!$this->canBeSupportedBy($this->getSide($this->getSupportingFace()))){
-			$this->position->getWorld()->useBreakOn($this->position);
-		}
-	}
-
-	public function asItem() : Item{
-		return VanillaItems::OMINOUS_BANNER();
-	}
-}
--- a/src/block/BaseSign.php
+++ b/src/block/BaseSign.php
@ -27,7 +27,6 @@ use pocketmine\block\tile\Sign as TileSign;
 use pocketmine\block\utils\DyeColor;
 use pocketmine\block\utils\SignText;
 use pocketmine\block\utils\SupportType;
-use pocketmine\block\utils\WoodMaterial;
 use pocketmine\block\utils\WoodType;
 use pocketmine\block\utils\WoodTypeTrait;
 use pocketmine\color\Color;
@ -45,7 +44,7 @@ use function array_map;
 use function assert;
 use function strlen;

-abstract class BaseSign extends Transparent implements WoodMaterial{
+abstract class BaseSign extends Transparent{
 	use WoodTypeTrait;

 	protected SignText $text;
--- a/src/block/Bed.php
+++ b/src/block/Bed.php
@ -24,10 +24,8 @@ declare(strict_types=1);
 namespace pocketmine\block;

 use pocketmine\block\tile\Bed as TileBed;
-use pocketmine\block\utils\Colored;
 use pocketmine\block\utils\ColoredTrait;
 use pocketmine\block\utils\DyeColor;
-use pocketmine\block\utils\HorizontalFacing;
 use pocketmine\block\utils\HorizontalFacingTrait;
 use pocketmine\block\utils\SupportType;
 use pocketmine\data\runtime\RuntimeDataDescriber;
@ -43,7 +41,7 @@ use pocketmine\utils\TextFormat;
 use pocketmine\world\BlockTransaction;
 use pocketmine\world\World;

-class Bed extends Transparent implements Colored, HorizontalFacing{
+class Bed extends Transparent{
 	use ColoredTrait;
 	use HorizontalFacingTrait;

--- a/src/block/Bell.php
+++ b/src/block/Bell.php
@ -25,7 +25,6 @@ namespace pocketmine\block;

 use pocketmine\block\tile\Bell as TileBell;
 use pocketmine\block\utils\BellAttachmentType;
-use pocketmine\block\utils\HorizontalFacing;
 use pocketmine\block\utils\HorizontalFacingTrait;
 use pocketmine\block\utils\SupportType;
 use pocketmine\data\runtime\RuntimeDataDescriber;
@ -39,7 +38,7 @@ use pocketmine\player\Player;
 use pocketmine\world\BlockTransaction;
 use pocketmine\world\sound\BellRingSound;

-final class Bell extends Transparent implements HorizontalFacing{
+final class Bell extends Transparent{
 	use HorizontalFacingTrait;

 	private BellAttachmentType $attachmentType = BellAttachmentType::FLOOR;
--- a/src/block/BlockTypeIds.php
+++ b/src/block/BlockTypeIds.php
@ -787,43 +787,8 @@ final class BlockTypeIds{
 	public const RESIN_CLUMP = 10757;
 	public const CHISELED_RESIN_BRICKS = 10758;
 	public const RESPAWN_ANCHOR = 10759;
-	public const OMINOUS_BANNER = 10760;
-	public const OMINOUS_WALL_BANNER = 10761;
-	public const ACACIA_CEILING_CENTER_HANGING_SIGN = 10762;
-	public const ACACIA_CEILING_EDGES_HANGING_SIGN = 10763;
-	public const ACACIA_WALL_HANGING_SIGN = 10764;
-	public const BIRCH_CEILING_CENTER_HANGING_SIGN = 10765;
-	public const BIRCH_CEILING_EDGES_HANGING_SIGN = 10766;
-	public const BIRCH_WALL_HANGING_SIGN = 10767;
-	public const CHERRY_CEILING_CENTER_HANGING_SIGN = 10768;
-	public const CHERRY_CEILING_EDGES_HANGING_SIGN = 10769;
-	public const CHERRY_WALL_HANGING_SIGN = 10770;
-	public const CRIMSON_CEILING_CENTER_HANGING_SIGN = 10771;
-	public const CRIMSON_CEILING_EDGES_HANGING_SIGN = 10772;
-	public const CRIMSON_WALL_HANGING_SIGN = 10773;
-	public const DARK_OAK_CEILING_CENTER_HANGING_SIGN = 10774;
-	public const DARK_OAK_CEILING_EDGES_HANGING_SIGN = 10775;
-	public const DARK_OAK_WALL_HANGING_SIGN = 10776;
-	public const JUNGLE_CEILING_CENTER_HANGING_SIGN = 10777;
-	public const JUNGLE_CEILING_EDGES_HANGING_SIGN = 10778;
-	public const JUNGLE_WALL_HANGING_SIGN = 10779;
-	public const MANGROVE_CEILING_CENTER_HANGING_SIGN = 10780;
-	public const MANGROVE_CEILING_EDGES_HANGING_SIGN = 10781;
-	public const MANGROVE_WALL_HANGING_SIGN = 10782;
-	public const OAK_CEILING_CENTER_HANGING_SIGN = 10783;
-	public const OAK_CEILING_EDGES_HANGING_SIGN = 10784;
-	public const OAK_WALL_HANGING_SIGN = 10785;
-	public const PALE_OAK_CEILING_CENTER_HANGING_SIGN = 10786;
-	public const PALE_OAK_CEILING_EDGES_HANGING_SIGN = 10787;
-	public const PALE_OAK_WALL_HANGING_SIGN = 10788;
-	public const SPRUCE_CEILING_CENTER_HANGING_SIGN = 10789;
-	public const SPRUCE_CEILING_EDGES_HANGING_SIGN = 10790;
-	public const SPRUCE_WALL_HANGING_SIGN = 10791;
-	public const WARPED_CEILING_CENTER_HANGING_SIGN = 10792;
-	public const WARPED_CEILING_EDGES_HANGING_SIGN = 10793;
-	public const WARPED_WALL_HANGING_SIGN = 10794;

-	public const FIRST_UNUSED_BLOCK_ID = 10795;
+	public const FIRST_UNUSED_BLOCK_ID = 10760;

 	private static int $nextDynamicId = self::FIRST_UNUSED_BLOCK_ID;

--- a/src/block/BlockTypeTags.php
+++ b/src/block/BlockTypeTags.php
@ -31,5 +31,4 @@ final class BlockTypeTags{
 	public const SAND = self::PREFIX . "sand";
 	public const POTTABLE_PLANTS = self::PREFIX . "pottable";
 	public const FIRE = self::PREFIX . "fire";
-	public const HANGING_SIGN = self::PREFIX . "hanging_sign";
 }
--- a/src/block/BoneBlock.php
+++ b/src/block/BoneBlock.php
@ -23,9 +23,8 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\PillarRotation;
 use pocketmine\block\utils\PillarRotationTrait;

-class BoneBlock extends Opaque implements PillarRotation{
+class BoneBlock extends Opaque{
 	use PillarRotationTrait;
 }
--- a/src/block/Button.php
+++ b/src/block/Button.php
@ -23,7 +23,6 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\AnyFacing;
 use pocketmine\block\utils\AnyFacingTrait;
 use pocketmine\data\runtime\RuntimeDataDescriber;
 use pocketmine\item\Item;
@ -34,7 +33,7 @@ use pocketmine\world\BlockTransaction;
 use pocketmine\world\sound\RedstonePowerOffSound;
 use pocketmine\world\sound\RedstonePowerOnSound;

-abstract class Button extends Flowable implements AnyFacing{
+abstract class Button extends Flowable{
 	use AnyFacingTrait;

 	protected bool $pressed = false;
--- a/src/block/Cactus.php
+++ b/src/block/Cactus.php
@ -23,7 +23,6 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Ageable;
 use pocketmine\block\utils\AgeableTrait;
 use pocketmine\block\utils\BlockEventHelper;
 use pocketmine\block\utils\StaticSupportTrait;
@ -34,7 +33,7 @@ use pocketmine\event\entity\EntityDamageEvent;
 use pocketmine\math\AxisAlignedBB;
 use pocketmine\math\Facing;

-class Cactus extends Transparent implements Ageable{
+class Cactus extends Transparent{
 	use AgeableTrait;
 	use StaticSupportTrait;

--- a/src/block/CakeWithCandle.php
+++ b/src/block/CakeWithCandle.php
@ -24,7 +24,6 @@ declare(strict_types=1);
 namespace pocketmine\block;

 use pocketmine\block\utils\CandleTrait;
-use pocketmine\block\utils\Lightable;
 use pocketmine\entity\Living;
 use pocketmine\item\Item;
 use pocketmine\math\AxisAlignedBB;
@ -32,7 +31,7 @@ use pocketmine\math\Facing;
 use pocketmine\math\Vector3;
 use pocketmine\player\Player;

-class CakeWithCandle extends BaseCake implements Lightable{
+class CakeWithCandle extends BaseCake{
 	use CandleTrait {
 		onInteract as onInteractCandle;
 	}
--- a/src/block/CakeWithDyedCandle.php
+++ b/src/block/CakeWithDyedCandle.php
@ -23,11 +23,10 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Colored;
 use pocketmine\block\utils\ColoredTrait;
 use pocketmine\block\utils\DyeColor;

-class CakeWithDyedCandle extends CakeWithCandle implements Colored{
+class CakeWithDyedCandle extends CakeWithCandle{
 	use ColoredTrait;

 	public function __construct(BlockIdentifier $idInfo, string $name, BlockTypeInfo $typeInfo){
--- a/src/block/Campfire.php
+++ b/src/block/Campfire.php
@ -25,9 +25,7 @@ namespace pocketmine\block;

 use pocketmine\block\inventory\CampfireInventory;
 use pocketmine\block\tile\Campfire as TileCampfire;
-use pocketmine\block\utils\HorizontalFacing;
 use pocketmine\block\utils\HorizontalFacingTrait;
-use pocketmine\block\utils\Lightable;
 use pocketmine\block\utils\LightableTrait;
 use pocketmine\block\utils\SupportType;
 use pocketmine\crafting\FurnaceRecipe;
@ -61,7 +59,7 @@ use function count;
 use function min;
 use function mt_rand;

-class Campfire extends Transparent implements Lightable, HorizontalFacing{
+class Campfire extends Transparent{
 	use HorizontalFacingTrait{
 		HorizontalFacingTrait::describeBlockOnlyState as encodeFacingState;
 	}
--- a/src/block/Candle.php
+++ b/src/block/Candle.php
@ -24,7 +24,6 @@ declare(strict_types=1);
 namespace pocketmine\block;

 use pocketmine\block\utils\CandleTrait;
-use pocketmine\block\utils\Lightable;
 use pocketmine\block\utils\SupportType;
 use pocketmine\data\runtime\RuntimeDataDescriber;
 use pocketmine\item\Item;
@ -36,7 +35,7 @@ use pocketmine\player\Player;
 use pocketmine\utils\AssumptionFailedError;
 use pocketmine\world\BlockTransaction;

-class Candle extends Transparent implements Lightable{
+class Candle extends Transparent{
 	use CandleTrait {
 		describeBlockOnlyState as encodeLitState;
 		getLightLevel as getBaseLightLevel;
--- a/src/block/Carpet.php
+++ b/src/block/Carpet.php
@ -23,13 +23,12 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Colored;
 use pocketmine\block\utils\ColoredTrait;
 use pocketmine\block\utils\StaticSupportTrait;
 use pocketmine\math\AxisAlignedBB;
 use pocketmine\math\Facing;

-class Carpet extends Flowable implements Colored{
+class Carpet extends Flowable{
 	use ColoredTrait;
 	use StaticSupportTrait;

--- a/src/block/CarvedPumpkin.php
+++ b/src/block/CarvedPumpkin.php
@ -24,8 +24,7 @@ declare(strict_types=1);
 namespace pocketmine\block;

 use pocketmine\block\utils\FacesOppositePlacingPlayerTrait;
-use pocketmine\block\utils\HorizontalFacing;

-class CarvedPumpkin extends Opaque implements HorizontalFacing{
+class CarvedPumpkin extends Opaque{
 	use FacesOppositePlacingPlayerTrait;
 }
--- a/src/block/CaveVines.php
+++ b/src/block/CaveVines.php
@ -23,7 +23,6 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Ageable;
 use pocketmine\block\utils\AgeableTrait;
 use pocketmine\block\utils\BlockEventHelper;
 use pocketmine\block\utils\StaticSupportTrait;
@ -40,7 +39,7 @@ use pocketmine\world\BlockTransaction;
 use pocketmine\world\sound\GlowBerriesPickSound;
 use function mt_rand;

-class CaveVines extends Flowable implements Ageable{
+class CaveVines extends Flowable{
 	use AgeableTrait;
 	use StaticSupportTrait;

--- a/src/block/CeilingCenterHangingSign.php
+++ b/src/block/CeilingCenterHangingSign.php
@ -1,61 +0,0 @@
-<?php
-
-/*
- *
- *  ____            _        _   __  __ _                  __  __ ____
- * |  _ \ ___   ___| | _____| |_|  \/  (_)_ __   ___      |  \/  |  _ \
- * | |_) / _ \ / __| |/ / _ \ __| |\/| | | '_ \ / _ \_____| |\/| | |_) |
- * |  __/ (_) | (__|   <  __/ |_| |  | | | | | |  __/_____| |  | |  __/
- * |_|   \___/ \___|_|\_\___|\__|_|  |_|_|_| |_|\___|     |_|  |_|_|
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * @author PocketMine Team
- * @link http://www.pocketmine.net/
- *
- *
- */
-
-declare(strict_types=1);
-
-namespace pocketmine\block;
-
-use pocketmine\block\utils\SignLikeRotation;
-use pocketmine\block\utils\SignLikeRotationTrait;
-use pocketmine\block\utils\StaticSupportTrait;
-use pocketmine\item\Item;
-use pocketmine\math\Facing;
-use pocketmine\math\Vector3;
-use pocketmine\player\Player;
-use pocketmine\world\BlockTransaction;
-
-final class CeilingCenterHangingSign extends BaseSign implements SignLikeRotation{
-	use SignLikeRotationTrait;
-	use StaticSupportTrait;
-
-	protected function getSupportingFace() : int{
-		return Facing::UP;
-	}
-
-	//TODO: duplicated code :(
-	public function place(BlockTransaction $tx, Item $item, Block $blockReplace, Block $blockClicked, int $face, Vector3 $clickVector, ?Player $player = null) : bool{
-		if($face !== Facing::DOWN){
-			return false;
-		}
-
-		if($player !== null){
-			$this->rotation = self::getRotationFromYaw($player->getLocation()->getYaw());
-		}
-		return parent::place($tx, $item, $blockReplace, $blockClicked, $face, $clickVector, $player);
-	}
-
-	private function canBeSupportedAt(Block $block) : bool{
-		$supportBlock = $block->getSide(Facing::UP);
-		return
-			$supportBlock->getSupportType(Facing::DOWN)->hasCenterSupport() ||
-			$supportBlock->hasTypeTag(BlockTypeTags::HANGING_SIGN);
-	}
-}
--- a/src/block/CeilingEdgesHangingSign.php
+++ b/src/block/CeilingEdgesHangingSign.php
@ -1,68 +0,0 @@
-<?php
-
-/*
- *
- *  ____            _        _   __  __ _                  __  __ ____
- * |  _ \ ___   ___| | _____| |_|  \/  (_)_ __   ___      |  \/  |  _ \
- * | |_) / _ \ / __| |/ / _ \ __| |\/| | | '_ \ / _ \_____| |\/| | |_) |
- * |  __/ (_) | (__|   <  __/ |_| |  | | | | | |  __/_____| |  | |  __/
- * |_|   \___/ \___|_|\_\___|\__|_|  |_|_|_| |_|\___|     |_|  |_|_|
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * @author PocketMine Team
- * @link http://www.pocketmine.net/
- *
- *
- */
-
-declare(strict_types=1);
-
-namespace pocketmine\block;
-
-use pocketmine\block\utils\HorizontalFacing;
-use pocketmine\block\utils\HorizontalFacingTrait;
-use pocketmine\block\utils\SupportType;
-use pocketmine\item\Item;
-use pocketmine\math\Facing;
-use pocketmine\math\Vector3;
-use pocketmine\player\Player;
-use pocketmine\world\BlockTransaction;
-
-final class CeilingEdgesHangingSign extends BaseSign implements HorizontalFacing{
-	use HorizontalFacingTrait;
-
-	protected function getSupportingFace() : int{
-		return Facing::UP;
-	}
-
-	public function place(BlockTransaction $tx, Item $item, Block $blockReplace, Block $blockClicked, int $face, Vector3 $clickVector, ?Player $player = null) : bool{
-		if($face !== Facing::DOWN){
-			return false;
-		}
-		if($player !== null){
-			$this->facing = Facing::opposite($player->getHorizontalFacing());
-		}
-		if(!$this->canBeSupportedAt($blockReplace)){
-			return false;
-		}
-
-		return parent::place($tx, $item, $blockReplace, $blockClicked, $face, $clickVector, $player);
-	}
-
-	public function onNearbyBlockChange() : void{
-		if(!$this->canBeSupportedAt($this)){
-			$this->position->getWorld()->useBreakOn($this->position);
-		}
-	}
-
-	private function canBeSupportedAt(Block $block) : bool{
-		$supportBlock = $block->getSide(Facing::UP);
-		return
-			$supportBlock->getSupportType(Facing::DOWN) === SupportType::FULL ||
-			(($supportBlock instanceof WallHangingSign || $supportBlock instanceof CeilingEdgesHangingSign) && Facing::axis($supportBlock->getFacing()) === Facing::axis($this->facing));
-	}
-}
--- a/src/block/Chain.php
+++ b/src/block/Chain.php
@ -23,14 +23,13 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\PillarRotation;
 use pocketmine\block\utils\PillarRotationTrait;
 use pocketmine\block\utils\SupportType;
 use pocketmine\math\Axis;
 use pocketmine\math\AxisAlignedBB;
 use pocketmine\math\Facing;

-final class Chain extends Transparent implements PillarRotation{
+final class Chain extends Transparent{
 	use PillarRotationTrait;

 	public function getSupportType(int $facing) : SupportType{
--- a/src/block/ChemistryTable.php
+++ b/src/block/ChemistryTable.php
@ -24,12 +24,11 @@ declare(strict_types=1);
 namespace pocketmine\block;

 use pocketmine\block\utils\FacesOppositePlacingPlayerTrait;
-use pocketmine\block\utils\HorizontalFacing;
 use pocketmine\item\Item;
 use pocketmine\math\Vector3;
 use pocketmine\player\Player;

-final class ChemistryTable extends Opaque implements HorizontalFacing{
+final class ChemistryTable extends Opaque{
 	use FacesOppositePlacingPlayerTrait;

 	public function onInteract(Item $item, int $face, Vector3 $clickVector, ?Player $player = null, array &$returnedItems = []) : bool{
--- a/src/block/Chest.php
+++ b/src/block/Chest.php
@ -25,7 +25,6 @@ namespace pocketmine\block;

 use pocketmine\block\tile\Chest as TileChest;
 use pocketmine\block\utils\FacesOppositePlacingPlayerTrait;
-use pocketmine\block\utils\HorizontalFacing;
 use pocketmine\block\utils\SupportType;
 use pocketmine\event\block\ChestPairEvent;
 use pocketmine\item\Item;
@ -34,7 +33,7 @@ use pocketmine\math\Facing;
 use pocketmine\math\Vector3;
 use pocketmine\player\Player;

-class Chest extends Transparent implements HorizontalFacing{
+class Chest extends Transparent{
 	use FacesOppositePlacingPlayerTrait;

 	protected function recalculateCollisionBoxes() : array{
--- a/src/block/ChiseledBookshelf.php
+++ b/src/block/ChiseledBookshelf.php
@ -26,7 +26,6 @@ namespace pocketmine\block;
 use pocketmine\block\tile\ChiseledBookshelf as TileChiseledBookshelf;
 use pocketmine\block\utils\ChiseledBookshelfSlot;
 use pocketmine\block\utils\FacesOppositePlacingPlayerTrait;
-use pocketmine\block\utils\HorizontalFacing;
 use pocketmine\block\utils\HorizontalFacingTrait;
 use pocketmine\data\runtime\RuntimeDataDescriber;
 use pocketmine\item\Book;
@ -39,7 +38,7 @@ use pocketmine\math\Vector3;
 use pocketmine\player\Player;
 use function spl_object_id;

-class ChiseledBookshelf extends Opaque implements HorizontalFacing{
+class ChiseledBookshelf extends Opaque{
 	use HorizontalFacingTrait;
 	use FacesOppositePlacingPlayerTrait;

@ -114,18 +113,6 @@ class ChiseledBookshelf extends Opaque implements HorizontalFacing{
 		return $this->slots;
 	}

-	/**
-	 * @param ChiseledBookshelfSlot[] $slots
-	 * @return $this
-	 */
-	public function setSlots(array $slots) : self{
-		$this->slots = [];
-		foreach($slots as $slot){
-			$this->setSlot($slot, true);
-		}
-		return $this;
-	}
-
 	/**
 	 * Returns the last slot interacted by a player or null if no slot has been interacted with yet.
 	 */
--- a/src/block/ChorusFlower.php
+++ b/src/block/ChorusFlower.php
@ -23,7 +23,6 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Ageable;
 use pocketmine\block\utils\AgeableTrait;
 use pocketmine\block\utils\StaticSupportTrait;
 use pocketmine\entity\projectile\Projectile;
@ -41,7 +40,7 @@ use function array_rand;
 use function min;
 use function mt_rand;

-final class ChorusFlower extends Flowable implements Ageable{
+final class ChorusFlower extends Flowable{
 	use AgeableTrait;
 	use StaticSupportTrait;

--- a/src/block/CocoaBlock.php
+++ b/src/block/CocoaBlock.php
@ -23,10 +23,8 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Ageable;
 use pocketmine\block\utils\AgeableTrait;
 use pocketmine\block\utils\BlockEventHelper;
-use pocketmine\block\utils\HorizontalFacing;
 use pocketmine\block\utils\HorizontalFacingTrait;
 use pocketmine\block\utils\WoodType;
 use pocketmine\data\runtime\RuntimeDataDescriber;
@ -41,7 +39,7 @@ use pocketmine\player\Player;
 use pocketmine\world\BlockTransaction;
 use function mt_rand;

-class CocoaBlock extends Flowable implements Ageable, HorizontalFacing{
+class CocoaBlock extends Flowable{
 	use HorizontalFacingTrait;
 	use AgeableTrait;

--- a/src/block/Concrete.php
+++ b/src/block/Concrete.php
@ -23,9 +23,8 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Colored;
 use pocketmine\block\utils\ColoredTrait;

-class Concrete extends Opaque implements Colored{
+class Concrete extends Opaque{
 	use ColoredTrait;
 }
--- a/src/block/ConcretePowder.php
+++ b/src/block/ConcretePowder.php
@ -24,13 +24,12 @@ declare(strict_types=1);
 namespace pocketmine\block;

 use pocketmine\block\utils\BlockEventHelper;
-use pocketmine\block\utils\Colored;
 use pocketmine\block\utils\ColoredTrait;
 use pocketmine\block\utils\Fallable;
 use pocketmine\block\utils\FallableTrait;
 use pocketmine\math\Facing;

-class ConcretePowder extends Opaque implements Fallable, Colored{
+class ConcretePowder extends Opaque implements Fallable{
 	use ColoredTrait;
 	use FallableTrait {
 		onNearbyBlockChange as protected startFalling;
--- a/src/block/CopperBulb.php
+++ b/src/block/CopperBulb.php
@ -26,13 +26,11 @@ namespace pocketmine\block;
 use pocketmine\block\utils\CopperMaterial;
 use pocketmine\block\utils\CopperOxidation;
 use pocketmine\block\utils\CopperTrait;
-use pocketmine\block\utils\Lightable;
 use pocketmine\block\utils\LightableTrait;
-use pocketmine\block\utils\PoweredByRedstone;
 use pocketmine\block\utils\PoweredByRedstoneTrait;
 use pocketmine\data\runtime\RuntimeDataDescriber;

-class CopperBulb extends Opaque implements CopperMaterial, Lightable, PoweredByRedstone{
+class CopperBulb extends Opaque implements CopperMaterial{
 	use CopperTrait;
 	use PoweredByRedstoneTrait;
 	use LightableTrait{
--- a/src/block/CoralBlock.php
+++ b/src/block/CoralBlock.php
@ -24,12 +24,11 @@ declare(strict_types=1);
 namespace pocketmine\block;

 use pocketmine\block\utils\BlockEventHelper;
-use pocketmine\block\utils\CoralMaterial;
 use pocketmine\block\utils\CoralTypeTrait;
 use pocketmine\item\Item;
 use function mt_rand;

-final class CoralBlock extends Opaque implements CoralMaterial{
+final class CoralBlock extends Opaque{
 	use CoralTypeTrait;

 	public function onNearbyBlockChange() : void{
--- a/src/block/Crops.php
+++ b/src/block/Crops.php
@ -23,7 +23,6 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Ageable;
 use pocketmine\block\utils\AgeableTrait;
 use pocketmine\block\utils\BlockEventHelper;
 use pocketmine\block\utils\CropGrowthHelper;
@ -35,7 +34,7 @@ use pocketmine\math\Vector3;
 use pocketmine\player\Player;
 use function mt_rand;

-abstract class Crops extends Flowable implements Ageable{
+abstract class Crops extends Flowable{
 	use AgeableTrait;
 	use StaticSupportTrait;

--- a/src/block/DaylightSensor.php
+++ b/src/block/DaylightSensor.php
@ -23,7 +23,6 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\AnalogRedstoneSignalEmitter;
 use pocketmine\block\utils\AnalogRedstoneSignalEmitterTrait;
 use pocketmine\block\utils\SupportType;
 use pocketmine\data\runtime\RuntimeDataDescriber;
@ -37,7 +36,7 @@ use function max;
 use function round;
 use const M_PI;

-class DaylightSensor extends Transparent implements AnalogRedstoneSignalEmitter{
+class DaylightSensor extends Transparent{
 	use AnalogRedstoneSignalEmitterTrait;

 	protected bool $inverted = false;
--- a/src/block/Door.php
+++ b/src/block/Door.php
@ -23,7 +23,6 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\HorizontalFacing;
 use pocketmine\block\utils\HorizontalFacingTrait;
 use pocketmine\block\utils\SupportType;
 use pocketmine\data\runtime\RuntimeDataDescriber;
@ -35,7 +34,7 @@ use pocketmine\player\Player;
 use pocketmine\world\BlockTransaction;
 use pocketmine\world\sound\DoorSound;

-class Door extends Transparent implements HorizontalFacing{
+class Door extends Transparent{
 	use HorizontalFacingTrait;

 	protected bool $top = false;
--- a/src/block/DoublePitcherCrop.php
+++ b/src/block/DoublePitcherCrop.php
@ -23,7 +23,6 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Ageable;
 use pocketmine\block\utils\AgeableTrait;
 use pocketmine\block\utils\CropGrowthHelper;
 use pocketmine\data\runtime\RuntimeDataDescriber;
@ -38,7 +37,7 @@ use pocketmine\math\Vector3;
 use pocketmine\player\Player;
 use pocketmine\world\BlockTransaction;

-final class DoublePitcherCrop extends DoublePlant implements Ageable{
+final class DoublePitcherCrop extends DoublePlant{
 	use AgeableTrait {
 		describeBlockOnlyState as describeAge;
 	}
--- a/src/block/DyedCandle.php
+++ b/src/block/DyedCandle.php
@ -23,10 +23,9 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Colored;
 use pocketmine\block\utils\ColoredTrait;

-class DyedCandle extends Candle implements Colored{
+class DyedCandle extends Candle{
 	use ColoredTrait;

 	protected function getCandleIfCompatibleType(Block $block) : ?Candle{
--- a/src/block/DyedShulkerBox.php
+++ b/src/block/DyedShulkerBox.php
@ -23,9 +23,8 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Colored;
 use pocketmine\block\utils\ColoredTrait;

-final class DyedShulkerBox extends ShulkerBox implements Colored{
+final class DyedShulkerBox extends ShulkerBox{
 	use ColoredTrait;
 }
--- a/src/block/EndPortalFrame.php
+++ b/src/block/EndPortalFrame.php
@ -24,12 +24,11 @@ declare(strict_types=1);
 namespace pocketmine\block;

 use pocketmine\block\utils\FacesOppositePlacingPlayerTrait;
-use pocketmine\block\utils\HorizontalFacing;
 use pocketmine\data\runtime\RuntimeDataDescriber;
 use pocketmine\math\AxisAlignedBB;
 use pocketmine\math\Facing;

-class EndPortalFrame extends Opaque implements HorizontalFacing{
+class EndPortalFrame extends Opaque{
 	use FacesOppositePlacingPlayerTrait;

 	protected bool $eye = false;
--- a/src/block/EndRod.php
+++ b/src/block/EndRod.php
@ -23,7 +23,6 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\AnyFacing;
 use pocketmine\block\utils\AnyFacingTrait;
 use pocketmine\item\Item;
 use pocketmine\math\Axis;
@ -33,7 +32,7 @@ use pocketmine\math\Vector3;
 use pocketmine\player\Player;
 use pocketmine\world\BlockTransaction;

-class EndRod extends Flowable implements AnyFacing{
+class EndRod extends Flowable{
 	use AnyFacingTrait;

 	public function place(BlockTransaction $tx, Item $item, Block $blockReplace, Block $blockClicked, int $face, Vector3 $clickVector, ?Player $player = null) : bool{
--- a/src/block/EnderChest.php
+++ b/src/block/EnderChest.php
@ -26,7 +26,6 @@ namespace pocketmine\block;
 use pocketmine\block\inventory\EnderChestInventory;
 use pocketmine\block\tile\EnderChest as TileEnderChest;
 use pocketmine\block\utils\FacesOppositePlacingPlayerTrait;
-use pocketmine\block\utils\HorizontalFacing;
 use pocketmine\block\utils\SupportType;
 use pocketmine\item\Item;
 use pocketmine\math\AxisAlignedBB;
@ -34,7 +33,7 @@ use pocketmine\math\Facing;
 use pocketmine\math\Vector3;
 use pocketmine\player\Player;

-class EnderChest extends Transparent implements HorizontalFacing{
+class EnderChest extends Transparent{
 	use FacesOppositePlacingPlayerTrait;

 	public function getLightLevel() : int{
--- a/src/block/FenceGate.php
+++ b/src/block/FenceGate.php
@ -23,10 +23,8 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\HorizontalFacing;
 use pocketmine\block\utils\HorizontalFacingTrait;
 use pocketmine\block\utils\SupportType;
-use pocketmine\block\utils\WoodMaterial;
 use pocketmine\block\utils\WoodTypeTrait;
 use pocketmine\data\runtime\RuntimeDataDescriber;
 use pocketmine\item\Item;
@ -37,7 +35,7 @@ use pocketmine\player\Player;
 use pocketmine\world\BlockTransaction;
 use pocketmine\world\sound\DoorSound;

-class FenceGate extends Transparent implements HorizontalFacing, WoodMaterial{
+class FenceGate extends Transparent{
 	use WoodTypeTrait;
 	use HorizontalFacingTrait;

--- a/src/block/Fire.php
+++ b/src/block/Fire.php
@ -23,7 +23,6 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Ageable;
 use pocketmine\block\utils\AgeableTrait;
 use pocketmine\block\utils\BlockEventHelper;
 use pocketmine\block\utils\SupportType;
@ -36,7 +35,7 @@ use function max;
 use function min;
 use function mt_rand;

-class Fire extends BaseFire implements Ageable{
+class Fire extends BaseFire{
 	use AgeableTrait;

 	public const MAX_AGE = 15;
--- a/src/block/FloorBanner.php
+++ b/src/block/FloorBanner.php
@ -23,7 +23,6 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\SignLikeRotation;
 use pocketmine\block\utils\SignLikeRotationTrait;
 use pocketmine\item\Item;
 use pocketmine\math\Facing;
@ -31,13 +30,9 @@ use pocketmine\math\Vector3;
 use pocketmine\player\Player;
 use pocketmine\world\BlockTransaction;

-final class FloorBanner extends BaseBanner implements SignLikeRotation{
+final class FloorBanner extends BaseBanner{
 	use SignLikeRotationTrait;

-	protected function getOminousVersion() : Block{
-		return VanillaBlocks::OMINOUS_BANNER()->setRotation($this->rotation);
-	}
-
 	protected function getSupportingFace() : int{
 		return Facing::DOWN;
 	}
--- a/src/block/FloorSign.php
+++ b/src/block/FloorSign.php
@ -23,7 +23,6 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\SignLikeRotation;
 use pocketmine\block\utils\SignLikeRotationTrait;
 use pocketmine\item\Item;
 use pocketmine\math\Facing;
@ -31,7 +30,7 @@ use pocketmine\math\Vector3;
 use pocketmine\player\Player;
 use pocketmine\world\BlockTransaction;

-final class FloorSign extends BaseSign implements SignLikeRotation{
+final class FloorSign extends BaseSign{
 	use SignLikeRotationTrait;

 	protected function getSupportingFace() : int{
--- a/src/block/FrostedIce.php
+++ b/src/block/FrostedIce.php
@ -23,12 +23,11 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Ageable;
 use pocketmine\block\utils\AgeableTrait;
 use pocketmine\block\utils\BlockEventHelper;
 use function mt_rand;

-class FrostedIce extends Ice implements Ageable{
+class FrostedIce extends Ice{
 	use AgeableTrait;

 	public const MAX_AGE = 3;
--- a/src/block/Furnace.php
+++ b/src/block/Furnace.php
@ -25,8 +25,6 @@ namespace pocketmine\block;

 use pocketmine\block\tile\Furnace as TileFurnace;
 use pocketmine\block\utils\FacesOppositePlacingPlayerTrait;
-use pocketmine\block\utils\HorizontalFacing;
-use pocketmine\block\utils\Lightable;
 use pocketmine\block\utils\LightableTrait;
 use pocketmine\crafting\FurnaceType;
 use pocketmine\data\runtime\RuntimeDataDescriber;
@ -35,7 +33,7 @@ use pocketmine\math\Vector3;
 use pocketmine\player\Player;
 use function mt_rand;

-class Furnace extends Opaque implements Lightable, HorizontalFacing{
+class Furnace extends Opaque{
 	use FacesOppositePlacingPlayerTrait;
 	use LightableTrait;

--- a/src/block/GlazedTerracotta.php
+++ b/src/block/GlazedTerracotta.php
@ -23,12 +23,10 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Colored;
 use pocketmine\block\utils\ColoredTrait;
 use pocketmine\block\utils\FacesOppositePlacingPlayerTrait;
-use pocketmine\block\utils\HorizontalFacing;

-class GlazedTerracotta extends Opaque implements Colored, HorizontalFacing{
+class GlazedTerracotta extends Opaque{
 	use ColoredTrait;
 	use FacesOppositePlacingPlayerTrait;
 }
--- a/src/block/GlowLichen.php
+++ b/src/block/GlowLichen.php
@ -24,7 +24,6 @@ declare(strict_types=1);
 namespace pocketmine\block;

 use pocketmine\block\utils\BlockEventHelper;
-use pocketmine\block\utils\MultiAnyFacing;
 use pocketmine\block\utils\MultiAnySupportTrait;
 use pocketmine\block\utils\SupportType;
 use pocketmine\item\Fertilizer;
@ -36,7 +35,7 @@ use pocketmine\world\World;
 use function count;
 use function shuffle;

-class GlowLichen extends Transparent implements MultiAnyFacing{
+class GlowLichen extends Transparent{
 	use MultiAnySupportTrait;

 	public function getLightLevel() : int{
--- a/src/block/HayBale.php
+++ b/src/block/HayBale.php
@ -23,11 +23,10 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\PillarRotation;
 use pocketmine\block\utils\PillarRotationTrait;
 use pocketmine\entity\Entity;

-class HayBale extends Opaque implements PillarRotation{
+class HayBale extends Opaque{
 	use PillarRotationTrait;

 	public function getFlameEncouragement() : int{
--- a/src/block/Hopper.php
+++ b/src/block/Hopper.php
@ -24,7 +24,6 @@ declare(strict_types=1);
 namespace pocketmine\block;

 use pocketmine\block\tile\Hopper as TileHopper;
-use pocketmine\block\utils\PoweredByRedstone;
 use pocketmine\block\utils\PoweredByRedstoneTrait;
 use pocketmine\block\utils\SupportType;
 use pocketmine\data\runtime\RuntimeDataDescriber;
@ -35,7 +34,7 @@ use pocketmine\math\Vector3;
 use pocketmine\player\Player;
 use pocketmine\world\BlockTransaction;

-class Hopper extends Transparent implements PoweredByRedstone{
+class Hopper extends Transparent{
 	use PoweredByRedstoneTrait;

 	private int $facing = Facing::DOWN;
--- a/src/block/ItemFrame.php
+++ b/src/block/ItemFrame.php
@ -24,7 +24,6 @@ declare(strict_types=1);
 namespace pocketmine\block;

 use pocketmine\block\tile\ItemFrame as TileItemFrame;
-use pocketmine\block\utils\AnyFacing;
 use pocketmine\block\utils\AnyFacingTrait;
 use pocketmine\block\utils\SupportType;
 use pocketmine\data\runtime\RuntimeDataDescriber;
@ -40,7 +39,7 @@ use pocketmine\world\sound\ItemFrameRotateItemSound;
 use function is_infinite;
 use function is_nan;

-class ItemFrame extends Flowable implements AnyFacing{
+class ItemFrame extends Flowable{
 	use AnyFacingTrait;

 	public const ROTATIONS = 8;
--- a/src/block/Ladder.php
+++ b/src/block/Ladder.php
@ -23,7 +23,6 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\HorizontalFacing;
 use pocketmine\block\utils\HorizontalFacingTrait;
 use pocketmine\block\utils\SupportType;
 use pocketmine\entity\Entity;
@ -36,7 +35,7 @@ use pocketmine\math\Vector3;
 use pocketmine\player\Player;
 use pocketmine\world\BlockTransaction;

-class Ladder extends Transparent implements HorizontalFacing{
+class Ladder extends Transparent{
 	use HorizontalFacingTrait;

 	public function hasEntityCollision() : bool{
--- a/src/block/Lectern.php
+++ b/src/block/Lectern.php
@ -25,7 +25,6 @@ namespace pocketmine\block;

 use pocketmine\block\tile\Lectern as TileLectern;
 use pocketmine\block\utils\FacesOppositePlacingPlayerTrait;
-use pocketmine\block\utils\HorizontalFacing;
 use pocketmine\block\utils\SupportType;
 use pocketmine\data\runtime\RuntimeDataDescriber;
 use pocketmine\item\Item;
@ -37,7 +36,7 @@ use pocketmine\player\Player;
 use pocketmine\world\sound\LecternPlaceBookSound;
 use function count;

-class Lectern extends Transparent implements HorizontalFacing{
+class Lectern extends Transparent{
 	use FacesOppositePlacingPlayerTrait;

 	protected int $viewedPage = 0;
--- a/src/block/LightningRod.php
+++ b/src/block/LightningRod.php
@ -23,7 +23,6 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\AnyFacing;
 use pocketmine\block\utils\AnyFacingTrait;
 use pocketmine\item\Item;
 use pocketmine\math\Axis;
@ -33,7 +32,7 @@ use pocketmine\math\Vector3;
 use pocketmine\player\Player;
 use pocketmine\world\BlockTransaction;

-final class LightningRod extends Transparent implements AnyFacing{
+final class LightningRod extends Transparent{
 	use AnyFacingTrait;

 	protected function recalculateCollisionBoxes() : array{
--- a/src/block/Loom.php
+++ b/src/block/Loom.php
@ -25,12 +25,11 @@ namespace pocketmine\block;

 use pocketmine\block\inventory\LoomInventory;
 use pocketmine\block\utils\FacesOppositePlacingPlayerTrait;
-use pocketmine\block\utils\HorizontalFacing;
 use pocketmine\item\Item;
 use pocketmine\math\Vector3;
 use pocketmine\player\Player;

-final class Loom extends Opaque implements HorizontalFacing{
+final class Loom extends Opaque{
 	use FacesOppositePlacingPlayerTrait;

 	public function onInteract(Item $item, int $face, Vector3 $clickVector, ?Player $player = null, array &$returnedItems = []) : bool{
--- a/src/block/NetherVines.php
+++ b/src/block/NetherVines.php
@ -23,7 +23,6 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Ageable;
 use pocketmine\block\utils\AgeableTrait;
 use pocketmine\block\utils\FortuneDropHelper;
 use pocketmine\block\utils\StaticSupportTrait;
@ -42,7 +41,7 @@ use function mt_rand;
 /**
 * This class is used for Weeping & Twisting vines, because they have same behaviour
 */
-class NetherVines extends Flowable implements Ageable{
+class NetherVines extends Flowable{
 	use AgeableTrait;
 	use StaticSupportTrait;

--- a/src/block/NetherWartPlant.php
+++ b/src/block/NetherWartPlant.php
@ -23,7 +23,6 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Ageable;
 use pocketmine\block\utils\AgeableTrait;
 use pocketmine\block\utils\BlockEventHelper;
 use pocketmine\block\utils\FortuneDropHelper;
@ -32,7 +31,7 @@ use pocketmine\item\Item;
 use pocketmine\math\Facing;
 use function mt_rand;

-class NetherWartPlant extends Flowable implements Ageable{
+class NetherWartPlant extends Flowable{
 	use AgeableTrait;
 	use StaticSupportTrait;

--- a/src/block/OminousFloorBanner.php
+++ b/src/block/OminousFloorBanner.php
@ -1,53 +0,0 @@
-<?php
-
-/*
- *
- *  ____            _        _   __  __ _                  __  __ ____
- * |  _ \ ___   ___| | _____| |_|  \/  (_)_ __   ___      |  \/  |  _ \
- * | |_) / _ \ / __| |/ / _ \ __| |\/| | | '_ \ / _ \_____| |\/| | |_) |
- * |  __/ (_) | (__|   <  __/ |_| |  | | | | | |  __/_____| |  | |  __/
- * |_|   \___/ \___|_|\_\___|\__|_|  |_|_|_| |_|\___|     |_|  |_|_|
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * @author PocketMine Team
- * @link http://www.pocketmine.net/
- *
- *
- */
-
-declare(strict_types=1);
-
-namespace pocketmine\block;
-
-use pocketmine\block\utils\SignLikeRotation;
-use pocketmine\block\utils\SignLikeRotationTrait;
-use pocketmine\item\Item;
-use pocketmine\math\Facing;
-use pocketmine\math\Vector3;
-use pocketmine\player\Player;
-use pocketmine\world\BlockTransaction;
-
-final class OminousFloorBanner extends BaseOminousBanner implements SignLikeRotation{
-	use SignLikeRotationTrait;
-
-	//TODO: duplicated code :(
-
-	protected function getSupportingFace() : int{
-		return Facing::DOWN;
-	}
-
-	public function place(BlockTransaction $tx, Item $item, Block $blockReplace, Block $blockClicked, int $face, Vector3 $clickVector, ?Player $player = null) : bool{
-		if($face !== Facing::UP){
-			return false;
-		}
-
-		if($player !== null){
-			$this->rotation = self::getRotationFromYaw($player->getLocation()->getYaw());
-		}
-		return parent::place($tx, $item, $blockReplace, $blockClicked, $face, $clickVector, $player);
-	}
-}
--- a/src/block/OminousWallBanner.php
+++ b/src/block/OminousWallBanner.php
@ -1,49 +0,0 @@
-<?php
-
-/*
- *
- *  ____            _        _   __  __ _                  __  __ ____
- * |  _ \ ___   ___| | _____| |_|  \/  (_)_ __   ___      |  \/  |  _ \
- * | |_) / _ \ / __| |/ / _ \ __| |\/| | | '_ \ / _ \_____| |\/| | |_) |
- * |  __/ (_) | (__|   <  __/ |_| |  | | | | | |  __/_____| |  | |  __/
- * |_|   \___/ \___|_|\_\___|\__|_|  |_|_|_| |_|\___|     |_|  |_|_|
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * @author PocketMine Team
- * @link http://www.pocketmine.net/
- *
- *
- */
-
-declare(strict_types=1);
-
-namespace pocketmine\block;
-
-use pocketmine\block\utils\HorizontalFacing;
-use pocketmine\block\utils\HorizontalFacingTrait;
-use pocketmine\item\Item;
-use pocketmine\math\Axis;
-use pocketmine\math\Facing;
-use pocketmine\math\Vector3;
-use pocketmine\player\Player;
-use pocketmine\world\BlockTransaction;
-
-final class OminousWallBanner extends BaseOminousBanner implements HorizontalFacing{
-	use HorizontalFacingTrait;
-
-	protected function getSupportingFace() : int{
-		return Facing::opposite($this->facing);
-	}
-
-	public function place(BlockTransaction $tx, Item $item, Block $blockReplace, Block $blockClicked, int $face, Vector3 $clickVector, ?Player $player = null) : bool{
-		if(Facing::axis($face) === Axis::Y){
-			return false;
-		}
-		$this->facing = $face;
-		return parent::place($tx, $item, $blockReplace, $blockClicked, $face, $clickVector, $player);
-	}
-}
--- a/src/block/PinkPetals.php
+++ b/src/block/PinkPetals.php
@ -24,7 +24,6 @@ declare(strict_types=1);
 namespace pocketmine\block;

 use pocketmine\block\utils\BlockEventHelper;
-use pocketmine\block\utils\HorizontalFacing;
 use pocketmine\block\utils\HorizontalFacingTrait;
 use pocketmine\block\utils\StaticSupportTrait;
 use pocketmine\data\runtime\RuntimeDataDescriber;
@ -35,7 +34,7 @@ use pocketmine\math\Vector3;
 use pocketmine\player\Player;
 use pocketmine\world\BlockTransaction;

-class PinkPetals extends Flowable implements HorizontalFacing{
+class PinkPetals extends Flowable{
 	use HorizontalFacingTrait;
 	use StaticSupportTrait {
 		canBePlacedAt as supportedWhenPlacedAt;
--- a/src/block/PitcherCrop.php
+++ b/src/block/PitcherCrop.php
@ -23,7 +23,6 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Ageable;
 use pocketmine\block\utils\AgeableTrait;
 use pocketmine\block\utils\BlockEventHelper;
 use pocketmine\block\utils\CropGrowthHelper;
@ -39,7 +38,7 @@ use pocketmine\math\Vector3;
 use pocketmine\player\Player;
 use pocketmine\world\BlockTransaction;

-final class PitcherCrop extends Flowable implements Ageable{
+final class PitcherCrop extends Flowable{
 	use AgeableTrait;
 	use StaticSupportTrait;

--- a/src/block/Planks.php
+++ b/src/block/Planks.php
@ -23,10 +23,9 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\WoodMaterial;
 use pocketmine\block\utils\WoodTypeTrait;

-class Planks extends Opaque implements WoodMaterial{
+class Planks extends Opaque{
 	use WoodTypeTrait;

 	public function getFuelTime() : int{
--- a/src/block/PoweredRail.php
+++ b/src/block/PoweredRail.php
@ -23,9 +23,8 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\PoweredByRedstone;
 use pocketmine\block\utils\RailPoweredByRedstoneTrait;

-class PoweredRail extends StraightOnlyRail implements PoweredByRedstone{
+class PoweredRail extends StraightOnlyRail{
 	use RailPoweredByRedstoneTrait;
 }
--- a/src/block/RedstoneComparator.php
+++ b/src/block/RedstoneComparator.php
@ -24,11 +24,8 @@ declare(strict_types=1);
 namespace pocketmine\block;

 use pocketmine\block\tile\Comparator;
-use pocketmine\block\utils\AnalogRedstoneSignalEmitter;
 use pocketmine\block\utils\AnalogRedstoneSignalEmitterTrait;
-use pocketmine\block\utils\HorizontalFacing;
 use pocketmine\block\utils\HorizontalFacingTrait;
-use pocketmine\block\utils\PoweredByRedstone;
 use pocketmine\block\utils\PoweredByRedstoneTrait;
 use pocketmine\block\utils\StaticSupportTrait;
 use pocketmine\block\utils\SupportType;
@ -41,7 +38,7 @@ use pocketmine\player\Player;
 use pocketmine\world\BlockTransaction;
 use function assert;

-class RedstoneComparator extends Flowable implements AnalogRedstoneSignalEmitter, PoweredByRedstone, HorizontalFacing{
+class RedstoneComparator extends Flowable{
 	use HorizontalFacingTrait;
 	use AnalogRedstoneSignalEmitterTrait;
 	use PoweredByRedstoneTrait;
--- a/src/block/RedstoneLamp.php
+++ b/src/block/RedstoneLamp.php
@ -23,12 +23,10 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Lightable;
-use pocketmine\block\utils\PoweredByRedstone;
 use pocketmine\block\utils\PoweredByRedstoneTrait;
 use pocketmine\data\runtime\RuntimeDataDescriber;

-class RedstoneLamp extends Opaque implements PoweredByRedstone, Lightable{
+class RedstoneLamp extends Opaque{
 	use PoweredByRedstoneTrait;

 	protected function describeBlockOnlyState(RuntimeDataDescriber $w) : void{
@ -38,14 +36,4 @@ class RedstoneLamp extends Opaque implements PoweredByRedstone, Lightable{
 	public function getLightLevel() : int{
 		return $this->powered ? 15 : 0;
 	}
-
-	public function isLit() : bool{
-		return $this->powered;
-	}
-
-	/** @return $this */
-	public function setLit(bool $lit = true) : self{
-		$this->powered = $lit;
-		return $this;
-	}
 }
--- a/src/block/RedstoneOre.php
+++ b/src/block/RedstoneOre.php
@ -24,7 +24,6 @@ declare(strict_types=1);
 namespace pocketmine\block;

 use pocketmine\block\utils\FortuneDropHelper;
-use pocketmine\block\utils\Lightable;
 use pocketmine\block\utils\LightableTrait;
 use pocketmine\item\Item;
 use pocketmine\item\VanillaItems;
@ -32,7 +31,7 @@ use pocketmine\math\Vector3;
 use pocketmine\player\Player;
 use function mt_rand;

-class RedstoneOre extends Opaque implements Lightable{
+class RedstoneOre extends Opaque{
 	use LightableTrait;

 	public function getLightLevel() : int{
--- a/src/block/RedstoneRepeater.php
+++ b/src/block/RedstoneRepeater.php
@ -23,9 +23,7 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\HorizontalFacing;
 use pocketmine\block\utils\HorizontalFacingTrait;
-use pocketmine\block\utils\PoweredByRedstone;
 use pocketmine\block\utils\PoweredByRedstoneTrait;
 use pocketmine\block\utils\StaticSupportTrait;
 use pocketmine\block\utils\SupportType;
@ -37,7 +35,7 @@ use pocketmine\math\Vector3;
 use pocketmine\player\Player;
 use pocketmine\world\BlockTransaction;

-class RedstoneRepeater extends Flowable implements PoweredByRedstone, HorizontalFacing{
+class RedstoneRepeater extends Flowable{
 	use HorizontalFacingTrait;
 	use PoweredByRedstoneTrait;
 	use StaticSupportTrait;
--- a/src/block/RedstoneTorch.php
+++ b/src/block/RedstoneTorch.php
@ -23,11 +23,10 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Lightable;
 use pocketmine\block\utils\LightableTrait;
 use pocketmine\data\runtime\RuntimeDataDescriber;

-class RedstoneTorch extends Torch implements Lightable{
+class RedstoneTorch extends Torch{
 	use LightableTrait;

 	public function __construct(BlockIdentifier $idInfo, string $name, BlockTypeInfo $typeInfo){
--- a/src/block/RedstoneWire.php
+++ b/src/block/RedstoneWire.php
@ -23,14 +23,13 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\AnalogRedstoneSignalEmitter;
 use pocketmine\block\utils\AnalogRedstoneSignalEmitterTrait;
 use pocketmine\block\utils\StaticSupportTrait;
 use pocketmine\item\Item;
 use pocketmine\item\VanillaItems;
 use pocketmine\math\Facing;

-class RedstoneWire extends Flowable implements AnalogRedstoneSignalEmitter{
+class RedstoneWire extends Flowable{
 	use AnalogRedstoneSignalEmitterTrait;
 	use StaticSupportTrait;

--- a/src/block/ResinClump.php
+++ b/src/block/ResinClump.php
@ -23,11 +23,10 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\MultiAnyFacing;
 use pocketmine\block\utils\MultiAnySupportTrait;
 use pocketmine\block\utils\SupportType;

-final class ResinClump extends Transparent implements MultiAnyFacing{
+final class ResinClump extends Transparent{
 	use MultiAnySupportTrait;

 	public function isSolid() : bool{
--- a/src/block/ShulkerBox.php
+++ b/src/block/ShulkerBox.php
@ -24,7 +24,6 @@ declare(strict_types=1);
 namespace pocketmine\block;

 use pocketmine\block\tile\ShulkerBox as TileShulkerBox;
-use pocketmine\block\utils\AnyFacing;
 use pocketmine\block\utils\AnyFacingTrait;
 use pocketmine\block\utils\SupportType;
 use pocketmine\data\runtime\RuntimeDataDescriber;
@ -33,7 +32,7 @@ use pocketmine\math\Vector3;
 use pocketmine\player\Player;
 use pocketmine\world\BlockTransaction;

-class ShulkerBox extends Opaque implements AnyFacing{
+class ShulkerBox extends Opaque{
 	use AnyFacingTrait;

 	protected function describeBlockOnlyState(RuntimeDataDescriber $w) : void{
--- a/src/block/SimplePillar.php
+++ b/src/block/SimplePillar.php
@ -23,13 +23,12 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\PillarRotation;
 use pocketmine\block\utils\PillarRotationTrait;

 /**
 * @internal This class provides a general base for pillar-like blocks. It **should not** be used for contract binding
 * in APIs, because not all pillar-like blocks extend this class.
 */
-class SimplePillar extends Opaque implements PillarRotation{
+class SimplePillar extends Opaque{
 	use PillarRotationTrait;
 }
--- a/src/block/SmallDripleaf.php
+++ b/src/block/SmallDripleaf.php
@ -23,7 +23,6 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\HorizontalFacing;
 use pocketmine\block\utils\HorizontalFacingTrait;
 use pocketmine\block\utils\SupportType;
 use pocketmine\data\runtime\RuntimeDataDescriber;
@ -37,7 +36,7 @@ use pocketmine\world\BlockTransaction;
 use pocketmine\world\Position;
 use function mt_rand;

-class SmallDripleaf extends Transparent implements HorizontalFacing{
+class SmallDripleaf extends Transparent{
 	use HorizontalFacingTrait;

 	protected bool $top = false;
--- a/src/block/StainedGlass.php
+++ b/src/block/StainedGlass.php
@ -23,9 +23,8 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Colored;
 use pocketmine\block\utils\ColoredTrait;

-final class StainedGlass extends Glass implements Colored{
+final class StainedGlass extends Glass{
 	use ColoredTrait;
 }
--- a/src/block/StainedGlassPane.php
+++ b/src/block/StainedGlassPane.php
@ -23,9 +23,8 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Colored;
 use pocketmine\block\utils\ColoredTrait;

-final class StainedGlassPane extends GlassPane implements Colored{
+final class StainedGlassPane extends GlassPane{
 	use ColoredTrait;
 }
--- a/src/block/StainedHardenedClay.php
+++ b/src/block/StainedHardenedClay.php
@ -23,9 +23,8 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Colored;
 use pocketmine\block\utils\ColoredTrait;

-final class StainedHardenedClay extends HardenedClay implements Colored{
+final class StainedHardenedClay extends HardenedClay{
 	use ColoredTrait;
 }
--- a/src/block/StainedHardenedGlass.php
+++ b/src/block/StainedHardenedGlass.php
@ -23,9 +23,8 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Colored;
 use pocketmine\block\utils\ColoredTrait;

-final class StainedHardenedGlass extends HardenedGlass implements Colored{
+final class StainedHardenedGlass extends HardenedGlass{
 	use ColoredTrait;
 }
--- a/src/block/StainedHardenedGlassPane.php
+++ b/src/block/StainedHardenedGlassPane.php
@ -23,9 +23,8 @@ declare(strict_types=1);

 namespace pocketmine\block;

-use pocketmine\block\utils\Colored;
 use pocketmine\block\utils\ColoredTrait;

-final class StainedHardenedGlassPane extends HardenedGlassPane implements Colored{
+final class StainedHardenedGlassPane extends HardenedGlassPane{
 	use ColoredTrait;
 }
--- a/Show More
+++ b/Show More
Author	SHA1	Message	Date
ShockedPlot7560	39c9387efe	Implement handlers stuck detection system	2025-08-05 15:37:24 +02:00
ShockedPlot7560	31275ba681	Merge remote-tracking branch 'upstream/minor-next' into feat/async-events	2025-07-29 14:12:40 +02:00
Dylan T.	a0d69a9fb8	github web editor don't fuck up indentation, challenge impossible	2024-11-29 14:13:25 +00:00
Dylan T.	e8ec81d123	fix PHPStan error	2024-11-29 14:08:06 +00:00
Dylan T.	866d473553	Merge branch 'minor-next' into feat/async-events	2024-11-29 13:49:20 +00:00
Dylan K. Taylor	d9080f182c	we don't need a fake server instance outside of setUp() in these tests	2024-11-20 16:44:00 +00:00
Dylan K. Taylor	d9f5634262	CS	2024-11-20 16:37:49 +00:00
Dylan K. Taylor	406e2c6c57	Convert integration tests to unit tests this required mocking to get around #6524. Longer term we should make improvements to avoid the need for mocking here.	2024-11-20 16:35:20 +00:00
Dylan K. Taylor	4451770ca3	Merge branch 'minor-next' into feat/async-events	2024-11-20 15:43:17 +00:00
Dylan T.	d2d663b1c9	Simplify handler sorting	2024-11-14 13:11:38 +00:00
Dylan T.	117026cb83	Merge branch 'minor-next' into feat/async-events	2024-11-13 23:06:05 +00:00
Dylan K. Taylor	a7a1077676	CONTRIBUTING: changing an event from sync to async or vice versa is a BC break	2024-11-13 23:00:49 +00:00
Dylan K. Taylor	0a56cf877b	Remove unused class	2024-11-13 22:58:29 +00:00
Dylan K. Taylor	11fdf79a7c	...	2024-11-13 22:55:08 +00:00
Dylan K. Taylor	edae9f26e4	Reduce number of classes	2024-11-13 22:23:43 +00:00
Dylan K. Taylor	667656b1c6	Split AsyncHandlerListManager this allows further code deduplication at the expense of needing 2 calls to unregister all handlers	2024-11-13 22:08:28 +00:00
Dylan K. Taylor	972a9fb201	PluginManager: ensure that handler candidates of async events with wrong return types don't attempt to register as sync events this will cause other, more confusing errors to be thrown. to be honest, I'm not sure if enforcing the return type here is even necessary (or desirable).	2024-11-13 21:30:24 +00:00
Dylan K. Taylor	ac1cf73f8e	Reduce code duplication	2024-11-13 21:09:52 +00:00
Dylan K. Taylor	96989d1dc4	cleanup	2024-11-13 20:44:35 +00:00
Dylan K. Taylor	8aed5d6b27	Handler inheritance is now working this code should also perform somewhat better	2024-11-13 20:35:14 +00:00
Dylan K. Taylor	fa796535ff	ah hello my old friend, impossible-generics.neon propagating generics all the way through the likes of HandlerList etc is more trouble than it's worth.	2024-11-13 19:09:52 +00:00
Dylan K. Taylor	32b1d6c0c2	Fixed test code the test still doesn't pass, but at least it's actually testing the problem now...	2024-11-13 18:52:56 +00:00
Dylan K. Taylor	6f40c6fc1d	CS	2024-11-13 18:49:58 +00:00
Dylan K. Taylor	a6a44bde90	Fix doc comments	2024-11-13 18:49:32 +00:00
Dylan K. Taylor	409066c8f5	AsyncEvent: make the code easier to make sense of	2024-11-13 18:49:15 +00:00
Dylan K. Taylor	cb2fadeb26	Fixed bug in concurrency integration test	2024-11-13 18:47:46 +00:00
Dylan K. Taylor	a14afb4bb5	Add integration tests most of these are failing - needs to be investigated	2024-11-13 18:39:14 +00:00
Dylan K. Taylor	db88e543fa	Fix PHPStan error	2024-11-13 16:04:27 +00:00
Dylan K. Taylor	c426677841	optimization	2024-11-13 16:03:10 +00:00
Dylan K. Taylor	17ae932d31	HandlerListManager: added getter	2024-11-13 15:36:51 +00:00
Dylan K. Taylor	8f48fe4856	Fully separate hierarchies for sync & async events there's no way to combine these without causing type compatibility issues for one side or the other. we might be able to use traits to reduce duplication, but the separation here seems to be necessary.	2024-11-13 15:35:41 +00:00
Dylan K. Taylor	48d2430064	Update PHPStan baseline	2024-11-13 14:58:09 +00:00
Dylan K. Taylor	b82d47dd32	Merge branch 'minor-next' into feat/async-events	2024-11-13 14:57:03 +00:00
Dylan K. Taylor	86fb041a65	Merge branch 'minor-next' of github.com:pmmp/PocketMine-MP into feat/async-events	2024-11-13 14:46:32 +00:00
ShockedPlot7560	b276133003	Merge remote-tracking branch 'origin/minor-next' into feat/async-events	2024-07-02 13:44:36 +00:00
ShockedPlot7560	c1e3903934	fix PHPstan	2024-01-21 12:04:23 +01:00
ShockedPlot7560	eb9814197b	resolve AsyncEvent with self instance	2024-01-21 11:50:31 +01:00
ShockedPlot7560	d6b7a9ed45	merge remote tracking upstream	2024-01-21 11:28:24 +01:00
ShockedPlot7560	64bbff6286	Merge remote-tracking branch 'upstream/minor-next' into feat/async-events	2024-01-21 11:25:37 +01:00
ShockedPlot7560	f82c422f64	remove using of Event API	2024-01-21 11:25:34 +01:00
ShockedPlot7560	aaa37baf2e	handlerListe: reduce code complexity	2023-10-27 22:28:04 +02:00
ShockedPlot7560	243a3035ba	follow up of #6110	2023-10-27 22:14:21 +02:00
ShockedPlot7560	823d4ead6a	inconsistency correction	2023-10-27 22:12:03 +02:00
ShockedPlot7560	ca95b2f28d	fix PHPStan	2023-10-27 22:08:49 +02:00
ShockedPlot7560	cc6e8ef232	move the asynchronous registration of handlers to a dedicated PluginManager function	2023-10-27 21:58:43 +02:00
ShockedPlot7560	5beaa3ce4e	correction of various problems	2023-10-27 21:45:22 +02:00
ShockedPlot7560	7e87fbbb7a	clarifying the exception message	2023-10-27 21:39:18 +02:00
ShockedPlot7560	ed739cff4f	cannot call async event in sync context + remove Event dependency for AsyncEventDelegate	2023-10-27 21:37:56 +02:00
ShockedPlot7560	dc85bba995	merge remote tracking	2023-10-27 21:28:09 +02:00
Dylan T	1176b7090c	Update src/player/Player.php Co-authored-by: Javier León <58715544+JavierLeon9966@users.noreply.github.com>	2023-10-23 17:31:53 +01:00
ShockedPlot7560	2b2fa9ddf1	phpstan: populate baseline	2023-10-22 15:45:05 +02:00
ShockedPlot7560	58155a77fb	fix PHPstan	2023-10-22 15:18:39 +02:00
ShockedPlot7560	c250bb0da7	undo Promise covariant + improve array types	2023-10-22 15:08:50 +02:00
ShockedPlot7560	b78ff00418	fix style	2023-10-22 15:06:17 +02:00
ShockedPlot7560	9b2b92ac1f	oops, remove test code	2023-10-22 15:05:06 +02:00
ShockedPlot7560	7a4b9a0367	events: asynchandler is defined by their return type and event type If the event is async and the handler return Promise, it will be handle as an async event. However, if the event is async and the handler return smth different than Promise, it will be handle synchronously. An async handler can specify if it wishes to be called with no concurrent handlers with the tag @noConcurrentCall	2023-10-22 15:01:11 +02:00
ShockedPlot7560	a84fc2b901	introduce AsyncEvent and ::callAsync() An asynchronous event is one that allows the addition of promises to be resolved before being completed. This implementation integrates priority levels, allowing you to wait for all promises added to one level before moving on to the next. This is made possible by separating the event call logic into several functions, which can then be integrated into AsyncEventTrait::callAsync()	2023-10-14 23:13:35 +02:00
ShockedPlot7560	5fe57a8f6f	temporaly add Promise::all code came from #6015 and will be subject to probable changes	2023-10-14 21:36:44 +02:00