mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-04 17:06:16 +00:00
Code Issues Projects Releases Wiki Activity

PluginManager: ensure that handler candidates of async events with wrong return types don't attempt to register as sync events

Browse Source 
this will cause other, more confusing errors to be thrown.

to be honest, I'm not sure if enforcing the return type here is even necessary (or desirable).
This commit is contained in:
Dylan K. Taylor
2024-11-13 21:30:24 +00:00
parent ac1cf73f8e
commit 972a9fb201
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugin/PluginManager.php
View File

@ -654,7 +654,10 @@ class PluginManager{
}
}
if(is_subclass_of($eventClass, AsyncEvent::class) && $this->canHandleAsyncEvent($handlerClosure)){
if(is_subclass_of($eventClass, AsyncEvent::class)){
if(!$this->canHandleAsyncEvent($handlerClosure)){
throw new PluginException("Event handler " . Utils::getNiceClosureName($handlerClosure) . " must return null|Promise<null> to be able to handle async events");
}
$this->registerAsyncEvent($eventClass, $handlerClosure, $priority, $plugin, $handleCancelled, $exclusiveCall);
}else{
$this->registerEvent($eventClass, $handlerClosure, $priority, $plugin, $handleCancelled);