9a0ead6deb
Validate paths in --data and --plugins
...
closes #2861
2022-10-21 14:28:22 +01:00
d74824c8d5
Correctly use Command->getLabel() instead of Command->getName()
...
getName() essentially serves as an ID for the command for CommandExecutors. It has no other sane use case.
Since it's not unique (multiple commands with the same name may be registered, and the fallback alias will be used on conflict), it cannot be used for array indexing. It's also not correct to use it for any display purpose, since the command may not be able to be invoked by its 'name' if there was a conflict.
There is an open debate about what to do with getName() and the wider CommandExecutor ecosystem, but that's a topic for another discussion.
closes #5344
2022-10-18 19:34:12 +01:00
d4eb73abe9
Bump phpstan/phpstan from 1.8.9 to 1.8.10 ( #5351 )
...
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan ) from 1.8.9 to 1.8.10.
- [Release notes](https://github.com/phpstan/phpstan/releases )
- [Changelog](https://github.com/phpstan/phpstan/blob/1.9.x/CHANGELOG.md )
- [Commits](https://github.com/phpstan/phpstan/compare/1.8.9...1.8.10 )
---
updated-dependencies:
- dependency-name: phpstan/phpstan
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-18 16:56:55 +01:00
d1d5020c53
FallableTrait: add default implementation of tickFalling() to reduce Fallable pollution ( #5350 )
...
this is only used by concrete powder currently, so it doesn't make much sense to reimplement it in every implementor of Fallable.
2022-10-18 16:56:21 +01:00
9f6c6b2b71
Merge branch 'next-minor' into next-major
2022-10-16 16:58:50 +01:00
bd01a919e5
Move command timings to Timings::
...
this avoids duplicate timings entries when command labels are changed and changed back, or if multiple command maps are in use.
In addition, it also solves some PHPStan issues :)
2022-10-16 16:57:10 +01:00
7864294336
Merge branch 'stable' into next-minor
2022-10-16 16:53:14 +01:00
2a910c1cc2
World: more minor documentation improvements
2022-10-16 16:50:42 +01:00
cd04a3db2e
World: ensure that addParticle/addSound don't send stuff to players who are not in range, even when an array of targets is given
...
closes #5347
2022-10-16 16:45:52 +01:00
572def9245
World: Improve quality of type information
2022-10-16 16:21:59 +01:00
20f5bed926
Bump phpstan/phpstan from 1.8.8 to 1.8.9 ( #5341 )
...
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan ) from 1.8.8 to 1.8.9.
- [Release notes](https://github.com/phpstan/phpstan/releases )
- [Changelog](https://github.com/phpstan/phpstan/blob/1.9.x/CHANGELOG.md )
- [Commits](https://github.com/phpstan/phpstan/compare/1.8.8...1.8.9 )
---
updated-dependencies:
- dependency-name: phpstan/phpstan
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-16 15:36:01 +01:00
14d17a9546
Remove Erroneous documentation ( #5346 )
2022-10-16 15:21:35 +01:00
b74c092d9b
Server: removed reference to nonexistent API method
2022-10-15 15:06:43 +01:00
53cae8911d
Merge branch 'next-minor' into next-major
2022-10-14 21:53:25 +01:00
7bcc663b60
Migrate core code to using symfony/filesystem
...
webmozart/path-util is retained for plugin compatibility, but is dropped in 5.0
2022-10-14 21:51:29 +01:00
b3bda788d9
Server: Deprecated getPlayerByPrefix()
...
this is only used for commands anyway, but we can't get rid of it yet.
2022-10-14 21:45:09 +01:00
2cc8a56e68
Server: fixed borked serverCommand timings
2022-10-14 20:02:44 +01:00
b70f7afbd6
Fix CS according to latest version of php-cs-fixer
2022-10-13 21:07:07 +01:00
92783a6db9
Merge branch 'next-minor' into next-major
2022-10-13 21:06:39 +01:00
57deb60355
Merge branch 'stable' into next-minor
2022-10-13 21:03:50 +01:00
92e47b98f8
Updated DevTools submodule to pmmp/DevTools@bd0fa048da
2022-10-13 21:02:39 +01:00
b84c110819
Fix CS according to newest php-cs-fixer
2022-10-13 21:00:57 +01:00
e1b0e00c6f
DataPacketSendEvent: add array type validation
...
this API is used directly by plugins, so anything goes.
2022-10-13 17:10:33 +01:00
774df0fa4c
DataPacketSendEvent: added setPackets()
...
this is an implicit BC break, since plugins may assume that the packets in this array aren't going to change.
However, in practice, it's not likely to cause any real issues.
2022-10-13 17:06:09 +01:00
f88ae93897
BC break: Replaced webmozart/path-util with symfony/filesystem, closes #5332
2022-10-13 16:43:36 +01:00
4fadb63f67
Bump build/php from 50062b5 to 14ed8ea ( #5337 )
...
Bumps [build/php](https://github.com/pmmp/php-build-scripts ) from `50062b5` to `14ed8ea`.
- [Release notes](https://github.com/pmmp/php-build-scripts/releases )
- [Commits](50062b5861...14ed8eaaddsupport@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-13 16:29:01 +01:00
c83f0896ac
Bump ncipollo/release-action from 1.10.0 to 1.11.1 ( #5319 )
...
Bumps [ncipollo/release-action](https://github.com/ncipollo/release-action ) from 1.10.0 to 1.11.1.
- [Release notes](https://github.com/ncipollo/release-action/releases )
- [Commits](https://github.com/ncipollo/release-action/compare/v1.10.0...v1.11.1 )
---
updated-dependencies:
- dependency-name: ncipollo/release-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-13 13:07:03 +01:00
0d29a138fb
Bump docker/build-push-action from 3.1.1 to 3.2.0 ( #5336 )
...
Bumps [docker/build-push-action](https://github.com/docker/build-push-action ) from 3.1.1 to 3.2.0.
- [Release notes](https://github.com/docker/build-push-action/releases )
- [Commits](https://github.com/docker/build-push-action/compare/v3.1.1...v3.2.0 )
---
updated-dependencies:
- dependency-name: docker/build-push-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-13 13:06:25 +01:00
421379fc77
SplashPotion: Use World::getCollidingEntities() instead of World::getNearbyEntities() ( #5326 )
...
fixes spectator players receiving effects from splash potions
2022-10-11 22:57:35 +01:00
293cea7714
4.9.2 is next
2022-10-11 22:47:58 +01:00
15645759e9
Release 4.9.1
2022-10-11 22:47:54 +01:00
8dc0d506f4
Merge branch 'next-minor' into next-major
2022-10-11 22:29:21 +01:00
8c651ce4b4
t Merge remote-tracking branch 'origin/next-minor' into next-major
2022-10-11 22:06:18 +01:00
db7cee6f22
Player: check if the item meaningfully changed before discarding it in creative
...
fixes #5220
2022-10-11 22:06:03 +01:00
6ae7cb288e
Merge remote-tracking branch 'origin/stable' into next-minor
2022-10-11 21:59:40 +01:00
7df2719fce
Update Composer dependencies
2022-10-11 21:57:22 +01:00
10b8dcfdd1
Bump phpstan/phpstan from 1.8.6 to 1.8.8 ( #5324 )
...
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan ) from 1.8.6 to 1.8.8.
- [Release notes](https://github.com/phpstan/phpstan/releases )
- [Changelog](https://github.com/phpstan/phpstan/blob/1.9.x/CHANGELOG.md )
- [Commits](https://github.com/phpstan/phpstan/compare/1.8.6...1.8.8 )
---
updated-dependencies:
- dependency-name: phpstan/phpstan
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-07 11:43:39 +01:00
c1fbac412e
event: ensure that modifications to items expected to be readonly have no effect
...
this isn't a very glorious fix, but it's the best I have for now.
2022-10-07 11:33:14 +01:00
3feaa18f6c
DelegateInventory: use WeakReference and __destruct to clean up inventory listener
...
this is more sane, since it allows the delegate to be reused without unexpected behaviour.
2022-09-30 15:12:37 +01:00
1c6a2b66f7
Merge remote-tracking branch 'origin/next-minor' into next-major
2022-09-29 22:38:26 +01:00
41970feb57
Entity: Fire EntitySpawnEvent/ItemSpawnEvent on the first entity tick, instead of in the constructor ( #5314 )
...
This allows plugins to modify the entity via setters in EntitySpawnEvent without their changes getting overwritten by setter calls directly after the 'new YourEntity' statement.
As well as benefiting plugins, this also clears a path for a BC-breaking change in PM5 (to have the programmer use addEntity() to spawn entities, instead of the constructor doing it, which will improve on a number of data handling aspects).
fixes #4973
This targets next-minor because it has some side effects on plugins that depended on the old behaviour, such as VanillaHopper, so it's not suitable for a patch release.
2022-09-29 22:30:12 +01:00
0edf2ea6a4
ConcretePowder: fix CS
2022-09-29 21:50:15 +01:00
cd4bb91676
Living: alter eye height so the player doesn't drown on the surface of water when swimming
...
fixes #4989
2022-09-29 00:15:07 +01:00
2be527060f
Sign: Fixed desync of colour and glowing state when using dye on signs
...
fixes #4932
2022-09-28 23:34:08 +01:00
6f68c6d8a0
Melon: extend Solid instead of Transparent, fixes #5050
2022-09-28 23:07:53 +01:00
ac16378410
Silence pre-spawn PlayerAuthInputPacket debug spam
2022-09-28 21:58:23 +01:00
1f9dfa77bf
PreSpawnPacketHandler: emit a separate debug message for sending creative data
2022-09-28 21:58:23 +01:00
0c7f8470b9
Avoid repeated strtolower usages in a couple of places
2022-09-28 21:30:06 +01:00
fc56c041f3
Correct knockback from explosions ( #5161 )
2022-09-28 21:09:07 +01:00
d6bbf8217d
ResourcePackManager: avoid repeated operation
2022-09-28 20:57:17 +01:00
