Dylan K. Taylor
4e777572c9
fix CS
2022-03-23 13:28:21 +00:00
Dylan K. Taylor
90a8595a40
Check for mismatched inventory slot predictions in transactions
...
this should limit the problems caused by mismatched gameplay features that result in ghost items, such as #4896 .
2022-03-22 17:42:19 +00:00
Dylan K. Taylor
bf71eb448a
Reduce chaos in inventory classes
2022-03-22 17:19:55 +00:00
Dylan K. Taylor
2c29d272ad
BaseInventory: move setMaxStackSize() to a more sensible place
2022-03-22 17:11:48 +00:00
Dylan K. Taylor
98aa2b9ff9
Inventory: move removeItem() next to remove()
...
this should hopefully be more attention grabbing and a bit less misleading, since people will wonder why there are 'remove' and 'removeItem' both.
we really need to rename one of these...
2022-03-22 17:08:30 +00:00
Dylan K. Taylor
ea33a04d00
Player: ensure that PlayerItemHeldEvent is called when the contents of the held slot changes
...
in PM3, this was done by implicitly relying on the client to send a MobEquipmentPacket selecting the same hotbar slot when the slot contents changes.
In PM4, we avoid relying on this, and fire the event directly when the listener detects a held slot change.
This ensures that the behaviour remains consistent regardless of what the client starts doing in the future.
closes #4905
2022-03-22 16:53:02 +00:00
Dylan K. Taylor
4a94cb85a2
fix CS
2022-03-22 15:44:11 +00:00
Dylan K. Taylor
b7e6854189
RegistryTrait: enforce name validation rules on everything, not just enums
...
fixes #4916
2022-03-22 15:41:17 +00:00
Dylan K. Taylor
2b8a54f8ff
Entity: added a guard to prevent __construct() from running multiple times
...
this typically happens due to flawed logic in child classes in plugins which causes parent::__construct() to get called multiple times.
2022-03-22 15:33:31 +00:00
dependabot[bot]
a5dab0f61e
Bump build/php from b6bb711 to 1fae6b8 ( #4918 )
...
Bumps [build/php](https://github.com/pmmp/php-build-scripts ) from `b6bb711` to `1fae6b8`.
- [Release notes](https://github.com/pmmp/php-build-scripts/releases )
- [Commits](b6bb7114b3...1fae6b8d4a
2022-03-21 21:05:13 +00:00
Dylan T
824f1f24ff
Build release Docker images on GitHub Actions ( #4891 )
...
this has been tested on a fork using GitHub Container Registry, but we'll have to do an actual release to test if it will work with Docker Hub. However, I don't expect there to be any problems.
This is one of two remaining jobs to be migrated off Jenkins.
2022-03-20 01:03:27 +00:00
PJZ9n
f4f5c3128f
EnumTrait: fixed regex not accepting member names with 1 character
...
this also fixes EnumTrait accepting invalid non-numeric characters for the first character, such as @.
2022-03-19 16:47:36 +00:00
Dylan K. Taylor
fdd42fd15f
4.2.5 is next
2022-03-18 20:20:47 +00:00
Dylan K. Taylor
05a5e5eac1
Release 4.2.4
2022-03-18 20:20:32 +00:00
Dylan K. Taylor
c8e1cfcbee
TypeConverter: account for possible out-of-range meta in items
2022-03-18 19:34:51 +00:00
dependabot[bot]
869dda9a45
Bump phpunit/phpunit from 9.5.18 to 9.5.19 ( #4900 )
...
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit ) from 9.5.18 to 9.5.19.
- [Release notes](https://github.com/sebastianbergmann/phpunit/releases )
- [Changelog](https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-9.5.md )
- [Commits](https://github.com/sebastianbergmann/phpunit/compare/9.5.18...9.5.19 )
---
updated-dependencies:
- dependency-name: phpunit/phpunit
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-15 19:39:49 +00:00
dependabot[bot]
e2c647ef91
Bump phpstan/phpstan from 1.4.9 to 1.4.10 ( #4899 )
...
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan ) from 1.4.9 to 1.4.10.
- [Release notes](https://github.com/phpstan/phpstan/releases )
- [Changelog](https://github.com/phpstan/phpstan/blob/1.5.x/CHANGELOG.md )
- [Commits](https://github.com/phpstan/phpstan/compare/1.4.9...1.4.10 )
---
updated-dependencies:
- dependency-name: phpstan/phpstan
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-15 12:04:50 +00:00
Dylan K. Taylor
05fdd94754
fix CS
2022-03-12 00:57:32 +00:00
dependabot[bot]
4a599b58ff
Bump phpstan/phpstan from 1.4.8 to 1.4.9 ( #4893 )
...
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan ) from 1.4.8 to 1.4.9.
- [Release notes](https://github.com/phpstan/phpstan/releases )
- [Changelog](https://github.com/phpstan/phpstan/blob/master/CHANGELOG.md )
- [Commits](https://github.com/phpstan/phpstan/compare/1.4.8...1.4.9 )
---
updated-dependencies:
- dependency-name: phpstan/phpstan
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-10 20:18:53 +00:00
Dylan K. Taylor
05792826bc
EntityFactory: use import aliases to improve readability slightly
2022-03-09 23:39:45 +00:00
Dylan K. Taylor
fbf7ad4295
4.2.4 is next
2022-03-09 22:52:42 +00:00
Dylan K. Taylor
6c1c0c867e
Release 4.2.3
2022-03-09 22:52:38 +00:00
Dylan K. Taylor
5c0eb92d81
Entity: harden setRotation(), setMotion(), addMotion() and teleport() against NaN/INF values
2022-03-09 22:36:44 +00:00
Dylan K. Taylor
1e88412a8f
Entity: harden constructor against dodgy locations containing NaN/INF components
2022-03-09 22:31:24 +00:00
Dylan K. Taylor
f97ce6afef
Harden APIs which accept Vector3/Position/Location in event namespace
2022-03-09 22:22:37 +00:00
Dylan K. Taylor
879476d8e0
ItemFrame: added missing bounds check for setItemDropChance()
2022-03-09 22:20:04 +00:00
Dylan K. Taylor
6d584cf008
EntityDataHelper: prevent INF/NaN being loaded from disk to come back and break things after the fact
2022-03-09 22:16:07 +00:00
Dylan K. Taylor
8efa299c65
phpstan 1.4.8
2022-03-09 18:30:54 +00:00
Dylan K. Taylor
b6e7ad187a
Updated composer dependencies
2022-03-09 18:07:28 +00:00
Dylan K. Taylor
5ef73ca9aa
Entity: Remove outdated comment
2022-03-09 18:02:57 +00:00
Dylan K. Taylor
c50518a4ca
build/generate-registry-annotations: specify type that PHPStan can't infer
2022-03-09 17:53:10 +00:00
Dylan K. Taylor
4c98780bdb
Fixed PHPStan iterable types for LevelDBIterator
2022-03-09 17:28:59 +00:00
Dylan K. Taylor
856fd2a33b
fix PHPStan failures
2022-03-09 17:26:05 +00:00
Dylan K. Taylor
581bbfe255
DiskResourceProvider: add @var for type that PHPStan can't infer
2022-03-09 17:18:40 +00:00
Dylan K. Taylor
b4e1edaa64
CommandSender: provide more detailed types for getScreenLineHeight() and setScreenLineHeight()
2022-03-09 17:17:51 +00:00
Dylan K. Taylor
025f6407e2
Fire: fixed sticking to transparent top-sides of blocks
...
closes #4879
closes #2819
2022-03-09 16:59:26 +00:00
IvanCraft623
10c0d83fa5
ShulkerBox: Allow opening unless the lid is obstructed by a solid block ( #4885 )
...
fixes #4884
2022-03-09 16:37:23 +00:00
dependabot[bot]
9a6ec14cbf
Bump phpunit/phpunit from 9.5.16 to 9.5.18 ( #4892 )
...
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit ) from 9.5.16 to 9.5.18.
- [Release notes](https://github.com/sebastianbergmann/phpunit/releases )
- [Changelog](https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-9.5.md )
- [Commits](https://github.com/sebastianbergmann/phpunit/compare/9.5.16...9.5.18 )
---
updated-dependencies:
- dependency-name: phpunit/phpunit
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-09 16:32:47 +00:00
Dylan K. Taylor
f77fec0c3c
doxygen -u doxygen/doxygen.conf
2022-03-09 16:28:38 +00:00
Dylan K. Taylor
5d970cf5bd
Fire: do not overwrite blocks during burning unless they were unchanged by onIncinerate()
...
onIncinerate() by custom blocks might produce custom results which aren't supposed to be burned away (e.g. wood could turn into charred wood, or something of that nature).
closes #4764
2022-03-03 19:19:59 +00:00
dependabot[bot]
58e186440b
Bump build/php from d110b60 to b6bb711 ( #4871 )
...
Bumps [build/php](https://github.com/pmmp/php-build-scripts ) from `d110b60` to `b6bb711`.
- [Release notes](https://github.com/pmmp/php-build-scripts/releases )
- [Commits](d110b60bef...b6bb7114b3
2022-03-03 19:02:30 +00:00
Leo Lee
6a39caa204
Fixed mycelium spreading onto coarse dirt ( #4816 )
2022-03-03 19:02:13 +00:00
ipad54
91f81d4c8e
Sweet Berry Bush now absorbs fall damage ( #4876 )
2022-03-03 19:00:44 +00:00
Dylan K. Taylor
dfd8c4e4b8
TaskScheduler: throw an exception if attempting to heartbeat a disabled scheduler
2022-03-03 18:49:17 +00:00
Dylan K. Taylor
c9c50e16ec
PluginManager: fixed mishandling of self-disabling plugins in enablePlugins()
...
this caused a leak of the plugin context, PluginEnableEvent to be called with a disabled plugin, and the plugin's scheduler to get ticked.
2022-03-03 18:48:52 +00:00
Dylan K. Taylor
3e90c3072a
4.2.3 is next
2022-03-02 23:00:33 +00:00
Dylan K. Taylor
12946fbe46
Release 4.2.2
2022-03-02 23:00:29 +00:00
Dylan K. Taylor
7cd394b0fb
Merge branch 'stable' of github.com:pmmp/PocketMine-MP into stable
2022-03-02 18:30:38 +00:00
Dylan K. Taylor
0bca098707
doxygen: remove footer timestamp
2022-03-02 18:30:26 +00:00
Rush2929
d47a7f48bd
BrewingStand: avoid duplicate method call ( #4874 )
2022-03-02 17:32:56 +00:00
