alvin0319
1e9d83f014
BaseInventory: validate given array in setContents() ( #5391 )
2022-11-07 13:09:05 +00:00
Dylan K. Taylor
6153a2ac70
Merge remote-tracking branch 'origin/stable' into next-minor
2022-11-04 20:51:40 +00:00
Dylan K. Taylor
ed452b9ccd
Scrub PHPStan baselines
2022-11-04 20:51:22 +00:00
Dylan K. Taylor
c19880e045
bootstrap: fix PHPStan error
2022-11-04 20:50:27 +00:00
Dylan K. Taylor
cdbdcb5d67
Merge branch 'stable' into next-minor
2022-11-04 20:44:28 +00:00
ipad54
29301614e8
Remove dead comments ( #5389 )
2022-11-04 20:23:56 +00:00
Dylan K. Taylor
2fdc46c165
PHPStan 1.9 features
2022-11-04 20:23:34 +00:00
Dylan K. Taylor
bfd1b2c635
PHPStan 1.9.1
2022-11-04 18:28:07 +00:00
Dylan K. Taylor
1671405cd0
Merge branch 'stable' into next-minor
2022-11-02 16:03:30 +00:00
Dylan K. Taylor
fe982c697b
Durable: reset durability when overstacked items are broken
...
this is not really defined behaviour, but it makes more sense than the current behaviour, which makes the tool unbreakable unintentionally.
fixes #5378
2022-11-02 15:42:44 +00:00
Dylan K. Taylor
1572b31b8d
FormattedCommandAlias: do not fill empty strings for missing placeholder arguments
...
this is pretty much always going to cause unexpected behaviour, as most execute() implementations don't expect empty strings, and it can also pad the args with dummy entries, breaking argument count requirements (e.g. aliasing say and using the alias with no arguments will confuse the target command).
Instead:
- Drop arguments that cannot be resolved (leave them unspecified)
- If they are at the end of the argument sequence, this is OK - it will behave the same as if some optional arguments weren't specified.
- If they are in the middle of the argument sequence, this will generate an error - this is preferable to having the target invoked with an empty string, which might cause unexpected behaviour.
fixes #5379
2022-11-02 15:02:29 +00:00
Dylan K. Taylor
b6f6671a81
Merge branch 'stable' into next-minor
2022-10-31 15:34:24 +00:00
Dylan K. Taylor
6da467b142
Updated composer dependencies
2022-10-31 15:27:56 +00:00
jasonw_4331
44af519cd6
SpawnResponsePacketHandler: silence PlayerAuthInputPacket debug spam ( #5368 )
2022-10-30 19:24:26 +00:00
Eren A. Akyol
fb31e6085e
StatusCommand: fix condition order for TPS colour ( #5366 )
2022-10-26 23:26:55 +01:00
Dylan K. Taylor
e4548da173
4.10.1 is next
2022-10-26 01:19:08 +01:00
Dylan K. Taylor
0d5287bf0b
Release 4.10.0
2022-10-26 01:19:02 +01:00
Dylan K. Taylor
a9361b3f8b
Changes for 1.19.40
2022-10-25 23:11:41 +01:00
dependabot[bot]
6e4c62744e
Bump phpstan/phpstan from 1.8.10 to 1.8.11 ( #5364 )
...
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan ) from 1.8.10 to 1.8.11.
- [Release notes](https://github.com/phpstan/phpstan/releases )
- [Changelog](https://github.com/phpstan/phpstan/blob/1.9.x/CHANGELOG.md )
- [Commits](https://github.com/phpstan/phpstan/compare/1.8.10...1.8.11 )
---
updated-dependencies:
- dependency-name: phpstan/phpstan
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-25 19:55:01 +01:00
Dylan K. Taylor
9a0ead6deb
Validate paths in --data and --plugins
...
closes #2861
2022-10-21 14:28:22 +01:00
Dylan K. Taylor
d74824c8d5
Correctly use Command->getLabel() instead of Command->getName()
...
getName() essentially serves as an ID for the command for CommandExecutors. It has no other sane use case.
Since it's not unique (multiple commands with the same name may be registered, and the fallback alias will be used on conflict), it cannot be used for array indexing. It's also not correct to use it for any display purpose, since the command may not be able to be invoked by its 'name' if there was a conflict.
There is an open debate about what to do with getName() and the wider CommandExecutor ecosystem, but that's a topic for another discussion.
closes #5344
2022-10-18 19:34:12 +01:00
dependabot[bot]
d4eb73abe9
Bump phpstan/phpstan from 1.8.9 to 1.8.10 ( #5351 )
...
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan ) from 1.8.9 to 1.8.10.
- [Release notes](https://github.com/phpstan/phpstan/releases )
- [Changelog](https://github.com/phpstan/phpstan/blob/1.9.x/CHANGELOG.md )
- [Commits](https://github.com/phpstan/phpstan/compare/1.8.9...1.8.10 )
---
updated-dependencies:
- dependency-name: phpstan/phpstan
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-18 16:56:55 +01:00
Dylan K. Taylor
0039af984d
Merge branch 'next-minor' into item-stack-request
2022-10-16 16:56:26 +01:00
Dylan K. Taylor
7864294336
Merge branch 'stable' into next-minor
2022-10-16 16:53:14 +01:00
Dylan K. Taylor
2a910c1cc2
World: more minor documentation improvements
2022-10-16 16:50:42 +01:00
Dylan K. Taylor
cd04a3db2e
World: ensure that addParticle/addSound don't send stuff to players who are not in range, even when an array of targets is given
...
closes #5347
2022-10-16 16:45:52 +01:00
Dylan K. Taylor
572def9245
World: Improve quality of type information
2022-10-16 16:21:59 +01:00
dependabot[bot]
20f5bed926
Bump phpstan/phpstan from 1.8.8 to 1.8.9 ( #5341 )
...
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan ) from 1.8.8 to 1.8.9.
- [Release notes](https://github.com/phpstan/phpstan/releases )
- [Changelog](https://github.com/phpstan/phpstan/blob/1.9.x/CHANGELOG.md )
- [Commits](https://github.com/phpstan/phpstan/compare/1.8.8...1.8.9 )
---
updated-dependencies:
- dependency-name: phpstan/phpstan
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-16 15:36:01 +01:00
IvanCraft623
14d17a9546
Remove Erroneous documentation ( #5346 )
2022-10-16 15:21:35 +01:00
Dylan K. Taylor
b74c092d9b
Server: removed reference to nonexistent API method
2022-10-15 15:06:43 +01:00
Dylan K. Taylor
7bcc663b60
Migrate core code to using symfony/filesystem
...
webmozart/path-util is retained for plugin compatibility, but is dropped in 5.0
2022-10-14 21:51:29 +01:00
Dylan K. Taylor
b3bda788d9
Server: Deprecated getPlayerByPrefix()
...
this is only used for commands anyway, but we can't get rid of it yet.
2022-10-14 21:45:09 +01:00
Dylan K. Taylor
2cc8a56e68
Server: fixed borked serverCommand timings
2022-10-14 20:02:44 +01:00
Dylan K. Taylor
57deb60355
Merge branch 'stable' into next-minor
2022-10-13 21:03:50 +01:00
Dylan K. Taylor
92e47b98f8
Updated DevTools submodule to pmmp/DevTools@bd0fa048da
2022-10-13 21:02:39 +01:00
Dylan K. Taylor
b84c110819
Fix CS according to newest php-cs-fixer
2022-10-13 21:00:57 +01:00
dependabot[bot]
4fadb63f67
Bump build/php from 50062b5 to 14ed8ea ( #5337 )
...
Bumps [build/php](https://github.com/pmmp/php-build-scripts ) from `50062b5` to `14ed8ea`.
- [Release notes](https://github.com/pmmp/php-build-scripts/releases )
- [Commits](50062b5861...14ed8eaadd
2022-10-13 16:29:01 +01:00
dependabot[bot]
c83f0896ac
Bump ncipollo/release-action from 1.10.0 to 1.11.1 ( #5319 )
...
Bumps [ncipollo/release-action](https://github.com/ncipollo/release-action ) from 1.10.0 to 1.11.1.
- [Release notes](https://github.com/ncipollo/release-action/releases )
- [Commits](https://github.com/ncipollo/release-action/compare/v1.10.0...v1.11.1 )
---
updated-dependencies:
- dependency-name: ncipollo/release-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-13 13:07:03 +01:00
dependabot[bot]
0d29a138fb
Bump docker/build-push-action from 3.1.1 to 3.2.0 ( #5336 )
...
Bumps [docker/build-push-action](https://github.com/docker/build-push-action ) from 3.1.1 to 3.2.0.
- [Release notes](https://github.com/docker/build-push-action/releases )
- [Commits](https://github.com/docker/build-push-action/compare/v3.1.1...v3.2.0 )
---
updated-dependencies:
- dependency-name: docker/build-push-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-13 13:06:25 +01:00
IvanCraft623
421379fc77
SplashPotion: Use World::getCollidingEntities() instead of World::getNearbyEntities() ( #5326 )
...
fixes spectator players receiving effects from splash potions
2022-10-11 22:57:35 +01:00
Dylan K. Taylor
293cea7714
4.9.2 is next
2022-10-11 22:47:58 +01:00
Dylan K. Taylor
15645759e9
Release 4.9.1
2022-10-11 22:47:54 +01:00
Dylan K. Taylor
6ae7cb288e
Merge remote-tracking branch 'origin/stable' into next-minor
2022-10-11 21:59:40 +01:00
Dylan K. Taylor
7df2719fce
Update Composer dependencies
2022-10-11 21:57:22 +01:00
dependabot[bot]
10b8dcfdd1
Bump phpstan/phpstan from 1.8.6 to 1.8.8 ( #5324 )
...
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan ) from 1.8.6 to 1.8.8.
- [Release notes](https://github.com/phpstan/phpstan/releases )
- [Changelog](https://github.com/phpstan/phpstan/blob/1.9.x/CHANGELOG.md )
- [Commits](https://github.com/phpstan/phpstan/compare/1.8.6...1.8.8 )
---
updated-dependencies:
- dependency-name: phpstan/phpstan
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-07 11:43:39 +01:00
Dylan K. Taylor
c1fbac412e
event: ensure that modifications to items expected to be readonly have no effect
...
this isn't a very glorious fix, but it's the best I have for now.
2022-10-07 11:33:14 +01:00
Dylan K. Taylor
3feaa18f6c
DelegateInventory: use WeakReference and __destruct to clean up inventory listener
...
this is more sane, since it allows the delegate to be reused without unexpected behaviour.
2022-09-30 15:12:37 +01:00
Dylan T
41970feb57
Entity: Fire EntitySpawnEvent/ItemSpawnEvent on the first entity tick, instead of in the constructor ( #5314 )
...
This allows plugins to modify the entity via setters in EntitySpawnEvent without their changes getting overwritten by setter calls directly after the 'new YourEntity' statement.
As well as benefiting plugins, this also clears a path for a BC-breaking change in PM5 (to have the programmer use addEntity() to spawn entities, instead of the constructor doing it, which will improve on a number of data handling aspects).
fixes #4973
This targets next-minor because it has some side effects on plugins that depended on the old behaviour, such as VanillaHopper, so it's not suitable for a patch release.
2022-09-29 22:30:12 +01:00
Dylan K. Taylor
cd4bb91676
Living: alter eye height so the player doesn't drown on the surface of water when swimming
...
fixes #4989
2022-09-29 00:15:07 +01:00
Dylan K. Taylor
2be527060f
Sign: Fixed desync of colour and glowing state when using dye on signs
...
fixes #4932
2022-09-28 23:34:08 +01:00
