Dylan K. Taylor
217d7ab4cf
Merge tag '4.17.2' into stable
2023-03-29 23:50:58 +01:00
Dylan K. Taylor
9e8c0a6bea
Release 4.17.2
2023-03-29 23:47:49 +01:00
Dylan K. Taylor
dc1b5a9285
it might help if we actually included the fix
2023-03-29 23:46:53 +01:00
Dylan K. Taylor
c3a16d9b1f
ItemStackResponseBuilder: fixed durability appearing to reset when moving durables around the inventory
...
closes #5656
2023-03-29 23:31:46 +01:00
Dylan K. Taylor
bed218d1dd
Fixed the first letter of event timing names getting trimmed off when src-namespace-prefix is not used
2023-03-29 23:11:30 +01:00
Dylan K. Taylor
5e1f837a73
...
2023-03-28 22:46:18 +01:00
Dylan K. Taylor
b49a9ae81d
Added timings for calling events
...
this gives a somewhat better overview of events, particularly if many plugins are subscribed to the same costly event (e.g. PlayerMoveEvent).
In addition, it allows us to see the frequency that events are occurring.
2023-03-28 17:26:20 +01:00
Dylan K. Taylor
4c60e82110
Merge remote-tracking branch 'origin/stable' into minor-next
2023-03-27 19:08:18 +01:00
Dylan K. Taylor
beb0713a40
4.18.2 is next
2023-03-27 18:03:17 +01:00
Dylan K. Taylor
cd603e8266
Release 4.18.1
2023-03-27 18:03:16 +01:00
Dylan K. Taylor
af385668c2
InventoryManager: give more detailed information on failure to get info for held item
2023-03-27 17:55:39 +01:00
Dylan K. Taylor
3ee62d8440
InGamePacketHandler: increase max ItemStackRequest actions to 60
...
due to implementation quirks + some unforeseen ways these actions can behave, there can be as many as 53 actions in a single crafting request. This is an edge case, but it has to be catered for.
2023-03-27 15:44:42 +01:00
Dylan K. Taylor
811639f2cd
InGamePacketHandler: relax errors on normal transactions to fix book editing
...
for some reason book edits generate a transaction in addition to BookEditPacket. PM has never used the transaction, and it doesn't pass anyway because CreateItemAction can't be used in survival mode.
However, since the strict validation introduced since ItemStackRequest, this dud transaction now causes the player to get kicked without these changes.
2023-03-27 13:26:26 +01:00
Dylan K. Taylor
58974765a6
InGamePacketHandler: fixed crash when attempting to drop more of an item than is available
2023-03-27 13:26:26 +01:00
dependabot[bot]
eca9fe50b6
Bump build/php from a464454 to 9d8807b ( #5654 )
...
Bumps [build/php](https://github.com/pmmp/php-build-scripts ) from `a464454` to `9d8807b`.
- [Release notes](https://github.com/pmmp/php-build-scripts/releases )
- [Commits](a464454d1e...9d8807be82
2023-03-27 13:03:30 +01:00
Dylan K. Taylor
1959d6dc9b
Fix CS
2023-03-27 12:59:26 +01:00
Dylan K. Taylor
9db7e5f0ca
Be more concise in event handler timing names
2023-03-27 01:19:17 +01:00
Dylan K. Taylor
c1cef19f84
stringifyKeys
2023-03-27 01:17:15 +01:00
Dylan K. Taylor
cebdb95265
Optimise plugin timings report entries
...
this format is already supported by the timings host, so no changes are required to support this.
2023-03-27 01:15:42 +01:00
Dylan K. Taylor
006cdaf6ea
RakLibInterface: log the name of the session which triggered an unhandled exception
...
this makes it easier to identify what sequence of events led up to the crash.
2023-03-26 18:56:24 +01:00
Dylan K. Taylor
acc8ae87fb
4.18.1 is next
2023-03-25 20:51:38 +00:00
Dylan K. Taylor
0e8b28716a
Release 4.18.0
2023-03-25 20:51:34 +00:00
Dylan K. Taylor
7c77233d12
Merge branch 'stable' into minor-next
2023-03-25 20:26:54 +00:00
Dylan K. Taylor
6f02b83a26
Update composer dependencies
2023-03-25 20:26:50 +00:00
Dylan K. Taylor
fbfdf749f2
Merge branch 'stable' into minor-next
2023-03-25 20:25:48 +00:00
Dylan K. Taylor
289c0b08f4
Explicitly state that pocketmine\network\mcpe is an internal package
2023-03-24 14:06:25 +00:00
Dylan K. Taylor
dd37b531ad
CONTRIBUTING.md: document network API policy
2023-03-24 14:02:23 +00:00
Dylan K. Taylor
58d5126ada
InventoryManager: fixed crashes when setting contents or slots of inventories during InventoryCloseEvent (and other similar logic)
2023-03-24 13:31:30 +00:00
Dylan K. Taylor
f978c1e9a0
Merge remote-tracking branch 'origin/stable' into minor-next
2023-03-22 22:45:41 +00:00
Dylan K. Taylor
0b8193aeb3
4.17.2 is next
2023-03-22 22:35:25 +00:00
Dylan K. Taylor
00286e761c
Release 4.17.1
2023-03-22 22:35:24 +00:00
Dylan K. Taylor
db59f71130
attempt to fix ghcr.io docker image push
2023-03-22 22:29:00 +00:00
Dylan K. Taylor
b11457d605
Fixed uncaught exception when retrieving a packet from the pool
2023-03-22 22:24:25 +00:00
Dylan K. Taylor
ea386c42d3
InGamePacketHandler: fixed dropping items from unselected hotbar slots
2023-03-21 14:45:18 +00:00
Dylan K. Taylor
043e81e737
4.18.0-ALPHA3 is next
2023-03-21 00:26:19 +00:00
Dylan K. Taylor
66a4c4c88b
Release 4.18.0-ALPHA2
2023-03-21 00:26:19 +00:00
Dylan K. Taylor
1a9322c00a
ItemStackRequestExecutor: added some missing @throws
2023-03-21 00:23:31 +00:00
Dylan K. Taylor
c8d9477da1
ItemStackRequestExecutor: make non-final, and make some stuff protected
...
this allows for plugin extension, for example to implement anvils.
2023-03-21 00:22:21 +00:00
Dylan K. Taylor
08e8ef275f
remove comment
2023-03-21 00:17:24 +00:00
Dylan K. Taylor
e57fbff28c
ItemStackRequestExecutor: added a sanity check for recipe repetitions
2023-03-21 00:16:03 +00:00
Dylan K. Taylor
f90315c4a2
ItemStackRequestExecutor: harden against invalid item counts
...
these cases should all be impossible, but that's assuming that the core code doesn't start using them for a different purpose in the future.
2023-03-21 00:13:21 +00:00
Dylan K. Taylor
955f7944bb
ItemStackRequestExecutor: fixed another possible crash condition
2023-03-21 00:06:33 +00:00
Dylan K. Taylor
ccd288d7fa
Avoid repeated calls to getItemInHand() in drop item handler
2023-03-21 00:04:29 +00:00
Dylan K. Taylor
097632902a
InGamePacketHandler: fixed crash condition in drop item handler
2023-03-21 00:02:32 +00:00
Dylan K. Taylor
e7771d76f2
Cover buffered inventory sync in timings
2023-03-20 23:29:02 +00:00
Dylan K. Taylor
ecc830a689
InventoryManager: avoid calling TypeConverter::getInstance() in a loop
2023-03-20 23:24:52 +00:00
Dylan K. Taylor
ee72e80fbb
ItemStackResponseBuilder: removed incorrect code
...
the client expects that all itemstacks must be acked by ItemStackResponse, regardless of whether the server changed them to some other item.
We'll overwrite the item to the correct thing at the end of the tick anyway.
2023-03-20 23:21:24 +00:00
Dylan K. Taylor
63310cf764
Do not cache ItemStacks for every item
...
this is very memory inefficient, and only provides a performance advantage in cold code anyway.
2023-03-20 23:18:43 +00:00
Dylan K. Taylor
1992d3b6db
InventoryManager: avoid useless work in trackItemStack()
...
this attempts to accommodate slots being set to themselves, which is a rare enough occurrence (only plugins will cause it) that it doesn't make sense to penalize every inventory update this way.
attempting to avoid changing the itemstackID in this way is detrimental to performance, and it doesn't actually matter if we set a new itemstackID anyway.
2023-03-20 23:08:17 +00:00
Dylan K. Taylor
035a0a4e9d
InventoryManager: specialize trackItemStack() to avoid useless lookups
2023-03-20 22:57:58 +00:00
