Dylan K. Taylor
3dae873731
Release 3.25.2
2021-11-02 17:21:44 +00:00
Dylan K. Taylor
5257755dc5
shut
2021-11-01 21:15:58 +00:00
Dylan K. Taylor
3214da8642
pthreads 4.0.0
2021-11-01 21:01:59 +00:00
Dylan K. Taylor
794142fe49
Merge l7/l8/l9 baselines into actual-problems
...
it doesn't serve any practical purpose to keep these separated, particularly since it's getting so difficult to figure out which errors are coming from which levels (since we always use 9, it doesn't really make any difference).
2021-11-01 17:27:31 +00:00
Dylan K. Taylor
ff27c5f7db
PHPStan 1.0.0
2021-11-01 17:24:20 +00:00
Dylan K. Taylor
4d4362801f
AvailableCommandsPacket: remove dead code
2021-11-01 17:01:26 +00:00
Dylan K. Taylor
0babe0a1ab
LevelDB: remove unused private method
2021-11-01 16:55:05 +00:00
Dylan K. Taylor
d696ebcda3
Level: do not use static:: to access levelIdCounter
...
the field is private.
2021-11-01 16:52:27 +00:00
Dylan K. Taylor
9f5c16bc46
Projectile: use closure instead of do/while for reading id/data of block
...
not ideal, but whatever I guess... this at least provides scope isolation
2021-11-01 15:56:28 +00:00
Dylan K. Taylor
8865bb73ba
BanEntry: remove useless do/while
2021-11-01 15:52:55 +00:00
Dylan K. Taylor
2dee1dbc28
Remove ridiculous code in ResourcePackManager
2021-11-01 15:41:21 +00:00
Dylan K. Taylor
0f0b6f0efa
Utils: eliminate usages of backtick operator
2021-11-01 15:25:56 +00:00
Dylan K. Taylor
d5f13d8be2
Timezone: make PHPStan 1.0 happy
2021-11-01 15:24:16 +00:00
Dylan K. Taylor
27ae959e89
Terminal: backport shell_exec() code from PM4 to make PHPStan 1.0 happy
2021-11-01 15:23:36 +00:00
Dylan K. Taylor
f8f39687e2
Achievement: declare proper type for $list static property
2021-11-01 15:22:33 +00:00
Dylan K. Taylor
94737934de
PlayerDeathEvent: fixed LSP violation reported by PHPStan 1.0
2021-11-01 14:17:54 +00:00
Dylan K. Taylor
debb469de1
Updated PHPUnit dependency junk
2021-11-01 13:54:04 +00:00
Dylan K. Taylor
73dc0598e4
CrashDump: remove derp space
2021-10-30 23:22:37 +01:00
Dylan K. Taylor
141fbde660
Player: fixed getting re-banned on rejoin after unban from hardcore death
...
closes #2175
2021-10-30 16:58:03 +01:00
Dylan K. Taylor
69952ae2af
Human: limit lifetime total XP range to INT32_MAX
...
closes #4484
2021-10-30 16:05:10 +01:00
Dylan K. Taylor
71f2a34616
Entity: spawnTo() must silently swallow errors
...
Player->showPlayer() assumes that spawnTo() will take care of all the checks necessary to ensure we don't actually spawn a player to someone it shouldn't be able to see. In PM3, there's nothing we can do about that.
This could be a problem if anything decides to override spawnTo() to do additional stuff and assumes that the function will always succeed; however, there's not much reason to do that (plugins sending packets should override sendSpawnPacket() instead).
2021-10-30 15:38:27 +01:00
Dylan K. Taylor
d17cd65803
3.25.2 is next
2021-10-29 22:23:28 +01:00
Dylan K. Taylor
a8d5e8c5f6
Release 3.25.1
2021-10-29 22:23:22 +01:00
Dylan K. Taylor
089e62b44e
Entity::spawnTo(): verify that the target player belongs to the same world as the entity
...
this should never be hit in the PM case, but it's an InvalidArgument rather than AssumptionFailedError because plugins can and do call this with bad things.
2021-10-29 18:54:00 +01:00
Dylan K. Taylor
f1cc168d26
phpstan: exclude a couple of files from analysis temporarily
...
close #4472
2021-10-29 00:23:13 +01:00
Dylan K. Taylor
f6e53f826b
Fixed Anvil/McRegion chunks getting autosaved on first time, even when unchanged
...
setGenerated/setPopulated and friends set hasChanged = true, which causes the world to autosave them the first time around, even though they weren't modified.
2021-10-25 19:52:44 +01:00
Dylan K. Taylor
986b4e0651
Enforce single-line PhpDoc for properties where possible
2021-10-21 20:32:37 +01:00
Dylan K. Taylor
dc07ac33d3
protocol: fixed missing field of CraftRecipeAuto
2021-10-20 19:47:32 +01:00
Dylan K. Taylor
9c5cec77b1
3.25.1 is next
2021-10-19 18:27:30 +01:00
Dylan K. Taylor
f48b703533
Release 3.25.0
2021-10-19 18:27:26 +01:00
Dylan K. Taylor
70636f6eb4
Protocol changes for 1.17.40
2021-10-19 18:00:34 +01:00
Dylan K. Taylor
ead9aae23c
Updated build/php submodule to pmmp/php-build-scripts@fab0cbeaae
2021-10-12 23:10:06 +01:00
Dylan K. Taylor
13068ba3a7
3.24.1 is next
2021-10-09 20:20:41 +01:00
Dylan K. Taylor
b54854529f
Release 3.24.0
2021-10-09 20:20:37 +01:00
Dylan K. Taylor
974d08efd6
Bump PHP minimum requirement to 8.0
...
PHPStan failed on 7.4 after updating to 0.12.99, and I figured it was less hassle to just do this than fix the build. In any case, we stopped shipping 7.4 months ago, and warned at 3.22 release that 7.4 support would soon be dropped.
2021-10-09 20:09:42 +01:00
Dylan K. Taylor
289553fa46
CS again
2021-10-09 19:50:07 +01:00
Dylan K. Taylor
e38866c4ba
phpstan 0.12.99
2021-10-09 19:33:43 +01:00
Dylan K. Taylor
58a95f8836
Updated transitive composer dependencies
2021-10-09 19:18:32 +01:00
Dylan K. Taylor
e032b8fe20
Server: fixed stats reporting checking a nonexistent pocketmine.yml property
...
this was originally worked around by 47f7af6739537af7a4d356a08aa00eb7feefd1ed. However, that commit was just duct tape, and I never bothered to investigate if the config was being checked somewhere else.
Here's to a years-old bug finally getting fixed.
2021-10-06 22:23:41 +01:00
Dylan K. Taylor
a27c14c00c
phpstan: exclude build/php from analysis
...
in case I built PHP in there, I don't want the install_data getting analysed and screwing up the analysis.
2021-10-05 00:14:44 +00:00
dependabot[bot]
003c002208
Bump phpunit/phpunit from 9.5.9 to 9.5.10 ( #4482 )
...
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit ) from 9.5.9 to 9.5.10.
- [Release notes](https://github.com/sebastianbergmann/phpunit/releases )
- [Changelog](https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-9.5.md )
- [Commits](https://github.com/sebastianbergmann/phpunit/compare/9.5.9...9.5.10 )
---
updated-dependencies:
- dependency-name: phpunit/phpunit
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-28 21:04:11 +01:00
Jason
d417b1e2f5
Projectile: fixed move() not using the given parameters ( #4481 )
...
it was using this->motion instead, which usually would be the same, but maybe not.
2021-09-28 21:03:03 +01:00
Dylan K. Taylor
65e468e3c2
Updated build/php submodule to pmmp/php-build-scripts@6aac46e500
2021-09-28 21:00:13 +01:00
Dylan K. Taylor
a11cf8c296
Update PHP versions used by GitHub Actions
2021-09-28 20:52:40 +01:00
Dylan K. Taylor
d455188d03
3.23.2 is next
2021-09-22 01:00:50 +01:00
Dylan K. Taylor
14fba36636
Release 3.23.1
2021-09-22 01:00:50 +01:00
Dylan K. Taylor
43ac3fbf3e
actions: use newer PHP versions
2021-09-22 00:51:06 +01:00
Dylan K. Taylor
352162a6e6
Fixed PHP 7.4 build
2021-09-22 00:50:00 +01:00
Dylan K. Taylor
b3601c9390
Regenerate PHPStan baselines
2021-09-22 00:45:07 +01:00
Dylan K. Taylor
817fec9e3d
EducationSettingsPacket: safeguard against purity issue reported by PHPStan
...
while annoying, PHPStan is right to complain about this, because putBool() is impure, meaning that these fields could have been mutated in the call.
We know they didn't, but PHPStan doesn't, and we can't mark the method as pure because .. well .. it isn't.
2021-09-22 00:44:52 +01:00
