Dylan K. Taylor
6111ce7df1
Human: don't hardcode max food
2018-05-19 16:48:21 +01:00
Dylan K. Taylor
1f73c08762
Human: fix possible bug with food ticking
...
it updates it but doesn't take note of the updated value, which could cause the code below to be erroneously triggered.
2018-05-19 16:47:04 +01:00
Dylan K. Taylor
2900167ffa
Human: removed redundant isSprinting() check from doFoodTick()
...
this is checked in setSprinting() anyway.
2018-05-19 16:33:13 +01:00
Dylan K. Taylor
11cc9f19ad
Human: replace hardcoded difficulty values with constants in doFoodTick()
2018-05-19 16:32:30 +01:00
Dylan K. Taylor
807af2e6fb
Human: change doFoodTick() visibility to protected
2018-05-19 16:30:41 +01:00
Dylan K. Taylor
f2511983cf
Level: use increment operation for updating time
2018-05-19 16:05:08 +01:00
Dylan K. Taylor
bac649137b
Level: fixed doc comment for getSafeSpawn()
2018-05-19 14:02:54 +01:00
Dylan K. Taylor
71224f51d5
Level: cleaned up some nonsensical code in getSafeSpawn()
...
it's impossible for this function to return false because $spawn is guaranteed to be a Vector3 when it's checked in instanceof.
2018-05-19 13:18:20 +01:00
Dylan K. Taylor
6c3fc4af46
Level: switch order of addEntity() and removeEntity()
...
now it's consistent with addTile() and removeTile()
2018-05-19 13:14:11 +01:00
Dylan K. Taylor
75d13be38e
EnderChestInventory: remove unused import
2018-05-19 11:37:22 +01:00
Dylan K. Taylor
9bc860f7a8
LevelDB: fixup extra-data handling, don't delete it - just don't read it
...
we'll need this once multi-layer block storages are implemented.
2018-05-19 11:35:54 +01:00
Dylan K. Taylor
66963fbf9a
Nuke block extradata
...
this has been superseded by multi-layer blockstorages in 1.2.14+
2018-05-19 11:03:28 +01:00
Dylan K. Taylor
172c6420c1
Server: add type documentation for fields
...
found a few bugs in the process too
2018-05-19 10:55:34 +01:00
Dylan K. Taylor
e7fc9227bc
Server: fixed bug in alwaysTickPlayers config
2018-05-19 10:53:31 +01:00
Dylan K. Taylor
13cd0cdcfd
Server: cast result of getProperty() for networkCompressionAsync
2018-05-19 10:52:09 +01:00
Dylan K. Taylor
0bb5e88b5c
Hinting up Entity API to PHP 7.2 standards
2018-05-19 10:46:47 +01:00
Dylan K. Taylor
389990e0a8
Entity: remove useless functions
...
these may be TODOs but I have no idea why or where they need to be implemented, so until they do they are useless clutter.
2018-05-18 20:09:55 +01:00
Dylan K. Taylor
067aad9546
PocketMine.php: Remove unused \pocketmine\ANSI constant
...
Terminal::hasFormattingCodes() should be used instead (this is also portable across threads even if constants aren't inherited by child threads, provided that the child thread has an autoloader available.
2018-05-18 18:51:18 +01:00
Dylan K. Taylor
b1a7606e82
PocketMine.php: Take dependency versions for granted
...
Since this is managed by Composer now, it's expected that users should install dependencies appropriately when running from source code. We have a few more dependencies than just RakLib and SPL which are version-critical which are not checked here, and I don't have the taste for adding more version checks here.
A better way would be to automatically detect outdated Composer autoloader and warn that dependencies might need updating, but I'm not sure how to do that off the hop. Users should prefer using prebuilt phars anyway - only developers and/or people who know what they are doing should be running the server from source code.
2018-05-18 18:47:12 +01:00
Dylan K. Taylor
febba6e3a6
Tile: call parent constructor instead of duping code
2018-05-18 16:49:14 +01:00
Dylan K. Taylor
d8dc89e7c8
EnderChestInventory: Removed unnecessary owner parameter
2018-05-18 16:46:48 +01:00
Dylan K. Taylor
b75413e3c4
CommandReader: Use stream_isatty() instead of posix_isatty() (new in 7.2)
2018-05-18 16:46:48 +01:00
Dylan K. Taylor
f08537a1e0
BlockMetadataStore: fix case of import
...
found by PHPStan static analysis tool
2018-05-18 16:46:48 +01:00
Dylan K. Taylor
6643fa5f09
README: it's not Pocket Edition anymore
2018-05-18 14:54:50 +01:00
Dylan K. Taylor
210e108574
Level: add a null coalesce
...
meant to add this before push but wasn't thinking clearly...
2018-05-18 11:28:52 +01:00
Dylan K. Taylor
813437e3ee
Level: Avoid unnecessary use of getChunk()
...
this is completely pointless.
2018-05-18 11:27:53 +01:00
Dylan K. Taylor
24295ce02f
Level: Avoid creating useless throwaway objects in sensitive functions
2018-05-18 11:05:41 +01:00
Dylan K. Taylor
29fd26627e
Level: Change isInWorld signature to use ints instead of floats
...
this is only used in one place, where it's being given floats, and it's 10% faster to use int for this because it won't convert it.
It is also 25% faster to remove typehints and 60% faster to inline it. We really need a proper PHP preprocessor for inlining.
2018-05-18 11:01:13 +01:00
Dylan K. Taylor
22b91aaa24
SubChunkIteratorManager: Added method invalidate() to allow destroying stale chunk refs conveniently
...
this could be necessary for reusable long-life iterators when chunks get replaced.
2018-05-18 09:52:27 +01:00
Dylan K. Taylor
f757ba1851
Merge branch 'release/alpha12'
2018-05-17 19:27:26 -04:00
Dylan K. Taylor
8c1c8f34cc
Player: confine command data resending on permission recalculate to post-spawn only
...
this fixes crashes when PurePerms causes this to be recalculated on player login - the client doesn't like receiving this before StartGame and crashes.
Confining this to post-spawn should not cause any issues since any permission recalculation in login events will be reflected immediately afterwards when the initial command data is sent anyway.
This same bug popped up at 1.1... I don't know why it wasn't fixed properly back then.
2018-05-17 19:26:42 -04:00
Dylan K. Taylor
c285295037
Merge branch 'release/alpha12'
2018-05-17 18:40:24 +01:00
Dylan K. Taylor
2034caf71c
Merge branch 'mcpe-1.4.0-alpha12' into release/alpha12
2018-05-17 18:38:58 +01:00
Dylan K. Taylor
89ccac7a8c
updated blockIDs table
2018-05-17 16:17:26 +01:00
Dylan K. Taylor
f6e71d8296
Protocol changes for 1.4.0 release
...
this is nearly the same as 1.5.0.0, except the skin packet premium boolean has been dropped.
This isn't production ready yet because the blockID table needs updating (waiting on MrARM to fix his script for that).
2018-05-17 10:36:16 +01:00
Dylan K. Taylor
b333a0e24c
PlayStatusPacket: add new constant
2018-05-17 10:33:18 +01:00
Dylan K. Taylor
8312ad709e
InventoryTransaction: Removed creationTime
...
this is no longer necessary because transactions now always arrive in a single packet.
2018-05-16 12:14:29 +01:00
Dylan K. Taylor
63fc04b3dd
thanks for being useless PhpStorm
2018-05-13 11:56:32 +01:00
Dylan K. Taylor
34b8557094
Moved parseDocComment from PluginManager to Utils
2018-05-13 11:24:04 +01:00
Dylan K. Taylor
edaef588ab
CommandReader: remove unnecessary setClassLoader() call
...
this is already handled in start() anyway.
2018-05-12 12:47:28 +01:00
Dylan K. Taylor
889222e9c5
MainLogger: Use PTHREADS_INHERIT_NONE
...
this thread doesn't need to inherit anything because its sole purpose is to write log messages to file.
2018-05-12 12:39:13 +01:00
Dylan K. Taylor
8239c67b1a
Enchantment: split up primary and secondary flags
...
closes #1911
2018-05-12 11:20:27 +01:00
Dylan K. Taylor
ed65e91a3c
Tree: avoid astonishing behaviour with dark-oak and acacia saplings
...
ref #1973 , these should simply not grow at all since they are not implemented yet.
2018-05-12 10:03:20 +01:00
Dylan K. Taylor
619390c5b7
Sapling: Account for light level when trying to grow on random ticks
2018-05-11 09:53:03 +01:00
Dylan K. Taylor
7e70569ba2
Player: Send all open inventories instead of hardcoded selection
...
Players have a few associated inventories which might need sending nowadays, such as main, armour, offhand (not implemented yet), cursor, crafting (if it ever worked). Under these conditions we should be sending all open windows.
2018-05-11 09:28:59 +01:00
Dylan K. Taylor
083ac8a770
Clean up Tool garbage leftovers
...
these were intended to be removed long ago, but other things came up and durability handling still depended on them.
2018-05-11 09:23:51 +01:00
Dylan K. Taylor
b21572774a
Tool: cleanup durability handling, closes #379
...
long overdue... this isn't quite as extensible as the original api3/blocks system was, but this is primarily intended to replace Item->useOn(). If plugins want to use it it can be extended later on.
2018-05-10 19:48:51 +01:00
Dylan K. Taylor
b8523cb304
Merge branch 'remove-weak-position'
2018-05-10 13:53:07 +01:00
Dylan K. Taylor
6ceb9af749
.-.
2018-05-10 12:51:39 +01:00
Dylan K. Taylor
bcd197d7bb
AsyncWorker: fixed __construct() signature
2018-05-10 12:50:09 +01:00
