5115387feb
fix CS (again)
2021-10-07 20:43:55 +01:00
dd0aaf59b5
MainLogger: Log exceptions as a single block message
2021-10-07 20:40:20 +01:00
a555f21b18
MainLogger: write messages before calling logger attachments
2021-10-07 20:32:02 +01:00
1be9b2f037
Config: drop packing of arrays
...
we don't handle arrays on decode, so there's no reason to support them on encode either.
2021-10-07 20:30:56 +01:00
32fd9879e5
fix CS
2021-10-07 20:16:54 +01:00
dc2e8e7e8f
ServerConfigGroup: do not assume that values are always bool|string
2021-10-07 20:02:21 +01:00
847e24fc41
4.0.0-BETA5 is next
2021-10-06 23:49:30 +01:00
9e6d740570
Release 4.0.0-BETA4
2021-10-06 23:49:13 +01:00
8e3772ceef
Block: fixed incorrect behaviour of isSameState() for multi-ID blocks
...
fixes #4492
2021-10-06 23:16:03 +01:00
e032b8fe20
Server: fixed stats reporting checking a nonexistent pocketmine.yml property
...
this was originally worked around by 47f7af6739
2021-10-06 22:23:41 +01:00
90800a4124
Config: Try to coerce types, similar to YAML
2021-10-06 21:09:23 +01:00
10b3596eef
PluginDescription: use typed properties
2021-10-06 02:00:55 +01:00
258c38f9cd
PluginDescription: loosen invalid permission message (it might be wrong type as well as not existing)
2021-10-06 01:45:40 +01:00
d07517fe8b
Use an object to represent command entries in plugin manifest
2021-10-06 01:42:03 +01:00
31a176286d
Do not register plugin commands without valid permissions
...
this could lead to harmful results, e.g. if a developer typo'd while writing the plugin.yml, an admin-only command could become accessible to everyone, since commands are by default accessible by everyone.
2021-10-06 01:18:14 +01:00
1fafce6d6f
PluginBase: remove special true/false handling for command permissions
...
these aren't accepted as permission names anymore, and they never worked properly anyway.
2021-10-06 01:12:02 +01:00
5061bbbc25
fuck you git x2
2021-10-06 01:01:20 +01:00
a101d1cdf9
Drop pocketmine.plugin.fileError in favour of pocketmine.plugin.loadError
...
fileError was unnecessarily noisy, putting the directory path on the console twice. This conveys just as much information but with less wasted space.
2021-10-05 23:31:00 +01:00
e25c03eec1
Gracefully handle errors loading plugin manifest
...
this isn't perfect, but it covers the common cases.
Now, the server won't spam crashdumps just because some plugin declared nested permissions.
2021-10-05 20:28:43 +01:00
7245d15abe
PermissionParser: Throw more specific exceptions
2021-10-05 19:57:26 +01:00
13178a47a5
fuck you git
2021-10-05 19:11:10 +01:00
817ab88c70
Properly handle errors decoding network item NBT
...
since the NBT is now decoded immediately now, any incorrect NBT will cause exceptions to be thrown that we weren't handling, causing server crashes.
2021-10-05 19:10:55 +01:00
fef8297907
GiveCommand: don't crash on bogus item NBT
2021-10-05 19:09:46 +01:00
dbeaf27cb7
Document that Item::setNamedTag() may cause NbtException to be thrown
...
if the NBT is bogus for some reason
in PM3, these kinds of bugs wouldn't show up until/unless the item NBT was actually used, but on PM4, we decode it ahead of time, so the errors always show up immediately.
2021-10-05 19:09:22 +01:00
2db79cf58d
Fix build
2021-10-05 18:41:47 +01:00
7d06b76aaf
PluginManager: account for possible invalid format of API version
...
we're seeing a lot of crashes because of this.
2021-10-05 18:36:00 +01:00
0ad663ff50
Merge remote-tracking branch 'origin/stable'
2021-10-05 01:17:59 +01:00
5b26abcb0e
NetworkSession: fixed code copy pasta
...
these are not, in fact, equivalent.
2021-10-05 01:02:15 +01:00
f2d6059613
NetworkSession: Sync world spawn on world change
2021-10-04 22:51:31 +01:00
bb6ea8cbdc
Do not call PlayerLoginEvent during the Player constructor
...
this closes a lot of loopholes in the login sequence that plugins were using to cause crashes.
2021-10-04 22:36:50 +01:00
356a49d225
NetworkSession: account for possibility of syncGameMode() being called before the player is ready to receive it
...
close #4323
2021-10-04 22:13:42 +01:00
fb570970a8
Localize gamemode command errors
2021-10-02 21:22:54 +01:00
30e10c38b6
Localize /help
2021-10-02 20:59:36 +01:00
05dc675d5b
Replace commands.generic.notFound with a custom PM version
...
this also fixes #4379 .
2021-10-02 20:42:59 +01:00
d63b9d1648
WorldManager: localize strings for world loading, generation and conversion
2021-10-02 20:33:32 +01:00
0108888450
Process: silence taskkill complaining that it can't commit suicide
...
since taskkill is a subprocess of the server process, it gets included in taskkill's own attempted killing spree, but taskkill (wisely) won't kill itself.
2021-10-02 17:23:26 +01:00
dd0c2fed82
Process: add subprocess parameter to kill()
...
fix CommandReader subprocess lingering on a crash and fucking up the console
2021-10-02 16:56:24 +01:00
54174eefa0
Make sure COMPOSER_AUTOLOADER_PATH is always declared
...
Sacrifice dynamic composer autoloader path to do this, because we don't
need it anyway - it was a misconceived feature from the days when I used
the same workspace for PM3 and PM4 both.
2021-10-02 15:27:17 +01:00
f5266ec816
World: remove dead code leftover from 34f01a3ce3
...
fixes #4486
2021-10-02 12:33:46 +01:00
f26f063164
UPnP: catch InternetException when attempting portforward
...
we might fail to get the internal IP for some reason, which shouldn't crash the server.
2021-10-02 00:52:14 +01:00
81d5598e96
UPnP: Fixed server crash on failure to find UPnP device
...
https://crash.pmmp.io/view/5241010
2021-10-01 23:27:58 +01:00
c7e9138994
PopulationTask: reduce code duplication
2021-10-01 23:18:56 +01:00
88f799da2c
more AssumptionFailedError hacks for PHPStan :(
...
the code in this class is really horrible
2021-10-01 23:05:48 +01:00
8de30e8162
FastChunkSerializer no longer serializes light by default
...
the core doesn't use this anywhere.
serializeWithoutLight() has been renamed to serializeTerrain() to more accurately describe what it does.
2021-10-01 22:57:22 +01:00
e6f6a036ef
LightPopulationTask: do not copy existing light arrays
...
this task wipes out the light arrays and recalculates them from scratch, so it's pointless to copy any preexisting light arrays anyway.
2021-10-01 22:34:11 +01:00
5b818827db
Chunk: stop exposing SplFixedArray<SubChunk> to the API
...
this fixes a large number of PHPStan errors, and also brings us a step closer to negative-build-height readiness.
2021-10-01 22:17:28 +01:00
42bf9578ce
Remove unused constants
2021-10-01 22:05:03 +01:00
349f37b15f
resource packs: manifest may also contain a list of dependencies
...
... which we should be verifying the presence of, as the server.
2021-10-01 21:14:28 +01:00
afa3349c04
Acknowledge the presence of capabilities field in resource pack manifest
...
closes #4485
2021-10-01 21:09:53 +01:00
d6dfcb11e8
BlockStateDeserializerR13: fixed some formatting issues
2021-09-30 17:32:06 +01:00
