mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-04-21 00:07:30 +00:00
Code Issues Projects Releases Wiki Activity

UPnP: catch InternetException when attempting portforward

Browse Source 
we might fail to get the internal IP for some reason, which shouldn't crash the server.
This commit is contained in:
Dylan K. Taylor 2021-10-02 00:52:14 +01:00
parent 81d5598e96
commit f26f063164
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/network/upnp/UPnPNetworkInterface.php
View File

@ -25,6 +25,7 @@ namespace pocketmine\network\upnp;
use pocketmine\network\NetworkInterface;
use pocketmine\utils\Internet;
use pocketmine\utils\InternetException;
final class UPnPNetworkInterface implements NetworkInterface{
@ -55,7 +56,7 @@ final class UPnPNetworkInterface implements NetworkInterface{
$this->serviceURL = UPnP::getServiceUrl();
UPnP::portForward($this->serviceURL, Internet::getInternalIP(), $this->port, $this->port);
$this->logger->info("Forwarded $this->ip:$this->port to external port $this->port");
}catch(UPnPException $e){
}catch(UPnPException | InternetException $e){
$this->logger->error("UPnP portforward failed: " . $e->getMessage());
}
}