Dylan K. Taylor
f624871b3f
strip extra blank lines (php-cs-fixer)
2020-01-22 14:50:29 +00:00
Dylan K. Taylor
9f44adf04a
pass 2, manual removal of incorrect non-nullable @param for nullable native types
2020-01-21 15:44:34 +00:00
Dylan K. Taylor
c4793241f5
Mass removal of useless @param/@return PHPDoc annotations, pass 1
2020-01-21 15:10:18 +00:00
Dylan K. Taylor
2c11742f9e
Player: populate missing type information
2020-01-19 19:16:38 +00:00
Dylan K. Taylor
1eedac87b2
added missing @var property types (reported by phpstan)
2020-01-09 14:13:54 +00:00
Dylan K. Taylor
f355044626
resources: do not remove client-side resource packs when forcing resources
...
I wanted to make this into a dedicated option, but it had some side effects (see 4794ba236a551bd839bbb8565474c19f93d97c30).
I'll settle for just disabling this useless behaviour, since we have other ways to force vanilla resources anyway; setting this flag to always-false has no user-facing effects anyway.
2020-01-04 16:14:08 +00:00
Dylan K. Taylor
4794ba236a
Revert "resource packs: added new option remove_client_resources, fixed client packs being removed when forcing resource pack download"
...
This reverts commit 06ec8b83978fcc52a7964d678a97c73b50a97aa8.
unfortunately, this had some unanticipated side effects, thanks to
idiotic behaviour in the client ... when having optional downloads but
trying to force resources, the client chokes because it thinks the
server is forcing it to apply a pack that it doesn't have. Since
there's no way to detect when this problem occurs in the protocol, the
only option is to revert this.
2020-01-04 16:04:07 +00:00
Dylan K. Taylor
06ec8b8397
resource packs: added new option remove_client_resources, fixed client packs being removed when forcing resource pack download
2020-01-04 13:16:47 +00:00
Dylan K. Taylor
494660102e
Replace empty() usages with count()
2019-12-18 11:23:24 +00:00
Dylan K. Taylor
26230c1f9b
Player: don't report never-played for a disconnected player
...
this should catch fire like everything else does.
2019-12-12 12:17:52 +00:00
Dylan K. Taylor
1171bae691
login: read the correct key SkinAnimationData
2019-12-11 22:40:05 +00:00
Dylan K. Taylor
494f8e8251
login: fixed missing base64_decode() for animation images
2019-12-11 22:39:40 +00:00
Dylan K. Taylor
394c999710
Merge branch 'drew-1.13' into stable
2019-12-06 20:38:49 +00:00
Dylan K. Taylor
16817ff301
Player: remove superfluous conditions for RESPAWN action handling
...
spawned is always true here because of the condition at the top of the function.
isOnline() is always true here because the handler won't even be called if it isn't.
2019-12-05 14:52:12 +00:00
Dylan K. Taylor
18863b1098
Player: remove superfluous check from processMovement()
...
if we reached this branch, revert is always false because it is not modified between this branch and the parent one.
detected by phpstan level 4
2019-12-05 14:47:15 +00:00
Stephen
fa56290bb4
Reflect StartGamePacket changes in Player
2019-11-21 15:05:09 -05:00
Stephen
c8d0cb315b
Move persona skin hack to legacyskinadapter
2019-11-20 21:52:49 -05:00
Stephen
be9c413a9e
Added network components for skins, to collect instead of throw out data
2019-11-20 21:43:41 -05:00
Dylan T
ba5a5981a0
Update Player.php
2019-11-12 08:19:05 +00:00
Stephen
a81d8dd6d5
Return false in unexpected condition
2019-11-11 16:25:53 -05:00
Stephen
7b152def7d
Move SkinAnimation and changed SerializedImage to SkinImage
...
Also change putImage and getImage to getSkinImage and putSkinImage
2019-11-11 15:23:48 -05:00
Stephen
e2fc7cdf88
Friendly BC skins (persona not supported)
2019-11-10 21:04:38 -05:00
Dylan K. Taylor
29cc9283f8
reverse unnecessary formatting changes
2019-11-08 11:29:00 +00:00
Dylan K. Taylor
e60962c31f
reverse BC-breaking change to Player->changeSkin()
...
this change would cause LSP violations for subclasses
2019-11-08 11:22:55 +00:00
Dylan K. Taylor
f6b5301e17
Player: remove unused import
2019-11-08 11:10:20 +00:00
Dylan K. Taylor
73b923e3a1
cleanup eating clusterfuck
2019-11-08 11:08:22 +00:00
Dylan K. Taylor
d2e4eb40b3
CompletedUsingItemPacket is superfluous
2019-11-08 08:29:25 +00:00
Stephen
bfb1ad1327
Removed PlayerUIInventory and BaseUIInventory
2019-11-07 23:17:01 -05:00
Stephen
eef979db4c
Switch to isUsingItem()
...
I don't plan on using this, as you informed me on discord that I didn't need the extra step, and it's a BC break anyway
2019-11-07 19:49:04 -05:00
Stephen
40b4166a6e
created method sendCompletedUsingItemPacket for less duplication
2019-11-06 22:30:05 -05:00
Stephen
3511ac010d
Fixed crafting
2019-11-06 20:42:53 -05:00
Stephen
07f19dd4a1
Fixed respawning
2019-11-05 22:33:12 -05:00
Stephen
17a17c31f3
Fixed items, but I'm not so sure how well this'll work out, it'll need improved in the future
2019-11-05 22:25:11 -05:00
Stephen
8b912c1363
Removed some useless casts
2019-11-05 20:59:48 -05:00
Stephen
080209c469
Fixed persona skins being messed up on join
2019-11-05 20:35:33 -05:00
Drew
cd2b60a860
Initial update to 1.13
2019-10-30 21:36:08 -04:00
Dylan K. Taylor
562b47a1e5
Player: guard against repeated resource pack sequence
...
this can happen because of the client being super broken in 1.12
close #3036
2019-10-03 11:20:44 +01:00
Dylan K. Taylor
26faf4a952
Player: fixed sendTranslation() passing parent parameters to translate parameters
2019-07-19 18:15:35 +01:00
Dylan K. Taylor
1767cbe80d
Player: Lower moved-too-fast warning and illegal-move warning to debug
...
many users have complained that this spams their consoles and they can't turn it off.
2019-07-16 13:51:38 +01:00
Dylan K. Taylor
6839712394
added new PlayerActionPacket constant, silence debug noise every time a player clicks a block
2019-07-14 17:30:37 +01:00
Dylan K. Taylor
a883c35fd0
clean up yesterday's mess
2019-07-13 18:15:14 +01:00
Dylan K. Taylor
c58a1bf9b7
Protocol changes for 1.12.0.28
2019-07-12 19:00:15 +01:00
Dylan K. Taylor
55cccff850
Player: fixed documentation of isValidUserName()
...
[ci skip]
2019-07-07 23:50:59 +01:00
Dylan K. Taylor
03e70e68f4
Player: fixed documentation of getDisplayName()
...
[ci skip]
2019-07-07 23:49:11 +01:00
Dylan K. Taylor
f782a478c4
Player: clarify resetTitles() documentation
2019-05-08 17:03:40 +01:00
Dylan K. Taylor
c06b4830d1
Player: don't spawn entities on out-of-sync chunks on join, closes #2911
2019-05-08 15:36:54 +01:00
Dylan K. Taylor
f6a0f4aa82
Player: fixed immobile interference on PlayerJoinEvent
...
closes #2894
this should use a cleaner hack that doesn't affect plugins at all, but that's too much work for this one bug fix.
2019-05-02 16:20:28 +01:00
Dylan K. Taylor
de09c8c082
Player: fix crash handling resource pack requests
2019-05-02 16:17:39 +01:00
Dylan K. Taylor
39360f127a
Player: Don't use iusername in cases where it's useless
...
these calls all do strtolower() anyway, so having iusername here just makes it confusing.
2019-04-26 12:07:47 +01:00
Dylan K. Taylor
25890e76e2
Player: replace redundant usage of Server->broadcast()
2019-04-26 12:04:56 +01:00