Dylan K. Taylor
ffb3af3e0d
fix CS
2022-09-02 00:59:58 +01:00
Dylan K. Taylor
b3f03d7ae6
Poll console on the main thread, instead of using a separate thread
...
There's no need to use an extra thread for this, since there's no concern of a socket getting stuck in a blocking read.
This is one less thing that can go wrong because of pthreads.
2022-09-02 00:58:49 +01:00
Dylan K. Taylor
2585160ca2
ConsoleReaderChildProcess: Commit suicide if the parent process dies and doesn't clean up
...
This happens if the main server process was forcibly killed, e.g. by the kill command on Linux, or taskkill/TaskManager on Windows.
Previously, the process would stick around as a zombie, which messed up terminals in some cases (e.g. git bash), though even having zombies with no side effects is bad enough.
2022-09-02 00:25:31 +01:00
Dylan K. Taylor
14d3e6c7d5
Allow disabling the console reader via pocketmine.yml
...
Useful to save resources on headless servers where the console is never used (e.g. hosted server, Docker, etc.)
2022-09-01 23:43:54 +01:00
Dylan T
65ec318c30
PluginManager: Ensure dependents are disabled before dependencies in disablePlugins() ( #5227 )
...
this could later be expanded to disablePlugin() to make this disable order mandatory, to provide certainty for plugin devs.
Alternative solutions to this include disabling plugins in the opposite order that they were enabled in, but this doesn't allow for random plugin disables. This way seemed to make sense.
2022-08-31 18:43:30 +01:00
ShockedPlot7560
a25cb3741a
Limit valid supporting blocks of dead bush ( #5055 )
2022-08-31 02:18:18 +01:00
Dylan K. Taylor
456439566b
Language: treat empty translation files the same as missing ones
2022-08-31 01:53:15 +01:00
Dylan K. Taylor
5b89833d5c
Merge branch 'stable' into next-minor
2022-08-27 17:27:15 +01:00
Dylan K. Taylor
fb25e05416
InventoryManager: fixed current window getting removed in race conditions with close window ACK
...
this could be observed by pressing E and immediately clicking a chest, which, if timed correctly, would lead to the chest lid closing, but the inventory being opened anyway.
2022-08-27 17:26:43 +01:00
Dylan K. Taylor
78b5be8dd0
4.8.2 is next
2022-08-26 19:16:39 +01:00
Dylan K. Taylor
0a92e91a30
Release 4.8.1
2022-08-26 19:16:39 +01:00
Dylan K. Taylor
08b9495bce
DyeColorIdMap: fixed uninitialized offset error on invalid dye colours
2022-08-26 18:58:00 +01:00
Dylan K. Taylor
c16893cbac
Merge branch 'stable' into next-minor
2022-08-25 19:25:19 +01:00
Dylan K. Taylor
7f175b47e6
Fix CS
2022-08-25 18:19:22 +01:00
Dylan K. Taylor
0e73ffe555
CrashDump: Added JIT mode to data
...
this is necessary for identifying JIT-specific bugs, which, unfortunately, are very common.
2022-08-25 17:39:40 +01:00
Dylan K. Taylor
1ffd38b37b
Utils: fixed currentTrace() when xdebug is loaded, but not in develop mode
...
this is really dumb... why does it register the functions at all if they aren't usable ???
2022-08-25 16:56:26 +01:00
Dylan K. Taylor
0c446c276c
4.8.1 is next
2022-08-24 20:03:57 +01:00
Dylan K. Taylor
0284e65f60
Release 4.8.0
2022-08-24 20:03:56 +01:00
Dylan K. Taylor
75eba9c9ed
4.7.4 is next
2022-08-22 19:28:47 +01:00
Dylan K. Taylor
b5a049d1fe
Release 4.7.3
2022-08-22 19:28:43 +01:00
Dylan K. Taylor
5cb77c8365
GiveCommand: fix CS
2022-08-22 00:55:17 +01:00
IvanCraft623
bf8befc40b
Remove dead comment on GiveCommand ( #5241 )
2022-08-22 00:49:22 +01:00
Dylan K. Taylor
f75ca312cc
Worker: Unstack tasks in a synchronized block
...
this prevents any tasks still left in the queue on shutdown getting pulled out by the worker when we're attempting to shut it down.
This led to various race conditions, most notably weird cases where PopulationTask would inexplicably find its expected generator state had not been correctly set up.
2022-08-21 21:57:11 +01:00
Dylan K. Taylor
d144832928
GiveCommand: limit max amount in line with vanilla
2022-08-21 21:19:16 +01:00
ipad54
709a869045
Vines can now only be placed on full cube blocks ( #5053 )
...
fixes #2673
2022-08-21 21:04:24 +01:00
Dylan K. Taylor
fc8434308b
SignText: changed misleading documentation
...
this looks like a leftover from the days when sign text was handled by the tile directly
2022-08-21 20:45:23 +01:00
Dylan K. Taylor
5426b41447
InventoryTransaction: prevent client-authoritative item overstacking
...
this cheat is often used to carry more items in the inventory, wear multiple pieces of armour in one slot, and more.
2022-08-21 20:35:23 +01:00
Dylan K. Taylor
af2babec23
GiveCommand: do not accept negative amounts
2022-08-21 20:28:39 +01:00
Dylan K. Taylor
5d5366a7c8
Merge branch 'stable' into next-minor
2022-08-21 19:11:59 +01:00
Dylan K. Taylor
c13170a00b
Avoid implicit integer cast in Normal::pickBiome()
...
this throws deprecation warnings on PHP 8.1.
2022-08-20 17:16:38 +01:00
Dylan K. Taylor
1b852ac290
bootstrap: do not complain about xdebug if mode is 'off'
...
if xdebug.mode=off, the performance impact is the same as if xdebug wasn't loaded.
2022-08-19 16:45:40 +01:00
Dylan K. Taylor
3235d128e5
Fixed handling of fake requests during block placement and other actions
2022-08-18 18:25:49 +01:00
Dylan K. Taylor
2b7510945a
First look at ItemStackRequest usage (very unstable)
2022-08-18 17:38:57 +01:00
Dylan K. Taylor
d6af2b12f4
Merge branch 'complex-inventory-rewrite' into next-minor
2022-08-18 17:30:00 +01:00
Dylan K. Taylor
ad2d59923c
Merge branch 'stable' into next-minor
2022-08-18 17:06:15 +01:00
Dylan K. Taylor
792c1b62b7
Introduce and use TransactionBuilder for inventory evacuations
2022-08-18 17:04:12 +01:00
Dylan K. Taylor
e90abecf38
Rewrite InventoryManager handling of complex mapped inventories
...
this turned out to be necessary when dealing with the ItemStackRequest system.
2022-08-17 14:42:30 +01:00
Dylan K. Taylor
575dd47db7
4.7.3 is next
2022-08-16 17:51:26 +01:00
Dylan K. Taylor
e4a5defabb
Release 4.7.2
2022-08-16 17:51:26 +01:00
Dylan K. Taylor
c9626c610b
Skin: Correctly handle errors produced by commented JSON decoder
2022-08-16 17:35:23 +01:00
Dylan K. Taylor
dce8bd6d21
CS: Standardize new with braces
2022-08-15 17:16:23 +01:00
ShockedPlot7560
8fa81242d6
Sugarcane: fixed support conditions ( #5052 )
2022-08-15 17:08:26 +01:00
NoClip
2f4a9469b6
Player: spectator shouldn't able to pick blocks they don't have ( #5111 )
...
Jury is out on whether they should be able to pick blocks at all, or be considered to have infinite resources, but this solution has been used in a few other places already anyway, so it can be cleaned up another time.
2022-08-15 16:48:37 +01:00
Dylan K. Taylor
4d34885b15
Merge branch 'stable' into next-minor
2022-08-14 20:11:10 +01:00
Dylan K. Taylor
d62df585f2
4.7.2 is next
2022-08-14 19:56:00 +01:00
Dylan K. Taylor
19d7c2b552
Release 4.7.1
2022-08-14 19:55:56 +01:00
Dylan K. Taylor
f7ab0a3b92
Merge branch 'stable' into next-minor
2022-08-14 18:37:56 +01:00
Dylan K. Taylor
036e06e889
Revert "Workaround items in blockentity NBT not being processed correctly in 1.19.10"
...
This reverts commit 2b61c025c26394c3293bcc12a2d0b2301cb4c7ee.
2022-08-14 17:25:55 +01:00
Dylan K. Taylor
2fc84f6c67
ItemFactory: treat durables with negative meta as unknown items
...
fixes #5117
2022-08-12 17:24:43 +01:00
Dylan K. Taylor
566f5935a3
CraftingManagerFromDataHelper: do not register recipes with unknown outputs
...
fixes #5093
we don't need to check the inputs, since unknown input items shouldn't be obtainable anyway.
2022-08-12 17:19:47 +01:00
