f88c4d9a8c
Remove more unnecessary local static variable usages
...
these are never mutated. Local constants would be better, if we had those.
2022-09-02 19:19:04 +01:00
66cd156d80
Utils: use static property for core count cache, instead of local static variable
2022-09-02 19:18:01 +01:00
222049927a
Language: fixed bogus callable reference in array_map
...
for some reason phpstan only reports this under checkImplicitMixed.
2022-09-02 19:15:05 +01:00
d72e947d15
BlockFactory: avoid unnecessary local static variable usage
...
phpstan treats these as always mixed, because it can't be sure what their types will be.
2022-09-02 19:14:35 +01:00
770cca2efa
Server: harden response handling for crash report submission
...
this eliminates some checkImplicitMixed errors in phpstan.
2022-09-02 19:13:54 +01:00
033dac3d16
Server: be explicit about the player promise resolver type
...
since there's no way for phpstan to infer the type of this, it becomes implicit mixed, which can conceal bugs.
2022-09-02 19:13:16 +01:00
85678aa356
phpstan 1.8.3
2022-09-02 18:28:33 +01:00
1d253bc8c2
Utils: remove 32-bit specific code from javaStringHash()
...
this was necessary in the days of 32-bit, but for 64-bit, the 0xffffffff mask is sufficient and produces the exact same result.
2022-09-02 18:23:49 +01:00
9e0b4621be
Fixed languages-not-found bug ( #5272 )
...
* Fixed languages-not-found bug
* Update Language.php
Co-authored-by: Dylan T <odigiman@gmail.com >
2022-09-02 03:51:31 +01:00
ffb3af3e0d
fix CS
2022-09-02 00:59:58 +01:00
b3f03d7ae6
Poll console on the main thread, instead of using a separate thread
...
There's no need to use an extra thread for this, since there's no concern of a socket getting stuck in a blocking read.
This is one less thing that can go wrong because of pthreads.
2022-09-02 00:58:49 +01:00
2585160ca2
ConsoleReaderChildProcess: Commit suicide if the parent process dies and doesn't clean up
...
This happens if the main server process was forcibly killed, e.g. by the kill command on Linux, or taskkill/TaskManager on Windows.
Previously, the process would stick around as a zombie, which messed up terminals in some cases (e.g. git bash), though even having zombies with no side effects is bad enough.
2022-09-02 00:25:31 +01:00
14d3e6c7d5
Allow disabling the console reader via pocketmine.yml
...
Useful to save resources on headless servers where the console is never used (e.g. hosted server, Docker, etc.)
2022-09-01 23:43:54 +01:00
65ec318c30
PluginManager: Ensure dependents are disabled before dependencies in disablePlugins() ( #5227 )
...
this could later be expanded to disablePlugin() to make this disable order mandatory, to provide certainty for plugin devs.
Alternative solutions to this include disabling plugins in the opposite order that they were enabled in, but this doesn't allow for random plugin disables. This way seemed to make sense.
2022-08-31 18:43:30 +01:00
a25cb3741a
Limit valid supporting blocks of dead bush ( #5055 )
2022-08-31 02:18:18 +01:00
456439566b
Language: treat empty translation files the same as missing ones
2022-08-31 01:53:15 +01:00
5b89833d5c
Merge branch 'stable' into next-minor
2022-08-27 17:27:15 +01:00
fb25e05416
InventoryManager: fixed current window getting removed in race conditions with close window ACK
...
this could be observed by pressing E and immediately clicking a chest, which, if timed correctly, would lead to the chest lid closing, but the inventory being opened anyway.
2022-08-27 17:26:43 +01:00
78b5be8dd0
4.8.2 is next
2022-08-26 19:16:39 +01:00
0a92e91a30
Release 4.8.1
2022-08-26 19:16:39 +01:00
08b9495bce
DyeColorIdMap: fixed uninitialized offset error on invalid dye colours
2022-08-26 18:58:00 +01:00
c16893cbac
Merge branch 'stable' into next-minor
2022-08-25 19:25:19 +01:00
7f175b47e6
Fix CS
2022-08-25 18:19:22 +01:00
0e73ffe555
CrashDump: Added JIT mode to data
...
this is necessary for identifying JIT-specific bugs, which, unfortunately, are very common.
2022-08-25 17:39:40 +01:00
1ffd38b37b
Utils: fixed currentTrace() when xdebug is loaded, but not in develop mode
...
this is really dumb... why does it register the functions at all if they aren't usable ???
2022-08-25 16:56:26 +01:00
0c446c276c
4.8.1 is next
2022-08-24 20:03:57 +01:00
0284e65f60
Release 4.8.0
2022-08-24 20:03:56 +01:00
75eba9c9ed
4.7.4 is next
2022-08-22 19:28:47 +01:00
b5a049d1fe
Release 4.7.3
2022-08-22 19:28:43 +01:00
5cb77c8365
GiveCommand: fix CS
2022-08-22 00:55:17 +01:00
bf8befc40b
Remove dead comment on GiveCommand ( #5241 )
2022-08-22 00:49:22 +01:00
f75ca312cc
Worker: Unstack tasks in a synchronized block
...
this prevents any tasks still left in the queue on shutdown getting pulled out by the worker when we're attempting to shut it down.
This led to various race conditions, most notably weird cases where PopulationTask would inexplicably find its expected generator state had not been correctly set up.
2022-08-21 21:57:11 +01:00
d144832928
GiveCommand: limit max amount in line with vanilla
2022-08-21 21:19:16 +01:00
709a869045
Vines can now only be placed on full cube blocks ( #5053 )
...
fixes #2673
2022-08-21 21:04:24 +01:00
fc8434308b
SignText: changed misleading documentation
...
this looks like a leftover from the days when sign text was handled by the tile directly
2022-08-21 20:45:23 +01:00
5426b41447
InventoryTransaction: prevent client-authoritative item overstacking
...
this cheat is often used to carry more items in the inventory, wear multiple pieces of armour in one slot, and more.
2022-08-21 20:35:23 +01:00
af2babec23
GiveCommand: do not accept negative amounts
2022-08-21 20:28:39 +01:00
5d5366a7c8
Merge branch 'stable' into next-minor
2022-08-21 19:11:59 +01:00
c13170a00b
Avoid implicit integer cast in Normal::pickBiome()
...
this throws deprecation warnings on PHP 8.1.
2022-08-20 17:16:38 +01:00
1b852ac290
bootstrap: do not complain about xdebug if mode is 'off'
...
if xdebug.mode=off, the performance impact is the same as if xdebug wasn't loaded.
2022-08-19 16:45:40 +01:00
3235d128e5
Fixed handling of fake requests during block placement and other actions
2022-08-18 18:25:49 +01:00
2b7510945a
First look at ItemStackRequest usage (very unstable)
2022-08-18 17:38:57 +01:00
d6af2b12f4
Merge branch 'complex-inventory-rewrite' into next-minor
2022-08-18 17:30:00 +01:00
ad2d59923c
Merge branch 'stable' into next-minor
2022-08-18 17:06:15 +01:00
792c1b62b7
Introduce and use TransactionBuilder for inventory evacuations
2022-08-18 17:04:12 +01:00
e90abecf38
Rewrite InventoryManager handling of complex mapped inventories
...
this turned out to be necessary when dealing with the ItemStackRequest system.
2022-08-17 14:42:30 +01:00
575dd47db7
4.7.3 is next
2022-08-16 17:51:26 +01:00
e4a5defabb
Release 4.7.2
2022-08-16 17:51:26 +01:00
c9626c610b
Skin: Correctly handle errors produced by commented JSON decoder
2022-08-16 17:35:23 +01:00
dce8bd6d21
CS: Standardize new with braces
2022-08-15 17:16:23 +01:00
