Dylan K. Taylor
2e720b48d9
AnimatePacket: added a new constant
2020-04-17 01:57:20 +01:00
Dylan K. Taylor
a6e79bedf5
ActorEventPacket: plug some gaps
2020-04-17 01:56:56 +01:00
ナナチさん
a5ba570fdf
StructureBlockUpdatePacket: Added encode/decode ( #3148 )
2020-04-17 01:11:16 +01:00
Dylan K. Taylor
0d5164af02
LabTablePacket: updated type field and added constants
2020-04-16 22:03:36 +01:00
Dylan K. Taylor
534af770f8
InteractPacket: new constant
2020-04-16 22:03:34 +01:00
Dylan K. Taylor
619a9892e5
RCON: properly handle potential errors during socket setup
2020-04-16 01:29:28 +01:00
Dylan K. Taylor
63b109f23e
RCONInstance: fixed incorrect doc comment for field
2020-04-15 21:16:47 +01:00
Dylan K. Taylor
604900d4c5
Merge branch 'stable' into next-minor
2020-04-14 01:38:01 +01:00
Twisted
6422ed7722
Added RakLibInterface::setPacketLimit() ( #3398 )
2020-04-11 23:27:17 +01:00
marshall
310de5a2b2
RCON: set SO_REUSEADDR to fix RCON start failure after restart ( #3357 )
2020-03-16 12:00:45 +00:00
Dylan K. Taylor
5a9a576bfa
AddActorPacket: remove unused import
2020-03-10 12:45:52 +00:00
Dylan K. Taylor
b8caf34e62
Merge branch 'stable' into next-minor
2020-03-10 12:45:00 +00:00
Dylan K. Taylor
456d9a722a
reduce some doc comments to single line
2020-03-10 12:36:19 +00:00
Dylan K. Taylor
6a507bb149
further CS fixes
2020-03-10 12:18:16 +00:00
Dylan K. Taylor
df65f1009c
Merge branch 'stable' into next-minor
2020-03-09 14:33:37 +00:00
Dylan K. Taylor
93e5c80962
MultiplayerSettingsPacket is bothways, close #3331
2020-03-03 12:32:57 +00:00
Dylan K. Taylor
c19ab97610
AddActorPacket: move BC hack to higher level
...
we shouldn't hack the protocol impl for BC.
2020-02-27 17:37:45 +00:00
Dylan K. Taylor
04581e2700
DataPacket: account for splitscreen header when decoding
2020-02-24 21:20:25 +00:00
Dylan K. Taylor
93597dcd50
SkinData: fixed loss of data from packet decode
2020-02-24 20:48:03 +00:00
Dylan K. Taylor
3cd1da196a
UpdateTradePacket: fix order of fields, closes #3327
2020-02-24 20:16:07 +00:00
Dylan K. Taylor
1257378198
clean up function imports
2020-02-08 09:31:15 +00:00
Dylan K. Taylor
25bc95cd1e
removing more unnecessary casts
2020-02-06 19:33:34 +00:00
Dylan K. Taylor
da3742b39e
Remove useless typecasts
2020-02-06 16:00:57 +00:00
Dylan K. Taylor
d26fcf7dee
Removed useless casts() from min/max calls
2020-02-06 15:58:27 +00:00
Dylan K. Taylor
34972c3327
Assume that getmypid() never returns false
...
my background research on this informs me that this returns false on negative PID, which never happens because the underlying C API call never fails - not on linux, bsd, or windows.
2020-02-05 21:00:56 +00:00
Dylan K. Taylor
1a5228e7a6
Fixed property types with missing null PhpDoc types
2020-02-05 20:55:03 +00:00
Dylan K. Taylor
495bfda044
Drop a bunch of invalid null defaults
...
phpstan doesn't report these out of the box, for reasons I'm not clear on. It's also not clear if having null defaults has any effect on nullability behaviour, so they are best removed. In addition, these would be problematic on 7.4.
2020-02-05 20:53:54 +00:00
Dylan K. Taylor
889cd5e206
PlayerNetworkSessionAdapter: clean up leftovers from multi quote support for json decode
2020-02-05 20:45:13 +00:00
Dylan K. Taylor
fa82cb26d8
added native types to closures (phpstan-strict-rules)
2020-02-05 16:35:10 +00:00
Dylan K. Taylor
e5a2cfb65f
avoid type juggling in conditions, always use explicit boolean conditions
2020-02-05 15:44:06 +00:00
Dylan K. Taylor
99038c752c
Avoid usage of for-loop vars outside of for-loop context
...
these problems were reported by PHPStan strict rules. They aren't actually bugs, but they could become bugs in the future.
2020-02-05 13:16:09 +00:00
Dylan K. Taylor
260ac47588
add some phpstan array types
2020-01-30 22:23:11 +00:00
Dylan K. Taylor
fc0619ee6e
populate missing array value types in network namespace
2020-01-30 21:12:00 +00:00
Dylan K. Taylor
259f0425a9
ClientboundMapItemDataPacket: replace assoc array with MapDecoration class
...
I thought I'd done this already, but it appears not.
2020-01-30 20:05:18 +00:00
Dylan K. Taylor
640df1003c
add some Generator generics for PHPStan
2020-01-29 16:38:50 +00:00
Dylan K. Taylor
8184a6b114
SkinImage: enforce that height/width must be positive
2020-01-22 14:58:36 +00:00
Dylan K. Taylor
b8d44ff162
SkinImage: fix formatting error
2020-01-22 14:58:00 +00:00
Dylan K. Taylor
f624871b3f
strip extra blank lines (php-cs-fixer)
2020-01-22 14:50:29 +00:00
Dylan K. Taylor
bff5bf25ae
LegacySkinAdapter: make resource patch validity check more robust
2020-01-22 14:36:40 +00:00
Dylan K. Taylor
c4793241f5
Mass removal of useless @param/@return PHPDoc annotations, pass 1
2020-01-21 15:10:18 +00:00
Dylan K. Taylor
fffeeddca6
DataPacket: add magic method return types to keep phpstan happy
...
this really shouldn't be necessary, but it is what it is.
2020-01-19 17:14:34 +00:00
Dylan K. Taylor
b42966f61b
network: explicitly specify @return void
2020-01-18 19:35:01 +00:00
Dylan K. Taylor
ca86ec2ec2
Network: added missing return type information for getUpload() and getDownload()
2020-01-18 19:33:27 +00:00
Dylan K. Taylor
ab57914322
CraftingDataPacket: added native return typehints to private methods
2020-01-18 17:45:15 +00:00
Dylan K. Taylor
f6d96c5827
DataPacket: clean() returns $this, not void
2020-01-14 17:30:48 +00:00
Dylan K. Taylor
b1458db47b
Revert "CraftingDataPacket: fixed trying to return void result of parent function"
...
This reverts commit e12ecaf62960dfc71871520e52787589447346ee.
2020-01-14 17:16:17 +00:00
Dylan K. Taylor
2d2c9379cd
DataPacket: apply @return void annotations to make phpstan happy
...
this eliminates 250+ errors on level 6.
2020-01-14 15:39:07 +00:00
Dylan K. Taylor
3400771770
DataPacket: add missing return type info for pid()
2020-01-14 15:38:24 +00:00
Dylan K. Taylor
e12ecaf629
CraftingDataPacket: fixed trying to return void result of parent function
2020-01-14 15:37:06 +00:00
Dylan K. Taylor
818d0e19ab
RCONInstance: remove always-false branch (readPacket() never returns null)
2020-01-11 21:54:03 +00:00
