Dylan K. Taylor
330e93e5e3
Player: do not handle inbound ActorEvents that are not for self
2020-03-13 15:15:20 +00:00
Dylan K. Taylor
af53c85e6a
Merge branch 'next-minor'
2020-03-12 11:48:26 +00:00
Dylan K. Taylor
e2579e0a2a
Merge branch 'stable' into next-minor
2020-03-12 11:47:33 +00:00
Dylan K. Taylor
2020fcd18e
updated build/php submodule
2020-03-12 11:47:15 +00:00
Dylan K. Taylor
899d05c6ec
DataPacket: strip some whitespace
2020-03-10 13:06:16 +00:00
Dylan K. Taylor
ca909ebc1d
Merge branch 'next-minor'
2020-03-10 13:05:37 +00:00
Dylan K. Taylor
5a9a576bfa
AddActorPacket: remove unused import
2020-03-10 12:45:52 +00:00
Dylan K. Taylor
b8caf34e62
Merge branch 'stable' into next-minor
2020-03-10 12:45:00 +00:00
Dylan K. Taylor
456d9a722a
reduce some doc comments to single line
2020-03-10 12:36:19 +00:00
Dylan K. Taylor
344c980cff
GlobalConstants: add strict_types
2020-03-10 12:35:13 +00:00
Dylan K. Taylor
167492087f
Chunk: specify expected bounds for Y coordinates
2020-03-10 12:33:53 +00:00
Dylan K. Taylor
db215283a2
Effect: add desc for color parameter
2020-03-10 12:28:44 +00:00
Dylan K. Taylor
6a507bb149
further CS fixes
2020-03-10 12:18:16 +00:00
Dylan K. Taylor
dc757c25c8
cleanup CS from 8ec0a4d0d60b218acf13dfc20137728e5b4943d2
2020-03-10 12:14:38 +00:00
Dylan K. Taylor
73267ae077
Merge branch 'stable' into next-minor
2020-03-10 12:11:36 +00:00
Dylan K. Taylor
a72e6ee706
Player: be aware of held item changing during click-block
...
this caused bugs if the inventory was cleared while using a hoe.
2020-03-10 12:10:01 +00:00
jasonwynn10
8ec0a4d0d6
Allow specifying compatible OS in plugin manifest ( #3192 )
2020-03-10 10:12:56 +00:00
Andrés Arias
89ea7f0a76
Player: Stop setting held item post entity attack if changed ( #3348 )
...
closes #3340
2020-03-10 10:09:31 +00:00
Dylan K. Taylor
2a97c7032e
Merge branch 'master' of https://github.com/pmmp/pocketmine-mp
2020-03-09 14:39:02 +00:00
Dylan K. Taylor
b4b1877ce5
Merge branch 'next-minor'
2020-03-09 14:38:15 +00:00
Dylan K. Taylor
df65f1009c
Merge branch 'stable' into next-minor
2020-03-09 14:33:37 +00:00
DaPigGuy
12e4e92894
Inventory: Pass old item(s) to inventory change listeners, closes #3323 ( #3337 )
2020-03-09 13:52:15 +00:00
Andrés Arias
a6ca37429c
Player: do not set held item post block-break if changed ( #3345 )
...
this usually happens when a plugin replaces the held item during BlockBreakEvent.
closes #2010
2020-03-09 13:45:58 +00:00
dependabot-preview[bot]
4bf9fb278b
Bump phpstan/phpstan from 0.12.11 to 0.12.14 ( #3338 )
2020-03-09 13:31:23 +00:00
Dylan K. Taylor
15d81154e6
PluginDescription: drop unenforceable type constraint on array keys
...
the data that comes through here isn't validated, and there's also no guarantee that all the keys will be strings in spite of our best efforts even if it was validated, because PHP is fucking stupid and casts int-like string keys to int keys.
2020-03-05 19:53:01 +00:00
Dylan K. Taylor
995309424e
updated pocketmine/nbt dependency
...
this is going to need work on exception handling, but right now it's so inconsistent that it doesn't matter anyway.
2020-03-04 17:53:37 +00:00
Dylan K. Taylor
6e39e34c1e
Merge branch 'stable'
2020-03-03 12:35:11 +00:00
Dylan K. Taylor
93e5c80962
MultiplayerSettingsPacket is bothways, close #3331
2020-03-03 12:32:57 +00:00
Dylan K. Taylor
c19ab97610
AddActorPacket: move BC hack to higher level
...
we shouldn't hack the protocol impl for BC.
2020-02-27 17:37:45 +00:00
Dylan K. Taylor
2ca10bf84b
Merge branch 'next-minor'
2020-02-27 17:08:59 +00:00
Dylan K. Taylor
dbaf851be7
Merge branch 'stable' into next-minor
2020-02-27 16:51:06 +00:00
Dylan K. Taylor
78394a336c
Merge branch 'stable'
2020-02-25 20:45:39 +00:00
Dylan K. Taylor
7aa8bd18d3
Revert "Item: restrict bounds of count to 0-255"
...
This reverts commit 10317527e4012fb1dbb1661f2f7fc33b05a7a6d1.
this breaks user code which exceeds stack limits in legitimate
circumstances. For example, it should be OK to add 6000x diamond to a
player's inventory without being forced to manually split the count up
for addItem().
2020-02-25 20:42:03 +00:00
Dylan K. Taylor
53067c26d7
BaseInventory: stop mutating item for no reason in canAddItem()
2020-02-25 20:30:37 +00:00
Dylan K. Taylor
5c2ae0257c
DataPacket: inject buffer via parameter instead of class field (packet & stream separation, step 2)
...
this is not complete yet, but the final change (having the binarystream actually come from outside) is a little more disruptive, and some extra changes need to be made. This will grant some sanity in the meantime without breaking too much stuff.
2020-02-25 16:19:11 +00:00
Dylan K. Taylor
a633e415ef
FastChunkSerializer: use machine endianness for pack() (thanks @Frago9876543210)
...
this is faster due to not having to reverse bytes. Since we don't use this format for persistence, it's OK to use machine byte order for this.
2020-02-25 15:08:53 +00:00
Dylan K. Taylor
bd00ee5038
Merge branch 'stable'
2020-02-24 22:11:13 +00:00
Dylan K. Taylor
e279672d45
updated pocketmine/nbt dependency
2020-02-24 22:00:03 +00:00
Dylan K. Taylor
04581e2700
DataPacket: account for splitscreen header when decoding
2020-02-24 21:20:25 +00:00
Dylan K. Taylor
93597dcd50
SkinData: fixed loss of data from packet decode
2020-02-24 20:48:03 +00:00
Dylan K. Taylor
8a770d837e
Merge branch 'stable'
2020-02-24 20:32:43 +00:00
Dylan K. Taylor
778814a35e
changelog: fix typo
2020-02-24 20:18:47 +00:00
Dylan K. Taylor
3cd1da196a
UpdateTradePacket: fix order of fields, closes #3327
2020-02-24 20:16:07 +00:00
Dylan K. Taylor
ce0af8b040
DataPacket now encapsulates NetworkBinaryStream instead of extending it
...
ultimately the goal is to remove the NetworkBinaryStream crap entirely, but this change has most of the same benefits and is less disruptive.
2020-02-24 18:59:54 +00:00
Dylan K. Taylor
7c2741e4f5
Inventory: eliminate remaining $send parameters
2020-02-23 21:59:51 +00:00
Dylan K. Taylor
36685001bd
ContainerOpenPacket: fixed entityInv() not initializing x/y/z fields
...
these are written even when not used, so they have to be initialized.
2020-02-23 20:59:53 +00:00
Dylan K. Taylor
365d4a1592
better fix for 1.14.30 movement bug
2020-02-23 19:31:32 +00:00
Dylan K. Taylor
2d7f37ac47
avoid direct mutation of Item->count field, use Item->pop() instead
...
I think this change was already applied on the master branch, but I don't remember for sure.
2020-02-23 17:37:25 +00:00
Dylan K. Taylor
50fcdd6e7e
Item: fixed documentation of pop() return type (it's not fluent)
2020-02-23 17:32:50 +00:00
Dylan K. Taylor
10317527e4
Item: restrict bounds of count to 0-255
2020-02-23 17:23:53 +00:00