9232f4509c
TimingsHandler: don't bail on redundant attempts to stop non-running timers
...
while it would be nice to bail, providing the environment to allow bailing without breaking stuff requires some complex changes that would reduce performance when timings is not running. Considering the limited usefulness of bailing here anyway, and the fact that it just has to be prevented to not have side effects, it doesn't make a whole lot of sense right now.
closes #3261 , closes #3269 , closes #3254
2020-01-04 14:44:55 +00:00
cef77907c6
Timings: fixed grandparent timers not working correctly, closes #3229
2020-01-04 13:23:04 +00:00
06ec8b8397
resource packs: added new option remove_client_resources, fixed client packs being removed when forcing resource pack download
2020-01-04 13:16:47 +00:00
ee08286eca
moved git hash detection code to its own unit
2020-01-02 21:01:31 +00:00
a83211f96a
VersionInfo: add strict_types to stop CS tools screwing with it
2020-01-02 20:05:50 +00:00
0b3c4ee496
bootstrap: don't choke on paths that have spaces in them
2019-12-30 11:58:44 +00:00
54de518634
bootstrap: fixed incorrect git hash detection when cwd is not the repo root
2019-12-30 09:09:47 +00:00
a908197907
Effect: document that duration is expected in ticks
2019-12-29 19:03:32 +00:00
3e23a568ca
phpstan: properly fixing FPs on constant comparisons
2019-12-29 14:25:44 +00:00
dadc5c1b87
3.11.3 is next
2019-12-29 13:11:30 +00:00
a37d740111
Release 3.11.2
2019-12-29 13:11:30 +00:00
2de0ec02ba
phpstan 0.12.3
2019-12-28 17:22:08 +00:00
d83820477f
TimingsHandler: throw on attempt to stop timer that is not running
...
I do not think that this bug is in effect in the core code, but I can't be sure.
2019-12-21 13:17:40 +00:00
8726604899
Merge #3251 : Remove usages of empty()
2019-12-19 11:08:08 +00:00
9cbe378e8c
Timezone: fix possible crash on CentOS
2019-12-18 11:23:24 +00:00
494660102e
Replace empty() usages with count()
2019-12-18 11:23:24 +00:00
216138a37e
PlayerAuthInputPacket: Fix assigning variable in static context
2019-12-17 22:04:24 +08:00
b08c38f8f9
build/make-release: remove redundant require_once
...
this is included by vendor/autoload.php since 3.7.x.
2019-12-17 11:47:07 +00:00
911b6feaf9
NetworkInventoryAction: remove dead code
...
the trading & beacon types need to be checked as well, but I don't have the tools to check that right now.
2019-12-17 11:17:40 +00:00
2cb6990698
Enchantment: don't throw exceptions on out of range IDs
...
this function is used for data deserialization, and data may have bad enchantment IDs in it.
2019-12-14 10:04:51 +00:00
f7d66613df
CompletedUsingItemPacket: added missing #include, closes #3219
2019-12-13 19:50:40 +00:00
95c32d26df
Explosion: fixed ray trace getting stuck on a block when it encounters an empty subchunk
...
this might have caused unexpected behaviour in large caves.
2019-12-13 18:07:59 +00:00
9e1f6a2486
protocol: updated particle IDs
2019-12-13 10:52:09 +00:00
76994f15ac
phpstan: green on level 5
2019-12-12 18:27:26 +00:00
cf73d74bd0
format/anvil: fixed possible type violation on saving chunk
2019-12-12 18:24:21 +00:00
37a8d95464
world IO: fixed crashes when garbage data found in tile/entity NBT data
2019-12-12 18:21:23 +00:00
9a4b72add5
PlayerInventory: fix type violation when calling equipItem() for non-Player holder
2019-12-12 16:31:22 +00:00
919534d978
EnderChest: fixed crash when plugins overwrite tile classes with incompatible ones
...
relates to 47a959dace
2019-12-12 16:28:30 +00:00
cb598155a4
Server: add @return annotation to crashDump() to make phpstan happy
...
this is technically a bug in PHPStan, but it's easier to do this than report a bug.
2019-12-12 16:19:57 +00:00
00888fdc55
TranslationContainer::__construct() accepts float and int too (they can be casted to string)
2019-12-12 16:19:04 +00:00
77795ae3bc
BaseLang::translateString() accepts float and int too (they can be casted to string)
2019-12-12 16:18:11 +00:00
f39fc7e525
CompressBatchedTask::__construct() accepts Player[] not string[]
2019-12-12 16:16:48 +00:00
77f7595e0e
Location::__construct() accepts floats for x,y,z
2019-12-12 16:16:16 +00:00
e8d3a25028
Position::__construct() accepts floats for x,y,z
2019-12-12 16:15:49 +00:00
1370930ea9
Entity: remove redundant defaults from lastX lastY lastZ, remove nullability
...
these fields are never null because they are initialized in the constructor, and they are never written to with null nor ever expected to be null.
2019-12-12 16:14:30 +00:00
70c3008b7b
phpstan: green on level 4
2019-12-12 13:00:57 +00:00
46930b98b7
Timings: add a dedicated field for checking initialization
2019-12-12 12:59:01 +00:00
92be8c8ec0
PopulationTask: don't assume anything about TLS return values
...
while these SHOULD be what we say they are, it's possible for something else to overwrite them with junk and make the server catch fire.
2019-12-12 12:19:54 +00:00
62069bc7af
Level: fix return type content doc comment for getAdjacentChunks()
2019-12-12 12:18:35 +00:00
26230c1f9b
Player: don't report never-played for a disconnected player
...
this should catch fire like everything else does.
2019-12-12 12:17:52 +00:00
a9fafbc5eb
BanEntry: remove nullable return from parseDate()
...
this function never returns null
2019-12-12 11:59:41 +00:00
b8778cb791
LevelProvider: fix doc comment of ::generate()
...
this raised false positives on phpstan level 4
2019-12-12 11:59:12 +00:00
73c5fe5cf9
BaseInventory: correctly annotate content type of slots field
...
fixes warnings on phpstan level 4
2019-12-12 11:58:11 +00:00
b3cfa5a3a0
TimingsHandler: use weak comparison for stopTiming start check
...
this could be an int or float, and 0 !== 0.0.
2019-12-12 11:48:34 +00:00
6127a02a8b
phpstan 0.12.2
2019-12-12 10:43:45 +00:00
dbca36e5e2
SkinImage: throw on wrong data length
2019-12-11 22:45:14 +00:00
1171bae691
login: read the correct key SkinAnimationData
2019-12-11 22:40:05 +00:00
494f8e8251
login: fixed missing base64_decode() for animation images
2019-12-11 22:39:40 +00:00
3c9af56e06
3.11.2 is next
2019-12-11 20:20:26 +00:00
40a2211a5a
Release 3.11.1
2019-12-11 20:20:26 +00:00
