PopulationTask: don't assume anything about TLS return values

while these SHOULD be what we say they are, it's possible for something else to overwrite them with junk and make the server catch fire.
This commit is contained in:
Dylan K. Taylor 2019-12-12 12:19:54 +00:00
parent 62069bc7af
commit 92be8c8ec0

View File

@ -56,11 +56,9 @@ class PopulationTask extends AsyncTask{
}
public function onRun(){
/** @var SimpleChunkManager $manager */
$manager = $this->getFromThreadStore("generation.level{$this->levelId}.manager");
/** @var Generator $generator */
$generator = $this->getFromThreadStore("generation.level{$this->levelId}.generator");
if($manager === null or $generator === null){
if(!($manager instanceof SimpleChunkManager) or !($generator instanceof Generator)){
$this->state = false;
return;
}