From 92be8c8ec0e978be291b39bedc806910829c56ff Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Thu, 12 Dec 2019 12:19:54 +0000 Subject: [PATCH] PopulationTask: don't assume anything about TLS return values while these SHOULD be what we say they are, it's possible for something else to overwrite them with junk and make the server catch fire. --- src/pocketmine/level/generator/PopulationTask.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/pocketmine/level/generator/PopulationTask.php b/src/pocketmine/level/generator/PopulationTask.php index 007a6f87f..d061c415b 100644 --- a/src/pocketmine/level/generator/PopulationTask.php +++ b/src/pocketmine/level/generator/PopulationTask.php @@ -56,11 +56,9 @@ class PopulationTask extends AsyncTask{ } public function onRun(){ - /** @var SimpleChunkManager $manager */ $manager = $this->getFromThreadStore("generation.level{$this->levelId}.manager"); - /** @var Generator $generator */ $generator = $this->getFromThreadStore("generation.level{$this->levelId}.generator"); - if($manager === null or $generator === null){ + if(!($manager instanceof SimpleChunkManager) or !($generator instanceof Generator)){ $this->state = false; return; }