7fdfe947b0
inventory: fix some transactions being rejected for no good reason
...
since 1.13, transactions such as interacting with creative inventory cause a spoof windowID 124 slot 50 action to appear which changes air -> air. This currently gets rejected because only cursor is mapped to ID 124, and it only has a single slot.
It is not clear what the purpose of 124:50 is, but this fix filters out any actions which do not change anything, since they won't affect transaction balance anyway.
2019-12-02 21:41:08 +00:00
b7c4379700
StartGamePacket: fixed asymmetry in block table handling
2019-12-02 19:35:55 +00:00
20b7418916
PlayerAuthInputPacket: added encode & decode, and some aux classes
2019-12-02 15:14:59 +00:00
85521f5e7a
EducationSettingsPacket: added encode & decode
2019-12-02 13:57:19 +00:00
f37ea6a203
AvailableCommandsPacket: fix nonsensical placement of HARDCODED_ENUMS
2019-12-02 12:57:05 +00:00
abf8081ebc
RuntimeBlockMapping: add a type check for decoded NBT root type
...
this is kinda redundant since this function can blow up in so many other ways anyway, but it makes PHPStan happy, so it'll do.
2019-12-02 08:21:42 +00:00
8594cb3e74
AvailableCommandsPacket: fixed doc comment for putEnumConstraint()
2019-12-02 08:17:00 +00:00
e37c8e3a5d
Merge branch 'drew-1.13' of https://github.com/dktapps/PocketMine-MP into dktapps-drew-1.13
2019-12-01 22:02:40 -05:00
e38c0c0fe1
Merge remote-tracking branch 'upstream/stable' into stable
2019-12-01 21:55:50 -05:00
92e1811b06
DataPacket: fixed bad null assignment to buffer in clean()
...
this is never expected to be null, so implicitly relies on PHP magic behaviour to convert it to string when appended.
2019-12-01 20:36:56 +00:00
163ed225f2
NetworkBinaryStream: fixed crash when non-compound root tag is provided for itemstack
2019-12-01 18:41:02 +00:00
d8188b807a
CraftingDataPacket: read & write potion recipes
2019-11-30 21:18:54 +00:00
8e68655fc7
Merge branch 'stable' into drew-1.13
2019-11-30 21:15:50 +00:00
6d109bfc6f
CraftingDataPacket: fixed not retaining cleanRecipes during decode
2019-11-30 21:15:37 +00:00
b7a5a53c9d
MoveActorDeltaPacket: flags is now a short
2019-11-30 12:56:16 +00:00
76bd0f452c
AvailableCommandsPacket: add special handling for enums which aren't referenced by any command directly
...
the CommandName enum is a magic enum used by the argtype.
TODO: It's possible that not sending the CommandName enum might be causing client sided crashes. Investigate.
2019-11-30 12:41:44 +00:00
363556e9b6
AvailableCommandsPacket: encode & decode for enum value constraints
...
This is a peculiarly overengineered system that is used for restricting access to enum members under certain conditions, e.g. to disallow changing specific gamerules in survival.
2019-11-30 12:31:31 +00:00
6f08853b29
Merge branch 'stable' into drew-1.13
2019-11-30 12:04:46 +00:00
42d8357821
AvailableCommandsPacket: fixed missing decoded overloads with 0 arguments
...
these should be listed even if they have 0 arguments
2019-11-30 11:58:29 +00:00
5d17405b92
Better checks on resource patch
2019-11-28 19:48:34 -05:00
a303c4b294
Add some isset checks to prevent server from crashing on an invalid resourcepatch
2019-11-21 17:58:33 -05:00
01d6cbe9c3
Added : void typehint to SkinAdapterSingleton & provide documentation
2019-11-21 15:01:34 -05:00
f682c16740
Changed eduMode to eduEditionOffer and added an unsignedVarInt in availablecommandspacket
2019-11-21 14:55:29 -05:00
74c09dc202
Remove inline assignment
2019-11-21 14:49:01 -05:00
0917b67573
Generate param docs for constructor
2019-11-21 14:46:10 -05:00
5cb0eafcb2
Should be checking the string, not an object
2019-11-21 14:24:47 -05:00
221e6db47d
Remove persona capes off of classic skins, add checks for empty cape data when converting
2019-11-21 14:21:08 -05:00
8d06018d81
make toSkinData return statement multi lined
2019-11-21 13:54:22 -05:00
4340349db7
Generate getters for SkinData, applied suggested change, and fixed an underfined variable in PlayerListPacket
2019-11-21 13:52:27 -05:00
6105198313
Update AvailableCommandsPacket constants
2019-11-20 22:47:48 -05:00
c96ba13c23
Extract geometry name from resource patch
2019-11-20 22:42:56 -05:00
c8d0cb315b
Move persona skin hack to legacyskinadapter
2019-11-20 21:52:49 -05:00
be9c413a9e
Added network components for skins, to collect instead of throw out data
2019-11-20 21:43:41 -05:00
10d44292e1
fix classic capes
2019-11-12 12:27:50 -05:00
70f81334ae
MultiplayerSettingsPacket
2019-11-12 11:58:40 -05:00
ead572fab9
fix skin sharing stupidity
2019-11-12 07:08:48 -05:00
ef8e286277
Merge branch 'stable' of https://github.com/drew-mcbe/pocketmine-mp into drew-1.13
2019-11-12 06:57:57 -05:00
c428596009
AddPlayerPacket: missing field
2019-11-11 16:36:55 -05:00
5bcbef90ea
Added variables for getSkin's animation for easier readability
2019-11-11 15:32:48 -05:00
1c67f094e3
Change get and put SkinImage visibility to private
2019-11-11 15:29:57 -05:00
7b152def7d
Move SkinAnimation and changed SerializedImage to SkinImage
...
Also change putImage and getImage to getSkinImage and putSkinImage
2019-11-11 15:23:48 -05:00
38c759c86e
ResourcePackStack: missing field
2019-11-11 14:58:45 -05:00
7fcd40df15
add encode/decode for some new packets
2019-11-11 11:20:37 -05:00
ba39327b28
Merge remote-tracking branch 'origin/stable' into drew-1.13
2019-11-11 10:42:25 -05:00
8d2e3894ef
DataPacket: fixed var_dump() not showing private & protected subclass properties
2019-11-11 15:41:08 +00:00
8ee0fbccc5
Merge branch 'stable' of https://github.com/drew-mcbe/pocketmine-mp into drew-1.13
2019-11-11 05:48:17 -05:00
19377c86a4
PlayerSkinPacket: reduce diff pollution
2019-11-11 09:47:04 +00:00
57e9fe78a3
change buildPlatform parameter to -1
2019-11-10 21:45:33 -05:00
e2fc7cdf88
Friendly BC skins (persona not supported)
2019-11-10 21:04:38 -05:00
635bb08fb9
Update playerskinpacket to use the strings
2019-11-10 19:39:07 -05:00
