04d0b6c054
don't spam listeners with slot-change notifications when doing a content change
2019-05-20 15:45:15 +01:00
c13b352b76
fix armour not being set correctly on entity spawn
2019-05-20 15:31:23 +01:00
d9bc48bb01
CraftingGrid: Remove redundant overrides
...
the network session knows not to send this stuff because it's not associated with any window ID.
2019-05-20 15:15:20 +01:00
bca0833035
Clean up handling of armour sync
2019-05-19 16:56:10 +01:00
cd103cefcc
Redesign inventory listening API
...
given that inventory listeners are no longer allowed to fiddle with the outcome of changing contents, it's now possible to allow having multiple listeners receiving events.
It's likely that this will be used for network inventory sync in the near future.
2019-05-19 16:36:38 +01:00
dec6c9f49b
Removed EntityInventoryChangeEvent and EntityArmorChangeEvent
...
there is nothing that these events do that can't be fulfilled by transactions. They complicate the internal implementation and produce unexpected behaviour for plugins when cancelled.
TL;DR: Use transactions. That's what they are there for.
2019-05-19 16:02:03 +01:00
67affcea32
move more packet logic to net session
...
it seems like net session is turning into a giant dumping ground for sending API ... this needs to be cleaned up somehow.
2019-05-19 15:48:01 +01:00
57219abc9d
fix test failure
2019-05-18 20:20:33 +01:00
c3c2dd3988
Rename SimpleSessionHandler -> InGameSessionHandler
...
the "simple" name comes from the early days of this refactor before I started splitting everything up into their own units. This handler is now in good enough condition to have a proper name.
2019-05-18 19:13:41 +01:00
fa9fcea189
SimpleSessionHandler: Do not read blocks from world in onFailedBlockAction()
...
the world will do this anyway, so we can reduce our code burden here.
2019-05-18 19:11:23 +01:00
d44ec702b0
Added BlockDataValidator::read5MinusHorizontalFacing()
2019-05-18 17:42:03 +01:00
b11d3b0401
CraftingDataPacket: Fixed uncaught exception in decode
...
this is not exploitable because it's not a serverbound packet, but it should be fixed nonetheless.
2019-05-18 17:19:44 +01:00
cd8645ff20
Removed PalettedBlockArray stub
...
the SubChunkConverter stub was accidentally removed in dd914e0752
2019-05-18 15:15:20 +01:00
6de0b48c1f
PacketBatch: Always encode packets freshly, never reuse buffers
...
this causes bugs when a packet is modified during events and then re-sent to a player. Since we can't control this, we can't allow this kind of buffer reuse.
The only notable case where this will cause loss of performance is when broadcasting a series of packet(s) which accumulate to less than 256 bytes, which is reasonably cheap to encode anyway.
In addition, removing this caching is one roadblock to moving this serialization to native code, which will make it vastly faster.
2019-05-17 18:04:51 +01:00
64f7f558a4
Merge branch 'stable'
...
# Conflicts:
# resources/vanilla
# src/pocketmine/entity/Human.php
2019-05-17 17:43:30 +01:00
76e5ea385b
Skin: improved error checking
...
plugin devs should find this less of a pain in the ass now.
2019-05-17 17:40:27 +01:00
0f398bbe66
LevelDB: Added conversion of legacy extradata -> 4D subchunk block layers
2019-05-17 17:15:45 +01:00
f7a9da4e92
PillarRotationTrait: Allow axis shift to be defined by the includer
2019-05-16 18:02:03 +01:00
dd914e0752
Block: move all legacy metadata constants into a dedicated class
...
this makes it easier to see what is using metadata (and makes it easier to get rid of later).
2019-05-16 16:55:44 +01:00
1898db840d
BlockFactory: more collapsible region things
2019-05-16 14:36:02 +01:00
642c16dfe7
added some //region ... //endregion
2019-05-16 14:35:34 +01:00
ff2600a0d0
Regenerated TODOs for BlockFactory and ItemFactory
...
also added //region and //endregion for IDE collapsibility
2019-05-16 14:20:51 +01:00
5024de38b8
added more types of stone slab
2019-05-15 18:15:25 +01:00
9ea684581f
Merge remote-tracking branch 'origin/stable'
2019-05-13 18:17:42 +01:00
fd413b512e
Remove useless Dandelion class
...
this class is line-for-line identical to the Flower class.
2019-05-12 18:42:49 +01:00
10831821be
Anvil: fix wrong visibility for recalculateBoundingBox()
2019-05-12 17:58:45 +01:00
85c6eb5003
Fence: cleanup some BB handling
2019-05-12 16:22:41 +01:00
166d821bcf
Stair: some BB handling cleanup
2019-05-12 16:22:20 +01:00
d6b720b55d
Wall: minor BB calculation cleanup
2019-05-12 16:21:52 +01:00
a19651a8dc
Painting: reduce complexity of getPaintingBB()
...
this makes it easier to unit-test.
2019-05-12 16:15:31 +01:00
adf4639625
Painting: Clean up painful BB calculation code
2019-05-12 16:10:51 +01:00
db4dac6d45
World: Remove incorrect isSolid() check for placement collision check
...
isSolid() != can be collided with. That's decided by the collision boxes provided, if any.
2019-05-12 16:00:38 +01:00
90e6073202
Vine: Clean up awful bounding-box calculation
...
the logic here is deceptively simple, just obscured by a lot of really nasty code.
2019-05-12 15:58:28 +01:00
41d754de5a
Vine: fix bug when reading state multiple times
2019-05-12 15:03:44 +01:00
5a351d3caf
Fix for Server::hasOfflinePlayerData ( #2919 )
2019-05-12 12:06:05 +01:00
bb93d4f8de
TimeCommand: Fix commands.time.query message ( #2917 )
2019-05-12 09:21:39 +01:00
66818e178a
DefaultPermissions: Fix typos in permission descriptions ( #2918 )
2019-05-12 09:20:45 +01:00
c99846e069
Unify Item constructor style
...
this exposed a few more dead classes.
2019-05-11 18:24:21 +01:00
51f96b195e
ItemFactory: fix wrong typehint
2019-05-11 18:02:18 +01:00
0bf7fd2c0d
Partially revert "Separate block break-info to a separate dynamic unit"
...
This reverts commit 9e72bc91a2
2019-05-11 09:46:20 +01:00
650e186481
Removed bad assumption that every Flowable descendent is an instant-breaking block
...
I'm wondering if there is even a point to Flowable at this point. Half of the blocks inheriting from it do not break instantly, or have some other modification to tool requirements.
2019-05-10 17:00:01 +01:00
01ad568256
Air: use BlockBreakInfo::indestructible()
2019-05-10 16:30:14 +01:00
9e72bc91a2
Separate block break-info to a separate dynamic unit
2019-05-10 16:24:59 +01:00
3be5de4570
Separate WoodenTrapdoor from Trapdoor, fixed iron trapdoors being valid furnace fuel, closes #2914 for bleeding-edge
2019-05-09 19:30:18 +01:00
5eb3c52a37
added PunchBlockParticle, encapsulate more network logic
2019-05-09 15:40:58 +01:00
51a8c2be9d
Player: Move rollback responsibility to network for interact/break block
...
Custom player implementations might not need rollbacks (f.e. Specter).
2019-05-09 14:54:56 +01:00
ca7c23c137
Player: remove dead functions
...
these functions belong in the network session, and they are currently just proxies for them. In the future we might have players who don't have IPs at all depending on how they connected (for example Specter) so this stuff shouldn't be in here.
2019-05-08 19:47:25 +01:00
4634baeb02
Player: don't repeat yourself
2019-05-08 19:38:57 +01:00
cf73c7f5c1
Cleanup to world provider exception handling
2019-05-08 18:26:41 +01:00
a51c06116a
Merge branch 'stable'
2019-05-08 17:04:37 +01:00
