Dylan K. Taylor
fd1bc1b845
AsyncWorker: deprecate ThreadStore methods
...
these are inconvenient and don't make any sense. It's far easier and more static-analysis-friendly to just use static properties.
2023-12-21 12:39:55 +00:00
Dylan K. Taylor
c05116849a
AsyncWorker: clean up nonsensical sleeper notifier handling code
2023-12-21 12:39:12 +00:00
Dylan K. Taylor
7a55a6e6b6
ServerKiller: harden against spurious wakeups
...
If awakened by spurious wakeup, the thread would immediately exit without doing anything, rendering it useless.
Not sure how it took so long for this to be found...
2023-12-20 17:22:11 +00:00
Dylan K. Taylor
bf99917f2a
ThreadSafeClassLoader: add native property types
2023-12-20 17:01:20 +00:00
Dylan K. Taylor
57f3a04bc5
data: Use statically analyzable ways of ensuring all cases are registered
...
PHPStan will verify that these matches cover all cases, which guarantees that all cases will be covered.
In addition, if PHPStan is not used, the constructors will immediately bail out when they hit a case that isn't covered.
The only downside is the extra indentation :(
2023-12-20 16:07:05 +00:00
Dylan K. Taylor
6b66cbfb1c
Merge branch 'minor-next' into major-next
2023-12-20 15:26:57 +00:00
Hugo_
c51b1b2812
Create LightableTrait and remove repetitive code ( #6111 )
2023-12-20 15:21:11 +00:00
Dylan K. Taylor
80125f9b19
Modernize single-use phpstan-template tags
2023-12-20 15:20:28 +00:00
Dylan K. Taylor
8dc28b7ea8
RuntimeDataDescriber: remove useless template parameter
2023-12-20 15:15:43 +00:00
Dylan K. Taylor
74cb0be868
Noise: give PHPStan some help understanding SplFixedArray
2023-12-20 14:43:36 +00:00
DiamondStrider1
c8da9dea95
WorldManager: Remove unused if in unloadWorld() ( #6203 )
2023-12-20 10:38:00 +00:00
Dylan K. Taylor
e1f4fd3048
ProcessLoginTask: remove dead comments
...
This is no longer an issue since b2df405cc0355dcffe202bc4040fae316940d427.
2023-12-15 16:01:43 +00:00
Dylan K. Taylor
d3d7f24015
Noise: make calls with many parameters less nauseating to read
2023-12-15 15:32:54 +00:00
Dylan K. Taylor
944dd7d3e4
BaseBanner: remove unnecessary array_filter() usage
2023-12-15 15:19:44 +00:00
Dylan K. Taylor
00a8ea267c
5.10.1 is next
2023-12-14 16:54:42 +00:00
Dylan K. Taylor
daeba95101
Release 5.10.0
2023-12-14 16:54:38 +00:00
Dylan K. Taylor
4d337add7c
Merge branch 'minor-next' into major-next
2023-12-14 14:03:09 +00:00
Dylan K. Taylor
06b2e61d3c
Merge remote-tracking branch 'origin/stable' into minor-next
2023-12-14 14:02:15 +00:00
Dylan K. Taylor
b4838f5b4e
5.9.1 is next
2023-12-06 15:02:57 +00:00
Dylan K. Taylor
46307973e3
Release 5.9.0
2023-12-06 15:02:57 +00:00
Dylan K. Taylor
927f129c6e
Fixed borked world loading
2023-12-06 14:41:19 +00:00
Dylan K. Taylor
25cca1b63f
Changes for 1.20.50
2023-12-06 14:29:23 +00:00
TheNewHEROBRINE
2420dee8be
AsyncTask: Fix retrieval of null data from the thread-local storage ( #6176 )
2023-12-06 13:40:09 +00:00
Dylan K. Taylor
b2df405cc0
NetworkSession: Send less information to clients on error disconnects
...
in particular, the information from VerifyLoginTask shouldn't be sent to clients, as it could contain sensitive information.
This change only affects disconnection screens. The server log shows the same amount of information as before (though formatted differently in some cases).
2023-11-29 16:31:59 +00:00
ace
d596dc571d
Fix pitcher pod wrongly registered as a block ( #6162 )
2023-11-27 14:46:20 +00:00
Dylan K. Taylor
a1748a92ca
Avoid unnecessary TypeConverter::getInstance() calls
...
we already have it available within these contexts
2023-11-17 14:00:25 +00:00
Dylan K. Taylor
fbcf4649eb
Avoid unnecessary Entity::getWorld() calls in loops
2023-11-17 13:58:41 +00:00
Dylan K. Taylor
0f620fad94
ChunkCache: inline unnecessary function
2023-11-17 13:30:44 +00:00
Dylan K. Taylor
67ad2bad17
World: fixed edge case that could lead to crash during block update sending
2023-11-17 13:24:06 +00:00
Dylan K. Taylor
bc07778434
Avoid unnecessary CompressBatchPromise allocations for sync-prepared batches
...
Sync-prepared batches account for the vast majority of outbound packets. Avoiding these useless objects further reduces the overhead of zero-compressed packets, as the creation of these objects is a significant part of the overhead for these cases.
closes #6157
2023-11-17 12:35:42 +00:00
Dylan K. Taylor
519784460f
Merge branch 'stable' into minor-next
2023-11-17 12:04:10 +00:00
Dylan K. Taylor
a25597ca30
Server: updated documentation for prepareBatch()
2023-11-17 12:01:19 +00:00
ace
89fbb3fd0d
Fix loading of Item Frame item rotation ( #6123 )
2023-11-16 10:16:29 +00:00
Dylan K. Taylor
e9c5846a06
World: simplify condition
2023-11-16 10:06:43 +00:00
Dylan K. Taylor
69f197dbec
PluginBase: fixed erroneous replacement
2023-11-14 13:04:14 +00:00
Dylan K. Taylor
13f34a500c
PluginBase: clean up inconsistent getter vs property access usages
2023-11-14 12:59:38 +00:00
Dylan K. Taylor
e5c96faa4b
Server: clean up inconsistent getter vs property access usages
2023-11-14 12:59:05 +00:00
Dylan K. Taylor
dd98e4aaed
block: clean up unnecessary getter usages
...
with the assistance of a custom phpstan rule
this inconsistent mess has been bothering me for a long time
2023-11-14 12:47:33 +00:00
Dylan K. Taylor
e525699dd4
TimeTrackingSleeperHandler: record time spent in each Snooze handler
2023-11-13 11:35:39 +00:00
Amir Muazzam
0ad6429fee
Fix RegistryTrait documentation ( #6153 )
2023-11-13 11:15:07 +00:00
Dylan K. Taylor
923c922960
Merge branch 'stable' into minor-next
2023-11-13 11:13:12 +00:00
Dylan K. Taylor
77590fb63a
Server: fixed prepareBatch() not being marked as internal
2023-11-13 11:12:12 +00:00
Dylan K. Taylor
58ea94bab8
...
2023-11-10 15:41:17 +00:00
Dylan K. Taylor
22b10e4cb0
Timings: Stop using BREAKDOWN group
...
with tree timings, the breakdown is actually pretty annoying, since it makes it hard to find a timer in the aggregate lists.
2023-11-10 15:36:35 +00:00
Dylan K. Taylor
c44758f36c
StringToItemParser: added pitcher_plant and pitcher_pod
...
it seems a bit weird to map pitcher_pod to PITCHER_CROP(). Perhaps this wasn't implemented correctly.
2023-11-10 15:26:02 +00:00
Dylan K. Taylor
b3766834c6
Merge branch 'stable' into minor-next
2023-11-09 19:02:08 +00:00
Dylan K. Taylor
93699024da
5.8.3 is next
2023-11-09 18:51:20 +00:00
Dylan K. Taylor
c3c81b09e8
Release 5.8.2
2023-11-09 18:51:17 +00:00
Dylan K. Taylor
9d75c45bf5
Merge branch 'minor-next' into major-next
2023-11-09 18:06:06 +00:00
Dylan K. Taylor
50592dc269
Merge branch 'stable' into minor-next
2023-11-09 18:05:38 +00:00
