Dylan K. Taylor
50a4c42f3f
NetworkBinaryStream: fix misplaced import
2019-12-09 19:53:32 +00:00
Dylan K. Taylor
6b61efcfc8
remove unused imports
2019-12-09 19:49:21 +00:00
Dylan K. Taylor
1a99938e4b
LegacySkinAdapter: clean up nonsensical code ordering
2019-12-09 18:26:20 +00:00
Dylan K. Taylor
a4d68fb32b
LegacySkinAdapter: fix some wacky cape handling logic
...
I added checks for length validity locally and ran into some interesting behaviour because of this code.
2019-12-09 18:16:46 +00:00
Dylan K. Taylor
5682cc8d53
3.10.2 is next
2019-12-07 16:41:41 +00:00
Dylan K. Taylor
4eb59c0372
Release 3.10.1
2019-12-07 16:41:41 +00:00
Dylan K. Taylor
3486db3f1b
update RakLib to 0.12.6
2019-12-07 14:20:35 +00:00
Dylan K. Taylor
733d530ed0
fixing EOF newlines on new files
2019-12-07 10:08:29 +00:00
Dylan K. Taylor
c10ce84035
fix invisible legacy skins which have empty geometry names
2019-12-07 10:02:22 +00:00
Dylan K. Taylor
82d9e481d2
3.10.1 is next
2019-12-06 20:53:15 +00:00
Dylan K. Taylor
d27c7f7141
Release 3.10.0
2019-12-06 20:53:15 +00:00
Dylan K. Taylor
394c999710
Merge branch 'drew-1.13' into stable
2019-12-06 20:38:49 +00:00
Dylan K. Taylor
6399dacba7
Release 3.9.8
2019-12-06 20:33:51 +00:00
Dylan K. Taylor
b6bbf655d7
InventoryTransactionPacket: fixed crafting flags being set on useless empty transactions
...
this fixes some misleading debug noise when getting stuff from creative inventory and triggers some different spam instead.
2019-12-06 20:08:09 +00:00
Dylan K. Taylor
3d2c018442
BiomeDefinitionListPacket: load pregenerated data from file
2019-12-06 11:32:33 +00:00
Dylan K. Taylor
da8c54cf8b
AvailableEntityIdentifiersPacket: load pregenerated data from file
2019-12-06 11:31:55 +00:00
Dylan K. Taylor
8e984a1bc3
RuntimeBlockMapping: use new data, item frames & doors fixed
...
floor & ceiling item frames not supported though
2019-12-06 11:31:18 +00:00
Dylan K. Taylor
124e60301a
updated submodule to pmmp/BedrockData@a38b427888
2019-12-06 11:26:58 +00:00
Dylan K. Taylor
4d13c48e5c
UPnP: COM constructor never returns false anymore
2019-12-05 16:07:06 +00:00
Dylan K. Taylor
9159e8f002
MainLogger: mark static logger field as nullable
2019-12-05 15:48:58 +00:00
Dylan K. Taylor
f5aa461945
GlobalConstants: assume we are on 64-bit when declaring INT32_MASK
...
fixes a FP reported by phpstan level 4
2019-12-05 15:48:11 +00:00
Dylan K. Taylor
16817ff301
Player: remove superfluous conditions for RESPAWN action handling
...
spawned is always true here because of the condition at the top of the function.
isOnline() is always true here because the handler won't even be called if it isn't.
2019-12-05 14:52:12 +00:00
Dylan K. Taylor
18863b1098
Player: remove superfluous check from processMovement()
...
if we reached this branch, revert is always false because it is not modified between this branch and the parent one.
detected by phpstan level 4
2019-12-05 14:47:15 +00:00
Dylan K. Taylor
e3cffca34b
StartGamePacket: fixed possible type violation on decoding block table
2019-12-05 11:05:34 +00:00
Dylan K. Taylor
d20d9fb689
Merge branch 'stable' into drew-1.13
2019-12-05 10:59:53 +00:00
Dylan K. Taylor
7b1ae2a822
phpstan: green on level 3
2019-12-04 22:12:14 +00:00
Dylan K. Taylor
8ecf5e02b9
bad fix for WritableBook phpstan warning
...
master has this shit so much better
2019-12-04 22:00:19 +00:00
Dylan K. Taylor
39c607cbd5
Position: mark level field as nullable
...
allowing the level to be null is, to be honest, a big design flaw, but one that can't be fixed without BC breaks.
2019-12-04 21:31:35 +00:00
Dylan K. Taylor
d867ffc60d
MetadataStore: fix some doc comments
2019-12-04 21:14:09 +00:00
Dylan K. Taylor
c57eb26fd5
phpstan-bugs: add some extra patterns for level 3 false positives
2019-12-04 19:50:15 +00:00
Dylan K. Taylor
c35d91a104
phpstan: allow blanket ignoreErrors in src to reduce merge work for master
2019-12-04 19:42:18 +00:00
Dylan K. Taylor
9fc260fb1a
keep phpstan.neon.dist ignoreErrors sorted by file
2019-12-04 19:38:54 +00:00
Dylan K. Taylor
73d0f799c2
Update to PHPStan 0.12.0
2019-12-04 10:29:49 +00:00
Dylan K. Taylor
ecb2e6e3af
PluginManager: remove useless information from softDepend debug
...
we don't report the parameter type anywhere else, and since PHP doesn't support overloading, we don't need to.
This fixes PHPStan 0.12 complaints about ReflectionNamedType. I figured this was the best solution instead of adding an extra few lines of code.
2019-12-04 10:17:25 +00:00
Dylan K. Taylor
7b75b6928d
AvailableCommandsPacket: fixed foreach docs
...
these probably aren't necessary at all to be honest.
2019-12-04 10:15:50 +00:00
Dylan K. Taylor
753a8a6937
Event: remove useless @var $this annotations
...
we are not in a trait here, the scope is always Event.
2019-12-04 10:15:04 +00:00
Dylan K. Taylor
bc76b1cafe
Server: remove several redundant @var annotations (copy pasta)
...
these are all useless because it is implied by the parameter type anyway.
2019-12-04 10:14:15 +00:00
Dylan K. Taylor
00e415fc79
move phpstan.neon to phpstan.neon.dist to allow phpstan.neon to be locally modified for development
2019-12-03 19:57:19 +00:00
Dylan K. Taylor
dbbe1f2d5c
Revert "Entity: remove redundant check from spawnTo()"
...
This reverts commit 3028832cd35c53937bb6502f74d3ad53646b12a7.
When I created this commit, I made the flawed assumption that spawnTo()
would not be used by plugins. In addition, I was not aware that there
are some usages of spawnTo() in the core which do not check for chunk
usage, such as in Player->showPlayer().
This caused a collection of problems including memory leaks and crashes
due to disconnecting players not removing their references from viewed
entities.
The reverted commit may be the cause of #3178 .
2019-12-03 10:41:13 +00:00
Dylan K. Taylor
740f0a2314
crafting now works on 1.13, but it's not good
2019-12-02 21:50:52 +00:00
Dylan K. Taylor
7fdfe947b0
inventory: fix some transactions being rejected for no good reason
...
since 1.13, transactions such as interacting with creative inventory cause a spoof windowID 124 slot 50 action to appear which changes air -> air. This currently gets rejected because only cursor is mapped to ID 124, and it only has a single slot.
It is not clear what the purpose of 124:50 is, but this fix filters out any actions which do not change anything, since they won't affect transaction balance anyway.
2019-12-02 21:41:08 +00:00
Dylan K. Taylor
b7c4379700
StartGamePacket: fixed asymmetry in block table handling
2019-12-02 19:35:55 +00:00
Dylan K. Taylor
20b7418916
PlayerAuthInputPacket: added encode & decode, and some aux classes
2019-12-02 15:14:59 +00:00
Dylan K. Taylor
85521f5e7a
EducationSettingsPacket: added encode & decode
2019-12-02 13:57:19 +00:00
Dylan K. Taylor
f37ea6a203
AvailableCommandsPacket: fix nonsensical placement of HARDCODED_ENUMS
2019-12-02 12:57:05 +00:00
Dylan K. Taylor
abf8081ebc
RuntimeBlockMapping: add a type check for decoded NBT root type
...
this is kinda redundant since this function can blow up in so many other ways anyway, but it makes PHPStan happy, so it'll do.
2019-12-02 08:21:42 +00:00
Dylan K. Taylor
8594cb3e74
AvailableCommandsPacket: fixed doc comment for putEnumConstraint()
2019-12-02 08:17:00 +00:00
Stephen
d155de35ed
Merge branch 'dktapps-drew-1.13' into stable
2019-12-01 22:03:03 -05:00
Stephen
e37c8e3a5d
Merge branch 'drew-1.13' of https://github.com/dktapps/PocketMine-MP into dktapps-drew-1.13
2019-12-01 22:02:40 -05:00
Stephen
e38c0c0fe1
Merge remote-tracking branch 'upstream/stable' into stable
2019-12-01 21:55:50 -05:00
