11607 Commits

Author SHA1 Message Date
Dylan K. Taylor
df8e0cf1f5 MemoryManager: eliminate unnecessary reference abuse in continueDump()
this makes the flow of data easier to understand, and also sidesteps some PHPStan bugs.
2020-02-05 17:06:05 +00:00
Dylan K. Taylor
ad87c11ae1 ThreadManager: use array-access instead of variable property access 2020-02-05 16:36:11 +00:00
Dylan K. Taylor
fa82cb26d8 added native types to closures (phpstan-strict-rules) 2020-02-05 16:35:10 +00:00
Dylan K. Taylor
fd2a7797bd include make-release.php in phpstan analysis 2020-02-05 15:55:41 +00:00
Dylan K. Taylor
e5a2cfb65f avoid type juggling in conditions, always use explicit boolean conditions 2020-02-05 15:44:06 +00:00
Dylan K. Taylor
b96bb7d824 Player: use strict base64_decode() for login decoding
though, perhaps we should beware of false returns?
2020-02-05 13:55:38 +00:00
Dylan K. Taylor
896cca0778 store composer cache for travis 2020-02-05 13:36:45 +00:00
Dylan K. Taylor
59cf8e95f0 Tree: fixed populator not growing trees any lower than y=2
this would only be a problem for custom generators, but nonetheless...
2020-02-05 13:17:09 +00:00
Dylan K. Taylor
99038c752c Avoid usage of for-loop vars outside of for-loop context
these problems were reported by PHPStan strict rules. They aren't actually bugs, but they could become bugs in the future.
2020-02-05 13:16:09 +00:00
Dylan K. Taylor
88afedd1e8 Human: avoid overwriting non-foreach vars in foreach 2020-02-05 12:59:59 +00:00
Dylan K. Taylor
c43e21235d HelpCommand: do not overwrite non-foreach vars in foreach 2020-02-05 12:57:27 +00:00
Dylan K. Taylor
3f7e7352fb added SplFixedArray generics for phpstan 0.12.9 2020-02-05 11:57:37 +00:00
Dylan K. Taylor
e1eb9186fe Merge branch 'stable' 2020-02-03 19:57:21 +00:00
Dylan K. Taylor
32d6ea0fba Chest: do not crash on failure to fetch pair, closes #2701
isPaired() returning true is not semantically equivalent to getPair() returning non-null. getPair() might return null if the pair is inaccessible, such as when it's in an unloaded chunk (it doesn't check this yet, but it should).
For the sake of opening inventory, we don't care if the chest believes if it is paired, we care if there is actually a pair to be accessed for inventory viewing.
In addition, it's possible to create this broken-data scenario artificially by close()ing a chest tile without unpairing it first, because a tile doesn't know the difference between being closed due to unload and being destroyed.
2020-02-03 19:32:58 +00:00
Dylan K. Taylor
28c787371a Server::$rcon may be null (disabled or failed to start) 2020-02-03 19:25:56 +00:00
Dylan K. Taylor
dba14c9f08 PharPluginLoader: remove useless instanceof, offset is always PharFileInfo at this point 2020-02-03 12:35:34 +00:00
Dylan K. Taylor
0e35ee8cb7 build/server-phar: drop unused imports 2020-02-03 11:18:21 +00:00
Dylan K. Taylor
da5b7f47df build/server-phar: import global functions 2020-02-03 11:17:51 +00:00
Dylan K. Taylor
d418dd7a09 build/make-release: fix formatting 2020-02-03 11:17:16 +00:00
Dylan K. Taylor
f3209ccc33 build/make-release: remove unused import 2020-02-03 11:16:51 +00:00
Dylan K. Taylor
4a4c28cd8c travis.sh: ditch PHP_BINARY variable, use PATH prefix instead
this is how normal people do it ...
2020-02-03 09:30:43 +00:00
Dylan K. Taylor
eba8d77034 3.11.6 is next 2020-02-02 18:31:51 +00:00
Dylan K. Taylor
13e4772f98 Release 3.11.5 3.11.5 2020-02-02 18:31:51 +00:00
Dylan K. Taylor
092933105a Merge branch 'stable' 2020-02-02 18:14:51 +00:00
Dylan K. Taylor
4bc2f28c6d Provide a ChunkUtils stub for PHPStan, so it doesn't get confused when the extension is loaded
for some reason the presence of the type problems were reported as
problems on ChunkUtils.php, despite being outside of the project scope
and the errors not applying to the polyfill.
2020-02-02 18:12:41 +00:00
Dylan K. Taylor
afeb9838e4 Merge branch 'stable' 2020-02-02 16:47:19 +00:00
Dylan K. Taylor
663469dfa7 travis: remove xdebug to improve build time
xdebug is almost completely useless here.
2020-02-02 16:30:00 +00:00
Dylan K. Taylor
963abb718f build/server-phar: compress using gzip (except stub)
this produces a 75% reduction in phar size, at the expense of a slight degradation of autoloading speed and needing a writable tmpdir.
2020-02-02 16:27:38 +00:00
Dylan K. Taylor
1f2fb73297 updated DevTools submodule to 1.14.0 2020-02-02 10:21:32 +00:00
Dylan K. Taylor
7cb363d6e7 Merge branch 'stable' 2020-02-01 23:00:07 +00:00
Dylan K. Taylor
1b50a2d8d4 updated composer dependencies 2020-02-01 22:59:52 +00:00
Dylan K. Taylor
ff55b520b9 updated composer dependencies 2020-02-01 22:55:27 +00:00
Dylan K. Taylor
3df9aaa916 Merge branch 'stable' 2020-02-01 22:19:34 +00:00
Dylan K. Taylor
cedd8abf0c README: no need to specify 'community' Discord [ci skip] 2020-02-01 22:19:24 +00:00
Dylan K. Taylor
80dc0eb8b8 rename BedrockData submodule 2020-02-01 22:14:53 +00:00
Dylan K. Taylor
d48597ec5d move BedrockData submodule to resources/ 2020-02-01 22:14:24 +00:00
Dylan K. Taylor
aad1a3400f Merge branch 'submodule-conflict-stable' into submodule-conflict-master 2020-02-01 22:13:43 +00:00
Dylan K. Taylor
496732999c reintroduce BedrockData submodule 2020-02-01 22:05:07 +00:00
Dylan K. Taylor
fed03fd535 Merge branch 'submodule-conflict-stable' into submodule-conflict-master 2020-02-01 22:02:44 +00:00
Dylan K. Taylor
6a8105f5a0 delete BedrockData submodule 2020-02-01 22:01:22 +00:00
Dylan K. Taylor
e3833ba4f0 Merge branch 'stable' 2020-02-01 21:03:21 +00:00
Dylan K. Taylor
b59dc1ef16 Merge commit 'b11c350b2b0b0cd38114e4240e056c3aa2028707'
# Conflicts:
#	composer.json
#	composer.lock
#	resources/vanilla
2020-02-01 21:00:03 +00:00
Dylan K. Taylor
c19b21db91 Merge commit 'f624e36faf2214fef76ad3b7148c17f7f7ff641f' 2020-02-01 20:59:23 +00:00
Dylan K. Taylor
e8f31adc02 Merge commit '14ce9c10bb0895974008d415a3fb66ead1ab2361' 2020-02-01 20:55:31 +00:00
Dylan K. Taylor
54604398f2 Merge commit 'f1083bd9c402c1456f4fc7dce8271c33360dc227' 2020-02-01 20:54:54 +00:00
Dylan K. Taylor
38b7a9b76b Merge commit '199fa61aef50ee731bbf08e23616b6087e267992' 2020-02-01 20:54:27 +00:00
Dylan K. Taylor
356ed5f1de DyeColor: fix PHP 7.2 compatibility 2020-02-01 20:50:16 +00:00
Dylan K. Taylor
f02f45f248 Merge commit 'af82a6bbe1e4c37564ce1e0932a8177d31750b7d' 2020-02-01 20:45:16 +00:00
Dylan K. Taylor
269066b2d0 added unit test for Enum lazy initialization 2020-02-01 20:42:04 +00:00
Dylan K. Taylor
9c33ea8dd1 EnumTrait: use a better method to initialize enums
this method is simpler, and is also safe at the native type level.
Coincidentally, it also eliminates 30 PHPStan false-positives.
2020-02-01 20:33:30 +00:00