mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-15 10:19:39 +00:00
Code Issues Projects Releases Wiki Activity
11,607 Commits 16 Branches 439 Tags
Commit Graph

11607 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dylan K. Taylor
f713cf25b1 travis: update leveldb version, only build sharedlibs targets on travis 2020-02-07 13:54:22 +00:00
Dylan K. Taylor
ada8cbb545 phpstan: drop some ignoreErrors that don't occur on 0.12.9 2020-02-06 21:01:05 +00:00
Dylan K. Taylor
0ac5e03ce9 Require PHPStan 0.12.9 minimum 2020-02-06 20:59:43 +00:00
Dylan K. Taylor
9b02b8e51e Item: do not compare serialized NBT in equals() 
this isn't cached anymore, and would be a performance drag.
It would be nice to have some kind of fast path for this, but comparing NBT binary isn't it.
 2020-02-06 20:23:58 +00:00
Dylan K. Taylor
6c7dada232 finally, integrate phpstan-strict-rules 2020-02-06 19:44:10 +00:00
Dylan K. Taylor
25bc95cd1e removing more unnecessary casts 2020-02-06 19:33:34 +00:00
Dylan K. Taylor
213bf8366a TranslationContainer: fix parameter type of setParameters() 2020-02-06 19:33:34 +00:00
Dylan K. Taylor
4e693e91e6 ChestInventory: document that getHolder() may return Position 
there is a variance issue with EnderChestInventory that was detected by phpstan-strict-rules which can't be addressed without a BC break. This fix will at least allow static analysers to be aware that code using this function might catch fire when it sees an EnderChestInventory without realizing it.
 2020-02-06 19:33:34 +00:00
Dylan K. Taylor
a1622fa345 UtilsTest: silence a phpstan-strict-rules warning 2020-02-06 18:53:05 +00:00
Dylan K. Taylor
0ec869932f Item: clean up internal NBT storage, discard useless legacy network cache 
this will now bail if the NBT string given is invalid upon setCompoundTag(), rather than shitting the bed when it's accessed.
 2020-02-06 17:59:05 +00:00
Dylan K. Taylor
79acaa3253 Utils: remove useless typecasts 2020-02-06 16:06:58 +00:00
Dylan K. Taylor
da3742b39e Remove useless typecasts 2020-02-06 16:00:57 +00:00
Dylan K. Taylor
d26fcf7dee Removed useless casts() from min/max calls 2020-02-06 15:58:27 +00:00
Dylan K. Taylor
812424a619 GroundCover: drop useless variable in calculating startY 2020-02-06 14:26:03 +00:00
Dylan K. Taylor
1bdc61dd5f Ore: do not destroy outer scope vars in for loops 2020-02-06 14:24:57 +00:00
Dylan K. Taylor
86fc33fe26 Level: add phpstan generics to getNearestEntity() 2020-02-06 14:20:19 +00:00
Dylan K. Taylor
70eb41470c ContainerInventory: remove redundant check 2020-02-06 14:19:33 +00:00
Dylan K. Taylor
3a5709bf5e start using phpstan-phpunit 
not using extension-installer because I want to part-integrate phpstan-strict-rules later on.
 2020-02-06 13:23:18 +00:00
Dylan K. Taylor
5ad66c3c9b BlockTest: throw exception instead of always-false assert 2020-02-06 13:21:39 +00:00
Dylan K. Taylor
7885b54824 phpstan: run static analysis on tests 2020-02-06 13:13:12 +00:00
Dylan K. Taylor
532dc0fb6f tests/phpunit: populate iterable types for phpstan 2020-02-06 13:11:56 +00:00
dependabot-preview[bot]
54ccc330d5
Bump irstea/phpunit-shim from 7.5.20 to 8.5.2 (#3296) 2020-02-06 12:50:51 +00:00
Dylan K. Taylor
e12618c705 tests/phpunit: added missing native typehints 2020-02-06 12:13:42 +00:00
Dylan K. Taylor
7d5f2eac8d Merge branch 'stable' of https://github.com/pmmp/pocketmine-mp into stable 2020-02-06 08:38:12 +00:00
Dylan K. Taylor
e964dd2ca8 travis: cache composer vcs directory too 2020-02-06 08:37:38 +00:00
Dylan T
dbb594f130
Merge pull request #3297 from pmmp/dependabot/composer/adhocore/json-comment-0.1.0 
Bump adhocore/json-comment from 0.0.7 to 0.1.0
 2020-02-05 22:47:04 +00:00
dependabot-preview[bot]
8f434b9edd
Bump adhocore/json-comment from 0.0.7 to 0.1.0 
Bumps [adhocore/json-comment](https://github.com/adhocore/php-json-comment) from 0.0.7 to 0.1.0.
- [Release notes](https://github.com/adhocore/php-json-comment/releases)
- [Changelog](https://github.com/adhocore/php-json-comment/blob/master/CHANGELOG.md)
- [Commits](https://github.com/adhocore/php-json-comment/compare/v0.0.7...0.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-02-05 22:40:41 +00:00
Dylan K. Taylor
34972c3327 Assume that getmypid() never returns false 
my background research on this informs me that this returns false on negative PID, which never happens because the underlying C API call never fails - not on linux, bsd, or windows.
 2020-02-05 21:00:56 +00:00
Dylan K. Taylor
037c34d961 Living: fixed bad @var confusing PHPStan 2020-02-05 20:58:38 +00:00
Dylan K. Taylor
4518d9d9ce Item: drop useless @var confusing PHPStan 2020-02-05 20:55:58 +00:00
Dylan K. Taylor
1a5228e7a6 Fixed property types with missing null PhpDoc types 2020-02-05 20:55:03 +00:00
Dylan K. Taylor
495bfda044 Drop a bunch of invalid null defaults 
phpstan doesn't report these out of the box, for reasons I'm not clear on. It's also not clear if having null defaults has any effect on nullability behaviour, so they are best removed. In addition, these would be problematic on 7.4.
 2020-02-05 20:53:54 +00:00
Dylan K. Taylor
41b1fa7b48 Config: clean up inconsistent data parsing & handling 2020-02-05 20:50:36 +00:00
Dylan K. Taylor
e689fd545b PocketMine.php: avoid use of short ternary 2020-02-05 20:48:54 +00:00
Dylan K. Taylor
889cd5e206 PlayerNetworkSessionAdapter: clean up leftovers from multi quote support for json decode 2020-02-05 20:45:13 +00:00
Dylan K. Taylor
e1ddf90695 Chunk: remove useless instanceof checks 
these are always CompoundTags, and if they aren't we have a bug somewhere else.
 2020-02-05 20:44:27 +00:00
Dylan K. Taylor
2f325b8c91 Permission: loadPermission() never returns null 2020-02-05 20:43:40 +00:00
Dylan K. Taylor
ac4f00be81 PluginManager: combine conditions into something less useless 
the left side was already implying that the var is a Plugin instance, but PHPStan doesn't like non-bool conditions in strict mode.
 2020-02-05 20:42:40 +00:00
Dylan K. Taylor
914450c30b Entity: remove useless assert() 
namedtag is always non-null here, and if it isn't, it should just catch fire the normal way.
 2020-02-05 20:40:34 +00:00
Dylan K. Taylor
25554f0d61 Level: remove useless code from unload() 2020-02-05 20:39:38 +00:00
Dylan K. Taylor
e1a61cb51a BaseLang: get() never returns null 2020-02-05 20:38:45 +00:00
Dylan K. Taylor
fe5620f097 ThreadManager: Lazy-init during getInstance() 2020-02-05 20:36:44 +00:00
Dylan K. Taylor
faef4e8736 SimpleCommandMap: Command->getLabel() never returns null 2020-02-05 20:33:27 +00:00
Dylan K. Taylor
0d19f6c968 Server: initialize auto updater before loading plugins, not after 
from a plugin PoV, getUpdater() is always supposed to return an AutoUpdater instance, but it would return null during onLoad(), which is bad.
 2020-02-05 20:32:51 +00:00
Dylan K. Taylor
ecf662bf74 Server: Lazy-init static sleeper as-needed 
this makes it testable without a server context.
 2020-02-05 20:31:01 +00:00
Dylan K. Taylor
8cba2e0346 Server: fixed wrong non-nullability of queryHandler 2020-02-05 19:56:16 +00:00
Dylan K. Taylor
dfc8a6ffdd Player: remove useless code from save() 2020-02-05 19:54:50 +00:00
Dylan K. Taylor
262728b091 PopulationTask: clean up overcomplicated garbage 2020-02-05 18:31:51 +00:00
Dylan K. Taylor
4572ec8175 travis: run composer with --prefer-dist 2020-02-05 17:14:11 +00:00
Dylan K. Taylor
0f6949ac34 phpstan 0.12.9 2020-02-05 17:11:08 +00:00