2f325b8c91
Permission: loadPermission() never returns null
2020-02-05 20:43:40 +00:00
ac4f00be81
PluginManager: combine conditions into something less useless
...
the left side was already implying that the var is a Plugin instance, but PHPStan doesn't like non-bool conditions in strict mode.
2020-02-05 20:42:40 +00:00
914450c30b
Entity: remove useless assert()
...
namedtag is always non-null here, and if it isn't, it should just catch fire the normal way.
2020-02-05 20:40:34 +00:00
25554f0d61
Level: remove useless code from unload()
2020-02-05 20:39:38 +00:00
e1a61cb51a
BaseLang: get() never returns null
2020-02-05 20:38:45 +00:00
fe5620f097
ThreadManager: Lazy-init during getInstance()
2020-02-05 20:36:44 +00:00
faef4e8736
SimpleCommandMap: Command->getLabel() never returns null
2020-02-05 20:33:27 +00:00
0d19f6c968
Server: initialize auto updater before loading plugins, not after
...
from a plugin PoV, getUpdater() is always supposed to return an AutoUpdater instance, but it would return null during onLoad(), which is bad.
2020-02-05 20:32:51 +00:00
ecf662bf74
Server: Lazy-init static sleeper as-needed
...
this makes it testable without a server context.
2020-02-05 20:31:01 +00:00
8cba2e0346
Server: fixed wrong non-nullability of queryHandler
2020-02-05 19:56:16 +00:00
dfc8a6ffdd
Player: remove useless code from save()
2020-02-05 19:54:50 +00:00
262728b091
PopulationTask: clean up overcomplicated garbage
2020-02-05 18:31:51 +00:00
4572ec8175
travis: run composer with --prefer-dist
2020-02-05 17:14:11 +00:00
0f6949ac34
phpstan 0.12.9
2020-02-05 17:11:08 +00:00
df8e0cf1f5
MemoryManager: eliminate unnecessary reference abuse in continueDump()
...
this makes the flow of data easier to understand, and also sidesteps some PHPStan bugs.
2020-02-05 17:06:05 +00:00
ad87c11ae1
ThreadManager: use array-access instead of variable property access
2020-02-05 16:36:11 +00:00
fa82cb26d8
added native types to closures (phpstan-strict-rules)
2020-02-05 16:35:10 +00:00
fd2a7797bd
include make-release.php in phpstan analysis
2020-02-05 15:55:41 +00:00
e5a2cfb65f
avoid type juggling in conditions, always use explicit boolean conditions
2020-02-05 15:44:06 +00:00
b96bb7d824
Player: use strict base64_decode() for login decoding
...
though, perhaps we should beware of false returns?
2020-02-05 13:55:38 +00:00
896cca0778
store composer cache for travis
2020-02-05 13:36:45 +00:00
59cf8e95f0
Tree: fixed populator not growing trees any lower than y=2
...
this would only be a problem for custom generators, but nonetheless...
2020-02-05 13:17:09 +00:00
99038c752c
Avoid usage of for-loop vars outside of for-loop context
...
these problems were reported by PHPStan strict rules. They aren't actually bugs, but they could become bugs in the future.
2020-02-05 13:16:09 +00:00
88afedd1e8
Human: avoid overwriting non-foreach vars in foreach
2020-02-05 12:59:59 +00:00
c43e21235d
HelpCommand: do not overwrite non-foreach vars in foreach
2020-02-05 12:57:27 +00:00
3f7e7352fb
added SplFixedArray generics for phpstan 0.12.9
2020-02-05 11:57:37 +00:00
32d6ea0fba
Chest: do not crash on failure to fetch pair, closes #2701
...
isPaired() returning true is not semantically equivalent to getPair() returning non-null. getPair() might return null if the pair is inaccessible, such as when it's in an unloaded chunk (it doesn't check this yet, but it should).
For the sake of opening inventory, we don't care if the chest believes if it is paired, we care if there is actually a pair to be accessed for inventory viewing.
In addition, it's possible to create this broken-data scenario artificially by close()ing a chest tile without unpairing it first, because a tile doesn't know the difference between being closed due to unload and being destroyed.
2020-02-03 19:32:58 +00:00
28c787371a
Server::$rcon may be null (disabled or failed to start)
2020-02-03 19:25:56 +00:00
dba14c9f08
PharPluginLoader: remove useless instanceof, offset is always PharFileInfo at this point
2020-02-03 12:35:34 +00:00
0e35ee8cb7
build/server-phar: drop unused imports
2020-02-03 11:18:21 +00:00
da5b7f47df
build/server-phar: import global functions
2020-02-03 11:17:51 +00:00
d418dd7a09
build/make-release: fix formatting
2020-02-03 11:17:16 +00:00
f3209ccc33
build/make-release: remove unused import
2020-02-03 11:16:51 +00:00
4a4c28cd8c
travis.sh: ditch PHP_BINARY variable, use PATH prefix instead
...
this is how normal people do it ...
2020-02-03 09:30:43 +00:00
eba8d77034
3.11.6 is next
2020-02-02 18:31:51 +00:00
13e4772f98
Release 3.11.5
2020-02-02 18:31:51 +00:00
4bc2f28c6d
Provide a ChunkUtils stub for PHPStan, so it doesn't get confused when the extension is loaded
...
for some reason the presence of the type problems were reported as
problems on ChunkUtils.php, despite being outside of the project scope
and the errors not applying to the polyfill.
2020-02-02 18:12:41 +00:00
663469dfa7
travis: remove xdebug to improve build time
...
xdebug is almost completely useless here.
2020-02-02 16:30:00 +00:00
963abb718f
build/server-phar: compress using gzip (except stub)
...
this produces a 75% reduction in phar size, at the expense of a slight degradation of autoloading speed and needing a writable tmpdir.
2020-02-02 16:27:38 +00:00
1f2fb73297
updated DevTools submodule to 1.14.0
2020-02-02 10:21:32 +00:00
ff55b520b9
updated composer dependencies
2020-02-01 22:55:27 +00:00
cedd8abf0c
README: no need to specify 'community' Discord [ci skip]
2020-02-01 22:19:24 +00:00
496732999c
reintroduce BedrockData submodule
2020-02-01 22:05:07 +00:00
6a8105f5a0
delete BedrockData submodule
2020-02-01 22:01:22 +00:00
0a566f8218
LevelProvider::generate() accepts class-string<Generator>, not any
...
string
2020-02-01 20:16:05 +00:00
829dd02eea
Server: fixed more bad non-nullable phpdocs
2020-02-01 19:30:47 +00:00
b11c350b2b
composer: use new pocketmine/log & pocketmine/classloader classes
2020-01-31 15:51:26 +00:00
f624e36faf
composer: all of these packages are now available on packagist
2020-01-31 15:49:33 +00:00
14ce9c10bb
BUILDING.md: fix typo
2020-01-31 13:27:29 +00:00
b27aaaeeb2
added build instructions, close #2839
2020-01-31 11:32:28 +00:00
