Dylan K. Taylor
1370930ea9
Entity: remove redundant defaults from lastX lastY lastZ, remove nullability
...
these fields are never null because they are initialized in the constructor, and they are never written to with null nor ever expected to be null.
2019-12-12 16:14:30 +00:00
Dylan K. Taylor
70c3008b7b
phpstan: green on level 4
2019-12-12 13:00:57 +00:00
Dylan K. Taylor
46930b98b7
Timings: add a dedicated field for checking initialization
2019-12-12 12:59:01 +00:00
Dylan K. Taylor
92be8c8ec0
PopulationTask: don't assume anything about TLS return values
...
while these SHOULD be what we say they are, it's possible for something else to overwrite them with junk and make the server catch fire.
2019-12-12 12:19:54 +00:00
Dylan K. Taylor
62069bc7af
Level: fix return type content doc comment for getAdjacentChunks()
2019-12-12 12:18:35 +00:00
Dylan K. Taylor
26230c1f9b
Player: don't report never-played for a disconnected player
...
this should catch fire like everything else does.
2019-12-12 12:17:52 +00:00
Dylan K. Taylor
a9fafbc5eb
BanEntry: remove nullable return from parseDate()
...
this function never returns null
2019-12-12 11:59:41 +00:00
Dylan K. Taylor
b8778cb791
LevelProvider: fix doc comment of ::generate()
...
this raised false positives on phpstan level 4
2019-12-12 11:59:12 +00:00
Dylan K. Taylor
73c5fe5cf9
BaseInventory: correctly annotate content type of slots field
...
fixes warnings on phpstan level 4
2019-12-12 11:58:11 +00:00
Dylan K. Taylor
b3cfa5a3a0
TimingsHandler: use weak comparison for stopTiming start check
...
this could be an int or float, and 0 !== 0.0.
2019-12-12 11:48:34 +00:00
Dylan K. Taylor
6127a02a8b
phpstan 0.12.2
2019-12-12 10:43:45 +00:00
Dylan K. Taylor
dbca36e5e2
SkinImage: throw on wrong data length
2019-12-11 22:45:14 +00:00
Dylan K. Taylor
1171bae691
login: read the correct key SkinAnimationData
2019-12-11 22:40:05 +00:00
Dylan K. Taylor
494f8e8251
login: fixed missing base64_decode() for animation images
2019-12-11 22:39:40 +00:00
Dylan K. Taylor
3c9af56e06
3.11.2 is next
2019-12-11 20:20:26 +00:00
Dylan K. Taylor
40a2211a5a
Release 3.11.1
3.11.1
2019-12-11 20:20:26 +00:00
Dylan K. Taylor
0196aa21d7
updated BedrockData submodule, close #3222 , close #3223
2019-12-11 20:19:17 +00:00
Dylan K. Taylor
833f3e574b
3.11.1 is next
2019-12-11 18:35:03 +00:00
Dylan K. Taylor
a386ff8ce7
Release 3.11.0
3.11.0
2019-12-11 18:35:03 +00:00
Dylan K. Taylor
e6c3b0fc0d
Changes for 1.14
...
there are no protocol changes in 1.14 that matter; the reason the protocol version has been bumped is because of new blocks, items, mobs and recipes.
2019-12-11 18:32:22 +00:00
Dylan K. Taylor
9568364277
fix minor formatting issue in SkinAdapterSingleton
2019-12-09 21:19:15 +00:00
Dylan K. Taylor
73d4ff6b52
more missed function imports
2019-12-09 21:16:35 +00:00
Dylan K. Taylor
7e98aa1497
leveldb: remove usage of multi-import statement
...
this doesn't conform to the code style.
2019-12-09 20:28:02 +00:00
Dylan K. Taylor
f00c69c513
added missing function imports
2019-12-09 20:13:02 +00:00
Dylan K. Taylor
50a4c42f3f
NetworkBinaryStream: fix misplaced import
2019-12-09 19:53:32 +00:00
Dylan K. Taylor
6b61efcfc8
remove unused imports
2019-12-09 19:49:21 +00:00
Dylan K. Taylor
1a99938e4b
LegacySkinAdapter: clean up nonsensical code ordering
2019-12-09 18:26:20 +00:00
Dylan K. Taylor
a4d68fb32b
LegacySkinAdapter: fix some wacky cape handling logic
...
I added checks for length validity locally and ran into some interesting behaviour because of this code.
2019-12-09 18:16:46 +00:00
Dylan K. Taylor
5682cc8d53
3.10.2 is next
2019-12-07 16:41:41 +00:00
Dylan K. Taylor
4eb59c0372
Release 3.10.1
3.10.1
2019-12-07 16:41:41 +00:00
Dylan K. Taylor
3486db3f1b
update RakLib to 0.12.6
2019-12-07 14:20:35 +00:00
Dylan K. Taylor
733d530ed0
fixing EOF newlines on new files
2019-12-07 10:08:29 +00:00
Dylan K. Taylor
c10ce84035
fix invisible legacy skins which have empty geometry names
2019-12-07 10:02:22 +00:00
Dylan K. Taylor
82d9e481d2
3.10.1 is next
2019-12-06 20:53:15 +00:00
Dylan K. Taylor
d27c7f7141
Release 3.10.0
3.10.0
2019-12-06 20:53:15 +00:00
Dylan K. Taylor
394c999710
Merge branch 'drew-1.13' into stable
2019-12-06 20:38:49 +00:00
Dylan K. Taylor
6399dacba7
Release 3.9.8
3.9.8
2019-12-06 20:33:51 +00:00
Dylan K. Taylor
b6bbf655d7
InventoryTransactionPacket: fixed crafting flags being set on useless empty transactions
...
this fixes some misleading debug noise when getting stuff from creative inventory and triggers some different spam instead.
2019-12-06 20:08:09 +00:00
Dylan K. Taylor
3d2c018442
BiomeDefinitionListPacket: load pregenerated data from file
2019-12-06 11:32:33 +00:00
Dylan K. Taylor
da8c54cf8b
AvailableEntityIdentifiersPacket: load pregenerated data from file
2019-12-06 11:31:55 +00:00
Dylan K. Taylor
8e984a1bc3
RuntimeBlockMapping: use new data, item frames & doors fixed
...
floor & ceiling item frames not supported though
2019-12-06 11:31:18 +00:00
Dylan K. Taylor
124e60301a
updated submodule to pmmp/BedrockData@a38b427888
2019-12-06 11:26:58 +00:00
Dylan K. Taylor
4d13c48e5c
UPnP: COM constructor never returns false anymore
2019-12-05 16:07:06 +00:00
Dylan K. Taylor
9159e8f002
MainLogger: mark static logger field as nullable
2019-12-05 15:48:58 +00:00
Dylan K. Taylor
f5aa461945
GlobalConstants: assume we are on 64-bit when declaring INT32_MASK
...
fixes a FP reported by phpstan level 4
2019-12-05 15:48:11 +00:00
Dylan K. Taylor
16817ff301
Player: remove superfluous conditions for RESPAWN action handling
...
spawned is always true here because of the condition at the top of the function.
isOnline() is always true here because the handler won't even be called if it isn't.
2019-12-05 14:52:12 +00:00
Dylan K. Taylor
18863b1098
Player: remove superfluous check from processMovement()
...
if we reached this branch, revert is always false because it is not modified between this branch and the parent one.
detected by phpstan level 4
2019-12-05 14:47:15 +00:00
Dylan K. Taylor
e3cffca34b
StartGamePacket: fixed possible type violation on decoding block table
2019-12-05 11:05:34 +00:00
Dylan K. Taylor
d20d9fb689
Merge branch 'stable' into drew-1.13
2019-12-05 10:59:53 +00:00
Dylan K. Taylor
7b1ae2a822
phpstan: green on level 3
2019-12-04 22:12:14 +00:00