109673382d
Implemented modifiers for crop growth speed
...
closes #6070
there are some unresolved questions about the growth speed of beetroots, pitcher plants and torchflower crops, but that's a topic for another commit.
this change also doesn't account for the light levels.
2023-11-02 15:16:11 +00:00
1e4a1565bb
Stem: fixed not attaching to grown pumpkin/melon
...
no idea how this got missed ...
2023-11-02 14:48:45 +00:00
8aaa6dd176
Stem: do not disable ticking when the stem is not attached to a pumpkin
...
fixes #6131
2023-11-02 14:47:55 +00:00
07dff9c9e8
5.8.2 is next
2023-11-01 17:55:23 +00:00
75a39491be
Release 5.8.1
2023-11-01 17:55:22 +00:00
a10e4b6481
Merge branch 'minor-next' into stable
2023-11-01 17:51:52 +00:00
68c6b87678
5.8.1 is next
2023-11-01 17:49:56 +00:00
e20c031aa1
Release 5.8.0
2023-11-01 17:49:53 +00:00
9832fe899f
Merge branch 'stable' into minor-next
2023-11-01 16:39:44 +00:00
55f3477ed9
5.7.2 is next
2023-11-01 16:37:46 +00:00
2c17f82eb8
Release 5.7.1
2023-11-01 16:37:46 +00:00
e6e2c54ec9
Fixed various reentrant-unsafe 2D array element unsets (similar to previous commit)
...
this pattern was used in various places
2023-11-01 16:28:59 +00:00
abce512860
Merge branch 'stable' of github.com:pmmp/PocketMine-MP into stable
2023-11-01 16:13:44 +00:00
0093732d49
PermissionManager: fixed non-reentrant-safe permission unsubscribing
...
during unset(), the destructors for other objects with cyclic references can get triggered, resulting in the functions being reentered before the count() call. This leads to a crash because the offset no longer exists.
Instead, we check if only the given PermissibleInternal is present, and clean everything up with a single unset instead of two.
This could also have been solved by adding extra isset() checks before checking the counts, but this way seemed more elegant.
This is similar to an issue with AsyncTask thread-local storage a few months ago, which was also caused by GC reentrancy.
closes #6119
2023-11-01 16:13:28 +00:00
9eb2a46942
World: remove useless isChunkLoaded checks
...
getChunkEntities() will return an empty array if the chunk isn't loaded anyway, so this is just wasting CPU cycles.
2023-11-01 15:53:37 +00:00
1402571055
Bump phpstan/phpstan from 1.10.39 to 1.10.40 ( #6126 )
...
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan ) from 1.10.39 to 1.10.40.
- [Release notes](https://github.com/phpstan/phpstan/releases )
- [Changelog](https://github.com/phpstan/phpstan/blob/1.11.x/CHANGELOG.md )
- [Commits](https://github.com/phpstan/phpstan/compare/1.10.39...1.10.40 )
---
updated-dependencies:
- dependency-name: phpstan/phpstan
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-01 15:26:46 +00:00
34bb86d2bf
Bump phpstan/phpstan-strict-rules from 1.5.1 to 1.5.2 ( #6125 )
...
Bumps [phpstan/phpstan-strict-rules](https://github.com/phpstan/phpstan-strict-rules ) from 1.5.1 to 1.5.2.
- [Release notes](https://github.com/phpstan/phpstan-strict-rules/releases )
- [Commits](https://github.com/phpstan/phpstan-strict-rules/compare/1.5.1...1.5.2 )
---
updated-dependencies:
- dependency-name: phpstan/phpstan-strict-rules
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-01 15:26:30 +00:00
b41960dfec
Merge branch 'stable' into minor-next
2023-10-26 12:55:47 +01:00
0b2fc84827
5.7.1 is next
2023-10-26 12:51:45 +01:00
22b9e70372
Release 5.7.0
2023-10-26 12:51:45 +01:00
a222636476
Merge branch 'legacy/pm4' into stable
2023-10-26 12:47:19 +01:00
fb586cc562
4.25.1 is next
2023-10-26 12:43:16 +01:00
f3f22ba48b
Release 4.25.0
2023-10-26 12:43:16 +01:00
a2e6e2e5b9
Update PHPStan
2023-10-26 12:39:45 +01:00
1aaaadb909
1.20.40 changes (PM4)
2023-10-26 12:36:12 +01:00
53a740433f
Changes for 1.20.40
2023-10-26 12:32:59 +01:00
8491d3c6c0
Merge branch 'stable' into minor-next
2023-10-24 11:56:51 +01:00
d637370b83
Wipe internal block AABB cache only for specific blocks that need it
...
the vast majority of blocks don't need this cache erasing, so it's costing performance for no good reason.
2023-10-23 17:38:04 +01:00
f655eda3b3
Player: bypass slow function call
...
for some reason the isSpectator() call here can take upwards of 2 microseconds, for no obvious reason. Subsequent calls are much faster, so I think there's some weird cache thing going on here.
2023-10-23 16:05:13 +01:00
af432c1a7f
Give neighbour block updates its own timer
...
this way we aren't conflating them with scheduled updates, which are usually caused by e.g. water
2023-10-23 12:33:36 +01:00
9fcc9f4338
StringToItemParser: added missing blocks
...
closes #6108
2023-10-23 12:24:02 +01:00
41c5f63565
World: remove dead code
2023-10-23 12:17:41 +01:00
73b1fba53c
Fixed Promise<null> calling rejection handler given after being successfully resolved
...
closes #6110
this is a weird use case, but it should work nonetheless.
2023-10-23 11:46:08 +01:00
8e17aed4f4
Fix build
2023-10-20 17:43:04 +01:00
1f461977d4
Block: Avoid useless Vector3 allocations in getHorizontalSides and getAllSides
2023-10-20 17:28:19 +01:00
e4888d7102
ÂCONTRIBUTING.md: restructure, reword and reorganize
...
[ci skip]
2023-10-20 12:12:14 +01:00
450ad42202
Added some new recommendations to CONTRIBUTING.md
2023-10-20 11:37:58 +01:00
eb935ca80f
ÂLeaves: use a constant for max distance from wood
2023-10-20 11:20:30 +01:00
1c5d3b43be
5.6.2 is next
2023-10-20 10:30:50 +01:00
decc188302
Release 5.6.1
2023-10-20 10:30:50 +01:00
8fa5c7cdab
World: do not apply fake state properties from tile if the block doesn't expect this tile type
...
This was causing a variety of crashes due to incorrect tiles, presumably from PM3 worlds.
2023-10-20 10:28:46 +01:00
7dd3a70d2e
Revert "World: discard tiles on load if they aren't the correct type or no tile is expected"
...
This reverts commit 8f804f6f34
2023-10-20 10:16:49 +01:00
dbb5a32a96
Liquid: eliminate unnecessary Position allocations and getSide() calls
2023-10-19 17:09:13 +01:00
9474324f75
Liquid: simplify code
2023-10-19 17:02:40 +01:00
ada37899aa
Liquid: improve code legibility and fix a bunch of PHPStan errors
2023-10-19 17:02:22 +01:00
f1440324a7
Update PHPStan baselines
2023-10-19 16:56:15 +01:00
73659318f6
World: Avoid unnecessary Vector3 usages in neighbour block update scheduling
...
The old code was allocating 6 Vector3s which were all immediately discarded. In addition, we didn't need to take the performance hit of reading Vector3 properties when we could have just passed integers directly.
The real performance difference of this is likely to be close to zero, but it's still worth doing.
2023-10-19 16:46:52 +01:00
f868c1d8c6
Liquid: Update legacy code with Facing::OFFSET
2023-10-19 16:38:34 +01:00
114f444ec3
Update PHPStan baseline
2023-10-19 13:28:40 +01:00
19a1792184
Fixed behavioural change on invalid Facing introduced by previous commit
...
while this shouldn't be given invalid facings anyway, Vector3::getSide() accepts them and just returns itself.
2023-10-19 13:27:44 +01:00
