Dylan K. Taylor
5f9e0081fd
Fixed mushroom block silk-touch drops and block picking behaviour
...
fixes #5284
2023-03-15 16:36:35 +00:00
Dylan K. Taylor
edb8f19a0c
Merge branch 'stable' into next-minor
2023-01-16 19:56:38 +00:00
Dylan K. Taylor
6c0254c1eb
Block: document parameters of place()
2023-01-16 19:49:24 +00:00
Dylan K. Taylor
a9f06fc5f4
Replaced hardcoded record.nowPlaying with KnownTranslationKeys
2023-01-13 17:27:57 +00:00
Dylan K. Taylor
39218017ca
Fixed walls and thin blocks not connecting to each other
...
closes #5498
2023-01-12 22:16:41 +00:00
Dylan K. Taylor
91ac47ecba
Merge branch 'stable' into next-minor
2023-01-12 21:47:37 +00:00
Dylan K. Taylor
f4a1d69075
Bell: fixed support requirements
...
this somehow got overlooked in the support types refactor.
2023-01-12 21:45:25 +00:00
Dylan K. Taylor
cbeae906e1
Torch: remove unused variable
2023-01-12 21:34:44 +00:00
Dylan K. Taylor
b25e8e26f0
BaseBanner: fixed incorrect support requirements
2023-01-12 21:31:50 +00:00
Dylan K. Taylor
a79be994de
World: fixed block placement when clicking on replaceable blocks
...
in vanilla, it appears to behave as if the player always clicked on the up face if a block was replaced.
In PM, we were still using the original face, which caused bugs when, for example, placing a button next to a wall by clicking on the side of tallgrass. The button would replace the tallgrass, but stick to the wall, instead of placing itself on the ground like vanilla expects.
This may appear unusual to anyone who also happens to implement canBePlacedAt(), since the facing behaviour will be different. However, this behaviour appears to match vanilla, and even slabs (which I feared might break because of this change) work perfectly.
In the future, it may be desirable to pass some other value here, such as null, to indicate that the clicked block is being replaced. However, that's a BC break and therefore outside of the scope of a stable bug fix.
2023-01-12 21:11:48 +00:00
Dylan K. Taylor
e26c8b9e9f
block: eliminate suspicious usages of $blockClicked in place()
2023-01-12 20:35:26 +00:00
Dylan K. Taylor
4e9c3e101d
Bell: fixed blocks not being able to be placed when not ringing the bell
2023-01-12 19:42:33 +00:00
Dylan K. Taylor
d295e1be54
PressurePlate: destroy self when no support is present
2023-01-12 19:36:47 +00:00
Dylan K. Taylor
2f3fcef97c
Fixed blocks incorrectly using blockClicked for support checks
...
this caused some interesting bugs, such as being able to place floating pressure plates by clicking on the side of a solid block halfway up a wall.
2023-01-12 19:36:23 +00:00
Dylan K. Taylor
5021096bdd
Fixed walls and thin blocks not connecting to each other
...
closes #5498
2023-01-09 20:46:57 +00:00
Alexey
172ce659b8
Use str_starts_with, str_ends_with and str_contains instead of strpos ( #5485 )
2022-12-31 13:02:23 +00:00
Dylan K. Taylor
b2017c8462
and more
2022-12-18 22:14:31 +00:00
Dylan K. Taylor
99996b62d6
Align PhpDoc @param tags according to PHP-CS-Fixer
2022-12-06 13:21:20 +00:00
zSALLAZAR
5c1e9a35a9
Fix missing sounds when interacting with item frames ( #5383 )
...
closes #5168
2022-11-25 14:28:41 +00:00
zSALLAZAR
36ab34df29
Implement BlockDeathEvent ( #5420 )
...
closes #4711
2022-11-23 12:57:26 +00:00
Dylan K. Taylor
cdbdcb5d67
Merge branch 'stable' into next-minor
2022-11-04 20:44:28 +00:00
Dylan K. Taylor
2fdc46c165
PHPStan 1.9 features
2022-11-04 20:23:34 +00:00
Dylan K. Taylor
6ae7cb288e
Merge remote-tracking branch 'origin/stable' into next-minor
2022-10-11 21:59:40 +01:00
Dylan K. Taylor
2be527060f
Sign: Fixed desync of colour and glowing state when using dye on signs
...
fixes #4932
2022-09-28 23:34:08 +01:00
Dylan K. Taylor
6f68c6d8a0
Melon: extend Solid instead of Transparent, fixes #5050
2022-09-28 23:07:53 +01:00
ShockedPlot7560
22486dd75e
Mushroom: check the light for placement, unless placed on mycelium or podzol ( #5054 )
...
The previous behaviour was inconsistent with vanilla.
2022-09-28 18:41:23 +01:00
ShockedPlot7560
1c7b1e9e5d
Fix sugarcane behaviour on fertilizers ( #4930 )
2022-09-28 16:38:24 +01:00
Dylan K. Taylor
a7dfa0907c
Merge branch 'stable' into next-minor
2022-09-24 18:07:56 +01:00
Dylan K. Taylor
f448b2e685
Block: Improve documentation for a whole bunch of methods
2022-09-24 18:06:46 +01:00
Dylan K. Taylor
6a0c54f850
Block: Relocate and document addVelocityToEntity()
...
maybe we should consider merging this with onEntityInside(), since they are both called for the same reasons? ...
2022-09-24 17:32:02 +01:00
Dylan K. Taylor
77a18d0aea
Block: add documentation for getFrictionFactor()
...
has no one ever questioned the fact that a higher _friction_ factor _reduces_ the block's friction???
2022-09-24 17:05:38 +01:00
Dylan K. Taylor
140a809c40
Block: improve documentation of hasEntityCollision() and onEntityInside()
2022-09-24 17:04:42 +01:00
Dylan K. Taylor
cb7c136035
Added documentation for some base Block classes
2022-09-24 16:54:21 +01:00
Dylan K. Taylor
441b06f6c7
Merge branch 'stable' into next-minor
2022-09-15 12:44:53 +01:00
Dylan K. Taylor
88eafdd614
Improve type info for RegistryTrait::getAll() and its users
2022-09-02 19:57:22 +01:00
Dylan K. Taylor
f88c4d9a8c
Remove more unnecessary local static variable usages
...
these are never mutated. Local constants would be better, if we had those.
2022-09-02 19:19:04 +01:00
Dylan K. Taylor
d72e947d15
BlockFactory: avoid unnecessary local static variable usage
...
phpstan treats these as always mixed, because it can't be sure what their types will be.
2022-09-02 19:14:35 +01:00
Dylan K. Taylor
85678aa356
phpstan 1.8.3
2022-09-02 18:28:33 +01:00
ShockedPlot7560
a25cb3741a
Limit valid supporting blocks of dead bush ( #5055 )
2022-08-31 02:18:18 +01:00
Dylan K. Taylor
c16893cbac
Merge branch 'stable' into next-minor
2022-08-25 19:25:19 +01:00
ipad54
709a869045
Vines can now only be placed on full cube blocks ( #5053 )
...
fixes #2673
2022-08-21 21:04:24 +01:00
Dylan K. Taylor
fc8434308b
SignText: changed misleading documentation
...
this looks like a leftover from the days when sign text was handled by the tile directly
2022-08-21 20:45:23 +01:00
Dylan K. Taylor
ad2d59923c
Merge branch 'stable' into next-minor
2022-08-18 17:06:15 +01:00
ShockedPlot7560
8fa81242d6
Sugarcane: fixed support conditions ( #5052 )
2022-08-15 17:08:26 +01:00
Dylan K. Taylor
2940547026
Eliminate repeated calls to Position->getWorld()
...
as well as improving readability, it also improves performance in some areas.
2022-07-20 20:44:05 +01:00
Dylan K. Taylor
24e72ec109
ContainerTrait: improve performance of block destroy hook
...
this was creating useless vector3s for every iteration, as well as repeatedly invoking Position->getWorld() for no reason.
2022-07-20 20:39:37 +01:00
IvanCraft623
fec89b7803
Lava burns entities for only 8 seconds in Bedrock ( #5173 )
2022-07-17 20:50:15 +01:00
Dylan K. Taylor
269b6ed16a
FallableTrait: fixed logic for block replacement
...
closes #5126
I don't know why it wasn't done this way to begin with. FallingBlock always used canBeReplaced()...
2022-07-06 16:16:49 +01:00
Dylan K. Taylor
df2d1fd4f9
of course there were two bugs on one line ...
2022-06-24 01:40:26 +01:00
Dylan K. Taylor
9f65fb5f90
Fixed top-side skulls with no-drop flag set being treated as unknown blocks
2022-06-24 01:31:11 +01:00
