Adding some missed commands typehints and documentation

src/pocketmine/command/defaults/BanCommand.php

@@ -31,7 +31,7 @@ use pocketmine\Player;
 
 class BanCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.ban.player.description",

src/pocketmine/command/defaults/BanIpCommand.php

@@ -31,7 +31,7 @@ use pocketmine\Player;
 
 class BanIpCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.ban.ip.description",
@@ -71,7 +71,7 @@ class BanIpCommand extends VanillaCommand{
 		return true;
 	}
 
-	private function processIPBan($ip, CommandSender $sender, $reason){
+	private function processIPBan(string $ip, CommandSender $sender, string $reason){
 		$sender->getServer()->getIPBans()->addBan($ip, $reason, null, $sender->getName());
 
 		foreach($sender->getServer()->getOnlinePlayers() as $player){

src/pocketmine/command/defaults/BanListCommand.php

@@ -30,7 +30,7 @@ use pocketmine\permission\BanEntry;
 
 class BanListCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.banlist.description",

src/pocketmine/command/defaults/DefaultGamemodeCommand.php

@@ -30,7 +30,7 @@ use pocketmine\Server;
 
 class DefaultGamemodeCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.defaultgamemode.description",

src/pocketmine/command/defaults/DeopCommand.php

@@ -32,7 +32,7 @@ use pocketmine\utils\TextFormat;
 
 class DeopCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.deop.description",

src/pocketmine/command/defaults/DifficultyCommand.php

@@ -32,7 +32,7 @@ use pocketmine\Server;
 
 class DifficultyCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.difficulty.description",

src/pocketmine/command/defaults/DumpMemoryCommand.php

@@ -29,7 +29,7 @@ class DumpMemoryCommand extends VanillaCommand{
 
 	private static $executions = 0;
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"Dumps the memory",

src/pocketmine/command/defaults/EffectCommand.php

@@ -31,7 +31,7 @@ use pocketmine\utils\TextFormat;
 
 class EffectCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.effect.description",

src/pocketmine/command/defaults/EnchantCommand.php

@@ -31,7 +31,7 @@ use pocketmine\utils\TextFormat;
 
 class EnchantCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.enchant.description",

src/pocketmine/command/defaults/GamemodeCommand.php

@@ -33,7 +33,7 @@ use pocketmine\utils\TextFormat;
 
 class GamemodeCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.gamemode.description",

src/pocketmine/command/defaults/GarbageCollectorCommand.php

@@ -28,7 +28,7 @@ use pocketmine\utils\TextFormat;
 
 class GarbageCollectorCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.gc.description",

src/pocketmine/command/defaults/GiveCommand.php

@@ -35,7 +35,7 @@ use pocketmine\utils\TextFormat;
 
 class GiveCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.give.description",

src/pocketmine/command/defaults/HelpCommand.php

@@ -30,7 +30,7 @@ use pocketmine\utils\TextFormat;
 
 class HelpCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.help.description",

src/pocketmine/command/defaults/KickCommand.php

@@ -32,7 +32,7 @@ use pocketmine\utils\TextFormat;
 
 class KickCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.kick.description",

src/pocketmine/command/defaults/KillCommand.php

@@ -33,7 +33,7 @@ use pocketmine\utils\TextFormat;
 
 class KillCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.kill.description",

src/pocketmine/command/defaults/ListCommand.php

@@ -29,7 +29,7 @@ use pocketmine\Player;
 
 class ListCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.list.description",

src/pocketmine/command/defaults/MeCommand.php

@@ -31,7 +31,7 @@ use pocketmine\utils\TextFormat;
 
 class MeCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.me.description",

src/pocketmine/command/defaults/OpCommand.php

@@ -32,7 +32,7 @@ use pocketmine\utils\TextFormat;
 
 class OpCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.op.description",

src/pocketmine/command/defaults/PardonCommand.php

@@ -30,7 +30,7 @@ use pocketmine\event\TranslationContainer;
 
 class PardonCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.unban.player.description",

src/pocketmine/command/defaults/PardonIpCommand.php

@@ -30,7 +30,7 @@ use pocketmine\event\TranslationContainer;
 
 class PardonIpCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.unban.ip.description",

src/pocketmine/command/defaults/ParticleCommand.php

@@ -64,7 +64,7 @@ use pocketmine\utils\TextFormat;
 
 class ParticleCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.particle.description",
@@ -126,7 +126,6 @@ class ParticleCommand extends VanillaCommand{
 
 	/**
 	 * @param string   $name
-	 *
 	 * @param Vector3  $pos
 	 * @param float    $xd
 	 * @param float    $yd
@@ -135,7 +134,7 @@ class ParticleCommand extends VanillaCommand{
 	 *
 	 * @return Particle|null
 	 */
-	private function getParticle($name, Vector3 $pos, $xd, $yd, $zd, $data){
+	private function getParticle(string $name, Vector3 $pos, float $xd, float $yd, float $zd, int $data = null){
 		switch($name){
 			case "explode":
 				return new ExplodeParticle($pos);

src/pocketmine/command/defaults/PluginsCommand.php

@@ -29,7 +29,7 @@ use pocketmine\utils\TextFormat;
 
 class PluginsCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.plugins.description",

src/pocketmine/command/defaults/ReloadCommand.php

@@ -30,7 +30,7 @@ use pocketmine\utils\TextFormat;
 
 class ReloadCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.reload.description",

src/pocketmine/command/defaults/SaveCommand.php

@@ -29,7 +29,7 @@ use pocketmine\event\TranslationContainer;
 
 class SaveCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.save.description",

src/pocketmine/command/defaults/SaveOffCommand.php

@@ -29,7 +29,7 @@ use pocketmine\event\TranslationContainer;
 
 class SaveOffCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.saveoff.description",

src/pocketmine/command/defaults/SaveOnCommand.php

@@ -29,7 +29,7 @@ use pocketmine\event\TranslationContainer;
 
 class SaveOnCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.saveon.description",

src/pocketmine/command/defaults/SayCommand.php

@@ -32,7 +32,7 @@ use pocketmine\utils\TextFormat;
 
 class SayCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.say.description",

src/pocketmine/command/defaults/SeedCommand.php

@@ -29,7 +29,7 @@ use pocketmine\Player;
 
 class SeedCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.seed.description",

src/pocketmine/command/defaults/SetWorldSpawnCommand.php

@@ -33,7 +33,7 @@ use pocketmine\utils\TextFormat;
 
 class SetWorldSpawnCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.setworldspawn.description",

src/pocketmine/command/defaults/SpawnpointCommand.php

@@ -34,7 +34,7 @@ use pocketmine\utils\TextFormat;
 
 class SpawnpointCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.spawnpoint.description",

src/pocketmine/command/defaults/StatusCommand.php

@@ -29,7 +29,7 @@ use pocketmine\utils\Utils;
 
 class StatusCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.status.description",

src/pocketmine/command/defaults/StopCommand.php

@@ -29,7 +29,7 @@ use pocketmine\event\TranslationContainer;
 
 class StopCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.stop.description",

src/pocketmine/command/defaults/TeleportCommand.php

@@ -33,7 +33,7 @@ use pocketmine\utils\TextFormat;
 
 class TeleportCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.tp.description",

src/pocketmine/command/defaults/TellCommand.php

@@ -31,7 +31,7 @@ use pocketmine\utils\TextFormat;
 
 class TellCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.tell.description",

src/pocketmine/command/defaults/TimeCommand.php

@@ -33,7 +33,7 @@ use pocketmine\utils\TextFormat;
 
 class TimeCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.time.description",

src/pocketmine/command/defaults/TimingsCommand.php

@@ -35,7 +35,7 @@ class TimingsCommand extends VanillaCommand{
 
 	public static $timingStart = 0;
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.timings.description",

src/pocketmine/command/defaults/TitleCommand.php

@@ -29,7 +29,7 @@ use pocketmine\event\TranslationContainer;
 
 class TitleCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.title.description",

src/pocketmine/command/defaults/TransferServerCommand.php

@@ -31,7 +31,7 @@ use pocketmine\Player;
 
 class TransferServerCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.transferserver.description",

src/pocketmine/command/defaults/VanillaCommand.php

@@ -30,11 +30,15 @@ abstract class VanillaCommand extends Command{
 	const MAX_COORD = 30000000;
 	const MIN_COORD = -30000000;
 
-	public function __construct($name, $description = "", $usageMessage = null, array $aliases = []){
-		parent::__construct($name, $description, $usageMessage, $aliases);
-	}
-
-	protected function getInteger(CommandSender $sender, $value, $min = self::MIN_COORD, $max = self::MAX_COORD){
+	/**
+	 * @param CommandSender $sender
+	 * @param mixed         $value
+	 * @param int           $min
+	 * @param int           $max
+	 *
+	 * @return int
+	 */
+	protected function getInteger(CommandSender $sender, $value, int $min = self::MIN_COORD, int $max = self::MAX_COORD) : int{
 		$i = (int) $value;
 
 		if($i < $min){
@@ -46,7 +50,16 @@ abstract class VanillaCommand extends Command{
 		return $i;
 	}
 
-	protected function getRelativeDouble($original, CommandSender $sender, $input, $min = self::MIN_COORD, $max = self::MAX_COORD){
+	/**
+	 * @param float         $original
+	 * @param CommandSender $sender
+	 * @param string        $input
+	 * @param float         $min
+	 * @param float         $max
+	 *
+	 * @return float
+	 */
+	protected function getRelativeDouble(float $original, CommandSender $sender, string $input, float $min = self::MIN_COORD, float $max = self::MAX_COORD) : float{
 		if($input{0} === "~"){
 			$value = $this->getDouble($sender, substr($input, 1));
 
@@ -56,7 +69,15 @@ abstract class VanillaCommand extends Command{
 		return $this->getDouble($sender, $input, $min, $max);
 	}
 
-	protected function getDouble(CommandSender $sender, $value, $min = self::MIN_COORD, $max = self::MAX_COORD){
+	/**
+	 * @param CommandSender $sender
+	 * @param mixed         $value
+	 * @param float         $min
+	 * @param float         $max
+	 *
+	 * @return float
+	 */
+	protected function getDouble(CommandSender $sender, $value, float $min = self::MIN_COORD, float $max = self::MAX_COORD) : float{
 		$i = (double) $value;
 
 		if($i < $min){

src/pocketmine/command/defaults/VersionCommand.php

@@ -31,7 +31,7 @@ use pocketmine\utils\TextFormat;
 
 class VersionCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.version.description",

src/pocketmine/command/defaults/WhitelistCommand.php

@@ -31,7 +31,7 @@ use pocketmine\utils\TextFormat;
 
 class WhitelistCommand extends VanillaCommand{
 
-	public function __construct($name){
+	public function __construct(string $name){
 		parent::__construct(
 			$name,
 			"%pocketmine.command.whitelist.description",
@@ -108,7 +108,7 @@ class WhitelistCommand extends VanillaCommand{
 		return true;
 	}
 
-	private function badPerm(CommandSender $sender, $perm){
+	private function badPerm(CommandSender $sender, string $perm) : bool{
 		if(!$sender->hasPermission("pocketmine.command.whitelist.$perm")){
 			$sender->sendMessage(new TranslationContainer(TextFormat::RED . "%commands.generic.permission"));