matthew/enhanced-discord.py
1
0
Fork 0
Code Issues 4 Pull Requests 21 Projects Releases Wiki Activity

Create a working button paginator #95

Open
ImAnAgent wants to merge 7 commits from ImAnAgent/patch-1 into 2.0
pull from: ImAnAgent/patch-1
merge into: matthew:2.0
Conversation 2 Commits 7 Files Changed 1 +210
ImAnAgent commented 2021-10-09 17:06:31 +00:00 (Migrated from github.com)
Copy Link

Simple Embed paginator that I've been using for a while. Thought it could help others too.

Summary

This PR provides an example Embed paginator using Views (buttons). I believe the examples/views folder could use one.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
Simple Embed paginator that I've been using for a while. Thought it could help others too. <!-- Pull requests that do not fill this information in will likely be closed --> ## Summary <!-- What is this pull request for? Does it fix any issues? --> This PR provides an example Embed paginator using Views (buttons). I believe the examples/views folder could use one. ## Checklist <!-- Put an x inside [ ] to check it, like so: [x] --> - [ ] If code changes were made then they have been tested. - [ ] I have updated the documentation to reflect the changes. - [ ] This PR fixes an issue. - [ ] This PR adds something new (e.g. new method or parameters). - [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed) - [x] This PR is **not** a code change (e.g. documentation, README, ...)
Gnome-py commented 2021-10-09 18:16:09 +00:00 (Migrated from github.com)
Copy Link
  1. Examples should be fully runnable and self-contained (with a client object, on_ready, etc)
  2. The max line length for dpy and edpy is 120
  3. Do the logic inside your callbacks, instead of the while True and view.value checking.

Overall, this is a good idea for an example but a bad implementation.

1. Examples should be fully runnable and self-contained (with a client object, on_ready, etc) 2. The max line length for dpy and edpy is 120 3. Do the logic inside your callbacks, instead of the `while True` and `view.value` checking. Overall, this is a good idea for an example but a bad implementation.
Soheab commented 2021-10-30 16:54:44 +00:00 (Migrated from github.com)
Copy Link

@ImAnAgent Is this still being worked on? because it does not look good in its current state.

@ImAnAgent Is this still being worked on? because it does not look good in its current state.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin ImAnAgent/patch-1:ImAnAgent/patch-1
git checkout ImAnAgent/patch-1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
matthew
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: matthew/enhanced-discord.py#95
No description provided.
Delete Branch "ImAnAgent/patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?