mirrors/discord.py
1
0
Fork 0
mirror of https://github.com/Rapptz/discord.py.git synced 2025-04-22 08:44:10 +00:00
Code Issues Projects Releases Wiki Activity

Change ui.Select.values to a ContextVar to avoid race conditions

Browse Source
This commit is contained in:
Mikey 2022-08-09 05:37:46 -07:00 committed by GitHub
parent dc81ff76c4
commit d826f4f3a8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
discord/ui/select.py
View File

@ -24,6 +24,7 @@ DEALINGS IN THE SOFTWARE.
from __future__ import annotations
from typing import List, Literal, Optional, TYPE_CHECKING, Tuple, TypeVar, Callable, Union
from contextvars import ContextVar
import inspect
import os
@ -53,6 +54,8 @@ if TYPE_CHECKING:
V = TypeVar('V', bound='View', covariant=True)
selected_values: ContextVar[Optional[List[str]]] = ContextVar('selected_values', default=None)
class Select(Item[V]):
"""Represents a UI select menu.
@ -108,7 +111,6 @@ class Select(Item[V]):
row: Optional[int] = None,
) -> None:
super().__init__()
self._selected_values: List[str] = []
self._provided_custom_id = custom_id is not MISSING
custom_id = os.urandom(16).hex() if custom_id is MISSING else custom_id
if not isinstance(custom_id, str):
@ -260,7 +262,8 @@ class Select(Item[V]):
@property
def values(self) -> List[str]:
"""List[:class:`str`]: A list of values that have been selected by the user."""
return self._selected_values
values = selected_values.get()
return values if values is not None else []
@property
def width(self) -> int:
@ -273,7 +276,7 @@ class Select(Item[V]):
self._underlying = component
def _refresh_state(self, data: MessageComponentInteractionData) -> None:
self._selected_values = data.get('values', [])
selected_values.set(data.get('values', []))
@classmethod
def from_component(cls, component: SelectMenu) -> Self: