Release 3.25.1

Entity::spawnTo(): verify that the target player belongs to the same world as the entity
this should never be hit in the PM case, but it's an InvalidArgument rather than AssumptionFailedError because plugins can and do call this with bad things.
2025-09-13 04:45:08 +00:00 · 2021-10-29 22:23:22 +01:00 · 2021-10-29 18:54:00 +01:00 · 2021-10-29 00:23:13 +01:00 · 2021-10-25 19:52:44 +01:00 · 2021-10-21 20:32:37 +01:00
45 changed files with 582 additions and 326 deletions
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@ -13,7 +13,7 @@ jobs:
    strategy:
      matrix:
        image: [ubuntu-20.04]
-        php: [7.4.22, 8.0.9]
+        php: [8.0.11]

    steps:
      - uses: actions/checkout@v2 #needed for build.sh
@ -36,13 +36,8 @@ jobs:
    strategy:
      fail-fast: false
      matrix:
-        include:
-          - php: 8.0.9
-            config: phpstan.neon.dist
-            image: ubuntu-20.04
-          - php: 7.4.22
-            config: phpstan.php7.neon
-            image: ubuntu-20.04
+        image: [ubuntu-20.04]
+        php: [8.0.11]

    steps:
      - uses: actions/checkout@v2
@ -82,7 +77,7 @@ jobs:
        run: php composer.phar install --prefer-dist --no-interaction

      - name: Run PHPStan
-        run: ./vendor/bin/phpstan analyze --no-progress --memory-limit=2G -c ${{ matrix.config }}
+        run: ./vendor/bin/phpstan analyze --no-progress --memory-limit=2G

  phpunit:
    name: PHPUnit tests
@ -92,7 +87,7 @@ jobs:
      fail-fast: false
      matrix:
        image: [ubuntu-20.04]
-        php: [7.4.22, 8.0.9]
+        php: [8.0.11]

    steps:
      - uses: actions/checkout@v2
@ -142,7 +137,7 @@ jobs:
      fail-fast: false
      matrix:
        image: [ubuntu-20.04]
-        php: [7.4.22, 8.0.9]
+        php: [8.0.11]

    steps:
      - uses: actions/checkout@v2
@ -194,7 +189,7 @@ jobs:
      fail-fast: false
      matrix:
        image: [ubuntu-20.04]
-        php: [7.4.22, 8.0.9]
+        php: [8.0.11]

    steps:
      - uses: actions/checkout@v2
@ -277,10 +272,10 @@ jobs:
      - uses: actions/checkout@v2

      - name: Setup PHP and tools
-        uses: shivammathur/setup-php@2.12.0
+        uses: shivammathur/setup-php@2.15.0
        with:
          php-version: 8.0
-          tools: php-cs-fixer
+          tools: php-cs-fixer:3.2

      - name: Run PHP-CS-Fixer
        run: php-cs-fixer fix --dry-run --diff
--- a/.github/workflows/update-php-versions.php
+++ b/.github/workflows/update-php-versions.php
@ -22,8 +22,6 @@
 declare(strict_types=1);

 const VERSIONS = [
-	"7.3",
-	"7.4",
 	"8.0"
 ];

--- a/.php-cs-fixer.php
+++ b/.php-cs-fixer.php
@ -62,6 +62,11 @@ return (new PhpCsFixer\Config)
 			],
 			'sort_algorithm' => 'alpha'
 		],
+		'phpdoc_line_span' => [
+			'property' => 'single',
+			'method' => null,
+			'const' => null
+		],
 		'phpdoc_trim' => true,
 		'phpdoc_trim_consecutive_blank_line_separation' => true,
 		'single_import_per_statement' => true,
--- a/BUILDING.md
+++ b/BUILDING.md
@ -2,13 +2,13 @@
 ## Pre-requisites
 - A bash shell (git bash is sufficient for Windows)
 - [`git`](https://git-scm.com) available in your shell
- PHP 7.4 or newer available in your shell
+- PHP 8.0 or newer available in your shell
 - [`composer`](https://getcomposer.org) available in your shell

 ## Custom PHP binaries
 Because PocketMine-MP requires several non-standard PHP extensions and configuration, PMMP provides scripts to build custom binaries for running PocketMine-MP, as well as prebuilt binaries.

- [Prebuilt binaries](https://jenkins.pmmp.io/job/PHP-7.4-Aggregate)
+- [Prebuilt binaries](https://jenkins.pmmp.io/job/PHP-8.0-Aggregate)
 - [Compile scripts](https://github.com/pmmp/php-build-scripts) are provided as a submodule in the path `build/php`

 If you use a custom binary, you'll need to replace `composer` usages in this guide with `path/to/your/php path/to/your/composer.phar`.
@ -38,7 +38,7 @@ There is a bug in PHP that might cause an error which looks like this:
 ```
 Fatal error: Uncaught BadMethodCallException: unable to create temporary file in PocketMine-MP/build/server-phar.php:119
 ```
-You can work around it by setting `ulimit -n` to some bigger number, e.g. `8192`, or by updating your PHP version to at least 7.4.16 or 8.0.3.
+You can work around it by setting `ulimit -n` to some bigger number, e.g. `8192`, or by updating your PHP version to at least 8.0.3.

 ## Running PocketMine-MP from source code
 Run `src/pocketmine/PocketMine.php` using your preferred PHP binary.
--- a/build/php
+++ b/build/php
--- a/changelogs/3.23.md
+++ b/changelogs/3.23.md
@ -9,3 +9,6 @@ Plugin developers should **only** update their required API to this version if y
 # 3.23.0
 - Added support for Minecraft: Bedrock Edition 1.17.30.
 - Removed compatibility with earlier versions.
+
+# 3.23.1
+- Fixed broken build of 3.23.0.
--- a/changelogs/3.24.md
+++ b/changelogs/3.24.md
@ -0,0 +1,12 @@
+**For Minecraft: Bedrock Edition 1.17.30**
+
+### Note about API versions
+Plugins which don't touch the protocol and compatible with any previous 3.x.y version will also run on these releases and do not need API bumps.
+Plugin developers should **only** update their required API to this version if you need the changes in this build.
+
+**WARNING: If your plugin uses the protocol, you're not shielded by API change constraints.** You should consider using the `mcpe-protocol` directive in `plugin.yml` as a constraint if you do.
+
+# 3.24.0
+- PHP 8.0 is now required as a minimum.
+- Fixed stats reporting checking the wrong `pocketmine.yml` property.
+- Fixed `Projectile->move()` not respecting the given `dx`/`dy`/`dz` and using its own motion instead.
--- a/changelogs/3.25.md
+++ b/changelogs/3.25.md
@ -0,0 +1,16 @@
+**For Minecraft: Bedrock Edition 1.17.40**
+
+### Note about API versions
+Plugins which don't touch the protocol and compatible with any previous 3.x.y version will also run on these releases and do not need API bumps.
+Plugin developers should **only** update their required API to this version if you need the changes in this build.
+
+**WARNING: If your plugin uses the protocol, you're not shielded by API change constraints.** You should consider using the `mcpe-protocol` directive in `plugin.yml` as a constraint if you do.
+
+# 3.25.0
+- Added support for Minecraft: Bedrock Edition 1.17.40.
+- Removed compatibility with earlier versions.
+
+# 3.25.1
+- Fixed autosave bug that caused unmodified chunks to be saved at least once (during the first autosave after they were loaded).
+- `Entity->spawnTo()` now has an additional sanity check for matching worlds (might expose a few new errors in plugins).
+- Fixed a missing field in `CraftRecipeAuto` item stack request type.
--- a/composer.json
+++ b/composer.json
@ -5,7 +5,7 @@
   "homepage": "https://pmmp.io",
   "license": "LGPL-3.0",
   "require": {
-      "php": "^7.4 || ^8.0",
+      "php": "^8.0",
      "php-64bit": "*",
      "ext-ctype": "*",
      "ext-curl": "*",
@ -38,7 +38,7 @@
      "pocketmine/spl": "^0.4.0"
   },
   "require-dev": {
-      "phpstan/phpstan": "0.12.98",
+      "phpstan/phpstan": "0.12.99",
      "phpstan/phpstan-phpunit": "^0.12.6",
      "phpstan/phpstan-strict-rules": "^0.12.2",
      "phpunit/phpunit": "^9.2"
@ -60,7 +60,7 @@
   },
   "config": {
      "platform": {
-         "php": "7.4.0"
+         "php": "8.0.0"
      },
      "sort-packages": true
   },
--- a/composer.lock
+++ b/composer.lock
@ -4,7 +4,7 @@
        "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
        "This file is @generated automatically"
    ],
-    "content-hash": "8fc787ba6d9029fb6daa3e8c112b76c5",
+    "content-hash": "cfba71d2ad0dd961ed00520b5d52e4d7",
    "packages": [
        {
            "name": "adhocore/json-comment",
@ -617,16 +617,16 @@
        },
        {
            "name": "nikic/php-parser",
-            "version": "v4.12.0",
+            "version": "v4.13.0",
            "source": {
                "type": "git",
                "url": "https://github.com/nikic/PHP-Parser.git",
-                "reference": "6608f01670c3cc5079e18c1dab1104e002579143"
+                "reference": "50953a2691a922aa1769461637869a0a2faa3f53"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/nikic/PHP-Parser/zipball/6608f01670c3cc5079e18c1dab1104e002579143",
-                "reference": "6608f01670c3cc5079e18c1dab1104e002579143",
+                "url": "https://api.github.com/repos/nikic/PHP-Parser/zipball/50953a2691a922aa1769461637869a0a2faa3f53",
+                "reference": "50953a2691a922aa1769461637869a0a2faa3f53",
                "shasum": ""
            },
            "require": {
@ -667,9 +667,9 @@
            ],
            "support": {
                "issues": "https://github.com/nikic/PHP-Parser/issues",
-                "source": "https://github.com/nikic/PHP-Parser/tree/v4.12.0"
+                "source": "https://github.com/nikic/PHP-Parser/tree/v4.13.0"
            },
-            "time": "2021-07-21T10:44:31+00:00"
+            "time": "2021-09-20T12:20:58+00:00"
        },
        {
            "name": "phar-io/manifest",
@ -893,16 +893,16 @@
        },
        {
            "name": "phpdocumentor/type-resolver",
-            "version": "1.4.0",
+            "version": "1.5.1",
            "source": {
                "type": "git",
                "url": "https://github.com/phpDocumentor/TypeResolver.git",
-                "reference": "6a467b8989322d92aa1c8bf2bebcc6e5c2ba55c0"
+                "reference": "a12f7e301eb7258bb68acd89d4aefa05c2906cae"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/phpDocumentor/TypeResolver/zipball/6a467b8989322d92aa1c8bf2bebcc6e5c2ba55c0",
-                "reference": "6a467b8989322d92aa1c8bf2bebcc6e5c2ba55c0",
+                "url": "https://api.github.com/repos/phpDocumentor/TypeResolver/zipball/a12f7e301eb7258bb68acd89d4aefa05c2906cae",
+                "reference": "a12f7e301eb7258bb68acd89d4aefa05c2906cae",
                "shasum": ""
            },
            "require": {
@ -910,7 +910,8 @@
                "phpdocumentor/reflection-common": "^2.0"
            },
            "require-dev": {
-                "ext-tokenizer": "*"
+                "ext-tokenizer": "*",
+                "psalm/phar": "^4.8"
            },
            "type": "library",
            "extra": {
@ -936,39 +937,39 @@
            "description": "A PSR-5 based resolver of Class names, Types and Structural Element Names",
            "support": {
                "issues": "https://github.com/phpDocumentor/TypeResolver/issues",
-                "source": "https://github.com/phpDocumentor/TypeResolver/tree/1.4.0"
+                "source": "https://github.com/phpDocumentor/TypeResolver/tree/1.5.1"
            },
-            "time": "2020-09-17T18:55:26+00:00"
+            "time": "2021-10-02T14:08:47+00:00"
        },
        {
            "name": "phpspec/prophecy",
-            "version": "1.13.0",
+            "version": "1.14.0",
            "source": {
                "type": "git",
                "url": "https://github.com/phpspec/prophecy.git",
-                "reference": "be1996ed8adc35c3fd795488a653f4b518be70ea"
+                "reference": "d86dfc2e2a3cd366cee475e52c6bb3bbc371aa0e"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/phpspec/prophecy/zipball/be1996ed8adc35c3fd795488a653f4b518be70ea",
-                "reference": "be1996ed8adc35c3fd795488a653f4b518be70ea",
+                "url": "https://api.github.com/repos/phpspec/prophecy/zipball/d86dfc2e2a3cd366cee475e52c6bb3bbc371aa0e",
+                "reference": "d86dfc2e2a3cd366cee475e52c6bb3bbc371aa0e",
                "shasum": ""
            },
            "require": {
                "doctrine/instantiator": "^1.2",
-                "php": "^7.2 || ~8.0, <8.1",
+                "php": "^7.2 || ~8.0, <8.2",
                "phpdocumentor/reflection-docblock": "^5.2",
                "sebastian/comparator": "^3.0 || ^4.0",
                "sebastian/recursion-context": "^3.0 || ^4.0"
            },
            "require-dev": {
-                "phpspec/phpspec": "^6.0",
+                "phpspec/phpspec": "^6.0 || ^7.0",
                "phpunit/phpunit": "^8.0 || ^9.0"
            },
            "type": "library",
            "extra": {
                "branch-alias": {
-                    "dev-master": "1.11.x-dev"
+                    "dev-master": "1.x-dev"
                }
            },
            "autoload": {
@ -1003,22 +1004,22 @@
            ],
            "support": {
                "issues": "https://github.com/phpspec/prophecy/issues",
-                "source": "https://github.com/phpspec/prophecy/tree/1.13.0"
+                "source": "https://github.com/phpspec/prophecy/tree/1.14.0"
            },
-            "time": "2021-03-17T13:42:18+00:00"
+            "time": "2021-09-10T09:02:12+00:00"
        },
        {
            "name": "phpstan/phpstan",
-            "version": "0.12.98",
+            "version": "0.12.99",
            "source": {
                "type": "git",
                "url": "https://github.com/phpstan/phpstan.git",
-                "reference": "3bb7cc246c057405dd5e290c3ecc62ab51d57e00"
+                "reference": "b4d40f1d759942f523be267a1bab6884f46ca3f7"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/phpstan/phpstan/zipball/3bb7cc246c057405dd5e290c3ecc62ab51d57e00",
-                "reference": "3bb7cc246c057405dd5e290c3ecc62ab51d57e00",
+                "url": "https://api.github.com/repos/phpstan/phpstan/zipball/b4d40f1d759942f523be267a1bab6884f46ca3f7",
+                "reference": "b4d40f1d759942f523be267a1bab6884f46ca3f7",
                "shasum": ""
            },
            "require": {
@ -1049,7 +1050,7 @@
            "description": "PHPStan - PHP Static Analysis Tool",
            "support": {
                "issues": "https://github.com/phpstan/phpstan/issues",
-                "source": "https://github.com/phpstan/phpstan/tree/0.12.98"
+                "source": "https://github.com/phpstan/phpstan/tree/0.12.99"
            },
            "funding": [
                {
@ -1069,7 +1070,7 @@
                    "type": "tidelift"
                }
            ],
-            "time": "2021-09-02T12:33:01+00:00"
+            "time": "2021-09-12T20:09:55+00:00"
        },
        {
            "name": "phpstan/phpstan-phpunit",
@ -1177,23 +1178,23 @@
        },
        {
            "name": "phpunit/php-code-coverage",
-            "version": "9.2.6",
+            "version": "9.2.7",
            "source": {
                "type": "git",
                "url": "https://github.com/sebastianbergmann/php-code-coverage.git",
-                "reference": "f6293e1b30a2354e8428e004689671b83871edde"
+                "reference": "d4c798ed8d51506800b441f7a13ecb0f76f12218"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/sebastianbergmann/php-code-coverage/zipball/f6293e1b30a2354e8428e004689671b83871edde",
-                "reference": "f6293e1b30a2354e8428e004689671b83871edde",
+                "url": "https://api.github.com/repos/sebastianbergmann/php-code-coverage/zipball/d4c798ed8d51506800b441f7a13ecb0f76f12218",
+                "reference": "d4c798ed8d51506800b441f7a13ecb0f76f12218",
                "shasum": ""
            },
            "require": {
                "ext-dom": "*",
                "ext-libxml": "*",
                "ext-xmlwriter": "*",
-                "nikic/php-parser": "^4.10.2",
+                "nikic/php-parser": "^4.12.0",
                "php": ">=7.3",
                "phpunit/php-file-iterator": "^3.0.3",
                "phpunit/php-text-template": "^2.0.2",
@ -1242,7 +1243,7 @@
            ],
            "support": {
                "issues": "https://github.com/sebastianbergmann/php-code-coverage/issues",
-                "source": "https://github.com/sebastianbergmann/php-code-coverage/tree/9.2.6"
+                "source": "https://github.com/sebastianbergmann/php-code-coverage/tree/9.2.7"
            },
            "funding": [
                {
@ -1250,7 +1251,7 @@
                    "type": "github"
                }
            ],
-            "time": "2021-03-28T07:26:59+00:00"
+            "time": "2021-09-17T05:39:03+00:00"
        },
        {
            "name": "phpunit/php-file-iterator",
@ -1495,16 +1496,16 @@
        },
        {
            "name": "phpunit/phpunit",
-            "version": "9.5.9",
+            "version": "9.5.10",
            "source": {
                "type": "git",
                "url": "https://github.com/sebastianbergmann/phpunit.git",
-                "reference": "ea8c2dfb1065eb35a79b3681eee6e6fb0a6f273b"
+                "reference": "c814a05837f2edb0d1471d6e3f4ab3501ca3899a"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/sebastianbergmann/phpunit/zipball/ea8c2dfb1065eb35a79b3681eee6e6fb0a6f273b",
-                "reference": "ea8c2dfb1065eb35a79b3681eee6e6fb0a6f273b",
+                "url": "https://api.github.com/repos/sebastianbergmann/phpunit/zipball/c814a05837f2edb0d1471d6e3f4ab3501ca3899a",
+                "reference": "c814a05837f2edb0d1471d6e3f4ab3501ca3899a",
                "shasum": ""
            },
            "require": {
@ -1520,7 +1521,7 @@
                "phar-io/version": "^3.0.2",
                "php": ">=7.3",
                "phpspec/prophecy": "^1.12.1",
-                "phpunit/php-code-coverage": "^9.2.3",
+                "phpunit/php-code-coverage": "^9.2.7",
                "phpunit/php-file-iterator": "^3.0.5",
                "phpunit/php-invoker": "^3.1.1",
                "phpunit/php-text-template": "^2.0.3",
@ -1582,7 +1583,7 @@
            ],
            "support": {
                "issues": "https://github.com/sebastianbergmann/phpunit/issues",
-                "source": "https://github.com/sebastianbergmann/phpunit/tree/9.5.9"
+                "source": "https://github.com/sebastianbergmann/phpunit/tree/9.5.10"
            },
            "funding": [
                {
@ -1594,7 +1595,7 @@
                    "type": "github"
                }
            ],
-            "time": "2021-08-31T06:47:40+00:00"
+            "time": "2021-09-25T07:38:51+00:00"
        },
        {
            "name": "sebastian/cli-parser",
@ -2449,7 +2450,6 @@
                    "type": "github"
                }
            ],
-            "abandoned": true,
            "time": "2020-09-28T06:45:17+00:00"
        },
        {
@ -2755,7 +2755,7 @@
    "prefer-stable": false,
    "prefer-lowest": false,
    "platform": {
-        "php": "^7.4 || ^8.0",
+        "php": "^8.0",
        "php-64bit": "*",
        "ext-ctype": "*",
        "ext-curl": "*",
@ -2778,7 +2778,7 @@
    },
    "platform-dev": [],
    "platform-overrides": {
-        "php": "7.4.0"
+        "php": "8.0.0"
    },
    "plugin-api-version": "2.1.0"
 }
--- a/phpstan.neon.dist
+++ b/phpstan.neon.dist
@ -5,7 +5,6 @@ includes:
 	- tests/phpstan/configs/l7-baseline.neon
 	- tests/phpstan/configs/l8-baseline.neon
 	- tests/phpstan/configs/php-bugs.neon
-	- tests/phpstan/configs/php74-compat.neon
 	- tests/phpstan/configs/phpstan-bugs.neon
 	- tests/phpstan/configs/phpunit-wiring-tests.neon
 	- tests/phpstan/configs/pthreads-bugs.neon
@ -33,7 +32,11 @@ parameters:
 		- tests/plugins/TesterPlugin
 	excludePaths:
 		analyseAndScan:
+			- build/php
 			- build/preprocessor
+		analyse:
+			- src/pocketmine/block/StoneSlab.php #overrides STONE constant
+			- src/pocketmine/item/Potion.php #overrides WATER constant
 	dynamicConstantNames:
 		- pocketmine\DEBUG
 		- pocketmine\IS_DEVELOPMENT_BUILD
@ -48,7 +51,5 @@ parameters:
 		#variadics don't work for this - mixed probably shouldn't work either, but for now it does
 		#what we actually need is something that accepts an infinite number of parameters, but in the absence of that,
 		#we'll just fill it with 10 - it's very unlikely to encounter a callable with 10 parameters anyway.
-		anyCallable: 'callable(mixed, mixed, mixed, mixed, mixed, mixed, mixed, mixed, mixed, mixed) : mixed'
-		anyClosure: '\Closure(mixed, mixed, mixed, mixed, mixed, mixed, mixed, mixed, mixed, mixed) : mixed'
-		PhpSocket: '\Socket'
-		PhpCurlHandle: '\CurlHandle'
+		anyCallable: 'callable(never, never, never, never, never, never, never, never, never, never) : mixed'
+		anyClosure: '\Closure(never, never, never, never, never, never, never, never, never, never) : mixed'
--- a/phpstan.php7.neon
+++ b/phpstan.php7.neon
@ -1,9 +0,0 @@
-includes:
-    - phpstan.neon.dist
-    - tests/phpstan/configs/php7.neon
-
-parameters:
-    phpVersion: 70400
-    typeAliases:
-        PhpSocket: resource
-        PhpCurlHandle: resource
--- a/src/pocketmine/Player.php
+++ b/src/pocketmine/Player.php
@ -563,7 +563,7 @@ class Player extends Human implements CommandSender, ChunkLoader, IPlayer{
 	}

 	public function spawnTo(Player $player) : void{
-		if($this->spawned and $player->spawned and $this->isAlive() and $player->isAlive() and $player->getLevelNonNull() === $this->level and $player->canSee($this) and !$this->isSpectator()){
+		if($this->spawned and $player->spawned and $this->isAlive() and $player->isAlive() and $player->canSee($this) and !$this->isSpectator()){
 			parent::spawnTo($player);
 		}
 	}
--- a/src/pocketmine/PocketMine.php
+++ b/src/pocketmine/PocketMine.php
@ -36,7 +36,7 @@ namespace pocketmine {

 	require_once __DIR__ . '/VersionInfo.php';

-	const MIN_PHP_VERSION = "7.4.0";
+	const MIN_PHP_VERSION = "8.0.0";

 	/**
 	 * @param string $message
--- a/src/pocketmine/Server.php
+++ b/src/pocketmine/Server.php
@ -1961,7 +1961,7 @@ class Server{
 			$this->network->blockAddress($entry->getName(), -1);
 		}

-		if((bool) $this->getProperty("settings.send-usage", true)){
+		if((bool) $this->getProperty("anonymous-statistics.enabled", true)){
 			$this->sendUsageTicker = 6000;
 			$this->sendUsage(SendUsageTask::TYPE_OPEN);
 		}
--- a/src/pocketmine/VersionInfo.php
+++ b/src/pocketmine/VersionInfo.php
@ -33,7 +33,7 @@ if(defined('pocketmine\_VERSION_INFO_INCLUDED')){
 const _VERSION_INFO_INCLUDED = true;

 const NAME = "PocketMine-MP";
-const BASE_VERSION = "3.23.0";
+const BASE_VERSION = "3.25.1";
 const IS_DEVELOPMENT_BUILD = false;
 const BUILD_NUMBER = 0;
 const BUILD_CHANNEL = "stable";
--- a/src/pocketmine/entity/Entity.php
+++ b/src/pocketmine/entity/Entity.php
@ -1950,6 +1950,9 @@ abstract class Entity extends Location implements Metadatable, EntityIds{
 	}

 	public function spawnTo(Player $player) : void{
+		if($player->getLevelNonNull() !== $this->level){
+			throw new \InvalidArgumentException("Player is not in the same world");
+		}
 		if(
 			!isset($this->hasSpawned[$player->getLoaderId()]) and
 			$this->chunk !== null and
--- a/src/pocketmine/entity/projectile/Projectile.php
+++ b/src/pocketmine/entity/projectile/Projectile.php
@ -180,7 +180,7 @@ abstract class Projectile extends Entity{
 		Timings::$entityMoveTimer->startTiming();

 		$start = $this->asVector3();
-		$end = $start->add($this->motion);
+		$end = $start->add($dx, $dy, $dz);

 		$blockHit = null;
 		$entityHit = null;
--- a/src/pocketmine/level/format/io/region/Anvil.php
+++ b/src/pocketmine/level/format/io/region/Anvil.php
@ -135,6 +135,7 @@ class Anvil extends McRegion{
 		$result->setLightPopulated($chunk->getByte("LightPopulated", 0) !== 0);
 		$result->setPopulated($chunk->getByte("TerrainPopulated", 0) !== 0);
 		$result->setGenerated();
+		$result->setChanged(false);
 		return $result;
 	}

--- a/src/pocketmine/level/format/io/region/McRegion.php
+++ b/src/pocketmine/level/format/io/region/McRegion.php
@ -201,6 +201,7 @@ class McRegion extends BaseLevelProvider{
 		$result->setLightPopulated($chunk->getByte("LightPopulated", 0) !== 0);
 		$result->setPopulated($chunk->getByte("TerrainPopulated", 0) !== 0);
 		$result->setGenerated(true);
+		$result->setChanged(false);
 		return $result;
 	}

--- a/src/pocketmine/network/mcpe/NetworkSession.php
+++ b/src/pocketmine/network/mcpe/NetworkSession.php
@ -116,6 +116,7 @@ use pocketmine\network\mcpe\protocol\NpcDialoguePacket;
 use pocketmine\network\mcpe\protocol\NpcRequestPacket;
 use pocketmine\network\mcpe\protocol\OnScreenTextureAnimationPacket;
 use pocketmine\network\mcpe\protocol\PacketViolationWarningPacket;
+use pocketmine\network\mcpe\protocol\PassengerJumpPacket;
 use pocketmine\network\mcpe\protocol\PhotoInfoRequestPacket;
 use pocketmine\network\mcpe\protocol\PhotoTransferPacket;
 use pocketmine\network\mcpe\protocol\PlayerActionPacket;
@ -144,7 +145,6 @@ use pocketmine\network\mcpe\protocol\ResourcePackDataInfoPacket;
 use pocketmine\network\mcpe\protocol\ResourcePacksInfoPacket;
 use pocketmine\network\mcpe\protocol\ResourcePackStackPacket;
 use pocketmine\network\mcpe\protocol\RespawnPacket;
-use pocketmine\network\mcpe\protocol\RiderJumpPacket;
 use pocketmine\network\mcpe\protocol\ScriptCustomEventPacket;
 use pocketmine\network\mcpe\protocol\ServerSettingsRequestPacket;
 use pocketmine\network\mcpe\protocol\ServerSettingsResponsePacket;
@ -178,6 +178,8 @@ use pocketmine\network\mcpe\protocol\StopSoundPacket;
 use pocketmine\network\mcpe\protocol\StructureBlockUpdatePacket;
 use pocketmine\network\mcpe\protocol\StructureTemplateDataRequestPacket;
 use pocketmine\network\mcpe\protocol\StructureTemplateDataResponsePacket;
+use pocketmine\network\mcpe\protocol\SubChunkPacket;
+use pocketmine\network\mcpe\protocol\SubChunkRequestPacket;
 use pocketmine\network\mcpe\protocol\SubClientLoginPacket;
 use pocketmine\network\mcpe\protocol\SyncActorPropertyPacket;
 use pocketmine\network\mcpe\protocol\TakeItemActorPacket;
@ -272,7 +274,7 @@ abstract class NetworkSession{
 		return false;
 	}

-	public function handleRiderJump(RiderJumpPacket $packet) : bool{
+	public function handlePassengerJump(PassengerJumpPacket $packet) : bool{
 		return false;
 	}

@ -871,4 +873,12 @@ abstract class NetworkSession{
 	public function handlePhotoInfoRequest(PhotoInfoRequestPacket $packet) : bool{
 		return false;
 	}
+
+	public function handleSubChunk(SubChunkPacket $packet) : bool{
+		return false;
+	}
+
+	public function handleSubChunkRequest(SubChunkRequestPacket $packet) : bool{
+		return false;
+	}
 }
--- a/src/pocketmine/network/mcpe/protocol/EducationSettingsPacket.php
+++ b/src/pocketmine/network/mcpe/protocol/EducationSettingsPacket.php
@ -133,9 +133,10 @@ class EducationSettingsPacket extends DataPacket{
 		$this->putBool($this->disableLegacyTitleBar);
 		$this->putString($this->postProcessFilter);
 		$this->putString($this->screenshotBorderResourcePath);
-		if($this->agentCapabilities !== null){
+		$agentCapabilities = $this->agentCapabilities;
+		if($agentCapabilities !== null){
 			$this->putBool(true);
-			$this->agentCapabilities->write($this);
+			$agentCapabilities->write($this);
 		}else{
 			$this->putBool(false);
 		}
@ -144,9 +145,10 @@ class EducationSettingsPacket extends DataPacket{
 			$this->putString($this->codeBuilderOverrideUri);
 		}
 		$this->putBool($this->hasQuiz);
-		if($this->linkSettings !== null){
+		$linkSettings = $this->linkSettings;
+		if($linkSettings !== null){
 			$this->putBool(true);
-			$this->linkSettings->write($this);
+			$linkSettings->write($this);
 		}else{
 			$this->putBool(false);
 		}
--- a/src/pocketmine/network/mcpe/protocol/PacketPool.php
+++ b/src/pocketmine/network/mcpe/protocol/PacketPool.php
@ -54,7 +54,7 @@ class PacketPool{
 		static::registerPacket(new TakeItemActorPacket());
 		static::registerPacket(new MoveActorAbsolutePacket());
 		static::registerPacket(new MovePlayerPacket());
-		static::registerPacket(new RiderJumpPacket());
+		static::registerPacket(new PassengerJumpPacket());
 		static::registerPacket(new UpdateBlockPacket());
 		static::registerPacket(new AddPaintingPacket());
 		static::registerPacket(new TickSyncPacket());
@ -204,6 +204,8 @@ class PacketPool{
 		static::registerPacket(new CreatePhotoPacket());
 		static::registerPacket(new UpdateSubChunkBlocksPacket());
 		static::registerPacket(new PhotoInfoRequestPacket());
+		static::registerPacket(new SubChunkPacket());
+		static::registerPacket(new SubChunkRequestPacket());
 	}

 	/**
--- a/src/pocketmine/network/mcpe/protocol/PassengerJumpPacket.php
+++ b/src/pocketmine/network/mcpe/protocol/PassengerJumpPacket.php
@ -27,8 +27,8 @@ namespace pocketmine\network\mcpe\protocol;

 use pocketmine\network\mcpe\NetworkSession;

-class RiderJumpPacket extends DataPacket{
-	public const NETWORK_ID = ProtocolInfo::RIDER_JUMP_PACKET;
+class PassengerJumpPacket extends DataPacket{
+	public const NETWORK_ID = ProtocolInfo::PASSENGER_JUMP_PACKET;

 	/** @var int */
 	public $jumpStrength; //percentage
@ -41,7 +41,7 @@ class RiderJumpPacket extends DataPacket{
 		$this->putVarInt($this->jumpStrength);
 	}

-	public function handle(NetworkSession $session) : bool{
-		return $session->handleRiderJump($this);
+	public function handle(NetworkSession $handler) : bool{
+		return $handler->handlePassengerJump($this);
 	}
 }
--- a/src/pocketmine/network/mcpe/protocol/ProtocolInfo.php
+++ b/src/pocketmine/network/mcpe/protocol/ProtocolInfo.php
@ -37,11 +37,11 @@ interface ProtocolInfo{
 	 */

 	/** Actual Minecraft: PE protocol version */
-	public const CURRENT_PROTOCOL = 465;
+	public const CURRENT_PROTOCOL = 471;
 	/** Current Minecraft PE version reported by the server. This is usually the earliest currently supported version. */
-	public const MINECRAFT_VERSION = 'v1.17.30';
+	public const MINECRAFT_VERSION = 'v1.17.40';
 	/** Version number sent to clients in ping responses. */
-	public const MINECRAFT_VERSION_NETWORK = '1.17.30';
+	public const MINECRAFT_VERSION_NETWORK = '1.17.40';

 	public const LOGIN_PACKET = 0x01;
 	public const PLAY_STATUS_PACKET = 0x02;
@ -62,7 +62,7 @@ interface ProtocolInfo{
 	public const TAKE_ITEM_ACTOR_PACKET = 0x11;
 	public const MOVE_ACTOR_ABSOLUTE_PACKET = 0x12;
 	public const MOVE_PLAYER_PACKET = 0x13;
-	public const RIDER_JUMP_PACKET = 0x14;
+	public const PASSENGER_JUMP_PACKET = 0x14;
 	public const UPDATE_BLOCK_PACKET = 0x15;
 	public const ADD_PAINTING_PACKET = 0x16;
 	public const TICK_SYNC_PACKET = 0x17;
@ -216,5 +216,7 @@ interface ProtocolInfo{
 	public const CREATE_PHOTO_PACKET = 0xab;
 	public const UPDATE_SUB_CHUNK_BLOCKS_PACKET = 0xac;
 	public const PHOTO_INFO_REQUEST_PACKET = 0xad;
+	public const SUB_CHUNK_PACKET = 0xae;
+	public const SUB_CHUNK_REQUEST_PACKET = 0xaf;

 }
--- a/src/pocketmine/network/mcpe/protocol/SubChunkPacket.php
+++ b/src/pocketmine/network/mcpe/protocol/SubChunkPacket.php
@ -0,0 +1,109 @@
+<?php
+
+/*
+ *
+ *  ____            _        _   __  __ _                  __  __ ____
+ * |  _ \ ___   ___| | _____| |_|  \/  (_)_ __   ___      |  \/  |  _ \
+ * | |_) / _ \ / __| |/ / _ \ __| |\/| | | '_ \ / _ \_____| |\/| | |_) |
+ * |  __/ (_) | (__|   <  __/ |_| |  | | | | | |  __/_____| |  | |  __/
+ * |_|   \___/ \___|_|\_\___|\__|_|  |_|_|_| |_|\___|     |_|  |_|_|
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * @author PocketMine Team
+ * @link http://www.pocketmine.net/
+ *
+ *
+*/
+
+declare(strict_types=1);
+
+namespace pocketmine\network\mcpe\protocol;
+
+#include <rules/DataPacket.h>
+
+use pocketmine\network\mcpe\NetworkSession;
+use pocketmine\network\mcpe\protocol\types\SubChunkPacketHeightMapInfo;
+use pocketmine\network\mcpe\protocol\types\SubChunkPacketHeightMapType;
+
+class SubChunkPacket extends DataPacket{
+	public const NETWORK_ID = ProtocolInfo::SUB_CHUNK_PACKET;
+
+	private int $dimension;
+	private int $subChunkX;
+	private int $subChunkY;
+	private int $subChunkZ;
+	private string $data;
+	private int $requestResult;
+	private ?SubChunkPacketHeightMapInfo $heightMapData = null;
+
+	public static function create(int $dimension, int $subChunkX, int $subChunkY, int $subChunkZ, string $data, int $requestResult, ?SubChunkPacketHeightMapInfo $heightMapData) : self{
+		$result = new self;
+		$result->dimension = $dimension;
+		$result->subChunkX = $subChunkX;
+		$result->subChunkY = $subChunkY;
+		$result->subChunkZ = $subChunkZ;
+		$result->data = $data;
+		$result->requestResult = $requestResult;
+		$result->heightMapData = $heightMapData;
+		return $result;
+	}
+
+	public function getDimension() : int{ return $this->dimension; }
+
+	public function getSubChunkX() : int{ return $this->subChunkX; }
+
+	public function getSubChunkY() : int{ return $this->subChunkY; }
+
+	public function getSubChunkZ() : int{ return $this->subChunkZ; }
+
+	public function getData() : string{ return $this->data; }
+
+	public function getRequestResult() : int{ return $this->requestResult; }
+
+	public function getHeightMapData() : ?SubChunkPacketHeightMapInfo{ return $this->heightMapData; }
+
+	protected function decodePayload() : void{
+		$this->dimension = $this->getVarInt();
+		$this->subChunkX = $this->getVarInt();
+		$this->subChunkY = $this->getVarInt();
+		$this->subChunkZ = $this->getVarInt();
+		$this->data = $this->getString();
+		$this->requestResult = $this->getVarInt();
+		$heightMapDataType = $this->getByte();
+		$this->heightMapData = match($heightMapDataType){
+			SubChunkPacketHeightMapType::NO_DATA => null,
+			SubChunkPacketHeightMapType::DATA => SubChunkPacketHeightMapInfo::read($this),
+			SubChunkPacketHeightMapType::ALL_TOO_HIGH => SubChunkPacketHeightMapInfo::allTooHigh(),
+			SubChunkPacketHeightMapType::ALL_TOO_LOW => SubChunkPacketHeightMapInfo::allTooLow(),
+			default => throw new \UnexpectedValueException("Unknown heightmap data type $heightMapDataType")
+		};
+	}
+
+	protected function encodePayload() : void{
+		$this->putVarInt($this->dimension);
+		$this->putVarInt($this->subChunkX);
+		$this->putVarInt($this->subChunkY);
+		$this->putVarInt($this->subChunkZ);
+		$this->putString($this->data);
+		$this->putVarInt($this->requestResult);
+		if($this->heightMapData === null){
+			$this->putByte(SubChunkPacketHeightMapType::NO_DATA);
+		}elseif($this->heightMapData->isAllTooLow()){
+			$this->putByte(SubChunkPacketHeightMapType::ALL_TOO_LOW);
+		}elseif($this->heightMapData->isAllTooHigh()){
+			$this->putByte(SubChunkPacketHeightMapType::ALL_TOO_HIGH);
+		}else{
+			$heightMapData = $this->heightMapData; //avoid PHPStan purity issue
+			$this->putByte(SubChunkPacketHeightMapType::DATA);
+			$heightMapData->write($this);
+		}
+	}
+
+	public function handle(NetworkSession $handler) : bool{
+		return $handler->handleSubChunk($this);
+	}
+}
--- a/src/pocketmine/network/mcpe/protocol/SubChunkRequestPacket.php
+++ b/src/pocketmine/network/mcpe/protocol/SubChunkRequestPacket.php
@ -0,0 +1,72 @@
+<?php
+
+/*
+ *
+ *  ____            _        _   __  __ _                  __  __ ____
+ * |  _ \ ___   ___| | _____| |_|  \/  (_)_ __   ___      |  \/  |  _ \
+ * | |_) / _ \ / __| |/ / _ \ __| |\/| | | '_ \ / _ \_____| |\/| | |_) |
+ * |  __/ (_) | (__|   <  __/ |_| |  | | | | | |  __/_____| |  | |  __/
+ * |_|   \___/ \___|_|\_\___|\__|_|  |_|_|_| |_|\___|     |_|  |_|_|
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * @author PocketMine Team
+ * @link http://www.pocketmine.net/
+ *
+ *
+*/
+
+declare(strict_types=1);
+
+namespace pocketmine\network\mcpe\protocol;
+
+#include <rules/DataPacket.h>
+
+use pocketmine\network\mcpe\NetworkSession;
+
+class SubChunkRequestPacket extends DataPacket/* implements ServerboundPacket*/{
+	public const NETWORK_ID = ProtocolInfo::SUB_CHUNK_REQUEST_PACKET;
+
+	private int $dimension;
+	private int $subChunkX;
+	private int $subChunkY;
+	private int $subChunkZ;
+
+	public static function create(int $dimension, int $subChunkX, int $subChunkY, int $subChunkZ) : self{
+		$result = new self;
+		$result->dimension = $dimension;
+		$result->subChunkX = $subChunkX;
+		$result->subChunkY = $subChunkY;
+		$result->subChunkZ = $subChunkZ;
+		return $result;
+	}
+
+	public function getDimension() : int{ return $this->dimension; }
+
+	public function getSubChunkX() : int{ return $this->subChunkX; }
+
+	public function getSubChunkY() : int{ return $this->subChunkY; }
+
+	public function getSubChunkZ() : int{ return $this->subChunkZ; }
+
+	protected function decodePayload() : void{
+		$this->dimension = $this->getVarInt();
+		$this->subChunkX = $this->getVarInt();
+		$this->subChunkY = $this->getVarInt();
+		$this->subChunkZ = $this->getVarInt();
+	}
+
+	protected function encodePayload() : void{
+		$this->putVarInt($this->dimension);
+		$this->putVarInt($this->subChunkX);
+		$this->putVarInt($this->subChunkY);
+		$this->putVarInt($this->subChunkZ);
+	}
+
+	public function handle(NetworkSession $handler) : bool{
+		return $handler->handleSubChunkRequest($this);
+	}
+}
--- a/src/pocketmine/network/mcpe/protocol/types/SubChunkPacketHeightMapInfo.php
+++ b/src/pocketmine/network/mcpe/protocol/types/SubChunkPacketHeightMapInfo.php
@ -0,0 +1,89 @@
+<?php
+
+/*
+ *
+ *  ____            _        _   __  __ _                  __  __ ____
+ * |  _ \ ___   ___| | _____| |_|  \/  (_)_ __   ___      |  \/  |  _ \
+ * | |_) / _ \ / __| |/ / _ \ __| |\/| | | '_ \ / _ \_____| |\/| | |_) |
+ * |  __/ (_) | (__|   <  __/ |_| |  | | | | | |  __/_____| |  | |  __/
+ * |_|   \___/ \___|_|\_\___|\__|_|  |_|_|_| |_|\___|     |_|  |_|_|
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * @author PocketMine Team
+ * @link http://www.pocketmine.net/
+ *
+ *
+*/
+
+declare(strict_types=1);
+
+namespace pocketmine\network\mcpe\protocol\types;
+
+use pocketmine\network\mcpe\NetworkBinaryStream;
+use pocketmine\utils\Binary;
+use function array_fill;
+use function count;
+
+class SubChunkPacketHeightMapInfo{
+
+	/**
+	 * @param int[] $heights ZZZZXXXX key bit order
+	 * @phpstan-param list<int> $heights
+	 */
+	public function __construct(private array $heights){
+		if(count($heights) !== 256){
+			throw new \InvalidArgumentException("Expected exactly 256 heightmap values");
+		}
+	}
+
+	/** @return int[] */
+	public function getHeights() : array{ return $this->heights; }
+
+	public function getHeight(int $x, int $z) : int{
+		return $this->heights[(($z & 0xf) << 4) | ($x & 0xf)];
+	}
+
+	public static function read(NetworkBinaryStream $in) : self{
+		$heights = [];
+		for($i = 0; $i < 256; ++$i){
+			$heights[] = Binary::signByte($in->getByte());
+		}
+		return new self($heights);
+	}
+
+	public function write(NetworkBinaryStream $out) : void{
+		for($i = 0; $i < 256; ++$i){
+			$out->putByte(Binary::unsignByte($this->heights[$i]));
+		}
+	}
+
+	public static function allTooLow() : self{
+		return new self(array_fill(0, 256, -1));
+	}
+
+	public static function allTooHigh() : self{
+		return new self(array_fill(0, 256, 16));
+	}
+
+	public function isAllTooLow() : bool{
+		foreach($this->heights as $height){
+			if($height >= 0){
+				return false;
+			}
+		}
+		return true;
+	}
+
+	public function isAllTooHigh() : bool{
+		foreach($this->heights as $height){
+			if($height <= 15){
+				return false;
+			}
+		}
+		return true;
+	}
+}
--- a/src/pocketmine/network/mcpe/protocol/types/inventory/stackrequest/CraftRecipeStackRequestActionTrait.php
+++ b/src/pocketmine/network/mcpe/protocol/types/inventory/stackrequest/CraftRecipeStackRequestActionTrait.php
@ -21,27 +21,12 @@

 declare(strict_types=1);

-namespace pocketmine\network\mcpe\protocol\types\inventory\stackrequest;
+namespace pocketmine\network\mcpe\protocol\types;

-use pocketmine\network\mcpe\NetworkBinaryStream;
+final class SubChunkPacketHeightMapType{

-trait CraftRecipeStackRequestActionTrait{
-
-	/** @var int */
-	private $recipeId;
-
-	final public function __construct(int $recipeId){
-		$this->recipeId = $recipeId;
-	}
-
-	public function getRecipeId() : int{ return $this->recipeId; }
-
-	public static function read(NetworkBinaryStream $in) : self{
-		$recipeId = $in->readGenericTypeNetworkId();
-		return new self($recipeId);
-	}
-
-	public function write(NetworkBinaryStream $out) : void{
-		$out->writeGenericTypeNetworkId($this->recipeId);
-	}
-}
+	public const NO_DATA = 0;
+	public const DATA = 1;
+	public const ALL_TOO_HIGH = 2;
+	public const ALL_TOO_LOW = 3;
+}
--- a/src/pocketmine/network/mcpe/protocol/types/SubChunkRequestResult.php
+++ b/src/pocketmine/network/mcpe/protocol/types/SubChunkRequestResult.php
@ -0,0 +1,34 @@
+<?php
+
+/*
+ *
+ *  ____            _        _   __  __ _                  __  __ ____
+ * |  _ \ ___   ___| | _____| |_|  \/  (_)_ __   ___      |  \/  |  _ \
+ * | |_) / _ \ / __| |/ / _ \ __| |\/| | | '_ \ / _ \_____| |\/| | |_) |
+ * |  __/ (_) | (__|   <  __/ |_| |  | | | | | |  __/_____| |  | |  __/
+ * |_|   \___/ \___|_|\_\___|\__|_|  |_|_|_| |_|\___|     |_|  |_|_|
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * @author PocketMine Team
+ * @link http://www.pocketmine.net/
+ *
+ *
+*/
+
+declare(strict_types=1);
+
+namespace pocketmine\network\mcpe\protocol\types;
+
+final class SubChunkRequestResult{
+
+	public const SUCCESS = 1;
+	//why even respond at all in these cases? ...
+	public const NO_SUCH_CHUNK = 2;
+	public const WRONG_DIMENSION = 3;
+	public const NULL_PLAYER = 4;
+	public const Y_INDEX_OUT_OF_BOUNDS = 5;
+}
--- a/src/pocketmine/network/mcpe/protocol/types/inventory/stackrequest/CraftRecipeAutoStackRequestAction.php
+++ b/src/pocketmine/network/mcpe/protocol/types/inventory/stackrequest/CraftRecipeAutoStackRequestAction.php
@ -23,12 +23,38 @@ declare(strict_types=1);

 namespace pocketmine\network\mcpe\protocol\types\inventory\stackrequest;

+use pocketmine\network\mcpe\NetworkBinaryStream;
+
 /**
 * Tells that the current transaction crafted the specified recipe, using the recipe book. This is effectively the same
 * as the regular crafting result action.
 */
 final class CraftRecipeAutoStackRequestAction extends ItemStackRequestAction{
-	use CraftRecipeStackRequestActionTrait;
+
+	/** @var int */
+	private $recipeId;
+	/** @var int */
+	private $repetitions;
+
+	final public function __construct(int $recipeId, int $repetitions){
+		$this->recipeId = $recipeId;
+		$this->repetitions = $repetitions;
+	}
+
+	public function getRecipeId() : int{ return $this->recipeId; }
+
+	public function getRepetitions() : int{ return $this->repetitions; }

 	public static function getTypeId() : int{ return ItemStackRequestActionType::CRAFTING_RECIPE_AUTO; }
+
+	public static function read(NetworkBinaryStream $in) : self{
+		$recipeId = $in->readGenericTypeNetworkId();
+		$repetitions = $in->getByte();
+		return new self($recipeId, $repetitions);
+	}
+
+	public function write(NetworkBinaryStream $out) : void{
+		$out->writeGenericTypeNetworkId($this->recipeId);
+		$out->putByte($this->repetitions);
+	}
 }
--- a/src/pocketmine/network/mcpe/protocol/types/inventory/stackrequest/CraftRecipeStackRequestAction.php
+++ b/src/pocketmine/network/mcpe/protocol/types/inventory/stackrequest/CraftRecipeStackRequestAction.php
@ -23,11 +23,30 @@ declare(strict_types=1);

 namespace pocketmine\network\mcpe\protocol\types\inventory\stackrequest;

+use pocketmine\network\mcpe\NetworkBinaryStream;
+
 /**
 * Tells that the current transaction crafted the specified recipe.
 */
 final class CraftRecipeStackRequestAction extends ItemStackRequestAction{
-	use CraftRecipeStackRequestActionTrait;
+
+	/** @var int */
+	private $recipeId;
+
+	final public function __construct(int $recipeId){
+		$this->recipeId = $recipeId;
+	}
+
+	public function getRecipeId() : int{ return $this->recipeId; }

 	public static function getTypeId() : int{ return ItemStackRequestActionType::CRAFTING_RECIPE; }
+
+	public static function read(NetworkBinaryStream $in) : self{
+		$recipeId = $in->readGenericTypeNetworkId();
+		return new self($recipeId);
+	}
+
+	public function write(NetworkBinaryStream $out) : void{
+		$out->writeGenericTypeNetworkId($this->recipeId);
+	}
 }
--- a/src/pocketmine/network/rcon/RCON.php
+++ b/src/pocketmine/network/rcon/RCON.php
@ -57,24 +57,15 @@ use const SOL_TCP;
 class RCON{
 	/** @var Server */
 	private $server;
-	/**
-	 * @var \Socket|resource
-	 * @phpstan-var PhpSocket
-	 */
+	/** @var \Socket */
 	private $socket;

 	/** @var RCONInstance */
 	private $instance;

-	/**
-	 * @var \Socket|resource
-	 * @phpstan-var PhpSocket
-	 */
+	/** @var \Socket */
 	private $ipcMainSocket;
-	/**
-	 * @var resource
-	 * @phpstan-var PhpSocket
-	 */
+	/** @var \Socket */
 	private $ipcThreadSocket;

 	public function __construct(Server $server, string $password, int $port = 19132, string $interface = "0.0.0.0", int $maxClients = 50){
--- a/src/pocketmine/network/rcon/RCONInstance.php
+++ b/src/pocketmine/network/rcon/RCONInstance.php
@ -60,10 +60,7 @@ class RCONInstance extends Thread{

 	/** @var bool */
 	private $stop;
-	/**
-	 * @var \Socket|resource
-	 * @phpstan-var PhpSocket
-	 */
+	/** @var \Socket */
 	private $socket;
 	/** @var string */
 	private $password;
@ -71,21 +68,12 @@ class RCONInstance extends Thread{
 	private $maxClients;
 	/** @var \ThreadedLogger */
 	private $logger;
-	/**
-	 * @var \Socket|resource
-	 * @phpstan-var PhpSocket
-	 */
+	/** @var \Socket */
 	private $ipcSocket;
 	/** @var SleeperNotifier|null */
 	private $notifier;

-	/**
-	 * @param \Socket|resource             $socket
-	 * @param \Socket|resource             $ipcSocket
-	 * @phpstan-param PhpSocket $socket
-	 * @phpstan-param PhpSocket $ipcSocket
-	 */
-	public function __construct($socket, string $password, int $maxClients, \ThreadedLogger $logger, $ipcSocket, ?SleeperNotifier $notifier){
+	public function __construct(\Socket $socket, string $password, int $maxClients, \ThreadedLogger $logger, \Socket $ipcSocket, ?SleeperNotifier $notifier){
 		$this->stop = false;
 		$this->cmd = "";
 		$this->response = "";
@ -100,12 +88,9 @@ class RCONInstance extends Thread{
 	}

 	/**
-	 * @param \Socket|resource $client
-	 * @phpstan-param PhpSocket $client
-	 *
 	 * @return int|false
 	 */
-	private function writePacket($client, int $requestID, int $packetType, string $payload){
+	private function writePacket(\Socket $client, int $requestID, int $packetType, string $payload){
 		$pk = Binary::writeLInt($requestID)
 			. Binary::writeLInt($packetType)
 			. $payload
@ -114,15 +99,13 @@ class RCONInstance extends Thread{
 	}

 	/**
-	 * @param \Socket|resource $client
 	 * @param int      $requestID reference parameter
 	 * @param int      $packetType reference parameter
 	 * @param string   $payload reference parameter
-	 * @phpstan-param PhpSocket $client
 	 *
 	 * @return bool
 	 */
-	private function readPacket($client, ?int &$requestID, ?int &$packetType, ?string &$payload){
+	private function readPacket(\Socket $client, ?int &$requestID, ?int &$packetType, ?string &$payload){
 		$d = @socket_read($client, 4);

 		socket_getpeername($client, $ip, $port);
@ -176,8 +159,8 @@ class RCONInstance extends Thread{
 		$this->registerClassLoader();

 		/**
-		 * @var \Socket[]|resource[] $clients
-		 * @phpstan-var array<int, PhpSocket> $clients
+		 * @var \Socket[] $clients
+		 * @phpstan-var array<int, \Socket> $clients
 		 */
 		$clients = [];
 		/** @var bool[] $authenticated */
@ -277,11 +260,7 @@ class RCONInstance extends Thread{
 		}
 	}

-	/**
-	 * @param \Socket|resource $client
-	 * @phpstan-param PhpSocket $client
-	 */
-	private function disconnectClient($client) : void{
+	private function disconnectClient(\Socket $client) : void{
 		socket_getpeername($client, $ip, $port);
 		@socket_set_option($client, SOL_SOCKET, SO_LINGER, ["l_onoff" => 1, "l_linger" => 1]);
 		@socket_shutdown($client, 2);
--- a/src/pocketmine/resources/vanilla
+++ b/src/pocketmine/resources/vanilla
--- a/src/pocketmine/utils/Internet.php
+++ b/src/pocketmine/utils/Internet.php
@ -31,6 +31,7 @@ use function curl_getinfo;
 use function curl_init;
 use function curl_setopt_array;
 use function explode;
+use function is_int;
 use function is_string;
 use function preg_match;
 use function socket_close;
@ -196,7 +197,7 @@ class Internet{
 	 * @param callable|null $onSuccess    function to be called if there is no error. Accepts a resource argument as the cURL handle.
 	 * @phpstan-param array<int, mixed>                $extraOpts
 	 * @phpstan-param list<string>                     $extraHeaders
-	 * @phpstan-param (callable(PhpCurlHandle) : void)|null $onSuccess
+	 * @phpstan-param (callable(\CurlHandle) : void)|null $onSuccess
 	 *
 	 * @return array a plain array of three [result body : string, headers : string[][], HTTP response code : int]. Headers are grouped by requests with strtolower(header name) as keys and header value as values
 	 * @phpstan-return array{string, list<array<string, string>>, int}
@ -233,6 +234,7 @@ class Internet{
 			}
 			if(!is_string($raw)) throw new AssumptionFailedError("curl_exec() should return string|false when CURLOPT_RETURNTRANSFER is set");
 			$httpCode = curl_getinfo($ch, CURLINFO_HTTP_CODE);
+			if(!is_int($httpCode)) throw new AssumptionFailedError("curl_getinfo(CURLINFO_HTTP_CODE) always returns int");
 			$headerSize = curl_getinfo($ch, CURLINFO_HEADER_SIZE);
 			$rawHeaders = substr($raw, 0, $headerSize);
 			$body = substr($raw, $headerSize);
--- a/src/pocketmine/utils/Timezone.php
+++ b/src/pocketmine/utils/Timezone.php
@ -201,9 +201,6 @@ abstract class Timezone{
 		}

 		$parsed = date_parse($offset);
-		if($parsed === false){
-			return false;
-		}
 		$offset = $parsed['hour'] * 3600 + $parsed['minute'] * 60 + $parsed['second'];

 		//After date_parse is done, put the sign back
--- a/src/pocketmine/utils/Utils.php
+++ b/src/pocketmine/utils/Utils.php
@ -454,7 +454,7 @@ class Utils{
 	 * @param callable|null $onSuccess    function to be called if there is no error. Accepts a resource argument as the cURL handle.
 	 * @phpstan-param array<int, mixed>                $extraOpts
 	 * @phpstan-param list<string>                     $extraHeaders
-	 * @phpstan-param (callable(PhpCurlHandle) : void)|null $onSuccess
+	 * @phpstan-param (callable(\CurlHandle) : void)|null $onSuccess
 	 *
 	 * @return array a plain array of three [result body : string, headers : string[][], HTTP response code : int]. Headers are grouped by requests with strtolower(header name) as keys and header value as values
 	 * @phpstan-return array{string, list<array<string, string>>, int}
@ -642,7 +642,6 @@ class Utils{
 		preg_match_all('/(*ANYCRLF)^[\t ]*(?:\* )?@([a-zA-Z]+)(?:[\t ]+(.+?))?[\t ]*$/m', $rawDocComment, $matches);

 		$result = array_combine($matches[1], $matches[2]);
-		if($result === false) throw new AssumptionFailedError("array_combine() doesn't return false with two equal-sized arrays");
 		return $result;
 	}

--- a/tests/gh-actions/build.sh
+++ b/tests/gh-actions/build.sh
@ -17,7 +17,7 @@ INSTALL_DIR="$(pwd)/bin/php7"
 export CFLAGS="$CFLAGS -march=x86-64"
 export CXXFLAGS="$CXXFLAGS -march=x86-64"

-git clone https://github.com/php-build/php-build.git
+git clone https://github.com/pmmp/php-build.git
 cd php-build
 ./install-dependencies.sh
 echo '"pthreads",,"https://github.com/pmmp/pthreads.git",,,"extension",' >> share/php-build/extension/definition
--- a/tests/phpstan/configs/check-explicit-mixed-baseline.neon
+++ b/tests/phpstan/configs/check-explicit-mixed-baseline.neon
@ -42,7 +42,7 @@ parameters:

 		-
 			message: "#^Parameter \\#1 \\$string of function base64_decode expects string, mixed given\\.$#"
-			count: 5
+			count: 6
 			path: ../../../src/pocketmine/Player.php

 		-
@ -51,27 +51,32 @@ parameters:
 			path: ../../../src/pocketmine/Player.php

 		-
-			message: "#^Parameter \\#10 \\$persona of class pocketmine\\\\network\\\\mcpe\\\\protocol\\\\types\\\\SkinData constructor expects bool, mixed given\\.$#"
+			message: "#^Parameter \\#10 \\$capeId of class pocketmine\\\\network\\\\mcpe\\\\protocol\\\\types\\\\SkinData constructor expects string, mixed given\\.$#"
 			count: 1
 			path: ../../../src/pocketmine/Player.php

 		-
-			message: "#^Parameter \\#11 \\$personaCapeOnClassic of class pocketmine\\\\network\\\\mcpe\\\\protocol\\\\types\\\\SkinData constructor expects bool, mixed given\\.$#"
+			message: "#^Parameter \\#12 \\$armSize of class pocketmine\\\\network\\\\mcpe\\\\protocol\\\\types\\\\SkinData constructor expects string, mixed given\\.$#"
 			count: 1
 			path: ../../../src/pocketmine/Player.php

 		-
-			message: "#^Parameter \\#12 \\$capeId of class pocketmine\\\\network\\\\mcpe\\\\protocol\\\\types\\\\SkinData constructor expects string, mixed given\\.$#"
+			message: "#^Parameter \\#13 \\$skinColor of class pocketmine\\\\network\\\\mcpe\\\\protocol\\\\types\\\\SkinData constructor expects string, mixed given\\.$#"
 			count: 1
 			path: ../../../src/pocketmine/Player.php

 		-
-			message: "#^Parameter \\#14 \\$armSize of class pocketmine\\\\network\\\\mcpe\\\\protocol\\\\types\\\\SkinData constructor expects string, mixed given\\.$#"
+			message: "#^Parameter \\#17 \\$premium of class pocketmine\\\\network\\\\mcpe\\\\protocol\\\\types\\\\SkinData constructor expects bool, mixed given\\.$#"
 			count: 1
 			path: ../../../src/pocketmine/Player.php

 		-
-			message: "#^Parameter \\#15 \\$skinColor of class pocketmine\\\\network\\\\mcpe\\\\protocol\\\\types\\\\SkinData constructor expects string, mixed given\\.$#"
+			message: "#^Parameter \\#18 \\$persona of class pocketmine\\\\network\\\\mcpe\\\\protocol\\\\types\\\\SkinData constructor expects bool, mixed given\\.$#"
+			count: 1
+			path: ../../../src/pocketmine/Player.php
+
+		-
+			message: "#^Parameter \\#19 \\$personaCapeOnClassic of class pocketmine\\\\network\\\\mcpe\\\\protocol\\\\types\\\\SkinData constructor expects bool, mixed given\\.$#"
 			count: 1
 			path: ../../../src/pocketmine/Player.php

@ -85,11 +90,6 @@ parameters:
 			count: 2
 			path: ../../../src/pocketmine/Player.php

-		-
-			message: "#^Parameter \\#9 \\$premium of class pocketmine\\\\network\\\\mcpe\\\\protocol\\\\types\\\\SkinData constructor expects bool, mixed given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/Player.php
-
 		-
 			message: "#^Cannot access offset 'git' on mixed\\.$#"
 			count: 2
--- a/tests/phpstan/configs/l7-baseline.neon
+++ b/tests/phpstan/configs/l7-baseline.neon
@ -41,7 +41,12 @@ parameters:
 			path: ../../../src/pocketmine/Player.php

 		-
-			message: "#^Parameter \\#8 \\$animationData of class pocketmine\\\\network\\\\mcpe\\\\protocol\\\\types\\\\SkinData constructor expects string, string\\|false given\\.$#"
+			message: "#^Parameter \\#8 \\$geometryDataEngineVersion of class pocketmine\\\\network\\\\mcpe\\\\protocol\\\\types\\\\SkinData constructor expects string, string\\|false given\\.$#"
+			count: 1
+			path: ../../../src/pocketmine/Player.php
+
+		-
+			message: "#^Parameter \\#9 \\$animationData of class pocketmine\\\\network\\\\mcpe\\\\protocol\\\\types\\\\SkinData constructor expects string, string\\|false given\\.$#"
 			count: 1
 			path: ../../../src/pocketmine/Player.php

@ -70,11 +75,6 @@ parameters:
 			count: 2
 			path: ../../../src/pocketmine/PocketMine.php

-		-
-			message: "#^Cannot cast array\\<int, mixed\\>\\|string\\|false to int\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/Server.php
-
 		-
 			message: "#^Cannot cast array\\<int, mixed\\>\\|string\\|false to string\\.$#"
 			count: 1
--- a/tests/phpstan/configs/l8-baseline.neon
+++ b/tests/phpstan/configs/l8-baseline.neon
@ -260,11 +260,6 @@ parameters:
 			count: 1
 			path: ../../../src/pocketmine/block/BaseRail.php

-		-
-			message: "#^Parameter \\#1 \\$constraint of method pocketmine\\\\block\\\\BaseRail\\:\\:getPossibleConnectionDirectionsOneConstraint\\(\\) expects int, int\\|null given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/block/BaseRail.php
-
 		-
 			message: "#^Only numeric types are allowed in \\-, int\\|null given on the left side\\.$#"
 			count: 1
--- a/tests/phpstan/configs/php7.neon
+++ b/tests/phpstan/configs/php7.neon
@ -1,112 +0,0 @@
-parameters:
-	ignoreErrors:
-		-
-			message: "#^Parameter \\#1 \\$fp of function fclose expects resource, resource\\|false given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/MemoryManager.php
-
-		-
-			message: "#^Parameter \\#1 \\$fp of function fwrite expects resource, resource\\|false given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/MemoryManager.php
-
-		-
-			message: "#^Parameter \\#1 \\$str of function base64_decode expects string, mixed given\\.$#"
-			count: 5
-			path: ../../../src/pocketmine/Player.php
-
-		-
-			message: "#^Parameter \\#1 \\$input of function array_filter expects array, array\\<int, string\\>\\|false given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/Server.php
-
-		-
-			message: "#^Parameter \\#1 \\$str of function strtolower expects string, mixed given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/Server.php
-
-		-
-			message: "#^Parameter \\#1 \\$number of function round expects float, mixed given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/command/defaults/StatusCommand.php
-
-		-
-			message: "#^Parameter \\#1 \\$fp of function fclose expects resource, resource\\|false given\\.$#"
-			count: 2
-			path: ../../../src/pocketmine/command/defaults/TimingsCommand.php
-
-		-
-			message: "#^Parameter \\#1 \\$fp of function fseek expects resource, resource\\|false given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/command/defaults/TimingsCommand.php
-
-		-
-			message: "#^Parameter \\#1 \\$source of function stream_get_contents expects resource, resource\\|false given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/command/defaults/TimingsCommand.php
-
-		-
-			message: "#^Parameter \\#1 \\$argument of class ReflectionClass constructor expects class\\-string\\<T of object\\>\\|T of object, string given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/event/HandlerList.php
-
-		-
-			message: "#^Parameter \\#2 \\$input1 of function array_map expects array, array\\|false given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/lang/BaseLang.php
-
-		-
-			message: "#^Parameter \\#2 \\$str of function explode expects string, mixed given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/level/format/io/leveldb/LevelDB.php
-
-		-
-			message: "#^Parameter \\#1 \\$input of function array_filter expects array, array\\<int, string\\>\\|false given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/level/format/io/region/McRegion.php
-
-		-
-			message: "#^Parameter \\#1 \\$str of function str_split expects string, string\\|false given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/network/mcpe/VerifyLoginTask.php
-
-		-
-			message: "#^Parameter \\#1 \\$str of function mb_strtoupper expects string, mixed given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/plugin/PluginDescription.php
-
-		-
-			message: "#^Parameter \\#1 \\$variable_representation of function unserialize expects string, mixed given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/scheduler/AsyncTask.php
-
-		-
-			message: "#^Parameter \\#1 \\$str of function strtolower expects string, mixed given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/updater/AutoUpdater.php
-
-		-
-			message: "#^Parameter \\#2 \\$timestamp of function date expects int, mixed given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/updater/AutoUpdater.php
-
-		-
-			message: "#^Parameter \\#2 \\$start of function substr expects int, mixed given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/utils/Internet.php
-
-		-
-			message: "#^Parameter \\#3 \\$length of function substr expects int, mixed given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/utils/Internet.php
-
-		-
-			message: "#^Parameter \\#2 \\$input1 of function array_map expects array, mixed given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/utils/Utils.php
-
-		-
-			message: "#^Method ReflectionMethod\\:\\:getClosure\\(\\) invoked with 0 parameters, 1 required\\.$#"
-			count: 1
-			path: ../../phpunit/network/mcpe/StupidJsonDecodeTest.php
-
--- a/tests/phpstan/configs/php74-compat.neon
+++ b/tests/phpstan/configs/php74-compat.neon
@ -1,11 +0,0 @@
-parameters:
-	ignoreErrors:
-		-
-			message: "#^Strict comparison using \\=\\=\\= between array\\<string, mixed\\> and false will always evaluate to false\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/utils/Timezone.php
-
-		-
-			message: "#^Strict comparison using \\=\\=\\= between array and false will always evaluate to false\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/utils/Utils.php
--- a/tests/phpstan/configs/phpstan-bugs.neon
+++ b/tests/phpstan/configs/phpstan-bugs.neon
@ -1,15 +1,60 @@
 parameters:
 	ignoreErrors:
+		-
+			message: "#^Parameter \\#2 \\$callback of function array_filter expects \\(callable\\(mixed, mixed\\)\\: bool\\)\\|null, Closure\\(pocketmine\\\\Player\\)\\: bool given\\.$#"
+			count: 1
+			path: ../../../src/pocketmine/Server.php
+
+		-
+			message: "#^Parameter \\#2 \\$callback of function array_filter expects \\(callable\\(mixed, mixed\\)\\: bool\\)\\|null, Closure\\(string\\)\\: bool given\\.$#"
+			count: 1
+			path: ../../../src/pocketmine/Server.php
+
 		-
 			message: "#^Call to function is_resource\\(\\) with resource will always evaluate to true\\.$#"
 			count: 3
 			path: ../../../src/pocketmine/command/CommandReader.php

+		-
+			message: "#^Parameter \\#2 \\$callback of function array_filter expects \\(callable\\(mixed, mixed\\)\\: bool\\)\\|null, Closure\\(pocketmine\\\\Player\\)\\: bool given\\.$#"
+			count: 1
+			path: ../../../src/pocketmine/command/defaults/ListCommand.php
+
+		-
+			message: "#^Parameter \\#2 \\$callback of function array_filter expects \\(callable\\(mixed, mixed\\)\\: bool\\)\\|null, Closure\\(pocketmine\\\\entity\\\\Attribute\\)\\: bool given\\.$#"
+			count: 1
+			path: ../../../src/pocketmine/entity/AttributeMap.php
+
+		-
+			message: "#^Parameter \\#2 \\$callback of function array_filter expects \\(callable\\(mixed, mixed\\)\\: bool\\)\\|null, Closure\\(pocketmine\\\\item\\\\Item\\)\\: bool given\\.$#"
+			count: 1
+			path: ../../../src/pocketmine/entity/Human.php
+
 		-
 			message: "#^Call to function assert\\(\\) with false and 'unknown hit type' will always evaluate to false\\.$#"
 			count: 1
 			path: ../../../src/pocketmine/entity/projectile/Projectile.php

+		-
+			message: "#^Parameter \\#2 \\$callback of function usort expects callable\\(mixed, mixed\\)\\: int, array\\('pocketmine\\\\\\\\inventory\\\\\\\\CraftingManager', 'sort'\\) given\\.$#"
+			count: 1
+			path: ../../../src/pocketmine/inventory/CraftingManager.php
+
+		-
+			message: "#^Parameter \\#2 \\$callback of function array_filter expects \\(callable\\(mixed, mixed\\)\\: bool\\)\\|null, Closure\\(string\\)\\: bool given\\.$#"
+			count: 1
+			path: ../../../src/pocketmine/lang/BaseLang.php
+
+		-
+			message: "#^Parameter \\#2 \\$callback of function array_filter expects \\(callable\\(mixed, mixed\\)\\: bool\\)\\|null, Closure\\(pocketmine\\\\entity\\\\Entity\\)\\: bool given\\.$#"
+			count: 1
+			path: ../../../src/pocketmine/level/format/Chunk.php
+
+		-
+			message: "#^Parameter \\#2 \\$callback of function array_filter expects \\(callable\\(mixed, mixed\\)\\: bool\\)\\|null, Closure\\(string\\)\\: bool given\\.$#"
+			count: 1
+			path: ../../../src/pocketmine/level/format/io/region/McRegion.php
+
 		-
 			message: "#^Call to function is_resource\\(\\) with resource will always evaluate to true\\.$#"
 			count: 2
@ -25,11 +70,6 @@ parameters:
 			count: 1
 			path: ../../../src/pocketmine/network/mcpe/protocol/DataPacket.php

-		-
-			message: "#^Parameter \\#1 \\$ of closure expects TMemberType, TMemberType given\\.$#"
-			count: 1
-			path: ../../../src/pocketmine/utils/Utils.php
-
 		-
 			message: "#^Strict comparison using \\=\\=\\= between string and false will always evaluate to false\\.$#"
 			count: 1
Author	SHA1	Message	Date
Dylan K. Taylor	a8d5e8c5f6	Release 3.25.1	2021-10-29 22:23:22 +01:00
Dylan K. Taylor	089e62b44e	Entity::spawnTo(): verify that the target player belongs to the same world as the entity this should never be hit in the PM case, but it's an InvalidArgument rather than AssumptionFailedError because plugins can and do call this with bad things.	2021-10-29 18:54:00 +01:00
Dylan K. Taylor	f1cc168d26	phpstan: exclude a couple of files from analysis temporarily close #4472	2021-10-29 00:23:13 +01:00
Dylan K. Taylor	f6e53f826b	Fixed Anvil/McRegion chunks getting autosaved on first time, even when unchanged setGenerated/setPopulated and friends set hasChanged = true, which causes the world to autosave them the first time around, even though they weren't modified.	2021-10-25 19:52:44 +01:00
Dylan K. Taylor	986b4e0651	Enforce single-line PhpDoc for properties where possible	2021-10-21 20:32:37 +01:00
Dylan K. Taylor	dc07ac33d3	protocol: fixed missing field of CraftRecipeAuto	2021-10-20 19:47:32 +01:00
Dylan K. Taylor	9c5cec77b1	3.25.1 is next	2021-10-19 18:27:30 +01:00
Dylan K. Taylor	f48b703533	Release 3.25.0	2021-10-19 18:27:26 +01:00
Dylan K. Taylor	70636f6eb4	Protocol changes for 1.17.40	2021-10-19 18:00:34 +01:00
Dylan K. Taylor	ead9aae23c	Updated build/php submodule to pmmp/php-build-scripts@fab0cbeaae	2021-10-12 23:10:06 +01:00
Dylan K. Taylor	13068ba3a7	3.24.1 is next	2021-10-09 20:20:41 +01:00
Dylan K. Taylor	b54854529f	Release 3.24.0	2021-10-09 20:20:37 +01:00
Dylan K. Taylor	974d08efd6	Bump PHP minimum requirement to 8.0 PHPStan failed on 7.4 after updating to 0.12.99, and I figured it was less hassle to just do this than fix the build. In any case, we stopped shipping 7.4 months ago, and warned at 3.22 release that 7.4 support would soon be dropped.	2021-10-09 20:09:42 +01:00
Dylan K. Taylor	289553fa46	CS again	2021-10-09 19:50:07 +01:00
Dylan K. Taylor	e38866c4ba	phpstan 0.12.99	2021-10-09 19:33:43 +01:00
Dylan K. Taylor	58a95f8836	Updated transitive composer dependencies	2021-10-09 19:18:32 +01:00
Dylan K. Taylor	e032b8fe20	Server: fixed stats reporting checking a nonexistent pocketmine.yml property this was originally worked around by `47f7af6739`. However, that commit was just duct tape, and I never bothered to investigate if the config was being checked somewhere else. Here's to a years-old bug finally getting fixed.	2021-10-06 22:23:41 +01:00
Dylan K. Taylor	a27c14c00c	phpstan: exclude build/php from analysis in case I built PHP in there, I don't want the install_data getting analysed and screwing up the analysis.	2021-10-05 00:14:44 +00:00
dependabot[bot]	003c002208	Bump phpunit/phpunit from 9.5.9 to 9.5.10 (#4482 ) Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 9.5.9 to 9.5.10. - [Release notes](https://github.com/sebastianbergmann/phpunit/releases) - [Changelog](https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-9.5.md) - [Commits](https://github.com/sebastianbergmann/phpunit/compare/9.5.9...9.5.10) --- updated-dependencies: - dependency-name: phpunit/phpunit dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2021-09-28 21:04:11 +01:00
Jason	d417b1e2f5	Projectile: fixed move() not using the given parameters (#4481 ) it was using this->motion instead, which usually would be the same, but maybe not.	2021-09-28 21:03:03 +01:00
Dylan K. Taylor	65e468e3c2	Updated build/php submodule to pmmp/php-build-scripts@6aac46e500	2021-09-28 21:00:13 +01:00
Dylan K. Taylor	a11cf8c296	Update PHP versions used by GitHub Actions	2021-09-28 20:52:40 +01:00
Dylan K. Taylor	d455188d03	3.23.2 is next	2021-09-22 01:00:50 +01:00
Dylan K. Taylor	14fba36636	Release 3.23.1	2021-09-22 01:00:50 +01:00
Dylan K. Taylor	43ac3fbf3e	actions: use newer PHP versions	2021-09-22 00:51:06 +01:00
Dylan K. Taylor	352162a6e6	Fixed PHP 7.4 build	2021-09-22 00:50:00 +01:00
Dylan K. Taylor	b3601c9390	Regenerate PHPStan baselines	2021-09-22 00:45:07 +01:00
Dylan K. Taylor	817fec9e3d	EducationSettingsPacket: safeguard against purity issue reported by PHPStan while annoying, PHPStan is right to complain about this, because putBool() is impure, meaning that these fields could have been mutated in the call. We know they didn't, but PHPStan doesn't, and we can't mark the method as pure because .. well .. it isn't.	2021-09-22 00:44:52 +01:00
Dylan K. Taylor	ceeef7c729	3.23.1 is next	2021-09-22 00:29:24 +01:00