Dylan K. Taylor
1b0ef468f3
CommonThreadPartsTrait: remove outdated documentation
...
This is now automatically called by the final run(), and the user now only needs to implement onRun(), so they have no business calling this function.
2023-12-21 13:09:05 +00:00
Dylan K. Taylor
b69843a8bd
CommonThreadPartsTrait: add common implementation of quit()
...
there's no need for the worker specialization here (isShutdown and shutdown are aliased to isJoined and join respectively), and the unstacking is not really desirable either as we previously learned with AsyncPool.
2023-12-21 12:56:51 +00:00
Dylan K. Taylor
03619ebca9
Thread/Worker: Remove duplicated code
...
Despite the comments, there doesn't seem to be an obvious reason for these to be copy-pasted. Perhaps there was some legacy reason for this with legacy pthreads.
In fact, it looks likely that quit() will probably be able to be traitified too.
2023-12-21 12:44:03 +00:00
Dylan K. Taylor
fd1bc1b845
AsyncWorker: deprecate ThreadStore methods
...
these are inconvenient and don't make any sense. It's far easier and more static-analysis-friendly to just use static properties.
2023-12-21 12:39:55 +00:00
Dylan K. Taylor
c05116849a
AsyncWorker: clean up nonsensical sleeper notifier handling code
2023-12-21 12:39:12 +00:00
Dylan K. Taylor
7a55a6e6b6
ServerKiller: harden against spurious wakeups
...
If awakened by spurious wakeup, the thread would immediately exit without doing anything, rendering it useless.
Not sure how it took so long for this to be found...
2023-12-20 17:22:11 +00:00
Dylan K. Taylor
bf99917f2a
ThreadSafeClassLoader: add native property types
2023-12-20 17:01:20 +00:00
Dylan K. Taylor
57f3a04bc5
data: Use statically analyzable ways of ensuring all cases are registered
...
PHPStan will verify that these matches cover all cases, which guarantees that all cases will be covered.
In addition, if PHPStan is not used, the constructors will immediately bail out when they hit a case that isn't covered.
The only downside is the extra indentation :(
2023-12-20 16:07:05 +00:00
Hugo_
c51b1b2812
Create LightableTrait and remove repetitive code ( #6111 )
2023-12-20 15:21:11 +00:00
Dylan K. Taylor
80125f9b19
Modernize single-use phpstan-template tags
2023-12-20 15:20:28 +00:00
Dylan K. Taylor
8dc28b7ea8
RuntimeDataDescriber: remove useless template parameter
2023-12-20 15:15:43 +00:00
Dylan K. Taylor
58ce746ae1
Remove dead PHPStan ignored error
2023-12-20 14:44:24 +00:00
Dylan K. Taylor
74cb0be868
Noise: give PHPStan some help understanding SplFixedArray
2023-12-20 14:43:36 +00:00
Dylan K. Taylor
4d9b97d2bb
Merge branch 'stable' into minor-next
2023-12-20 14:30:38 +00:00
Dylan K. Taylor
90af8cfd69
Update composer dependencies
2023-12-20 14:29:02 +00:00
DiamondStrider1
c8da9dea95
WorldManager: Remove unused if in unloadWorld() ( #6203 )
2023-12-20 10:38:00 +00:00
Dylan K. Taylor
e1f4fd3048
ProcessLoginTask: remove dead comments
...
This is no longer an issue since b2df405cc0355dcffe202bc4040fae316940d427.
2023-12-15 16:01:43 +00:00
Dylan K. Taylor
d3d7f24015
Noise: make calls with many parameters less nauseating to read
2023-12-15 15:32:54 +00:00
Dylan K. Taylor
944dd7d3e4
BaseBanner: remove unnecessary array_filter() usage
2023-12-15 15:19:44 +00:00
dependabot[bot]
a03013d582
Bump phpstan/phpstan from 1.10.47 to 1.10.50 ( #6198 )
...
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan ) from 1.10.47 to 1.10.50.
- [Release notes](https://github.com/phpstan/phpstan/releases )
- [Changelog](https://github.com/phpstan/phpstan/blob/1.11.x/CHANGELOG.md )
- [Commits](https://github.com/phpstan/phpstan/compare/1.10.47...1.10.50 )
---
updated-dependencies:
- dependency-name: phpstan/phpstan
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-15 14:49:32 +00:00
dependabot[bot]
053abfbb6f
Bump actions/upload-artifact from 3 to 4 ( #6199 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](https://github.com/actions/upload-artifact/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-15 12:23:49 +00:00
Dylan K. Taylor
00a8ea267c
5.10.1 is next
2023-12-14 16:54:42 +00:00
Dylan K. Taylor
daeba95101
Release 5.10.0
2023-12-14 16:54:38 +00:00
Dylan K. Taylor
a750af72db
Updated build/php submodule to pmmp/PHP-Binaries@73e5950eb9
2023-12-14 16:05:38 +00:00
Dylan K. Taylor
61decaa2f8
Merge branch 'minor-next' into stable
2023-12-14 16:04:51 +00:00
Dylan K. Taylor
06b2e61d3c
Merge remote-tracking branch 'origin/stable' into minor-next
2023-12-14 14:02:15 +00:00
Dylan K. Taylor
b4838f5b4e
5.9.1 is next
2023-12-06 15:02:57 +00:00
Dylan K. Taylor
46307973e3
Release 5.9.0
2023-12-06 15:02:57 +00:00
Dylan K. Taylor
2f1d6115a0
Merge branch 'legacy/pm4' into stable
2023-12-06 14:55:18 +00:00
Dylan K. Taylor
ba89ae5bf2
4.26.1 is next
2023-12-06 14:53:00 +00:00
Dylan K. Taylor
30433bba10
Release 4.26.0
2023-12-06 14:52:59 +00:00
Dylan K. Taylor
ed3fe2b727
Update dependencies for 1.20.50
2023-12-06 14:47:44 +00:00
Dylan K. Taylor
927f129c6e
Fixed borked world loading
2023-12-06 14:41:19 +00:00
Dylan K. Taylor
2a136c7804
Update composer dependencies
2023-12-06 14:37:27 +00:00
Dylan K. Taylor
25cca1b63f
Changes for 1.20.50
2023-12-06 14:29:23 +00:00
Dylan K. Taylor
15574ec99a
Update composer dependencies
2023-12-06 14:28:30 +00:00
TheNewHEROBRINE
2420dee8be
AsyncTask: Fix retrieval of null data from the thread-local storage ( #6176 )
2023-12-06 13:40:09 +00:00
dependabot[bot]
bd65948453
Bump phpstan/phpstan from 1.10.46 to 1.10.47 ( #6189 )
...
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan ) from 1.10.46 to 1.10.47.
- [Release notes](https://github.com/phpstan/phpstan/releases )
- [Changelog](https://github.com/phpstan/phpstan/blob/1.11.x/CHANGELOG.md )
- [Commits](https://github.com/phpstan/phpstan/compare/1.10.46...1.10.47 )
---
updated-dependencies:
- dependency-name: phpstan/phpstan
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-06 13:29:40 +00:00
dependabot[bot]
0984aa670d
Bump phpstan/phpstan from 1.10.44 to 1.10.46 ( #6182 )
...
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan ) from 1.10.44 to 1.10.46.
- [Release notes](https://github.com/phpstan/phpstan/releases )
- [Changelog](https://github.com/phpstan/phpstan/blob/1.11.x/CHANGELOG.md )
- [Commits](https://github.com/phpstan/phpstan/compare/1.10.44...1.10.46 )
---
updated-dependencies:
- dependency-name: phpstan/phpstan
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-29 16:33:04 +00:00
dependabot[bot]
239f9ed83a
Bump shivammathur/setup-php from 2.27.1 to 2.28.0 ( #6179 )
...
Bumps [shivammathur/setup-php](https://github.com/shivammathur/setup-php ) from 2.27.1 to 2.28.0.
- [Release notes](https://github.com/shivammathur/setup-php/releases )
- [Commits](https://github.com/shivammathur/setup-php/compare/2.27.1...2.28.0 )
---
updated-dependencies:
- dependency-name: shivammathur/setup-php
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-29 16:32:42 +00:00
Dylan K. Taylor
b2df405cc0
NetworkSession: Send less information to clients on error disconnects
...
in particular, the information from VerifyLoginTask shouldn't be sent to clients, as it could contain sensitive information.
This change only affects disconnection screens. The server log shows the same amount of information as before (though formatted differently in some cases).
2023-11-29 16:31:59 +00:00
ace
d596dc571d
Fix pitcher pod wrongly registered as a block ( #6162 )
2023-11-27 14:46:20 +00:00
dependabot[bot]
bc11894f0a
Bump build/php from 6b4c9c7 to b0ffbdb ( #6178 )
...
Bumps [build/php](https://github.com/pmmp/php-build-scripts ) from `6b4c9c7` to `b0ffbdb`.
- [Release notes](https://github.com/pmmp/php-build-scripts/releases )
- [Commits](6b4c9c76bd...b0ffbdbe33
2023-11-27 11:01:36 +00:00
dependabot[bot]
d51475dc72
Bump docker/build-push-action from 5.0.0 to 5.1.0 ( #6169 )
...
Bumps [docker/build-push-action](https://github.com/docker/build-push-action ) from 5.0.0 to 5.1.0.
- [Release notes](https://github.com/docker/build-push-action/releases )
- [Commits](https://github.com/docker/build-push-action/compare/v5.0.0...v5.1.0 )
---
updated-dependencies:
- dependency-name: docker/build-push-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-24 16:31:34 +00:00
dependabot[bot]
233c8b746d
Bump phpstan/phpstan from 1.10.41 to 1.10.44 ( #6172 )
...
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan ) from 1.10.41 to 1.10.44.
- [Release notes](https://github.com/phpstan/phpstan/releases )
- [Changelog](https://github.com/phpstan/phpstan/blob/1.11.x/CHANGELOG.md )
- [Commits](https://github.com/phpstan/phpstan/compare/1.10.41...1.10.44 )
---
updated-dependencies:
- dependency-name: phpstan/phpstan
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-24 16:31:18 +00:00
Dylan K. Taylor
c1f0f13d5a
Add PHP 8.3 to test matrix
2023-11-24 16:29:27 +00:00
dependabot[bot]
06e2d36294
Bump build/php from 19f2ee6 to 6b4c9c7 ( #6171 )
...
Bumps [build/php](https://github.com/pmmp/php-build-scripts ) from `19f2ee6` to `6b4c9c7`.
- [Release notes](https://github.com/pmmp/php-build-scripts/releases )
- [Commits](19f2ee6d33...6b4c9c76bd
2023-11-22 11:06:32 +00:00
Dylan K. Taylor
a1748a92ca
Avoid unnecessary TypeConverter::getInstance() calls
...
we already have it available within these contexts
2023-11-17 14:00:25 +00:00
Dylan K. Taylor
fbcf4649eb
Avoid unnecessary Entity::getWorld() calls in loops
2023-11-17 13:58:41 +00:00
Dylan K. Taylor
0f620fad94
ChunkCache: inline unnecessary function
2023-11-17 13:30:44 +00:00
