10062 Commits

Author SHA1 Message Date
Dylan K. Taylor
756840f11d Fixed matchItems corrupting CraftingTransaction internal state on repeated validation
This bug became apparent while developing a more robust fix for 1.16 crafting.
2020-08-02 23:07:47 +01:00
Dylan K. Taylor
df2c3136c9 VersionString: added missing start anchor to regex 2020-08-02 21:10:47 +01:00
Dylan K. Taylor
a6b5cddd5a remove unused import 2020-07-21 19:26:24 +01:00
Dylan K. Taylor
5b9453af43 WhitelistCommand: fixed incorrect implode() parameter order
PHP allows this to work either way for legacy reasons, but glue-first is the canonical way for a long time.
2020-07-21 11:46:11 +01:00
TheNewHEROBRINEX
8bba25f4f5
Fix wrong hardness value for Podzol (#3709) 2020-07-16 22:07:41 +01:00
dependabot-preview[bot]
f9bd7016aa
Bump phpstan/phpstan-strict-rules from 0.12.2 to 0.12.3 (#3705) 2020-07-16 15:24:42 +00:00
dependabot-preview[bot]
213406fc60
Bump phpunit/phpunit from 9.2.5 to 9.2.6 (#3701) 2020-07-14 16:44:35 +00:00
Dylan K. Taylor
7ff6e5895e added missing 3.14.2 changelog 2020-07-13 11:55:08 +01:00
Dylan K. Taylor
2e6b62fdec 3.14.3 is next 2020-07-13 10:46:58 +01:00
Dylan K. Taylor
4fc5b9772a Release 3.14.2 3.14.2 2020-07-13 10:46:57 +01:00
Dylan K. Taylor
5d4880b0a7 SendUsageTask: fixed json_encode() choking on player list keys 2020-07-11 20:14:04 +01:00
Dylan K. Taylor
2b1a0e1e72 PlayerRespawnEvent: harden setRespawnPosition()
apparently plugins like to pass around positions which have null worlds, which aside from being quite stupid, also breaks a lot of stuff and makes it look like PM is to blame when it's just trying to make everything work the way it's supposed to ...
2020-07-10 20:37:45 +01:00
Dylan K. Taylor
cd022f1592 EmotePacket: make FLAG_SERVER constant public 2020-07-10 20:02:32 +01:00
Dylan K. Taylor
4ae3fd7734 Player: Reset spawn chunk send count if teleporting pre-spawn 2020-07-09 12:17:19 +01:00
Dylan K. Taylor
b2249f93c0 TaskHandler: bail if given a task that already has a handler
This fixes undefined behaviour when scheduling the same task twice. This is usually accidental and almost never desirable.
Note that this still allows a task to be scheduled again after it has
been cancelled; it only disallows scheduling a task multiple times
concurrently.

This commit will probably break MyPlot and other plugins that have
self-scheduling tasks, but as far as I can tell those use-cases should
be replaced with self-cancelling repeating tasks anyway.
2020-07-08 11:02:33 +01:00
Dylan K. Taylor
303344783a CheckTestCompletionTask: use TaskHandler->cancel() 2020-07-08 10:57:20 +01:00
Dylan K. Taylor
75e0844ff5 MainLogger: log stack traces with CRITICAL level
maybe this will get people to send the whole thing instead of just the error message? ...
2020-07-08 10:45:15 +01:00
Dylan K. Taylor
18fabf5466 3.14.2 is next 2020-07-08 10:32:07 +01:00
Dylan K. Taylor
2751c59979 Release 3.14.1 3.14.1 2020-07-08 10:32:07 +01:00
Dylan K. Taylor
d99ffbd66c Attribute: register lava_movement attribute
this is purely to fix crashes when decoding net packets
2020-07-08 10:21:20 +01:00
Dylan K. Taylor
a34f3261cb event: harden APIs that accept arrays
plugin devs can't be relied on to pass the proper types to these APIs, and when the wrong types get passed it makes type errors appear from inside the internals.
2020-07-04 21:55:23 +01:00
Dylan K. Taylor
8ce0022de6 protocol: added UUInventorySlotOffset constants 2020-07-04 21:37:37 +01:00
Dylan K. Taylor
fb6491ddeb BanListCommand: sort output into lexical order 2020-07-03 11:23:00 +01:00
Dylan K. Taylor
3b961d0e5f WhitelistCommand: sort output of /whitelist list into lexical order 2020-07-03 11:19:23 +01:00
Dylan K. Taylor
a60fc4cc28 ListCommand: sort output into lexical order 2020-07-03 11:15:31 +01:00
Dylan K. Taylor
b747899fdd PluginsCommand: sort plugins list into lexical order 2020-07-03 11:13:32 +01:00
Kang Ji-won
57b6451e16
Fix projectile motion being changed by the ladder, close #3602 (#3631) 2020-06-27 21:18:39 +01:00
Twisted
8cf025a2df Default isVerified to true (#3644) 2020-06-27 21:17:34 +01:00
Dylan K. Taylor
8480ee82ea Player: track hardcoded window state, fixes crashes opening inventory on high-latency connections 2020-06-27 18:34:39 +01:00
Dylan K. Taylor
a6c1b7bf9c InventoryTransactionPacket: added missing field for encode 2020-06-26 20:57:48 +01:00
Dylan K. Taylor
c267137fde 3.14.1 is next 2020-06-26 14:19:02 +01:00
Dylan K. Taylor
461bc94236 Release 3.14.0 3.14.0 2020-06-26 14:19:02 +01:00
Dylan K. Taylor
4fed08bcd4 ProtocolInfo: fixed version number 2020-06-26 14:15:58 +01:00
Dylan K. Taylor
e990c5a0a5 Protocol changes for 1.16.0 2020-06-26 14:06:41 +01:00
Dylan K. Taylor
c616d9bb7c 3.13.2 is next 2020-06-26 12:31:56 +01:00
Dylan K. Taylor
81051441ba Release 3.13.1 3.13.1 2020-06-26 12:31:56 +01:00
Dylan K. Taylor
3ecae0db19 WindowTypes: fill in a couple of blanks 2020-06-26 12:04:11 +01:00
Dylan K. Taylor
c5bbb2bcbc Move crafting action detection from InventoryTransactionPacket to Player 2020-06-26 11:59:30 +01:00
Dylan K. Taylor
24a2889758 NetworkInventoryAction does not require an InventoryTransactionPacket 2020-06-26 11:51:06 +01:00
Dylan K. Taylor
60b26a7ea8 NetworkBinaryStream: unknown byte preceding NBT is a version, not a count 2020-06-26 11:47:08 +01:00
Dylan K. Taylor
22b52f03d1 Player: fixed formatting error in InteractPacket debug message 2020-06-26 11:44:41 +01:00
Matt
df76c02e7a
Explicitly release server.lock file when shutdown the server. (#3619)
Previously, this relied on PHP itself to release locks during the resource destructor phase during process exit, but sometimes it doesn't for god knows what reason. This change makes the lock file get explicitly released before the process dies.
2020-06-26 11:41:39 +01:00
Dylan K. Taylor
d343187e58 phpstan: drop 2 obsolete level 8 error patterns fixed by 763c8ebfe3bb8a597768d86040fee130c8fc7ab8 2020-06-23 12:57:25 +01:00
Dylan K. Taylor
c5ad127854 BaseInventory: mark eventProcessor as nullable, fixes a phpstan level 8 error 2020-06-23 12:55:06 +01:00
Dylan K. Taylor
0f6dc9082a lock phpstan at 0.12.29
0.12.30 starts reporting non-ignorable errors for overriding Thread::start() due to outdated stubs for pthreads that I can't replace
2020-06-22 20:57:12 +01:00
Dylan K. Taylor
2b6dcbc2e2 BaseLang: fixed passing onlyPrefix to str_replace()'s count reference parameter 2020-06-22 20:34:23 +01:00
Dylan K. Taylor
763c8ebfe3 Thread/Worker: drop nullability flag from start() (fixed in pthreads 3.2.0, which we require as a minimum) 2020-06-21 19:07:01 +01:00
Dylan K. Taylor
c572e9bb6a phpstan: regenerate l7 baseline 2020-06-21 18:58:41 +01:00
Dylan K. Taylor
89521f166d Explosion: account for multi-block structures, fixes #2767 2020-06-21 17:28:38 +01:00
Dylan K. Taylor
49d3a42120 phpstan: make EntityEvent generic, fix a bunch of 'actual-problems' ignored errors 2020-06-21 00:27:32 +01:00