55f8314fa7
Merge branch 'next-minor'
...
# Conflicts:
# resources/vanilla
2020-05-18 20:33:22 +01:00
fffa4b9501
phpstan: baseline our way to level 8
...
we really need the level 8 checks on new code now, and waiting until old code is clean is not going to benefit us much because the issues that are there already exist.
2020-05-18 20:09:25 +01:00
040fdc2875
Merge commit '8e1b3ed'
...
# Conflicts:
# phpstan.neon.dist
# resources/vanilla
# tests/phpstan/configs/phpstan-bugs.neon
# tests/phpstan/configs/phpunit-wiring-tests.neon
# tests/phpstan/configs/pthreads-bugs.neon
# tests/phpstan/configs/runtime-type-checks.neon
2020-04-25 12:35:30 +01:00
bb8ef3ff6d
Merge commit 'da9731e'
...
# Conflicts:
# phpstan.neon.dist
# resources/vanilla
# src/PocketMine.php
2020-04-25 12:20:23 +01:00
4c1b10b24b
restructure ignoreErrors to allow regenerating them file by file
2020-04-25 11:59:06 +01:00
61dc9d7f6b
phpstan: split up phpstan-bugs and phpstan-bugs-generated configs
2020-04-25 11:26:54 +01:00
da9731ef59
phpstan: add stub defines to improve analysis
2020-04-25 11:07:05 +01:00
d3da485278
fix phpstan analyze failure
2020-04-25 10:43:06 +01:00
35be36961d
Merge tag '3.11.7'
2020-04-18 11:29:47 +01:00
5c12a95151
phpstan: force static reflection for COM class
...
com_dotnet has crap reflection exports and the class name case doesn't match.
2020-04-14 01:43:02 +01:00
83a3adecff
LoginPacket: use netresearch/jsonmapper for login data decoding
...
this makes retrieval static analysis friendly without extra steps.
2020-03-23 22:00:13 +00:00
2e3a9f251f
missed one
2020-02-07 22:17:33 +00:00
fb1126797a
Merge branch 'stable'
2020-02-07 18:13:55 +00:00
6c7dada232
finally, integrate phpstan-strict-rules
2020-02-06 19:44:10 +00:00
3a5709bf5e
start using phpstan-phpunit
...
not using extension-installer because I want to part-integrate phpstan-strict-rules later on.
2020-02-06 13:23:18 +00:00
7885b54824
phpstan: run static analysis on tests
2020-02-06 13:13:12 +00:00
fd2a7797bd
include make-release.php in phpstan analysis
2020-02-05 15:55:41 +00:00
4bc2f28c6d
Provide a ChunkUtils stub for PHPStan, so it doesn't get confused when the extension is loaded
...
for some reason the presence of the type problems were reported as
problems on ChunkUtils.php, despite being outside of the project scope
and the errors not applying to the polyfill.
2020-02-02 18:12:41 +00:00
f02f45f248
Merge commit 'af82a6bbe1e4c37564ce1e0932a8177d31750b7d'
2020-02-01 20:45:16 +00:00
3688f78986
Merge commit '004f7ef82e9613d60c3614dbf634836b7e2f3774'
2020-01-31 22:09:20 +00:00
af82a6bbe1
phpstan: enable checkMissingIterableValueType
2020-01-30 22:31:42 +00:00
004f7ef82e
phpstan: stub out the iterable bullshit with pthreads
...
this isn't a perfect fix, but it's better than it whining about all the things.
2020-01-30 22:31:15 +00:00
89ebd2b880
remove some dead ignoreErrors
2020-01-30 22:30:04 +00:00
757f5b2fbf
Merge branch 'stable'
2020-01-20 18:12:58 +00:00
5a97c378fc
phpstan: green on level 6, minus iterable types
...
iterable types are a big pain in the ass because of pthreads' awful architecture, and there's nothing I can do about that without BC-breaking changes to pthreads.
2020-01-20 17:54:55 +00:00
a4b810977a
Merge commit '651ef500a3be530f5bf1f72990c711706eab3ca7'
2020-01-13 19:29:38 +00:00
f2f4715d97
Merge commit '30f2e7527818e3275ceb0ff26093c4f26a84c51c'
2020-01-13 19:17:54 +00:00
0e1cea043a
added some phpstan-specific generic type annotations
2020-01-13 15:05:02 +00:00
651ef500a3
Make pocketmine\PATH and pocketmine\RESOURCE_PATH always available
...
these are non-dependent on environment, so they can be determined with no external input.
This fixes 2 PHPStan issues, fixes some code that couldn't run outside of PM, and makes it easier to write code that depends on PM.
2020-01-13 10:55:54 +00:00
30f2e75278
phpstan 0.12.5
2020-01-12 16:57:43 +00:00
715a5c55f4
Merge branch 'stable'
2020-01-09 20:02:22 +00:00
6dcd2a4ece
phpstan: start phasing in some level 6 checks
2020-01-09 19:56:04 +00:00
16bab02b13
actually use the DisallowEnumComparisonRule (derp)
2020-01-09 17:54:52 +00:00
a733f094ac
phpstan: added a custom rule to disallow strict equality operators on enum members
...
comparing enums with equality operators is unreliable because there is no guarantee that the enum objects won't be somehow duplicated, through serialization, cloning or ext-parallel dumb object copying. This means that two equal enum objects may not be thw same object.
2020-01-08 19:45:05 +00:00
dd5be9692c
Merge commit '5cd7e11b298a35bf796b41b577c28441e41ff411'
2020-01-04 16:24:29 +00:00
08e3b8ffdc
build: added specialized script to create a server phar
...
this is much easier to use than devtools, and allows us to make additional specializations for PM build that would otherwise just be a colossal pain in the ass.
2020-01-04 14:56:53 +00:00
cccade9ade
Merge branch 'stable'
2019-12-29 15:31:10 +00:00
3e23a568ca
phpstan: properly fixing FPs on constant comparisons
2019-12-29 14:25:44 +00:00
c36377ea5a
Merge branch 'next-minor'
2019-12-12 19:47:12 +00:00
76994f15ac
phpstan: green on level 5
2019-12-12 18:27:26 +00:00
a9c09e4517
Merge branch 'next-minor'
2019-12-12 13:52:14 +00:00
70c3008b7b
phpstan: green on level 4
2019-12-12 13:00:57 +00:00
ff5aedaf6b
master: green on phpstan level 3
2019-12-05 14:35:02 +00:00
a5e8419d5b
Merge branch 'next-minor'
...
# Conflicts:
# phpstan.neon.dist
# resources/vanilla
# src/item/WritableBookBase.php
# src/pocketmine/metadata/MetadataStore.php
# src/world/Position.php
2019-12-05 14:11:59 +00:00
7b1ae2a822
phpstan: green on level 3
2019-12-04 22:12:14 +00:00
0e3ce7ff39
Merge branch 'next-minor'
2019-12-04 19:59:57 +00:00
c35d91a104
phpstan: allow blanket ignoreErrors in src to reduce merge work for master
2019-12-04 19:42:18 +00:00
9fc260fb1a
keep phpstan.neon.dist ignoreErrors sorted by file
2019-12-04 19:38:54 +00:00
c0ea871599
updated rules for master on PHPStan 0.12
2019-12-04 11:35:57 +00:00
dc5d985cf4
Merge branch 'next-minor'
2019-12-04 11:23:30 +00:00
