e66197036d
InGamePacketHandler: drop transactions with 0 actions without trying to execute them
...
often we throw out actions that have no value, which can lead to an empty transaction and re-syncing the inventory. This happens every time we interact with the creative inventory in 1.13+, which causes items to appear to vanish when taking them from the creative menu.
The correct fix for this is to resend only the slots affected by SlotChangeActions, but this fix will suffice for now without rewriting everything.
2020-01-25 18:10:37 +00:00
5955ff5393
fix phpdoc spacing screwed up by phpstorm
2020-01-22 15:20:50 +00:00
8efc4d12ec
trim phpdoc lines
2020-01-22 15:18:37 +00:00
0b423c5b96
Merge branch 'stable'
2020-01-22 15:16:10 +00:00
055b13a6cf
strip extra blank lines (php-cs-fixer)
2020-01-22 15:14:10 +00:00
8d7a364b29
Empty merge of 'f624871b3fdd04c983c3d37e42b9862ef8f03b68'
2020-01-22 15:09:03 +00:00
a3bffd375b
master-specific addendum to cd55cdf5c6
2020-01-22 15:07:47 +00:00
cd55cdf5c6
Merge commit '9cd6b3e1c7cd81d0a4b0da68d9b3ff026c9f6495'
2020-01-22 15:04:06 +00:00
4481474d41
Merge commit 'aad1eb5b3e9b2e3b3db968a000e5454152195d7f'
2020-01-22 15:01:46 +00:00
7f06002027
Merge commit 'bff5bf25aea5cf56bbbfaeaa89f5e1f0ac920c90'
2020-01-22 15:00:13 +00:00
8184a6b114
SkinImage: enforce that height/width must be positive
2020-01-22 14:58:36 +00:00
b8d44ff162
SkinImage: fix formatting error
2020-01-22 14:58:00 +00:00
f6611a38bc
Explosion: fix trailing whitespace in explodeA() phpdoc
2020-01-22 14:51:49 +00:00
24ed823d96
WritableBook: remove extra line from phpdoc on setPages()
2020-01-22 14:51:14 +00:00
f624871b3f
strip extra blank lines (php-cs-fixer)
2020-01-22 14:50:29 +00:00
9cd6b3e1c7
fix remaining multiline @var annotations
2020-01-22 14:44:36 +00:00
aad1eb5b3e
CoreConstants: fix EOF newline
2020-01-22 14:40:03 +00:00
bff5bf25ae
LegacySkinAdapter: make resource patch validity check more robust
2020-01-22 14:36:40 +00:00
1b33143f4f
pass 2, manual removal of incorrect non-nullable phpdoc types
2020-01-22 12:06:47 +00:00
67bcc1c0fb
phpdoc armageddon for master, pass 1
2020-01-22 11:55:03 +00:00
4bae3baa74
Empty merge of stable
...
easier to reapply these changes than to resolve conflicts
2020-01-22 10:56:43 +00:00
cda90fd7f1
Merge pull request #3280 from pmmp/stable-phpdoc-armageddon
...
Mass-removal of redundant @param / @return PhpDoc annotations
2020-01-22 10:48:50 +00:00
ccdf003c8d
ResourcePacksPacketHandler: fixed chemistry being applied to top of stack instead of bottom
...
it seems like the stack order is reversed, so all 'regular' in-memory stack behaviour goes out of the window.
2020-01-22 08:26:44 +00:00
9f44adf04a
pass 2, manual removal of incorrect non-nullable @param for nullable native types
2020-01-21 15:44:34 +00:00
c4793241f5
Mass removal of useless @param/@return PHPDoc annotations, pass 1
2020-01-21 15:10:18 +00:00
757f5b2fbf
Merge branch 'stable'
2020-01-20 18:12:58 +00:00
7532c609fb
3.11.5 is next
2020-01-20 18:06:46 +00:00
13f28d8454
Release 3.11.4
2020-01-20 18:06:46 +00:00
5a97c378fc
phpstan: green on level 6, minus iterable types
...
iterable types are a big pain in the ass because of pthreads' awful architecture, and there's nothing I can do about that without BC-breaking changes to pthreads.
2020-01-20 17:54:55 +00:00
f44c9adbb0
Merge branch 'stable'
2020-01-20 17:33:43 +00:00
545f04b2c8
Utils: apply phpstan generics to cloneObjectArray()
2020-01-20 17:28:26 +00:00
e5d62ec901
phpstan 0.12.6
2020-01-20 17:26:48 +00:00
cfd975009e
Leaves: fix decay performance issue
...
this code was written with references in mind, but it looks like someone forgot the reference.
2020-01-20 11:52:11 +00:00
01016d7e17
Merge branch 'stable'
2020-01-19 19:59:56 +00:00
73257ffde7
updated pocketmine/spl dependency
2020-01-19 19:50:20 +00:00
8252bea699
phpstan: enable MissingMethodReturnTypehintRule
...
this was a bitch of a job, but it's one step closer to bypassing level 6.
2020-01-19 19:43:52 +00:00
ea935a1af5
pocketmine root: sweep missing return type information
2020-01-19 19:40:01 +00:00
e8a5fa8a37
updater: populate missing return type information
2020-01-19 19:38:41 +00:00
db734675d8
level: populate missing interface return types
2020-01-19 19:38:09 +00:00
6ede56015d
level/biome: populate missing return type information
2020-01-19 19:37:08 +00:00
5334099fbf
level/format: populate missing return type information
2020-01-19 19:36:34 +00:00
82e9072223
level/format/io: populate missing return type information
2020-01-19 19:35:45 +00:00
2c11742f9e
Player: populate missing type information
2020-01-19 19:16:38 +00:00
bd4a63b668
Server: populate missing return type information
2020-01-19 19:09:08 +00:00
cd36af46bf
Level: populate missing type information
2020-01-19 18:44:41 +00:00
aa7d55e21d
level/generator: populate missing return type information
2020-01-19 18:07:54 +00:00
31e8efa6d1
level/light: populate missing return type information
2020-01-19 18:06:31 +00:00
facca13139
permission: populate missing return type information
...
PermissibleBase has some redundant phpdoc removed so that the Permissible interface can provide return types.
2020-01-19 17:23:52 +00:00
fffeeddca6
DataPacket: add magic method return types to keep phpstan happy
...
this really shouldn't be necessary, but it is what it is.
2020-01-19 17:14:34 +00:00
e6ba3ce8a6
item: populate missing return type information
2020-01-19 17:13:33 +00:00
