mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-08 02:42:58 +00:00
Code Issues Projects Releases Wiki Activity
10,591 Commits 19 Branches 449 Tags
e35a92d8e8605765afcb056876033665d518d9be
Commit Graph

10591 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dylan K. Taylor
e35a92d8e8 tile\Banner: fixed bad default value for patterns field 
detected by PHPStan on level 3
 2019-12-04 18:25:08 +00:00
Dylan K. Taylor
850dbb38c6 phpstan-bugs: remove false positive that is fixed in 0.12.0 2019-12-04 11:38:01 +00:00
Dylan K. Taylor
c0ea871599 updated rules for master on PHPStan 0.12 2019-12-04 11:35:57 +00:00
Dylan K. Taylor
117e46f639 LevelDB: fix doc comment handling for deserializeLegacyExtraData() 2019-12-04 11:29:41 +00:00
Dylan K. Taylor
66aa940ed1 Item: fixed foreach doc comment in deserializeCompoundTag() 
detected by PHPStan 0.12.0
 2019-12-04 11:28:59 +00:00
Dylan K. Taylor
dc5d985cf4 Merge branch 'next-minor' 2019-12-04 11:23:30 +00:00
Dylan K. Taylor
e65bc5c3ae Merge branch 'stable' into next-minor 2019-12-04 11:11:29 +00:00
Dylan K. Taylor
73d0f799c2 Update to PHPStan 0.12.0 2019-12-04 10:29:49 +00:00
Dylan K. Taylor
ecb2e6e3af PluginManager: remove useless information from softDepend debug 
we don't report the parameter type anywhere else, and since PHP doesn't support overloading, we don't need to.
This fixes PHPStan 0.12 complaints about ReflectionNamedType. I figured this was the best solution instead of adding an extra few lines of code.
 2019-12-04 10:17:25 +00:00
Dylan K. Taylor
7b75b6928d AvailableCommandsPacket: fixed foreach docs 
these probably aren't necessary at all to be honest.
 2019-12-04 10:15:50 +00:00
Dylan K. Taylor
753a8a6937 Event: remove useless @var $this annotations 
we are not in a trait here, the scope is always Event.
 2019-12-04 10:15:04 +00:00
Dylan K. Taylor
bc76b1cafe Server: remove several redundant @var annotations (copy pasta) 
these are all useless because it is implied by the parameter type anyway.
 2019-12-04 10:14:15 +00:00
Dylan K. Taylor
f302517a2d Door: fix deserialization of top flag 
it's not clear what bugs this caused, if any, but nonetheless it is incorrect.
 2019-12-03 21:04:04 +00:00
Dylan K. Taylor
962e6162eb Merge branch 'next-minor' 2019-12-03 20:00:08 +00:00
Dylan K. Taylor
2ae37cc1c5 Merge branch 'stable' into next-minor 2019-12-03 19:59:35 +00:00
Dylan K. Taylor
00e415fc79 move phpstan.neon to phpstan.neon.dist to allow phpstan.neon to be locally modified for development 2019-12-03 19:57:19 +00:00
Dylan K. Taylor
29ce829247 fix error counts for UPnP 2019-12-03 17:45:23 +00:00
Dylan K. Taylor
5b91be81cc Entity: rewrite dbbe1f2d5c for master 2019-12-03 12:16:10 +00:00
Dylan K. Taylor
54c2778e56 phpstan: update split configs for master branch 2019-12-03 12:08:56 +00:00
Dylan K. Taylor
5f9ce78814 WorldProviderManager: removed incorrect param doc 
this was used to trick phpstorm, but PHPStan doesn't like it, and it isn't consistently used anyway.
 2019-12-03 12:08:04 +00:00
Dylan K. Taylor
fede6b8234 protocol: fixed static analysis warnings in MetadataProperty::equals() implementations 2019-12-03 12:06:57 +00:00
Dylan K. Taylor
e110ea5aea LoginPacket: fixed param doc for validate() 2019-12-03 11:59:28 +00:00
Dylan K. Taylor
d3d7709ead Merge branch 'next-minor' 2019-12-03 11:55:45 +00:00
Dylan K. Taylor
9a67192f74 Merge branch 'stable' into next-minor 2019-12-03 10:45:51 +00:00
Dylan K. Taylor
dbbe1f2d5c Revert "Entity: remove redundant check from spawnTo()" 
This reverts commit 3028832cd3.

When I created this commit, I made the flawed assumption that spawnTo()
would not be used by plugins. In addition, I was not aware that there
are some usages of spawnTo() in the core which do not check for chunk
usage, such as in Player->showPlayer().

This caused a collection of problems including memory leaks and crashes
due to disconnecting players not removing their references from viewed
entities.

The reverted commit may be the cause of #3178.
 2019-12-03 10:41:13 +00:00
Dylan K. Taylor
02c1dabc3d update pocketmine/nbt dependency 2019-12-02 19:24:00 +00:00
Dylan K. Taylor
ce27c03774 PlayerChatEvent: fixed crash when non-CommandSender permissibles subscribe to broadcast permission 
doing such a thing doesn't make any sense, but the system allows it, so it has to be accounted for.
 2019-12-01 21:44:13 +00:00
Dylan K. Taylor
c4a8781b5c Fixed doc type inconsistencies surrounding chat broadcast handling (several problems that are all related) 2019-12-01 21:40:11 +00:00
Dylan K. Taylor
dbab8b5733 Level: fixed type doc of tickRateTime field 2019-12-01 21:21:42 +00:00
Dylan K. Taylor
2b08bbc7b1 Server: fixed type doc comment of nextTick field 2019-12-01 21:18:20 +00:00
Dylan K. Taylor
17037f5e9c Chunk: clean up nonsensical code in initChunk() 
I have no idea why the extra check was there, or why the null assignment was used, because it doesn't make any sense.
 2019-12-01 21:14:23 +00:00
Dylan K. Taylor
fee3c17148 CraftingManager: fixed type doc of craftingDataCache field 2019-12-01 21:06:34 +00:00
Dylan K. Taylor
25e6cb74b3 Squid: fixed type doc comment of swimDirection field 2019-12-01 21:06:03 +00:00
Dylan K. Taylor
8d2e59222e Entity: fixed not calculating surrounding blocks on entity creation 
it's unclear if this was actually causing any bugs, but if it was it would likely manifest in the form of, for example, not burning in lava.
 2019-12-01 21:05:36 +00:00
Dylan K. Taylor
cd778661c2 Entity: fixed type doc comment for blocksAround field 2019-12-01 21:03:57 +00:00
Dylan K. Taylor
c2afc05e7c Entity: fix type doc comment for static knownEntities field 2019-12-01 21:03:29 +00:00
Dylan K. Taylor
9be95bf263 Block: return [] instead of null in getMetadata() (return type is non-nullable) 2019-12-01 21:02:49 +00:00
Dylan K. Taylor
4b65e1cbe1 Command: fix type doc comment for commandMap field 2019-12-01 21:01:57 +00:00
Dylan K. Taylor
5caae37768 Server: fixed return type doc comment for getCommandAliases() 2019-12-01 21:00:49 +00:00
Dylan K. Taylor
92e1811b06 DataPacket: fixed bad null assignment to buffer in clean() 
this is never expected to be null, so implicitly relies on PHP magic behaviour to convert it to string when appended.
 2019-12-01 20:36:56 +00:00
Dylan K. Taylor
293c2710d0 PlayerCreationEvent: fixed doc comments for baseClass and playerClass fields 2019-12-01 20:19:59 +00:00
Dylan K. Taylor
8a7017fd6b Enchantment: fixed doc comment for static enchantments field 2019-12-01 20:16:45 +00:00
Dylan K. Taylor
15f8886958 phpstan: separate non-PM bugs from the main neon config 
everything left in here is now a PM problem that needs to be looked into.
 2019-12-01 20:12:41 +00:00
Dylan K. Taylor
3226a9dc6a phpstan: ignore more optional-leveldb errors 2019-12-01 19:52:49 +00:00
Dylan K. Taylor
1a1e3ff63b BaseInventory: fixed incorrect & redundant default value for slots field 2019-12-01 19:45:16 +00:00
Dylan K. Taylor
ea413d0882 phpstan: analyze on level 2, close #3193 2019-12-01 19:32:03 +00:00
Dylan K. Taylor
0890b5fc99 AsyncPool: assert() that the unstacked task is actually an AsyncTask 
it's possible that it might not be if the workers were accessed directly, but that shouldn't be possible.
This also silences a PHPStan warning on level 2.
 2019-12-01 19:28:05 +00:00
Dylan K. Taylor
163ed225f2 NetworkBinaryStream: fixed crash when non-compound root tag is provided for itemstack 2019-12-01 18:41:02 +00:00
Dylan K. Taylor
a4a6d3e094 PlayerCreationEvent: fixed illegal doc comment types 2019-12-01 18:08:25 +00:00
Dylan K. Taylor
ecbf3e9722 GamemodeCommand: fix CommandSender assignment causing troubles for type inference on static analyzers 
this would never crash, but in strongly typed code it would be a compile failure.
 2019-12-01 09:33:12 +00:00