18016 Commits

Author SHA1 Message Date
Dylan K. Taylor
d789c75c00
Improve PHPStan error reporting for unsafe foreaches
these are actually two separate concerns: one for dodgy PHPStan type suppression on implicit keys, and the other for arrays being casted to strings by PHP.
2025-05-08 02:26:09 +01:00
Dylan K. Taylor
f2e7473629
Update PHP-CS-Fixer 2025-05-04 17:19:15 +01:00
dependabot[bot]
6f3506360e
Bump the github-actions group with 3 updates (#6683) 2025-05-01 08:30:26 +00:00
Dylan K. Taylor
1ea5c060fd
bruh 2025-04-20 18:16:54 +01:00
Dylan K. Taylor
4a5c1e7540
Entity: truncate fire ticks instead of throwing exceptions
as written in the comments, it's not reasonable to propagate this limitation, since it
ultimately comes from a shortfall in the Mojang save format, not a limitation of PM's
capability. It's also not obvious how this would be propagated to the likes of setOnFire(),
as this would translate into a max time of 1638 seconds, a value no one is going to
remember.

There's a case to be made for truncating this on save rather than on initial set, but
this is at least better than having Fire Aspect level 1000 cause crashes and whatever
other gameplay logic that would have to work around this stupid limitation.
2025-04-20 16:57:44 +01:00
Dylan K. Taylor
2548422973
AvailableEnchantmentRegistry: reject non-string tags
fixes https://crash.pmmp.io/view/12627328
2025-04-20 16:44:23 +01:00
Dylan K. Taylor
f661443ec7
Update Ubuntu base image for GitHub Actions 2025-04-15 16:48:13 +01:00
Dylan K. Taylor
835c383d4e
Update Composer dependencies 2025-04-06 20:00:21 +01:00
pmmp-admin-bot[bot]
d3f6c22996 5.27.2 is next
Commit created by: https://github.com/pmmp/RestrictedActions/actions/runs/14288755593
2025-04-06 03:53:08 +00:00
Dylan T.
6f3851be80
5.27.1 (#6670) 5.27.1 2025-04-06 04:52:15 +01:00
pmmp-admin-bot[bot]
e88b81a4cb 5.27.1 is next
Commit created by: https://github.com/pmmp/RestrictedActions/actions/runs/14110940403
2025-03-27 15:49:33 +00:00
Dries C
687112f4cd
5.27.0, Bedrock 1.21.70 support (#6665)
Co-authored-by: Dylan K. Taylor <dktapps@pmmp.io>
5.27.0
2025-03-27 15:48:19 +00:00
dependabot[bot]
c9e85603b0
Bump phpstan/phpstan-strict-rules in the development-patch-updates group (#6664) 2025-03-24 14:43:29 +00:00
pmmp-admin-bot[bot]
c80a4d5b55 5.26.1 is next
Commit created by: https://github.com/pmmp/RestrictedActions/actions/runs/14011298411
2025-03-22 18:33:19 +00:00
Dylan T.
f416cb8902
Merge pull request #6658 from pmmp/minor-next-release 5.26.0 2025-03-22 18:32:15 +00:00
Dylan T.
f123df5e0d
changelog: use more accurate terminology 2025-03-22 18:16:33 +00:00
Dylan K. Taylor
de26ebd124
Prepare 5.26.0 release 2025-03-22 17:59:20 +00:00
dependabot[bot]
1c6a4bde86
Bump pocketmine/locale-data in the production-patch-updates group (#6656) 2025-03-17 13:20:59 +00:00
Dylan K. Taylor
c2f8e9365b
BlockStateToObjectDeserializer: check that the returned state is actually registered
if not, this will cause random crashes in core code, which assumes that state IDs found on runtime chunk memory are valid and registered.

this problem exists in other places too, and probably requires a rethink of how we're dealing with this, but for now, this will do as a band-aid.
2025-03-15 20:53:49 +00:00
Dylan K. Taylor
4ef21fabab
Merge branch 'stable' into minor-next 2025-03-15 20:37:28 +00:00
Dylan K. Taylor
4407e585e4
Update composer dependencies (minor-next) 2025-03-15 20:36:39 +00:00
Dylan K. Taylor
463be36b72
Update composer dependencies 2025-03-15 20:33:47 +00:00
Dylan K. Taylor
8b57e9007a
👺 2025-03-15 01:33:29 +00:00
Dylan K. Taylor
e03c586c86
GarbageCollectorManager: promote debug message to info
this has such a big impact on performance that I think this is warranted. Should also make it more obvious what the GC is doing without needing to enable ALL debug info.
2025-03-15 01:29:49 +00:00
pmmp-admin-bot[bot]
802e373bf3 Merge 'stable' into 'minor-next'
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/13868087288
2025-03-15 01:26:47 +00:00
Dylan T.
09acbfab4c
dependabot: ignore phpstan/phpstan updates
these are noisy and cause conflicts. Since they also usually cause new errors to be reported, we often can't directly update it anyway. Better to test & update this locally.
2025-03-15 00:03:09 +00:00
Dylan K. Taylor
7cfaf04b87
stfu 2025-03-14 16:10:56 +00:00
Dylan K. Taylor
d9e0e51e14
Reduce code duplication in copper block serialization handling 2025-03-14 16:08:06 +00:00
Dylan K. Taylor
069ecf007f
Merge branch 'stable' into minor-next 2025-03-14 15:41:46 +00:00
Dylan K. Taylor
341c7a03a9
CopperMaterial: fixed missing @return $this docs 2025-03-14 15:40:27 +00:00
pmmp-admin-bot[bot]
7ae90dda5d Merge 'stable' into 'minor-next'
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/13825107599
2025-03-13 01:36:47 +00:00
Dylan T.
73a4b076d6
actions: tidy support response message 2025-03-12 16:19:11 +00:00
Dylan T.
00df508727
Update bug-report.yml 2025-03-12 13:06:57 +00:00
pmmp-admin-bot[bot]
a6553097f4 Merge 'stable' into 'minor-next'
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/13754675430
2025-03-10 01:14:10 +00:00
Lee Siu San
afc4a3c7f1
Fixed entity position offset not being included in AddActorPacket (#6643)
this was causing TNT and falling blocks to briefly appear half a block lower than their true position, because their positions are measured from the center and not the base.
2025-03-09 02:09:53 +00:00
pmmp-admin-bot[bot]
ac7b5b3b13 Merge 'stable' into 'minor-next'
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/13743358576
2025-03-09 01:16:28 +00:00
Dylan K. Taylor
7af5eb3da2
crafting: validate array inputs
this makes sure wrong parameters don't show up as core errors, as seen in crash report 12373907
closes #6642
2025-03-09 01:10:12 +00:00
Dylan K. Taylor
95284bc9de
change error identifier 2025-03-09 00:54:39 +00:00
Dylan K. Taylor
2291546610
phpstan: added rule to ban new $class
see #6635 for rationale on why we want to get rid of this

for now, this rule will prevent this anti-feature from being used in new code
2025-03-09 00:51:12 +00:00
Dylan T.
aad2bce9e4
readme: call out Easy tasks issues 2025-03-09 00:23:59 +00:00
pmmp-admin-bot[bot]
09f0ce458c Merge 'stable' into 'minor-next'
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/13666455727
2025-03-05 01:27:20 +00:00
pmmp-admin-bot[bot]
50a1e59aa4 5.25.3 is next
Commit created by: https://github.com/pmmp/RestrictedActions/actions/runs/13662905668
2025-03-04 21:05:10 +00:00
Dylan T.
e8824a36b9
Merge pull request #6645 from pmmp/explode-limit
5.25.2
5.25.2
2025-03-04 21:03:52 +00:00
Dylan T.
b1e63e544f
Merge branch 'stable' into explode-limit 2025-03-04 21:00:40 +00:00
Dylan K. Taylor
9e9f8a4870
Prepare 5.25.2 release 2025-03-04 20:57:47 +00:00
Dylan K. Taylor
d0d84d4c51
New rule: explode() limit parameter must be set 2025-03-04 20:44:01 +00:00
pmmp-admin-bot[bot]
9382e6e5b3 Merge 'stable' into 'minor-next'
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/13610829991
2025-03-02 01:38:07 +00:00
dependabot[bot]
e3e0c14275
Bump the github-actions group with 2 updates (#6644) 2025-03-01 10:04:01 +00:00
Dylan K. Taylor
afac178cf4
Merge branch 'stable' into minor-next 2025-02-26 17:31:55 +00:00
Dylan K. Taylor
e2f5e3e73c
Update composer dependencies 2025-02-26 17:31:26 +00:00